Skip to contentSkip to conversation

README: Add kernel-modules for SCTP

PATCH In review [email protected] 3 participants 4 messages May 20, 2020 – May 27, 2020 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 README: Add kernel-modules for SCTP

From: William Roberts <[email protected]>

Some Fedora images, notably the Fedora 32 cloud image, do not have the kernel modules package installed by default. Thus SCTP isn't available. Add the proper kernel-modules package for the running kernel.

Note: This applies to selinux-testsuite.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
README.md +2 -1
index 1bec9fe85c91..1a4c70c40d56 100644
@@ -77,7 +77,8 @@ following command:
 		kernel-devel-$(uname -r) \
 		quota \
 		xfsprogs-devel \
-		libuuid-devel
+		libuuid-devel \
+		kernel-modules-$(uname -r)
 
 #### Debian
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 5 lines · On Wed, May 20, 2020 at 5:26 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

Some Fedora images, notably the Fedora 32 cloud image, do not have the kernel modules package installed by default. Thus SCTP isn't available. Add the proper kernel-modules package for the running kernel.

Hm, I thought it wasn't possible to remove the kernel-modules package for the running kernel, but it really is...

Quoted 13 lines

Note: This applies to selinux-testsuite.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
README.md +0 -0
index 1bec9fe85c91..1a4c70c40d56 100644

README.md following command: · line 81

Quoted 6 lines
README.md +2 -1
@@ -77,7 +77,8 @@ following command:
                kernel-devel-$(uname -r) \
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-modules-$(uname -r)

Can you please put both the kernel-* packages together? I think it would be best to always have both at the end so that anyone who uses locally built kernels can easily copy the command without the two. Or I can just amend your patch when applying if you're OK with that.

Quoted 6 lines
README.md +0 -1
 #### Debian
 
--

2.17.1

Signature · 3 lines
Ondrej Mosnacek
Software Engineer, Platform Security - SELinux kernel,
Red Hat, Inc.
#2 lore raw
Quoted 19 lines · Ondrej Mosnacek
Quoted 5 lines · On Wed, May 20, 2020 at 5:26 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

Some Fedora images, notably the Fedora 32 cloud image, do not have the kernel modules package installed by default. Thus SCTP isn't available. Add the proper kernel-modules package for the running kernel.

Hm, I thought it wasn't possible to remove the kernel-modules package for the running kernel, but it really is...

Quoted 8 lines

Note: This applies to selinux-testsuite.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 16 lines

README.md following command: · line 81

Quoted 11 lines
README.md +2 -1
index 1bec9fe85c91..1a4c70c40d56 100644
@@ -77,7 +77,8 @@ following command:
                kernel-devel-$(uname -r) \
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-modules-$(uname -r)

Can you please put both the kernel-* packages together? I think it would be best to always have both at the end so that anyone who uses locally built kernels can easily copy the command without the two. Or I can just amend your patch when applying if you're OK with that.

Thats fine by me, thanks.

Quoted 13 lines
Quoted 7 lines
README.md +0 -1
 #### Debian
 
--

2.17.1

--
Ondrej Mosnacek
Software Engineer, Platform Security - SELinux kernel, Red Hat, Inc.

#3 lore raw
Quoted 38 lines · William Roberts
Quoted 19 lines · Ondrej Mosnacek
Quoted 5 lines · On Wed, May 20, 2020 at 5:26 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

Some Fedora images, notably the Fedora 32 cloud image, do not have the kernel modules package installed by default. Thus SCTP isn't available. Add the proper kernel-modules package for the running kernel.

Hm, I thought it wasn't possible to remove the kernel-modules package for the running kernel, but it really is...

Quoted 8 lines

Note: This applies to selinux-testsuite.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 16 lines

README.md following command: · line 81

Quoted 11 lines
README.md +2 -1
index 1bec9fe85c91..1a4c70c40d56 100644
@@ -77,7 +77,8 @@ following command:
                kernel-devel-$(uname -r) \
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-modules-$(uname -r)

Can you please put both the kernel-* packages together? I think it would be best to always have both at the end so that anyone who uses locally built kernels can easily copy the command without the two. Or I can just amend your patch when applying if you're OK with that.

Quoted 1 line

Thats fine by me, thanks.

OK, the patch is now applied.

Signature · 3 lines
Ondrej Mosnacek
Software Engineer, Platform Security - SELinux kernel,
Red Hat, Inc.