dt-bindings: input: touchscreen: edt-ft5x06: change reg property
Subsystems (4)
PATCH 1/1 dt-bindings: input: touchscreen: edt-ft5x06: change reg property
A test with the command below gives this error:
arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml:
touchscreen@3e: reg:0:0: 56 was expected
The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models was shipped with different addresses then the binding currently allows. Change the reg property that any address will pass.
make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/ edt-ft5x06.yaml
--- Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +1 -1
@@ -42,7 +42,7 @@ properties: - focaltech,ft6236 reg: - const: 0x38 + maxItems: 1 interrupts: maxItems: 1
Signature · 1 line
2.11.0
Dmitry Torokhov
maintainerHi Johan,
Quoted 23 lines · Johan Jonker
A test with the command below gives this error:
arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml:
touchscreen@3e: reg:0:0: 56 was expectedThe touchscreen chip on 'rk3188-bqedison2qc' and other BQ models was shipped with different addresses then the binding currently allows. Change the reg property that any address will pass.
make ARCH=arm
dtbs_checkDT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yamlSigned-off-by Johan Jonker <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +0
-0
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml properties: · line 45
Quoted 5 lines
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +1
-1@@ -42,7 +42,7 @@ properties: - focaltech,ft6236 reg: - const: 0x38 + maxItems: 1
Should we have a list of valid addresses instead of allowing any address? Controllers usually have only a couple of addresses that they support.
Thanks.
Signature · 1 line
Dmitry
Heiko Stübner
maintainerHi Dmitry,
Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov:
Quoted 28 lines
Hi Johan,
Quoted 25 lines · Johan Jonker
A test with the command below gives this error:
arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml:
touchscreen@3e: reg:0:0: 56 was expectedThe touchscreen chip on 'rk3188-bqedison2qc' and other BQ models was shipped with different addresses then the binding currently allows. Change the reg property that any address will pass.
make ARCH=arm
dtbs_checkDT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yamlSigned-off-by Johan Jonker <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +0
-0@@ -42,7 +42,7 @@ properties: - focaltech,ft6236
Quoted 7 lines
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml properties: · line 45
Quoted 3 lines
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +1
-1reg: - const: 0x38 + maxItems: 1Should we have a list of valid addresses instead of allowing any address? Controllers usually have only a couple of addresses that they support.
from what I've read, the fdt touchscreen controllers are just a generic cpu with device-specific (or better panel-specific) firmware, which seems to include the address as well - so it looks to be variable.
But of course that is only 2nd hand knowledge for me ;-)
But also, the i2c address is something you cannot really mess up, either it is correct and your touchscreen works, or it isn't and and adding entries to this list every time a new address variant pops up feels clumsy.
Heiko
Rob Herring
maintainerQuoted 43 lines · Heiko Stübner
Hi Dmitry,
Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov:
Quoted 28 lines
Hi Johan,
Quoted 25 lines · Johan Jonker
A test with the command below gives this error:
arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml:
touchscreen@3e: reg:0:0: 56 was expectedThe touchscreen chip on 'rk3188-bqedison2qc' and other BQ models was shipped with different addresses then the binding currently allows. Change the reg property that any address will pass.
make ARCH=arm
dtbs_checkDT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yamlSigned-off-by Johan Jonker <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +0
-0@@ -42,7 +42,7 @@ properties: - focaltech,ft6236Quoted 7 lines
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml properties: · line 45
Quoted 3 lines
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +1
-1reg: - const: 0x38 + maxItems: 1Should we have a list of valid addresses instead of allowing any address? Controllers usually have only a couple of addresses that they support.
from what I've read, the fdt touchscreen controllers are just a generic cpu with device-specific (or better panel-specific) firmware, which seems to include the address as well - so it looks to be variable.
Quoted 7 lines
But of course that is only 2nd hand knowledge for me ;-)
But also, the i2c address is something you cannot really mess up, either it is correct and your touchscreen works, or it isn't and and adding entries to this list every time a new address variant pops up feels clumsy.
Is that an Ack?
I'm fine either way. It's really only useful if there's a single address because with a list it could still be wrong just as any other data like an interrupt number could be wrong.
Rob
Am Freitag, 29. Mai 2020, 00:01:36 CEST schrieb Rob Herring:
Quoted 47 lines · Heiko Stübner
Quoted 46 lines
Hi Dmitry,
Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov:
Quoted 28 lines
Hi Johan,
Quoted 25 lines · Johan Jonker
A test with the command below gives this error:
arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml:
touchscreen@3e: reg:0:0: 56 was expectedThe touchscreen chip on 'rk3188-bqedison2qc' and other BQ models was shipped with different addresses then the binding currently allows. Change the reg property that any address will pass.
make ARCH=arm
dtbs_checkDT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yamlSigned-off-by Johan Jonker <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +0
-0@@ -42,7 +42,7 @@ properties: - focaltech,ft6236Quoted 7 lines
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml properties: · line 45
Quoted 3 lines
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +1
-1reg: - const: 0x38 + maxItems: 1Should we have a list of valid addresses instead of allowing any address? Controllers usually have only a couple of addresses that they support.
from what I've read, the fdt touchscreen controllers are just a generic cpu with device-specific (or better panel-specific) firmware, which seems to include the address as well - so it looks to be variable.
But of course that is only 2nd hand knowledge for me ;-)
Quoted 6 lines
Quoted 4 lines
But also, the i2c address is something you cannot really mess up, either it is correct and your touchscreen works, or it isn't and and adding entries to this list every time a new address variant pops up feels clumsy.
Is that an Ack?
for the patch itself:
Quoted 6 lines
I'm fine either way. It's really only useful if there's a single address because with a list it could still be wrong just as any other data like an interrupt number could be wrong.
Rob
Quoted 9 lines · Johan Jonker
A test with the command below gives this error:
arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml:
touchscreen@3e: reg:0:0: 56 was expectedThe touchscreen chip on 'rk3188-bqedison2qc' and other BQ models was shipped with different addresses then the binding currently allows. Change the reg property that any address will pass.
Quoted 9 lines
make ARCH=arm
dtbs_checkDT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yamlSigned-off-by Johan Jonker <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!