irqchip/gic-v2,v3: Drop extra IRQ_NOAUTOEN setting for (E)PPIs
Subsystems (2)
PATCH 1/1 irqchip/gic-v2,v3: Drop extra IRQ_NOAUTOEN setting for (E)PPIs
(E)PPIs are per-CPU interrupts, so we want each CPU to go and enable them via enable_percpu_irq(); this also means we want IRQ_NOAUTOEN for them as the autoenable would lead to calling irq_enable() instead of the more appropriate irq_percpu_enable().
Calling irq_set_percpu_devid() is enough to get just that since it trickles down to irq_set_percpu_devid_flags(), which gives us IRQ_NOAUTOEN (and a few others). Setting IRQ_NOAUTOEN *again* right after this call is just redundant, so don't do it.
--- drivers/irqchip/irq-gic-v3.c | 1 - drivers/irqchip/irq-gic.c | 1 - 2 files changed, 2 deletions(-)
drivers/irqchip/irq-gic-v3.c +0 -1
@@ -1282,7 +1282,6 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq,irq_set_percpu_devid (irq);irq_domain_set_info (d, irq, hw, chip, d->host_data, handle_percpu_devid_irq,NULL ,NULL ); -irq_set_status_flags (irq,IRQ_NOAUTOEN );break ;case SPI_RANGE :
drivers/irqchip/irq-gic.c +0 -1
@@ -982,7 +982,6 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq,irq_set_percpu_devid (irq);irq_domain_set_info (d, irq, hw, &gic->chip, d->host_data, handle_percpu_devid_irq,NULL ,NULL ); -irq_set_status_flags (irq,IRQ_NOAUTOEN ); }else {irq_domain_set_info (d, irq, hw, &gic->chip, d->host_data, handle_fasteoi_irq,NULL ,NULL );
Signature · 1 line
2.24.0
Re: [PATCH] irqchip/gic-v2, v3: Drop extra IRQ_NOAUTOEN setting for (E)PPIs
Quoted 11 lines · Valentin Schneider
(E)PPIs are per-CPU interrupts, so we want each CPU to go and enable them via
enable_percpu_irq(); this also means we wantIRQ_NOAUTOENfor them as the autoenable would lead to callingirq_enable()instead of the more appropriateirq_percpu_enable().Calling
irq_set_percpu_devid()is enough to get just that since it trickles down toirq_set_percpu_devid_flags(), which gives usIRQ_NOAUTOEN(and a few others). SettingIRQ_NOAUTOEN*again* right after this call is just redundant, so don't do it.[...]
Applied to irq/irqchip-next, thanks!
[1/1] irqchip/gic-v2, v3: Drop extra IRQ_NOAUTOEN setting for (E)PPIs
commit: cc86432aa8cc5a81f99d79eea2a29099da694df3
Cheers,
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
[tip: irq/core] irqchip/gic-v2, v3: Drop extra IRQ_NOAUTOEN setting for (E)PPIs
In reply to Valentin SchneiderThe following commit has been merged into the irq/core branch of tip:
The following commit has been merged into the irq/core branch of tip:
Commit-ID: cc86432aa8cc5a81f99d79eea2a29099da694df3 Gitweb: https://git.kernel.org/tip/cc86432aa8cc5a81f99d79eea2a29099da694df3 Author: Valentin Schneider <[email protected]> AuthorDate: Thu, 21 May 2020 23:35:00 +01:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Mon, 25 May 2020 10:32:51 +01:00
irqchip/gic-v2, v3: Drop extra IRQ_NOAUTOEN setting for (E)PPIs
(E)PPIs are per-CPU interrupts, so we want each CPU to go and enable them via enable_percpu_irq(); this also means we want IRQ_NOAUTOEN for them as the autoenable would lead to calling irq_enable() instead of the more appropriate irq_percpu_enable().
Calling irq_set_percpu_devid() is enough to get just that since it trickles down to irq_set_percpu_devid_flags(), which gives us IRQ_NOAUTOEN (and a few others). Setting IRQ_NOAUTOEN *again* right after this call is just redundant, so don't do it.
--- drivers/irqchip/irq-gic-v3.c | 1 - drivers/irqchip/irq-gic.c | 1 - 2 files changed, 2 deletions(-)
drivers/irqchip/irq-gic-v3.c +0 -1
@@ -1282,7 +1282,6 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq,irq_set_percpu_devid (irq);irq_domain_set_info (d, irq, hw, chip, d->host_data, handle_percpu_devid_irq,NULL ,NULL ); -irq_set_status_flags (irq,IRQ_NOAUTOEN );break ;case SPI_RANGE :
drivers/irqchip/irq-gic.c +0 -1
@@ -982,7 +982,6 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq,irq_set_percpu_devid (irq);irq_domain_set_info (d, irq, hw, &gic->chip, d->host_data, handle_percpu_devid_irq,NULL ,NULL ); -irq_set_status_flags (irq,IRQ_NOAUTOEN ); }else {irq_domain_set_info (d, irq, hw, &gic->chip, d->host_data, handle_fasteoi_irq,NULL ,NULL );