Skip to contentSkip to conversation

strace: fix failing ptests

PATCH In review Anuj Mittal 3 participants 4 messages May 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 strace: fix failing ptests

From: Alexander Kanavin <[email protected]>

1. They need to be run under regular user.
2. Some tests genuinely need more time than 30 seconds
3. The Makefile patch erroneously introduced a test-breaking change.

(From OE-Core rev: 3d6bf58c7080c1cacf3ed1f270ff5acf4858c790)

(cherry picked from commit a5e90281ac211e912ec6bfd6873e56152ec8bd4e)
---
 meta/recipes-devtools/strace/strace/Makefile-ptest.patch | 2 +-
 meta/recipes-devtools/strace/strace/run-ptest            | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)
meta/recipes-devtools/strace/strace/Makefile-ptest.patch +1 -1
index 08fa5c53b8..36e93a2dcf 100644
@@ -44,6 +44,6 @@ index 825c989..4623c48 100644
 +	done
 +	for file in $(EXTRA_DIST); do \
 +		install $(srcdir)/$$file $(DESTDIR)/$(TESTDIR); \
-+		sed -i -e 's/$${srcdir=.}/./g' $(DESTDIR)/$(TESTDIR)/$$file; \
++		#sed -i -e 's/$${srcdir=.}/./g' $(DESTDIR)/$(TESTDIR)/$$file; \
 +	done
 +	for i in net scm_rights-fd rt_sigaction; do sed -i -e 's/$$srcdir/./g' $(DESTDIR)/$(TESTDIR)/$$i.test; done
meta/recipes-devtools/strace/strace/run-ptest +5 -2
index 2fed984e90..4660207220 100755
@@ -1,3 +1,6 @@
 #!/bin/sh
-export TIMEOUT_DURATION=30
-make -B -C tests -k test-suite.log
+export TIMEOUT_DURATION=120
+chown nobody tests
+chown nobody tests/*
+chown nobody ../ptest
+su nobody -c "make -B -C tests -k test-suite.log"
Signature · 1 line
2.25.4
#1 lore raw

Is this for Zeus?

Quoted 52 lines · Anuj Mittal

From: Alexander Kanavin <[email protected]>

1. They need to be run under regular user.
2. Some tests genuinely need more time than 30 seconds
3. The Makefile patch erroneously introduced a test-breaking change.

(From OE-Core rev: 3d6bf58c7080c1cacf3ed1f270ff5acf4858c790)

(cherry picked from commit a5e90281ac211e912ec6bfd6873e56152ec8bd4e)
---
 meta/recipes-devtools/strace/strace/Makefile-ptest.patch | 2 +-
 meta/recipes-devtools/strace/strace/run-ptest            | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)
meta/recipes-devtools/strace/strace/Makefile-ptest.patch +1 -1
index 08fa5c53b8..36e93a2dcf 100644
@@ -44,6 +44,6 @@ index 825c989..4623c48 100644
 +      done
 +      for file in $(EXTRA_DIST); do \
 +              install $(srcdir)/$$file $(DESTDIR)/$(TESTDIR); \
-+              sed -i -e 's/$${srcdir=.}/./g'
 $(DESTDIR)/$(TESTDIR)/$$file; \
++              #sed -i -e 's/$${srcdir=.}/./g'
 $(DESTDIR)/$(TESTDIR)/$$file; \

+ done
+ for i in net scm_rights-fd rt_sigaction; do sed -i -e
's/$$srcdir/./g' $(DESTDIR)/$(TESTDIR)/$$i.test; done

meta/recipes-devtools/strace/strace/run-ptest +5 -3
index 2fed984e90..4660207220 100755
@@ -1,3 +1,6 @@
 #!/bin/sh
-export TIMEOUT_DURATION=30
-make -B -C tests -k test-suite.log
+export TIMEOUT_DURATION=120
+chown nobody tests
+chown nobody tests/*
+chown nobody ../ptest
+su nobody -c "make -B -C tests -k test-suite.log"
--

2.25.4

#2 lore raw
Quoted 1 line · Tim Orling

Is this for Zeus?

Yes, I forgot to include the prefix. Have sent it again with right prefix now.

Thanks,

Anuj

#3 lore raw

✗ patchtest: failure for strace: fix failing ptests

In reply to Anuj Mittal

== Series Details ==

Series: strace: fix failing ptests
Revision: 1
URL : https://patchwork.openembedded.org/series/24266/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 8fc19639f4)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe