Skip to contentSkip to conversation

dm-zoned: remove leftover hunk for switching to sequential zones

PATCH Superseded Hannes Reinecke 2 participants 2 messages May 22, 2020 Device mapper

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dm-zoned: remove leftover hunk for switching to sequential zones

Remove a leftover hunk to switch from sequential zones to random zones when selecting a reclaim zone; the logic has moved into the caller and this patch is now pointless.

Fixes 34f5affd04c4 ("dm zoned: separate random and cache zones")
---
 drivers/md/dm-zoned-metadata.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/md/dm-zoned-metadata.c +0 -8
index db0dc2b5d44d..4a2e351365c5 100644
@@ -2111,14 +2111,6 @@ struct dm_zone *dmz_alloc_zone(struct dmz_metadata *zmd, unsigned long flags)
 		 */
 		if (!(flags & DMZ_ALLOC_RECLAIM))
 			return NULL;
-		/*
-		 * Use sequential write zones if we started off with random
-		 * zones and the list is empty
-		 */
-		if (list == &zmd->unmap_rnd_list) {
-			list = &zmd->unmap_seq_list;
-			goto again;
-		}
 		/*
 		 * Fallback to the reserved sequential zones
 		 */
Signature · 1 line
2.25.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Hannes Reinecke

Remove a leftover hunk to switch from sequential zones to random

...from random zones to sequential zones...

Quoted 2 lines

zones when selecting a reclaim zone; the logic has moved into the caller and this patch is now pointless.

s/this patch/this hunk/ ?

Quoted 16 lines
Fixes 34f5affd04c4 ("dm zoned: separate random and cache zones")
---
 drivers/md/dm-zoned-metadata.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/md/dm-zoned-metadata.c +0 -1
index db0dc2b5d44d..4a2e351365c5 100644
@@ -2111,14 +2111,6 @@ struct dm_zone *dmz_alloc_zone(struct dmz_metadata *zmd, unsigned long flags)
 		 */
 		if (!(flags & DMZ_ALLOC_RECLAIM))
 			return NULL;
-		/*

drivers/md/dm-zoned-metadata.c struct dm_zone *dmz_alloc_zone(struct dmz_metadata *zmd, unsigned long flags) · line 2116

Quoted 10 lines
drivers/md/dm-zoned-metadata.c +0 -7
-		 * Use sequential write zones if we started off with random
-		 * zones and the list is empty
-		 */
-		if (list == &zmd->unmap_rnd_list) {
-			list = &zmd->unmap_seq_list;
-			goto again;
-		}
 		/*
 		 * Fallback to the reserved sequential zones
 		 */

Apart from the commit message nits, looks good.

Signature · 2 lines
Damien Le Moal
Western Digital Research