x86/idle: prevent entering C3/C6 on some Intel CPUs due to errata
PATCH 1/1 x86/idle: prevent entering C3/C6 on some Intel CPUs due to errata
Apply a workaround for errata BA80, AAK120, AAM108, AAO67, BD59,
AAY54: Rapid Core C3/C6 Transition May Cause Unpredictable System Behavior.
Limit maximum C state to C2 when SMT is enabled on the affected CPUs.
Signed-off-by Roger Pau Monné <[email protected]>
--- xen/arch/x86/cpu/intel.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+)
xen/arch/x86/cpu/intel.c +37 -0
@@ -296,6 +296,41 @@ static void early_init_intel(struct cpuinfo_x86 *c)ctxt_switch_levelling (NULL ); } +/* +* Errata BA80, AAK120, AAM108, AAO67, BD59, AAY54: Rapid Core C3/C6 Transition +* May Cause Unpredictable System Behavior +* +* Under a complex set of internal conditions, cores rapidly performing C3/C6 +* transitions in a system with Intel Hyper-Threading Technology enabled may +* cause a machine check error (IA32_MCi_STATUS.MCACOD = 0x0106), system hang +* or unpredictable system behavior. +*/ +static void probe_c3_errata (const struct cpuinfo_x86 *c) +{ +#define INTEL_FAM6_MODEL (m) { X86_VENDOR_INTEL, 6, m, X86_FEATURE_ALWAYS } +static const struct x86_cpu_id models[] = { +/* Nehalem */ +INTEL_FAM6_MODEL (0x1a ), +INTEL_FAM6_MODEL (0x1e ), +INTEL_FAM6_MODEL (0x1f ), +INTEL_FAM6_MODEL (0x2e ), +/* Westmere (note Westmere-EX is not affected) */ +INTEL_FAM6_MODEL (0x2c ), +INTEL_FAM6_MODEL (0x25 ), + { } + }; +#undef INTEL_FAM6_MODEL + +/* Serialized by the AP bringup code. */ +if ( max_cstate >1 && (c->apicid & (c->x86_num_siblings -1 )) && +x86_match_cpu (models) ) + { +printk (XENLOG_WARNING +"Disabling C-states C3 and C6 due to CPU errata\n" ); + max_cstate =1 ; + } +} +/* * P4 Xeon errata 037 workaround. * Hardware prefetcher may cause stale data to be loaded into the cache.
@@ -323,6 +358,8 @@ static void Intel_errata_workarounds(struct cpuinfo_x86 *c)if (cpu_has_tsx_force_abort && opt_rtm_abort)wrmsrl (MSR_TSX_FORCE_ABORT ,TSX_FORCE_ABORT_RTM ); + +probe_c3_errata (c); }
Signature · 1 line
2.26.2
Quoted 5 lines · Roger Pau Monne
Apply a workaround for errata BA80, AAK120, AAM108, AAO67, BD59,
AAY54: Rapid Core C3/C6 Transition May Cause Unpredictable System Behavior.Limit maximum C state to C2 when SMT is enabled on the affected CPUs.
C1
Quoted 1 line
Signed-off-by Roger Pau Monné <[email protected]>
Acked-by Andrew Cooper <[email protected]>
A fix for this is long overdue.
~Andrew