Skip to contentSkip to conversation

regulator: max14577: Add proper dt-compatible strings

PATCH Applied Marek Szyprowski 4 participants 6 messages May 22, 2020 – May 28, 2020 1 message not in the archive

Subsystems (5)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20200522102452eucas1p17c18de8f79e27de96474e5fcad6db5fa@eucas1p1.samsung.com

#1 lore raw

PATCH v3 1/3 regulator: max14577: Add proper dt-compatible strings

Add device tree compatible strings and create proper modalias structures to let this driver load automatically if compiled as module, because max14577 MFD driver creates MFD cells with such compatible strings.

---
v3:
- sorted of_max14577_regulator_dt_match
v2:
- added .of_match_table pointer

---
 drivers/regulator/max14577-regulator.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
drivers/regulator/max14577-regulator.c +12 -2
index 07a150c9bbf2..4c9ae52b9e87 100644
@@ -238,10 +238,20 @@ static const struct platform_device_id max14577_regulator_id[] = {
 };
 MODULE_DEVICE_TABLE(platform, max14577_regulator_id);
 
+static const struct of_device_id of_max14577_regulator_dt_match[] = {
+	{ .compatible = "maxim,max14577-regulator",
+	  .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
+	{ .compatible = "maxim,max77836-regulator",
+	  .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
+	{ },
+};
+MODULE_DEVICE_TABLE(of, of_max14577_regulator_dt_match);
+
 static struct platform_driver max14577_regulator_driver = {
 	.driver = {
-		   .name = "max14577-regulator",
-		   },
+		.name = "max14577-regulator",
+		.of_match_table = of_max14577_regulator_dt_match,
+	},
 	.probe		= max14577_regulator_probe,
 	.id_table	= max14577_regulator_id,
 };
Signature · 1 line
2.17.1
#2 lore raw

PATCH v3 2/3 extcon: max14577: Add proper dt-compatible strings

Add device tree compatible strings and create proper modalias structures to let this driver load automatically if compiled as module, because max14577 MFD driver creates MFD cells with such compatible strings.

---
v3:
- sorted of_max14577_muic_dt_match
v2:
- added .of_match_table pointer

---
 drivers/extcon/extcon-max14577.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/extcon/extcon-max14577.c +10 -0
index 32f663436e6e..03af678ddeba 100644
@@ -782,9 +782,19 @@ static const struct platform_device_id max14577_muic_id[] = {
 };
 MODULE_DEVICE_TABLE(platform, max14577_muic_id);
 
+static const struct of_device_id of_max14577_muic_dt_match[] = {
+	{ .compatible = "maxim,max14577-muic",
+	  .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
+	{ .compatible = "maxim,max77836-muic",
+	  .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
+	{ },
+};
+MODULE_DEVICE_TABLE(of, of_max14577_muic_dt_match);
+
 static struct platform_driver max14577_muic_driver = {
 	.driver		= {
 		.name	= "max14577-muic",
+		.of_match_table = of_max14577_muic_dt_match,
 	},
 	.probe		= max14577_muic_probe,
 	.remove		= max14577_muic_remove,
Signature · 1 line
2.17.1
maintainer Applied
#3 lore raw

Re: [PATCH v3 2/3] extcon: max14577: Add proper dt-compatible strings

Hi Marek,

Quoted 29 lines · Marek Szyprowski

Add device tree compatible strings and create proper modalias structures to let this driver load automatically if compiled as module, because max14577 MFD driver creates MFD cells with such compatible strings.

---
v3:
- sorted of_max14577_muic_dt_match
v2:
- added .of_match_table pointer

---
 drivers/extcon/extcon-max14577.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/extcon/extcon-max14577.c +6 -0
index 32f663436e6e..03af678ddeba 100644
@@ -782,9 +782,19 @@ static const struct platform_device_id max14577_muic_id[] = {
 };
 MODULE_DEVICE_TABLE(platform, max14577_muic_id);
 
+static const struct of_device_id of_max14577_muic_dt_match[] = {
+	{ .compatible = "maxim,max14577-muic",
+	  .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
+	{ .compatible = "maxim,max77836-muic",
+	  .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
+	{ },

drivers/extcon/extcon-max14577.c static const struct platform_device_id max14577_muic_id[] = { · line 800

Quoted 10 lines
drivers/extcon/extcon-max14577.c +4 -0
+};
+MODULE_DEVICE_TABLE(of, of_max14577_muic_dt_match);
+
 static struct platform_driver max14577_muic_driver = {
 	.driver		= {
 		.name	= "max14577-muic",
+		.of_match_table = of_max14577_muic_dt_match,
 	},
 	.probe		= max14577_muic_probe,
 	.remove		= max14577_muic_remove,

Applied it. Thanks.

Signature · 3 lines
Best Regards,
Chanwoo Choi
Samsung Electronics
#4 lore raw

PATCH v3 3/3 power: charger: max14577: Add proper dt-compatible strings

In reply to Marek Szyprowski

Add device tree compatible strings and create proper modalias structures to let this driver load automatically if compiled as module, because max14577 MFD driver creates MFD cells with such compatible strings.

---
v3:
- sorted of_max14577_charger_dt_match
v2:
- added .of_match_table pointer

---
 drivers/power/supply/max14577_charger.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/power/supply/max14577_charger.c +10 -0
index 8a59feac6468..96f4cd1941b2 100644
@@ -623,9 +623,19 @@ static const struct platform_device_id max14577_charger_id[] = {
 };
 MODULE_DEVICE_TABLE(platform, max14577_charger_id);
 
+static const struct of_device_id of_max14577_charger_dt_match[] = {
+	{ .compatible = "maxim,max14577-charger",
+	  .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
+	{ .compatible = "maxim,max77836-charger",
+	  .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
+	{ },
+};
+MODULE_DEVICE_TABLE(of, of_max14577_charger_dt_match);
+
 static struct platform_driver max14577_charger_driver = {
 	.driver = {
 		.name	= "max14577-charger",
+		.of_match_table = of_max14577_charger_dt_match,
 	},
 	.probe		= max14577_charger_probe,
 	.remove		= max14577_charger_remove,
Signature · 1 line
2.17.1
#5 lore raw

Re: [PATCH v3 3/3] power: charger: max14577: Add proper dt-compatible strings

Hi,

Quoted 6 lines · Marek Szyprowski

Add device tree compatible strings and create proper modalias structures to let this driver load automatically if compiled as module, because max14577 MFD driver creates MFD cells with such compatible strings.

---

I saw some discussion for patch 1, but still queued this considering the compatible string is already documented in the DT bindings and at least one of them is already being used in DT files.

TL;DR: Thanks, queued.

-- Sebastian

Quoted 35 lines

v3:
- sorted of_max14577_charger_dt_match
v2:
- added .of_match_table pointer

---
 drivers/power/supply/max14577_charger.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/power/supply/max14577_charger.c +10 -0
index 8a59feac6468..96f4cd1941b2 100644
@@ -623,9 +623,19 @@ static const struct platform_device_id max14577_charger_id[] = {
 };
 MODULE_DEVICE_TABLE(platform, max14577_charger_id);
 
+static const struct of_device_id of_max14577_charger_dt_match[] = {
+	{ .compatible = "maxim,max14577-charger",
+	  .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
+	{ .compatible = "maxim,max77836-charger",
+	  .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
+	{ },
+};
+MODULE_DEVICE_TABLE(of, of_max14577_charger_dt_match);
+
 static struct platform_driver max14577_charger_driver = {
 	.driver = {
 		.name	= "max14577-charger",
+		.of_match_table = of_max14577_charger_dt_match,
 	},
 	.probe		= max14577_charger_probe,
 	.remove		= max14577_charger_remove,
Signature · 1 line
2.17.1
maintainer
#6 lore raw
In reply to Marek Szyprowski
Quoted 3 lines · Marek Szyprowski

Add device tree compatible strings and create proper modalias structures to let this driver load automatically if compiled as module, because max14577 MFD driver creates MFD cells with such compatible strings.

Same issue as before, you're putting the current Linux model into DT without adding any additional description of the hardware.