i2c: designware: Get rid of PCI driver specifics in common code
Subsystems (3)
Andy Shevchenko
reviewerPATCH v2 1/7 i2c: designware: Get rid of PCI driver specifics in common code
Do not spread PCI specifics over common code. It seems to be a layering violation which can be easily avoided. Refactor PCI driver and drop PCI specifics from common code.
---
v2: new patch
drivers/i2c/busses/i2c-designware-core.h | 1 - drivers/i2c/busses/i2c-designware-pcidrv.c | 24 +++++++++++++--------- 2 files changed, 14 insertions(+), 11 deletions(-)
drivers/i2c/busses/i2c-designware-core.h +0 -1
@@ -232,7 +232,6 @@ struct dw_i2c_dev {struct reset_control *rst;struct i2c_client *slave;u32 (*get_clk_rate_khz) (struct dw_i2c_dev *dev); -struct dw_pci_controller *controller;int cmd_err;struct i2c_msg *msgs;int msgs_num;
drivers/i2c/busses/i2c-designware-pcidrv.c +14 -10
@@ -48,10 +48,10 @@ struct dw_pci_controller {u32 bus_num;u32 tx_fifo_depth;u32 rx_fifo_depth; -u32 clk_khz;u32 flags;struct dw_scl_sda_cfg *scl_sda_cfg;int (*setup)(struct pci_dev *pdev,struct dw_pci_controller *c); +u32 (*get_clk_rate_khz)(struct dw_i2c_dev *dev); };/* Merrifield HCNT/LCNT/SDA hold time */
@@ -80,6 +80,11 @@ static struct dw_scl_sda_cfg hsw_config = { .sda_hold = 0x9, }; +static u32 mfld_get_clk_rate_khz (struct dw_i2c_dev *dev) +{ +return 25000 ; +} +static int mfld_setup (struct pci_dev *pdev,struct dw_pci_controller *c) {struct dw_i2c_dev *dev =dev_get_drvdata (&pdev->dev);
@@ -120,13 +125,18 @@ static int mrfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)return -ENODEV ; } +static u32 ehl_get_clk_rate_khz (struct dw_i2c_dev *dev) +{ +return 100000 ; +} +static struct dw_pci_controller dw_pci_controllers[] = { [medfield] = { .bus_num =-1 , .tx_fifo_depth =32 , .rx_fifo_depth =32 , - .clk_khz =25000 , .setup = mfld_setup, + .get_clk_rate_khz = mfld_get_clk_rate_khz, }, [merrifield] = { .bus_num =-1 ,
@@ -158,7 +168,7 @@ static struct dw_pci_controller dw_pci_controllers[] = { .bus_num = -1, .tx_fifo_depth = 32, .rx_fifo_depth = 32, - .clk_khz = 100000, + .get_clk_rate_khz = ehl_get_clk_rate_khz, }, };
@@ -188,11 +198,6 @@ static int i2c_dw_pci_resume(struct device *dev) static UNIVERSAL_DEV_PM_OPS(i2c_dw_pm_ops, i2c_dw_pci_suspend, i2c_dw_pci_resume, NULL); -static u32 i2c_dw_get_clk_rate_khz (struct dw_i2c_dev *dev) -{ -return dev->controller->clk_khz; -} -static int i2c_dw_pci_probe (struct pci_dev *pdev,const struct pci_device_id *id) {
@@ -233,8 +238,7 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev,if (r <0 )return r; - dev->controller = controller; - dev->get_clk_rate_khz = i2c_dw_get_clk_rate_khz; + dev->get_clk_rate_khz = controller->get_clk_rate_khz; dev->timings.bus_freq_hz =I2C_MAX_FAST_MODE_FREQ ; dev->base =pcim_iomap_table (pdev)[0 ]; dev->dev = &pdev->dev;
Signature · 1 line
2.26.2
Andy Shevchenko
reviewerPATCH v2 2/7 i2c: designware: Include proper headers in i2c-desingware-core.h
This header is a user of some generic ones, include them respectively.
---
v2: new patch
drivers/i2c/busses/i2c-designware-core.h | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/i2c/busses/i2c-designware-core.h +9 -0
@@ -9,7 +9,13 @@* Copyright (C) 2009 Provigent Ltd. */ +#include <linux/bits.h> +#include <linux/compiler_types.h> +#include <linux/completion.h> +#include <linux/dev_printk.h> +#include <linux/errno.h> #include <linux/i2c.h> +#include <linux/types.h> #define DW_IC_DEFAULT_FUNCTIONALITY (I2C_FUNC_I2C | \ I2C_FUNC_SMBUS_BYTE | \
@@ -170,6 +176,9 @@ DW_IC_TX_ABRT_TXDATA_NOACK | \ DW_IC_TX_ABRT_GCALL_NOACK) +struct clk ; +struct device ; +struct reset_control ;/** * struct dw_i2c_dev - private i2c-designware data
Signature · 1 line
2.26.2
Andy Shevchenko
reviewerPATCH v2 3/7 i2c: designware: Move i2c_dw_validate_speed() helper to a common code
In reply to Andy ShevchenkoIn order to export array supported speed for wider use, move it to a header along with i2c_dw_validate_speed() helper moved to a common code.
No functional changes intended.
---
v2: move it to common code instead of being separate (Jarkko)
drivers/i2c/busses/i2c-designware-common.c | 24 +++++++++++++++++ drivers/i2c/busses/i2c-designware-core.h | 9 +++++++ drivers/i2c/busses/i2c-designware-platdrv.c | 29 ++++----------------- 3 files changed, 38 insertions(+), 24 deletions(-)
drivers/i2c/busses/i2c-designware-common.c +24 -0
@@ -116,6 +116,30 @@ int i2c_dw_set_reg_access(struct dw_i2c_dev *dev)return 0 ; } +int i2c_dw_validate_speed (struct dw_i2c_dev *dev) +{ +struct i2c_timings *t = &dev->timings; +unsigned int i; + +/* +* Only standard mode at 100kHz, fast mode at 400kHz, +* fast mode plus at 1MHz and high speed mode at 3.4MHz are supported. +*/ +for (i =0 ; i <ARRAY_SIZE (i2c_dw_supported_speeds); i++) { +if (t->bus_freq_hz == i2c_dw_supported_speeds[i]) +break ; + } +if (i ==ARRAY_SIZE (i2c_dw_supported_speeds)) { +dev_err (dev->dev, +"%d Hz is unsupported, only 100kHz, 400kHz, 1MHz and 3.4MHz are supported\n" , + t->bus_freq_hz); +return -EINVAL ; + } + +return 0 ; +} +EXPORT_SYMBOL_GPL (i2c_dw_validate_speed); +u32 i2c_dw_scl_hcnt (u32 ic_clk,u32 tSYMBOL,u32 tf,int cond,int offset) {/*
drivers/i2c/busses/i2c-designware-core.h +9 -0
@@ -359,3 +359,12 @@ extern int i2c_dw_probe_lock_support(struct dw_i2c_dev *dev);#else static inline int i2c_dw_probe_lock_support (struct dw_i2c_dev *dev) {return 0 ; }#endif + +static __maybe_unused const u32 i2c_dw_supported_speeds[] = { +I2C_MAX_HIGH_SPEED_MODE_FREQ , +I2C_MAX_FAST_MODE_PLUS_FREQ , +I2C_MAX_FAST_MODE_FREQ , +I2C_MAX_STANDARD_MODE_FREQ , +}; + +int i2c_dw_validate_speed (struct dw_i2c_dev *dev);
drivers/i2c/busses/i2c-designware-platdrv.c +5 -24
@@ -192,13 +192,6 @@ static void dw_i2c_plat_pm_cleanup(struct dw_i2c_dev *dev)pm_runtime_put_noidle (dev->dev); } -static const u32 supported_speeds[] = { -I2C_MAX_HIGH_SPEED_MODE_FREQ , -I2C_MAX_FAST_MODE_PLUS_FREQ , -I2C_MAX_FAST_MODE_FREQ , -I2C_MAX_STANDARD_MODE_FREQ , -}; -static int dw_i2c_plat_probe (struct platform_device *pdev) {struct dw_i2c_platform_data *pdata =dev_get_platdata (&pdev->dev);
@@ -241,11 +234,11 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)* Some DSTDs use a non standard speed, round down to the lowest * standard speed. */ -for (i =0 ; i <ARRAY_SIZE (supported_speeds); i++) { -if (acpi_speed >= supported_speeds[i]) +for (i =0 ; i <ARRAY_SIZE (i2c_dw_supported_speeds); i++) { +if (acpi_speed >= i2c_dw_supported_speeds[i])break ; } - acpi_speed = i <ARRAY_SIZE (supported_speeds) ? supported_speeds[i] :0 ; + acpi_speed = i <ARRAY_SIZE (i2c_dw_supported_speeds) ? i2c_dw_supported_speeds[i] :0 ;/* * Find bus speed from the "clock-frequency" device property, ACPI
@@ -266,21 +259,9 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)if (has_acpi_companion (&pdev->dev))dw_i2c_acpi_configure (pdev); -/* -* Only standard mode at 100kHz, fast mode at 400kHz, -* fast mode plus at 1MHz and high speed mode at 3.4MHz are supported. -*/ -for (i =0 ; i <ARRAY_SIZE (supported_speeds); i++) { -if (t->bus_freq_hz == supported_speeds[i]) -break ; - } -if (i ==ARRAY_SIZE (supported_speeds)) { -dev_err (&pdev->dev, -"%d Hz is unsupported, only 100kHz, 400kHz, 1MHz and 3.4MHz are supported\n" , - t->bus_freq_hz); - ret = -EINVAL ; + ret =i2c_dw_validate_speed (dev); +if (ret) goto exit_reset; - } ret =i2c_dw_probe_lock_support (dev);if (ret)
Signature · 1 line
2.26.2
Andy Shevchenko
reviewerPATCH v2 4/7 i2c: designware: Drop unneeded condition in i2c_dw_validate_speed()
In reply to Andy ShevchenkoWe may bailout directly from the loop instead of breaking it and testing a loop counter. This also gives advantages such as decreased indentation level along with dropped unneeded condition.
---
v2: new patch
drivers/i2c/busses/i2c-designware-common.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/i2c/busses/i2c-designware-common.c +6 -8
@@ -127,16 +127,14 @@ int i2c_dw_validate_speed(struct dw_i2c_dev *dev)*/ for (i =0 ; i <ARRAY_SIZE (i2c_dw_supported_speeds); i++) {if (t->bus_freq_hz == i2c_dw_supported_speeds[i]) -break ; - } -if (i ==ARRAY_SIZE (i2c_dw_supported_speeds)) { -dev_err (dev->dev, -"%d Hz is unsupported, only 100kHz, 400kHz, 1MHz and 3.4MHz are supported\n" , - t->bus_freq_hz); -return -EINVAL ; +return 0 ; } -return 0 ; +dev_err (dev->dev, +"%d Hz is unsupported, only 100kHz, 400kHz, 1MHz and 3.4MHz are supported\n" , + t->bus_freq_hz); + +return -EINVAL ; }EXPORT_SYMBOL_GPL (i2c_dw_validate_speed);
Signature · 1 line
2.26.2
Andy Shevchenko
reviewerPATCH v2 5/7 i2c: designware: Move ACPI parts into common module
In reply to Andy ShevchenkoFor possible code reuse in the future, move ACPI parts into common module.
---
v2: moved to a common code instead of being a separate (Jarkko)
drivers/i2c/busses/i2c-designware-common.c | 135 +++++++++++++++++++- drivers/i2c/busses/i2c-designware-core.h | 15 ++- drivers/i2c/busses/i2c-designware-platdrv.c | 111 +--------------- 3 files changed, 142 insertions(+), 119 deletions(-)
drivers/i2c/busses/i2c-designware-common.c +131 -4
@@ -8,17 +8,21 @@* Copyright (C) 2007 MontaVista Software Inc. * Copyright (C) 2009 Provigent Ltd. */ +#include <linux/acpi.h> #include <linux/clk.h> #include <linux/delay.h> -#include <linux/export.h> -#include <linux/errno.h> +#include <linux/device.h> #include <linux/err.h> +#include <linux/errno.h> +#include <linux/export.h> #include <linux/i2c.h> #include <linux/interrupt.h> #include <linux/io.h> +#include <linux/kernel.h> #include <linux/module.h> #include <linux/pm_runtime.h> #include <linux/swab.h> +#include <linux/types.h> #include "i2c-designware-core.h"
@@ -116,6 +120,13 @@ int i2c_dw_set_reg_access(struct dw_i2c_dev *dev)return 0 ; } +static const u32 supported_speeds[] = { +I2C_MAX_HIGH_SPEED_MODE_FREQ , +I2C_MAX_FAST_MODE_PLUS_FREQ , +I2C_MAX_FAST_MODE_FREQ , +I2C_MAX_STANDARD_MODE_FREQ , +}; +int i2c_dw_validate_speed (struct dw_i2c_dev *dev) {struct i2c_timings *t = &dev->timings;
@@ -125,8 +136,8 @@ int i2c_dw_validate_speed(struct dw_i2c_dev *dev)* Only standard mode at 100kHz, fast mode at 400kHz, * fast mode plus at 1MHz and high speed mode at 3.4MHz are supported. */ -for (i =0 ; i <ARRAY_SIZE (i2c_dw_supported_speeds); i++) { -if (t->bus_freq_hz == i2c_dw_supported_speeds[i]) +for (i =0 ; i <ARRAY_SIZE (supported_speeds); i++) { +if (t->bus_freq_hz == supported_speeds[i])return 0 ; }
@@ -138,6 +149,122 @@ int i2c_dw_validate_speed(struct dw_i2c_dev *dev) }EXPORT_SYMBOL_GPL (i2c_dw_validate_speed); +#ifdef CONFIG_ACPI + +#include <linux/dmi.h> + +/* +* The HCNT/LCNT information coming from ACPI should be the most accurate +* for given platform. However, some systems get it wrong. On such systems +* we get better results by calculating those based on the input clock. +*/ +static const struct dmi_system_id i2c_dw_no_acpi_params[] = { + { + .ident ="Dell Inspiron 7348" , + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"Dell Inc." ), +DMI_MATCH (DMI_PRODUCT_NAME ,"Inspiron 7348" ), + }, + }, + {} +}; + +static void i2c_dw_acpi_params (struct device *device,char method[], +u16 *hcnt,u16 *lcnt,u32 *sda_hold) +{ +struct acpi_buffer buf = {ACPI_ALLOCATE_BUFFER }; +acpi_handle handle =ACPI_HANDLE (device); +union acpi_object *obj; + +if (dmi_check_system (i2c_dw_no_acpi_params)) +return ; + +if (ACPI_FAILURE (acpi_evaluate_object (handle, method,NULL , &buf))) +return ; + + obj = (union acpi_object *)buf.pointer; +if (obj->type ==ACPI_TYPE_PACKAGE && obj->package.count ==3 ) { +const union acpi_object *objs = obj->package.elements; + + *hcnt = (u16 )objs[0 ].integer.value; + *lcnt = (u16 )objs[1 ].integer.value; + *sda_hold = (u32 )objs[2 ].integer.value; + } + +kfree (buf.pointer); +} + +int i2c_dw_acpi_configure (struct device *device) +{ +struct dw_i2c_dev *dev =dev_get_drvdata (device); +struct i2c_timings *t = &dev->timings; +u32 ss_ht =0 , fp_ht =0 , hs_ht =0 , fs_ht =0 ; + + dev->tx_fifo_depth =32 ; + dev->rx_fifo_depth =32 ; + +/* +* Try to get SDA hold time and *CNT values from an ACPI method for +* selected speed modes. +*/ +i2c_dw_acpi_params (device,"SSCN" , &dev->ss_hcnt, &dev->ss_lcnt, &ss_ht); +i2c_dw_acpi_params (device,"FPCN" , &dev->fp_hcnt, &dev->fp_lcnt, &fp_ht); +i2c_dw_acpi_params (device,"HSCN" , &dev->hs_hcnt, &dev->hs_lcnt, &hs_ht); +i2c_dw_acpi_params (device,"FMCN" , &dev->fs_hcnt, &dev->fs_lcnt, &fs_ht); + +switch (t->bus_freq_hz) { +case I2C_MAX_STANDARD_MODE_FREQ : + dev->sda_hold_time = ss_ht; +break ; +case I2C_MAX_FAST_MODE_PLUS_FREQ : + dev->sda_hold_time = fp_ht; +break ; +case I2C_MAX_HIGH_SPEED_MODE_FREQ : + dev->sda_hold_time = hs_ht; +break ; +case I2C_MAX_FAST_MODE_FREQ : +default : + dev->sda_hold_time = fs_ht; +break ; + } + +return 0 ; +} +EXPORT_SYMBOL_GPL (i2c_dw_acpi_configure); + +void i2c_dw_acpi_adjust_bus_speed (struct device *device) +{ +struct dw_i2c_dev *dev =dev_get_drvdata (device); +struct i2c_timings *t = &dev->timings; +u32 acpi_speed; +int i; + + acpi_speed =i2c_acpi_find_bus_speed (device); +/* +* Some DSTDs use a non standard speed, round down to the lowest +* standard speed. +*/ +for (i =0 ; i <ARRAY_SIZE (supported_speeds); i++) { +if (acpi_speed >= supported_speeds[i]) +break ; + } + acpi_speed = i <ARRAY_SIZE (supported_speeds) ? supported_speeds[i] :0 ; + +/* +* Find bus speed from the "clock-frequency" device property, ACPI +* or by using fast mode if neither is set. +*/ +if (acpi_speed && t->bus_freq_hz) + t->bus_freq_hz =min (t->bus_freq_hz, acpi_speed); +else if (acpi_speed || t->bus_freq_hz) + t->bus_freq_hz =max (t->bus_freq_hz, acpi_speed); +else + t->bus_freq_hz =I2C_MAX_FAST_MODE_FREQ ; +} +EXPORT_SYMBOL_GPL (i2c_dw_acpi_adjust_bus_speed); + +#endif /* CONFIG_ACPI */ +u32 i2c_dw_scl_hcnt (u32 ic_clk,u32 tSYMBOL,u32 tf,int cond,int offset) {/*
drivers/i2c/busses/i2c-designware-core.h +8 -7
@@ -360,11 +360,12 @@ extern int i2c_dw_probe_lock_support(struct dw_i2c_dev *dev);static inline int i2c_dw_probe_lock_support (struct dw_i2c_dev *dev) {return 0 ; }#endif -static __maybe_unused const u32 i2c_dw_supported_speeds[] = { -I2C_MAX_HIGH_SPEED_MODE_FREQ , -I2C_MAX_FAST_MODE_PLUS_FREQ , -I2C_MAX_FAST_MODE_FREQ , -I2C_MAX_STANDARD_MODE_FREQ , -}; -int i2c_dw_validate_speed (struct dw_i2c_dev *dev); + +#if IS_ENABLED (CONFIG_ACPI ) +int i2c_dw_acpi_configure (struct device *device); +void i2c_dw_acpi_adjust_bus_speed (struct device *device); +#else +static inline int i2c_dw_acpi_configure (struct device *device) {return -ENODEV ; } +static inline void i2c_dw_acpi_adjust_bus_speed (struct device *device) {} +#endif
drivers/i2c/busses/i2c-designware-platdrv.c +3 -108
147 lines not on this page · raw message
Signature · 1 line
2.26.2
Andy Shevchenko
reviewerPATCH v2 6/7 i2c: designware: Read counters from ACPI for PCI driver
In reply to Andy ShevchenkoPCI devices may have been backed with ACPI handle which supplies an additional information to the drivers, such as counters.
Call for ACPI configuration from PCI driver in order to utilize counters provided by ACPI.
---
v2: also call i2c_dw_acpi_adjust_bus_speed()
drivers/i2c/busses/i2c-designware-pcidrv.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/i2c/busses/i2c-designware-pcidrv.c +11 -0
@@ -255,6 +255,17 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev, } } +i2c_dw_acpi_adjust_bus_speed (&pdev->dev); + +if (has_acpi_companion (&pdev->dev)) +i2c_dw_acpi_configure (&pdev->dev); + + r =i2c_dw_validate_speed (dev); +if (r) { +pci_free_irq_vectors (pdev); +return r; + } +i2c_dw_configure (dev);if (controller->scl_sda_cfg) {
Signature · 1 line
2.26.2
Andy Shevchenko
reviewerPATCH v2 7/7 i2c: designware: Drop hard coded FIFO depth assignment
In reply to Andy ShevchenkoIt's not clear why the commit fe20ff5c7e9c
("i2c-designware: Add support for Designware core behind PCI devices.")
followed by commit b61b14154b19
("i2c-designware: add support for Intel Lynxpoint")
chose to hard code FIFO depth size. The FIFO depth on all hardware, I have tested on, can be nicely detected automatically.
Thus, we may safely drop hard coded FIFO sizes from the driver.
---
v2: new patch
drivers/i2c/busses/i2c-designware-common.c | 3 --- drivers/i2c/busses/i2c-designware-pcidrv.c | 17 ----------------- 2 files changed, 20 deletions(-)
drivers/i2c/busses/i2c-designware-common.c +0 -3
@@ -200,9 +200,6 @@ int i2c_dw_acpi_configure(struct device *device)struct i2c_timings *t = &dev->timings;u32 ss_ht =0 , fp_ht =0 , hs_ht =0 , fs_ht =0 ; - dev->tx_fifo_depth =32 ; - dev->rx_fifo_depth =32 ; -/* * Try to get SDA hold time and *CNT values from an ACPI method for * selected speed modes.
drivers/i2c/busses/i2c-designware-pcidrv.c +0 -17
@@ -46,8 +46,6 @@ struct dw_scl_sda_cfg {struct dw_pci_controller {u32 bus_num; -u32 tx_fifo_depth; -u32 rx_fifo_depth;u32 flags;struct dw_scl_sda_cfg *scl_sda_cfg;int (*setup)(struct pci_dev *pdev,struct dw_pci_controller *c);
@@ -133,41 +131,29 @@ static u32 ehl_get_clk_rate_khz(struct dw_i2c_dev *dev)static struct dw_pci_controller dw_pci_controllers[] = { [medfield] = { .bus_num =-1 , - .tx_fifo_depth =32 , - .rx_fifo_depth =32 , .setup = mfld_setup, .get_clk_rate_khz = mfld_get_clk_rate_khz, }, [merrifield] = { .bus_num =-1 , - .tx_fifo_depth =64 , - .rx_fifo_depth =64 , .scl_sda_cfg = &mrfld_config, .setup = mrfld_setup, }, [baytrail] = { .bus_num =-1 , - .tx_fifo_depth =32 , - .rx_fifo_depth =32 , .scl_sda_cfg = &byt_config, }, [haswell] = { .bus_num =-1 , - .tx_fifo_depth =32 , - .rx_fifo_depth =32 , .scl_sda_cfg = &hsw_config, }, [cherrytrail] = { .bus_num =-1 , - .tx_fifo_depth =32 , - .rx_fifo_depth =32 , .flags =MODEL_CHERRYTRAIL , .scl_sda_cfg = &byt_config, }, [elkhartlake] = { .bus_num =-1 , - .tx_fifo_depth =32 , - .rx_fifo_depth =32 , .get_clk_rate_khz = ehl_get_clk_rate_khz, }, };
@@ -277,9 +263,6 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev, dev->sda_hold_time = cfg->sda_hold; } - dev->tx_fifo_depth = controller->tx_fifo_depth; - dev->rx_fifo_depth = controller->rx_fifo_depth; - adap = &dev->adapter; adap->owner =THIS_MODULE ; adap->class =0 ;
Signature · 1 line
2.26.2
Quoted 11 lines · Andy Shevchenko
Do not spread PCI specifics over common code. It seems to be a layering violation which can be easily avoided. Refactor PCI driver and drop PCI specifics from common code.
Signed-off-by Andy Shevchenko <[email protected]>---
v2: new patchdrivers/i2c/busses/i2c-designware-core.h | 1 - drivers/i2c/busses/i2c-designware-pcidrv.c | 24 +++++++++++++--------- 2 files changed, 14 insertions(+), 11 deletions(-)
For all patches 1-7/7:
Andy Shevchenko
reviewerQuoted 12 lines · Jarkko Nikula
Quoted 11 lines · Andy Shevchenko
Do not spread PCI specifics over common code. It seems to be a layering violation which can be easily avoided. Refactor PCI driver and drop PCI specifics from common code.
Signed-off-by Andy Shevchenko <[email protected]>---
v2: new patchdrivers/i2c/busses/i2c-designware-core.h | 1 - drivers/i2c/busses/i2c-designware-pcidrv.c | 24 +++++++++++++--------- 2 files changed, 14 insertions(+), 11 deletions(-)
Quoted 3 lines
For all patches 1-7/7:
Acked-by Jarkko Nikula <[email protected]>
Thank you, Jarkko!
Wolfram, do we have a chance to get this into v5.8-rc1?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 6 lines
Quoted 2 lines
Acked-by Jarkko Nikula <[email protected]>Thank you, Jarkko!
Wolfram, do we have a chance to get this into v5.8-rc1?
I think so.
Wolfram Sang
AppliedQuoted 5 lines · Andy Shevchenko
Do not spread PCI specifics over common code. It seems to be a layering violation which can be easily avoided. Refactor PCI driver and drop PCI specifics from common code.
Signed-off-by Andy Shevchenko <[email protected]>
Applied to for-next, thanks!