x86/idle: Extend ISR/C6 erratum workaround to Haswell
PATCH 1/1 x86/idle: Extend ISR/C6 erratum workaround to Haswell
This bug was first discovered against Haswell. It is definitely affected.
(The XenServer ticket for this bug was opened on 2013-05-30 which is coming up on 7 years old, and predates Broadwell).
Signed-off-by Andrew Cooper <[email protected]>
---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>
We've followed up with Intel, but based on conversations, I was expecting Haswell to be treated the same as Broadwell in this regard.
--- xen/arch/x86/acpi/cpu_idle.c | 8 ++++++++ 1 file changed, 8 insertions(+)
xen/arch/x86/acpi/cpu_idle.c +8 -0
@@ -583,8 +583,16 @@ bool errata_c6_workaround(void)* registers), the processor may dispatch the second interrupt (from * the IRR bit) before the first interrupt has completed and written to * the EOI register, causing the first interrupt to never complete. +* +* Note: Haswell hasn't had errata issued, but this issue was first +* discovered on Haswell hardware, and is affected. */ static const struct x86_cpu_id isr_errata[] = { +/* Haswell */ +INTEL_FAM6_MODEL (0x3c ), +INTEL_FAM6_MODEL (0x3f ), +INTEL_FAM6_MODEL (0x45 ), +INTEL_FAM6_MODEL (0x46 ),/* Broadwell */ INTEL_FAM6_MODEL (0x47 ),INTEL_FAM6_MODEL (0x3d ),
Signature · 1 line
2.11.0
Quoted 6 lines · Andrew Cooper
This bug was first discovered against Haswell. It is definitely affected.
(The XenServer ticket for this bug was opened on 2013-05-30 which is coming up on 7 years old, and predates Broadwell).
Signed-off-by Andrew Cooper <[email protected]>
Acked-by Jan Beulich <[email protected]>