Skip to contentSkip to conversation

IB/cma: Fix ports memory leak in cma_configfs

PATCH Applied Leon Romanovsky 2 participants 2 messages May 21, 2020 – May 22, 2020 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IB/cma: Fix ports memory leak in cma_configfs

From: Maor Gottlieb <[email protected]>

The allocated ports structure in never freed. The free function should be called by release_cma_ports_group, but the group is never released since we don't remove its default group.

Remove default groups when device group is deleted.

Fixes 045959db65c6 ("IB/cma: Add configfs for rdma_cm")
---
 drivers/infiniband/core/cma_configfs.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
drivers/infiniband/core/cma_configfs.c +13 -0
index c672a4978bfd..5b6754f89a98 100644
@@ -322,8 +322,21 @@ static struct config_group *make_cma_dev(struct config_group *group,
 	return ERR_PTR(err);
 }
 
+static void drop_cma_dev(struct config_group *cgroup,
+		struct config_item *item)
+{
+	struct config_group *group =
+		container_of(item, struct config_group, cg_item);
+	struct cma_dev_group *cma_dev_group =
+		container_of(group, struct cma_dev_group, device_group);
+	configfs_remove_default_groups(&cma_dev_group->ports_group);
+	configfs_remove_default_groups(&cma_dev_group->device_group);
+	config_item_put(item);
+}
+
 static struct configfs_group_operations cma_subsys_group_ops = {
 	.make_group	= make_cma_dev,
+	.drop_item	= drop_cma_dev,
 };
 
 static const struct config_item_type cma_subsys_type = {

--
2.26.2

#1 lore raw
Quoted 6 lines · Leon Romanovsky

From: Maor Gottlieb <[email protected]>

The allocated ports structure in never freed. The free function should be called by release_cma_ports_group, but the group is never released since we don't remove its default group.

Quoted 8 lines

Remove default groups when device group is deleted.

Fixes 045959db65c6 ("IB/cma: Add configfs for rdma_cm")
---
 drivers/infiniband/core/cma_configfs.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Applied to for-next, thanks

Jason