arm-toolchain: gcc-aarch64-none-elf: Add recipe
PATCH 1/1 arm-toolchain: gcc-aarch64-none-elf: Add recipe
From: Denys Dmytriyenko <[email protected]>
Adds a recipe to pull down the prebuilt GCC for compiling bare-metal targets for Aarch64 processors from ARM.
--- .../gcc-aarch64-none-elf_9.2-2019.12.bb | 38 ++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb new file +38 -0
@@ -0,0 +1,38 @@ +# Copyright (C) 2020 Texas Instruments Inc. +# Released under the MIT license (see COPYING.MIT for the terms) + +SUMMARY = "Baremetal GCC for Aarch64 processors" +LICENSE = "GPL-3.0-with-GCC-exception & GPLv3" + +LIC_FILES_CHKSUM = "file://share/doc/gcc/GNU-Free-Documentation-License.html;md5=cc1e9a49a59ce7e6ae5ef37cd16eca0c" + +PROVIDES = "virtual/aarch64-none-elf-gcc" + +SRC_URI = "https://developer.arm.com/-/media/Files/downloads/gnu-a/9.2-2019.12/binrel/gcc-arm-${PV}-x86_64-aarch64-none-elf.tar.xz" + +SRC_URI[sha256sum] = "36d2cbe7c2984f2c20f562ac2f3ba524c59151adfa8ee10f1326c88de337b6d1" + +S = "${WORKDIR}/gcc-arm-${PV}-x86_64-aarch64-none-elf" + +COMPATIBLE_HOST = "x86_64.*-linux" + +do_install() { + install -d ${D}${datadir}/aarch64-none-elf/ + cp -r ${S}/. ${D}${datadir}/aarch64-none-elf/ + + install -d ${D}${bindir} + # Symlink all executables into bindir + for f in ${D}${datadir}/aarch64-none-elf/bin/aarch64-none-elf-*; do + lnr $f ${D}${bindir}/$(basename $f) + done +} + +FILES_${PN} = "${datadir} ${bindir}" + +INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps" + +INHIBIT_SYSROOT_STRIP = "1" +INHIBIT_PACKAGE_STRIP = "1" +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" + +BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
2.7.4
Quoted 53 lines · Denys Dmytriyenko
From: Denys Dmytriyenko <[email protected]>
Adds a recipe to pull down the prebuilt GCC for compiling bare-metal targets for Aarch64 processors from ARM.
Signed-off-by Denys Dmytriyenko <[email protected]>--- .../gcc-aarch64-none-elf_9.2-2019.12.bb | 38 ++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
diff --git b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb new file mode 100644
index 0000000..2ec0f9c
---/dev/null
+++
b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bbmeta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb new file +7
-0@@ -0,0 +1,38 @@ +# Copyright (C) 2020 Texas Instruments Inc. +# Released under the MIT license (see COPYING.MIT for the terms) + +SUMMARY = "Baremetal GCC for Aarch64 processors" +LICENSE = "GPL-3.0-with-GCC-exception & GPLv3" + +LIC_FILES_CHKSUM ="file://share/doc/gcc/GNU-Free-Documentation-License.html;md5=cc1e9a49a59ce7e6ae5ef37cd16eca0c"
meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb new file +4
-0+ +PROVIDES = "virtual/aarch64-none-elf-gcc" + +SRC_URI =(quoted diff) +2
-0+ +SRC_URI[sha256sum] ="
36d2cbe7c2984f2c20f562ac2f3ba524c59151adfa8ee10f1326c88de337b6d1"meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb new file +15
-0+ +S = "${WORKDIR}/gcc-arm-${PV}-x86_64-aarch64-none-elf" + +COMPATIBLE_HOST = "x86_64.*-linux" + +do_install() { + install -d ${D}${datadir}/aarch64-none-elf/ + cp -r ${S}/. ${D}${datadir}/aarch64-none-elf/ + + install -d ${D}${bindir} + # Symlink all executables into bindir + for f in ${D}${datadir}/aarch64-none-elf/bin/aarch64-none-elf-*; do + lnr $f ${D}${bindir}/$(basename $f) + done +}
meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb line 38
Quoted 10 lines
meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb new file +10
-0+ +FILES_${PN} = "${datadir} ${bindir}" + +INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps" + +INHIBIT_SYSROOT_STRIP = "1" +INHIBIT_PACKAGE_STRIP = "1" +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" + +BBCLASSEXTEND = "native nativesdk"
I see lots of commonalities (code duplication) with the gcc-arm-none-eabi_9-2019-q4-major.bb recipe. Isn't now a good opportunity to have a .inc to avoid this? The path inside the do_install can be easily controlled by a variable set from the recipes that are including it.
Quoted 4 lines
Signature · 1 line
2.7.4
Quoted 8 lines · Diego Sueiro
Quoted 7 lines · Denys Dmytriyenko
b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb new file +5
-0@@ -0,0 +1,38 @@ +# Copyright (C) 2020 Texas Instruments Inc. +# Released under the MIT license (see COPYING.MIT for the terms) + +SUMMARY = "Baremetal GCC for Aarch64 processors" +LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
<snip>
Quoted 3 lines
I see lots of commonalities (code duplication) with the gcc-arm-none-eabi_9-2019-q4-major.bb recipe. Isn't now a good opportunity to have a
.incto avoid this?
Yes, there's lots of duplication in those 2 recipes. Unfortunately, there's copyright in the original one and I cannot touch it w/o a lawyer. That's why I don't like copyrights in recipes (nothing much to copyright there anyway)
Quoted 2 lines
The path inside the
do_installcan be easily controlled by a variable set from the recipes that are including it.
Well, those are technical details I can handle quite easily - I've been doing OE for 13+ years. But it is legal issues where I draw the line...
Signature · 1 line
Denys
Quoted 12 lines · Denys Dmytriyenko
Quoted 8 lines · Diego Sueiro
Quoted 7 lines · Denys Dmytriyenko
b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb new file +5
-0@@ -0,0 +1,38 @@ +# Copyright (C) 2020 Texas Instruments Inc. +# Released under the MIT license (see COPYING.MIT for the terms) + +SUMMARY = "Baremetal GCC for Aarch64 processors" +LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"<snip>
Quoted 7 lines
Quoted 3 lines
I see lots of commonalities (code duplication) with the gcc-arm-none-eabi_9-2019-q4-major.bb recipe. Isn't now a good opportunity to have a
.incto avoid this?Yes, there's lots of duplication in those 2 recipes. Unfortunately, there's copyright in the original one and I cannot touch it w/o a lawyer. That's why I don't like copyrights in recipes (nothing much to copyright there anyway)
I'm confused. You mean the MIT license in gcc-arm-none-eabi_9-2019-q4-major.bb? If so, is it not the same as the license you reference above in your patch?
Quoted 5 lines
Quoted 2 lines
The path inside the
do_installcan be easily controlled by a variable set from the recipes that are including it.Well, those are technical details I can handle quite easily - I've been doing OE for 13+ years. But it is legal issues where I draw the line...
Assuming it's the MIT license, and you are unwilling to do it, I can pull it in and make the common inc file.
Thanks,
Jon
Quoted 5 lines
Signature · 2 lines
-- Denys
Quoted 25 lines · Jon Mason
Quoted 12 lines · Denys Dmytriyenko
Quoted 8 lines · Diego Sueiro
Quoted 7 lines · Denys Dmytriyenko
b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb new file +5
-0@@ -0,0 +1,38 @@ +# Copyright (C) 2020 Texas Instruments Inc. +# Released under the MIT license (see COPYING.MIT for the terms) + +SUMMARY = "Baremetal GCC for Aarch64 processors" +LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"<snip>
Quoted 7 lines
Quoted 3 lines
I see lots of commonalities (code duplication) with the gcc-arm-none-eabi_9-2019-q4-major.bb recipe. Isn't now a good opportunity to have a
.incto avoid this?Yes, there's lots of duplication in those 2 recipes. Unfortunately, there's copyright in the original one and I cannot touch it w/o a lawyer. That's why I don't like copyrights in recipes (nothing much to copyright there anyway)
I'm confused. You mean the MIT license in gcc-arm-none-eabi_9-2019-q4-major.bb? If so, is it not the same as the license you reference above in your patch?
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
The path inside the
do_installcan be easily controlled by a variable set from the recipes that are including it.Well, those are technical details I can handle quite easily - I've been doing OE for 13+ years. But it is legal issues where I draw the line...
Assuming it's the MIT license, and you are unwilling to do it, I can pull it in and make the common inc file.
I've been discussing this with Joshua offline lately - give me a bit more time to sort it out, hopefully I can come up with a solution. If not, I'll let you know. Thanks.
Signature · 1 line
Denys
Quoted 32 lines · Denys Dmytriyenko
Quoted 31 lines · Jon Mason
Quoted 12 lines · Denys Dmytriyenko
Quoted 8 lines · Diego Sueiro
Quoted 7 lines · Denys Dmytriyenko
b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
(quoted diff) +5
-0@@ -0,0 +1,38 @@ +# Copyright (C) 2020 Texas Instruments Inc. +# Released under the MIT license (see COPYING.MIT for the terms) + +SUMMARY = "Baremetal GCC for Aarch64 processors" +LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"<snip>
Quoted 7 lines
Quoted 3 lines
I see lots of commonalities (code duplication) with the gcc-arm-none-eabi_9-2019-q4-major.bb recipe. Isn't now a good opportunity to have a
.incto avoid this?Yes, there's lots of duplication in those 2 recipes. Unfortunately, there's copyright in the original one and I cannot touch it w/o a lawyer. That's why I don't like copyrights in recipes (nothing much to copyright there anyway)
I'm confused. You mean the MIT license in gcc-arm-none-eabi_9-2019-q4-major.bb? If so, is it not the same as the license you reference above in your patch?
Quoted 5 lines
Quoted 2 lines
The path inside the
do_installcan be easily controlled by a variable set from the recipes that are including it.Well, those are technical details I can handle quite easily - I've been doing OE for 13+ years. But it is legal issues where I draw the line...
Quoted 9 lines
Quoted 2 lines
Assuming it's the MIT license, and you are unwilling to do it, I can pull it in and make the common inc file.
I've been discussing this with Joshua offline lately - give me a bit more time to sort it out, hopefully I can come up with a solution. If not, I'll let you know. Thanks.
Signature · 1 line
Denys
100% untested, but I think the following might work
commit aa673cf5cb64ddb7d91a6281556e9d02daa78546
Author: Jon Mason <[email protected]> Date: Thu May 28 09:33:17 2020 -0400
Unification of recipes
meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb +0 -10
@@ -14,7 +14,6 @@ SRC_URI[sha256sum] = "36d2cbe7c2984f2c20f562ac2f3ba524c59151adfa8ee10f1326c88de3 S = "${WORKDIR}/gcc-arm-${PV}-x86_64-aarch64-none-elf" -COMPATIBLE_HOST = "x86_64.*-linux" do_install() { install -d ${D}${datadir}/aarch64-none-elf/
@@ -27,12 +26,3 @@ do_install() { done } -FILES_${PN} = "${datadir} ${bindir}" - -INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps" - -INHIBIT_SYSROOT_STRIP = "1" -INHIBIT_PACKAGE_STRIP = "1" -INHIBIT_PACKAGE_DEBUG_SPLIT = "1" - -BBCLASSEXTEND = "native nativesdk"
meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb +0 -14
@@ -13,10 +13,6 @@ SRC_URI = "https://developer.arm.com/-/media/Files/downloads/gnu-rm/9-2019q4/${B SRC_URI[md5sum] = "fe0029de4f4ec43cf7008944e34ff8cc" SRC_URI[sha256sum] = "bcd840f839d5bf49279638e9f67890b2ef3a7c9c7a9b25271e83ec4ff41d177a" -S = "${WORKDIR}/${BPN}-${PV}" - -COMPATIBLE_HOST = "x86_64.*-linux" - do_install() { install -d ${D}${datadir}/arm-none-eabi/ cp -r ${S}/. ${D}${datadir}/arm-none-eabi/
@@ -27,13 +23,3 @@ do_install() { lnr $f ${D}${bindir}/$(basename $f) done } - -FILES_${PN} = "${datadir} ${bindir}" - -INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps" - -INHIBIT_SYSROOT_STRIP = "1" -INHIBIT_PACKAGE_STRIP = "1" -INHIBIT_PACKAGE_DEBUG_SPLIT = "1" - -BBCLASSEXTEND = "native nativesdk"
meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc new file +27 -0
@@ -0,0 +1,27 @@ + +S = "${WORKDIR}/${BPN}-${PV}" + +COMPATIBLE_HOST = "x86_64.*-linux" + +FILES_${PN} = "${datadir} ${bindir}" + +NAME = "${BPN}".strip("gcc-") + +do_install() { + install -d ${D}${datadir}/${NAME}/ + cp -r ${S}/. ${D}${datadir}/${NAME}/ + + install -d ${D}${bindir} + # Symlink all executables into bindir + for f in ${D}${datadir}/${NAME}/bin/${NAME}-*; do + lnr $f ${D}${bindir}/$(basename $f) + done +} + +INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps" + +INHIBIT_SYSROOT_STRIP = "1" +INHIBIT_PACKAGE_STRIP = "1" +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" + +BBCLASSEXTEND = "native nativesdk"
Quoted 36 lines · Jon Mason
Quoted 35 lines · Denys Dmytriyenko
Quoted 33 lines · Jon Mason
Quoted 12 lines · Denys Dmytriyenko
Quoted 8 lines · Diego Sueiro
Quoted 7 lines · Denys Dmytriyenko
b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
(quoted diff) +5
-0@@ -0,0 +1,38 @@ +# Copyright (C) 2020 Texas Instruments Inc. +# Released under the MIT license (see COPYING.MIT for the terms) + +SUMMARY = "Baremetal GCC for Aarch64 processors" +LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"<snip>
Quoted 7 lines
Quoted 3 lines
I see lots of commonalities (code duplication) with the gcc-arm-none-eabi_9-2019-q4-major.bb recipe. Isn't now a good opportunity to have a
.incto avoid this?Yes, there's lots of duplication in those 2 recipes. Unfortunately, there's copyright in the original one and I cannot touch it w/o a lawyer. That's why I don't like copyrights in recipes (nothing much to copyright there anyway)
I'm confused. You mean the MIT license in gcc-arm-none-eabi_9-2019-q4-major.bb? If so, is it not the same as the license you reference above in your patch?
Quoted 5 lines
Quoted 2 lines
The path inside the
do_installcan be easily controlled by a variable set from the recipes that are including it.Well, those are technical details I can handle quite easily - I've been doing OE for 13+ years. But it is legal issues where I draw the line...
Assuming it's the MIT license, and you are unwilling to do it, I can pull it in and make the common inc file.
Quoted 8 lines
Quoted 6 lines
I've been discussing this with Joshua offline lately - give me a bit more time to sort it out, hopefully I can come up with a solution. If not, I'll let you know. Thanks.
Signature · 1 line
Denys100% untested, but I think the following might work
Thanks, Jon. This is a step in the right direction, but I see you define NAME variable and a common do_install that uses it, but you didn't remove specific do_install versions from the corresponding recipes...
Also, for this commit you'd have to accept my original patch submission to add aarch64 version. Or do you plan to squash them?
Denys
Quoted 96 lines
commit
aa673cf5cb64ddb7d91a6281556e9d02daa78546Author: Jon Mason <[email protected]> Date: Thu May 28 09:33:17 2020 -0400Unification of recipes
Signed-off-by Jon Mason <[email protected]>meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb +0
-10@@ -14,7 +14,6 @@ SRC_URI[sha256sum] = "36d2cbe7c2984f2c20f562ac2f3ba524c59151adfa8ee10f1326c88de3 S = "${WORKDIR}/gcc-arm-${PV}-x86_64-aarch64-none-elf" -COMPATIBLE_HOST = "x86_64.*-linux" do_install() { install -d ${D}${datadir}/aarch64-none-elf/@@ -27,12 +26,3 @@ do_install() { done } -FILES_${PN} = "${datadir} ${bindir}" - -INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps" - -INHIBIT_SYSROOT_STRIP = "1" -INHIBIT_PACKAGE_STRIP = "1" -INHIBIT_PACKAGE_DEBUG_SPLIT = "1" - -BBCLASSEXTEND = "native nativesdk"meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb +0
-14@@ -13,10 +13,6 @@ SRC_URI = "https://developer.arm.com/-/media/Files/downloads/gnu-rm/9-2019q4/${B SRC_URI[md5sum] = "fe0029de4f4ec43cf7008944e34ff8cc" SRC_URI[sha256sum] = "bcd840f839d5bf49279638e9f67890b2ef3a7c9c7a9b25271e83ec4ff41d177a" -S = "${WORKDIR}/${BPN}-${PV}" - -COMPATIBLE_HOST = "x86_64.*-linux" - do_install() { install -d ${D}${datadir}/arm-none-eabi/ cp -r ${S}/. ${D}${datadir}/arm-none-eabi/@@ -27,13 +23,3 @@ do_install() { lnr $f ${D}${bindir}/$(basename $f) done } - -FILES_${PN} = "${datadir} ${bindir}" - -INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps" - -INHIBIT_SYSROOT_STRIP = "1" -INHIBIT_PACKAGE_STRIP = "1" -INHIBIT_PACKAGE_DEBUG_SPLIT = "1" - -BBCLASSEXTEND = "native nativesdk"meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc new file +27
-0@@ -0,0 +1,27 @@ + +S = "${WORKDIR}/${BPN}-${PV}" + +COMPATIBLE_HOST = "x86_64.*-linux" + +FILES_${PN} = "${datadir} ${bindir}" + +NAME = "${BPN}".strip("gcc-") + +do_install() { + install -d ${D}${datadir}/${NAME}/ + cp -r ${S}/. ${D}${datadir}/${NAME}/ + + install -d ${D}${bindir} + # Symlink all executables into bindir + for f in ${D}${datadir}/${NAME}/bin/${NAME}-*; do + lnr $f ${D}${bindir}/$(basename $f) + done +} + +INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps" + +INHIBIT_SYSROOT_STRIP = "1" +INHIBIT_PACKAGE_STRIP = "1" +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" + +BBCLASSEXTEND = "native nativesdk"
Quoted 41 lines · Denys Dmytriyenko
Quoted 40 lines · Jon Mason
Quoted 39 lines · Denys Dmytriyenko
Quoted 25 lines · Jon Mason
Quoted 12 lines · Denys Dmytriyenko
Quoted 8 lines · Diego Sueiro
Quoted 7 lines · Denys Dmytriyenko
b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
(quoted diff) +5
-0@@ -0,0 +1,38 @@ +# Copyright (C) 2020 Texas Instruments Inc. +# Released under the MIT license (see COPYING.MIT for the terms) + +SUMMARY = "Baremetal GCC for Aarch64 processors" +LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"<snip>
Quoted 7 lines
Quoted 3 lines
I see lots of commonalities (code duplication) with the gcc-arm-none-eabi_9-2019-q4-major.bb recipe. Isn't now a good opportunity to have a
.incto avoid this?Yes, there's lots of duplication in those 2 recipes. Unfortunately, there's copyright in the original one and I cannot touch it w/o a lawyer. That's why I don't like copyrights in recipes (nothing much to copyright there anyway)
I'm confused. You mean the MIT license in gcc-arm-none-eabi_9-2019-q4-major.bb? If so, is it not the same as the license you reference above in your patch?
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
The path inside the
do_installcan be easily controlled by a variable set from the recipes that are including it.Well, those are technical details I can handle quite easily - I've been doing OE for 13+ years. But it is legal issues where I draw the line...
Assuming it's the MIT license, and you are unwilling to do it, I can pull it in and make the common inc file.
I've been discussing this with Joshua offline lately - give me a bit more time to sort it out, hopefully I can come up with a solution. If not, I'll let you know. Thanks.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Signature · 1 line
Denys100% untested, but I think the following might work
Thanks, Jon. This is a step in the right direction, but I see you define NAME variable and a common
do_installthat uses it, but you didn't remove specificdo_installversions from the corresponding recipes...
Slop from trying to get the patch out and not committing what I had locally. I was more showing this to see if the "NAME" way I did it was an acceptable "Yocto" way to resolve the issue (instead of a dirty hack).
Quoted 2 lines
Also, for this commit you'd have to accept my original patch submission to add aarch64 version. Or do you plan to squash them?
I'm fine with either way. It is probably easier to pull in yours as-is and do mine as a follow-on, unless someone has a strong opinion against.
Thanks,
Jon
Quoted 99 lines
Denys
Quoted 96 lines
commit
aa673cf5cb64ddb7d91a6281556e9d02daa78546Author: Jon Mason <[email protected]> Date: Thu May 28 09:33:17 2020 -0400Unification of recipes
Signed-off-by Jon Mason <[email protected]>meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb +0
-10@@ -14,7 +14,6 @@ SRC_URI[sha256sum] = "36d2cbe7c2984f2c20f562ac2f3ba524c59151adfa8ee10f1326c88de3 S = "${WORKDIR}/gcc-arm-${PV}-x86_64-aarch64-none-elf" -COMPATIBLE_HOST = "x86_64.*-linux" do_install() { install -d ${D}${datadir}/aarch64-none-elf/@@ -27,12 +26,3 @@ do_install() { done } -FILES_${PN} = "${datadir} ${bindir}" - -INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps" - -INHIBIT_SYSROOT_STRIP = "1" -INHIBIT_PACKAGE_STRIP = "1" -INHIBIT_PACKAGE_DEBUG_SPLIT = "1" - -BBCLASSEXTEND = "native nativesdk"meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb +0
-14@@ -13,10 +13,6 @@ SRC_URI = "https://developer.arm.com/-/media/Files/downloads/gnu-rm/9-2019q4/${B SRC_URI[md5sum] = "fe0029de4f4ec43cf7008944e34ff8cc" SRC_URI[sha256sum] = "bcd840f839d5bf49279638e9f67890b2ef3a7c9c7a9b25271e83ec4ff41d177a" -S = "${WORKDIR}/${BPN}-${PV}" - -COMPATIBLE_HOST = "x86_64.*-linux" - do_install() { install -d ${D}${datadir}/arm-none-eabi/ cp -r ${S}/. ${D}${datadir}/arm-none-eabi/@@ -27,13 +23,3 @@ do_install() { lnr $f ${D}${bindir}/$(basename $f) done } - -FILES_${PN} = "${datadir} ${bindir}" - -INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps" - -INHIBIT_SYSROOT_STRIP = "1" -INHIBIT_PACKAGE_STRIP = "1" -INHIBIT_PACKAGE_DEBUG_SPLIT = "1" - -BBCLASSEXTEND = "native nativesdk"meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc new file +27
-0@@ -0,0 +1,27 @@ + +S = "${WORKDIR}/${BPN}-${PV}" + +COMPATIBLE_HOST = "x86_64.*-linux" + +FILES_${PN} = "${datadir} ${bindir}" + +NAME = "${BPN}".strip("gcc-") + +do_install() { + install -d ${D}${datadir}/${NAME}/ + cp -r ${S}/. ${D}${datadir}/${NAME}/ + + install -d ${D}${bindir} + # Symlink all executables into bindir + for f in ${D}${datadir}/${NAME}/bin/${NAME}-*; do + lnr $f ${D}${bindir}/$(basename $f) + done +} + +INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps" + +INHIBIT_SYSROOT_STRIP = "1" +INHIBIT_PACKAGE_STRIP = "1" +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" + +BBCLASSEXTEND = "native nativesdk"
Quoted 47 lines · Jon Mason
Quoted 46 lines · Denys Dmytriyenko
Quoted 44 lines · Jon Mason
Quoted 32 lines · Denys Dmytriyenko
Quoted 31 lines · Jon Mason
Quoted 12 lines · Denys Dmytriyenko
Quoted 8 lines · Diego Sueiro
Quoted 7 lines · Denys Dmytriyenko
b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
(quoted diff) +5
-0@@ -0,0 +1,38 @@ +# Copyright (C) 2020 Texas Instruments Inc. +# Released under the MIT license (see COPYING.MIT for the terms) + +SUMMARY = "Baremetal GCC for Aarch64 processors" +LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"<snip>
Quoted 7 lines
Quoted 3 lines
I see lots of commonalities (code duplication) with the gcc-arm-none-eabi_9-2019-q4-major.bb recipe. Isn't now a good opportunity to have a
.incto avoid this?Yes, there's lots of duplication in those 2 recipes. Unfortunately, there's copyright in the original one and I cannot touch it w/o a lawyer. That's why I don't like copyrights in recipes (nothing much to copyright there anyway)
I'm confused. You mean the MIT license in gcc-arm-none-eabi_9-2019-q4-major.bb? If so, is it not the same as the license you reference above in your patch?
Quoted 5 lines
Quoted 2 lines
The path inside the
do_installcan be easily controlled by a variable set from the recipes that are including it.Well, those are technical details I can handle quite easily - I've been doing OE for 13+ years. But it is legal issues where I draw the line...
Quoted 9 lines
Quoted 2 lines
Assuming it's the MIT license, and you are unwilling to do it, I can pull it in and make the common inc file.
I've been discussing this with Joshua offline lately - give me a bit more time to sort it out, hopefully I can come up with a solution. If not, I'll let you know. Thanks.
Signature · 1 line
Denys100% untested, but I think the following might work
Quoted 8 lines
Quoted 3 lines
Thanks, Jon. This is a step in the right direction, but I see you define NAME variable and a common
do_installthat uses it, but you didn't remove specificdo_installversions from the corresponding recipes...Slop from trying to get the patch out and not committing what I had locally. I was more showing this to see if the "NAME" way I did it was an acceptable "Yocto" way to resolve the issue (instead of a dirty hack).
Sounds good. Let me know if you have an updated version to review.
Quoted 6 lines
Quoted 2 lines
Also, for this commit you'd have to accept my original patch submission to add aarch64 version. Or do you plan to squash them?
I'm fine with either way. It is probably easier to pull in yours as-is and do mine as a follow-on, unless someone has a strong opinion against.
I think merging mine as-is and then follow-up with unification would be the most appropriate when it comes to copyrights and legal stuff. Sorry it causes extra issues, but I'm just trying to be extra careful around this stuff...
Signature · 1 line
Denys
Quoted 52 lines · Denys Dmytriyenko
Quoted 51 lines · Jon Mason
Quoted 49 lines · Denys Dmytriyenko
Quoted 36 lines · Jon Mason
Quoted 35 lines · Denys Dmytriyenko
Quoted 33 lines · Jon Mason
Quoted 12 lines · Denys Dmytriyenko
Quoted 8 lines · Diego Sueiro
Quoted 7 lines · Denys Dmytriyenko
b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
(quoted diff) +5
-0@@ -0,0 +1,38 @@ +# Copyright (C) 2020 Texas Instruments Inc. +# Released under the MIT license (see COPYING.MIT for the terms) + +SUMMARY = "Baremetal GCC for Aarch64 processors" +LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"<snip>
Quoted 7 lines
Quoted 3 lines
I see lots of commonalities (code duplication) with the gcc-arm-none-eabi_9-2019-q4-major.bb recipe. Isn't now a good opportunity to have a
.incto avoid this?Yes, there's lots of duplication in those 2 recipes. Unfortunately, there's copyright in the original one and I cannot touch it w/o a lawyer. That's why I don't like copyrights in recipes (nothing much to copyright there anyway)
I'm confused. You mean the MIT license in gcc-arm-none-eabi_9-2019-q4-major.bb? If so, is it not the same as the license you reference above in your patch?
Quoted 5 lines
Quoted 2 lines
The path inside the
do_installcan be easily controlled by a variable set from the recipes that are including it.Well, those are technical details I can handle quite easily - I've been doing OE for 13+ years. But it is legal issues where I draw the line...
Assuming it's the MIT license, and you are unwilling to do it, I can pull it in and make the common inc file.
Quoted 8 lines
Quoted 6 lines
I've been discussing this with Joshua offline lately - give me a bit more time to sort it out, hopefully I can come up with a solution. If not, I'll let you know. Thanks.
Signature · 1 line
Denys100% untested, but I think the following might work
Thanks, Jon. This is a step in the right direction, but I see you define NAME variable and a common
do_installthat uses it, but you didn't remove specificdo_installversions from the corresponding recipes...
Quoted 6 lines
Quoted 4 lines
Slop from trying to get the patch out and not committing what I had locally. I was more showing this to see if the "NAME" way I did it was an acceptable "Yocto" way to resolve the issue (instead of a dirty hack).
Sounds good. Let me know if you have an updated version to review.
Okay, I'll send out an updated version of the path shortly.
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Also, for this commit you'd have to accept my original patch submission to add aarch64 version. Or do you plan to squash them?
Quoted 7 lines
Quoted 3 lines
I'm fine with either way. It is probably easier to pull in yours as-is and do mine as a follow-on, unless someone has a strong opinion against.
I think merging mine as-is and then follow-up with unification would be the most appropriate when it comes to copyrights and legal stuff. Sorry it causes extra issues, but I'm just trying to be extra careful around this stuff...
No problem. Patch merged to master.
Thanks,
Jon
Quoted 3 lines
Signature · 2 lines
-- Denys