Skip to contentSkip to conversation

MAINTAINERS: Update my maintainer entries to reorder email addresses

PATCH In review Shuah Khan 3 participants 9 messages May 23, 2020 – May 26, 2020

lore
Share & tools
lore

Shuah Khan

author
#0 lore raw

PATCH 1/1 MAINTAINERS: Update my maintainer entries to reorder email addresses

get_maintainer.pl picks only the first email address found in the file. Reorder my email addresses so it finds my linuxfoundation.org email.

---
 MAINTAINERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
MAINTAINERS +3 -3
index ecc0749810b0..dbad8b18bfe6 100644
@@ -4404,8 +4404,8 @@ F:	include/linux/cpuidle.h
 
 CPU POWER MONITORING SUBSYSTEM
 M:	Thomas Renninger <[email protected]>
-M:	Shuah Khan <[email protected]>
 M:	Shuah Khan <[email protected]>
+M:	Shuah Khan <[email protected]>
 L:	[email protected]
 S:	Maintained
 F:	tools/power/cpupower/
@@ -9238,8 +9238,8 @@ F:	include/uapi/linux/sunrpc/
 F:	net/sunrpc/
 
 KERNEL SELFTEST FRAMEWORK
-M:	Shuah Khan <[email protected]>
 M:	Shuah Khan <[email protected]>
+M:	Shuah Khan <[email protected]>
 L:	[email protected]
 S:	Maintained
 Q:	https://patchwork.kernel.org/project/linux-kselftest/list/
@@ -17484,8 +17484,8 @@ F:	drivers/usb/common/usb-otg-fsm.c
 
 USB OVER IP DRIVER
 M:	Valentina Manea <[email protected]>
-M:	Shuah Khan <[email protected]>
 M:	Shuah Khan <[email protected]>
+M:	Shuah Khan <[email protected]>
 L:	[email protected]
 S:	Maintained
 F:	Documentation/usb/usbip_protocol.rst
Signature · 1 line
2.25.1
#1 lore raw
Quoted 2 lines · Shuah Khan

get_maintainer.pl picks only the first email address found in the file. Reorder my email addresses so it finds my linuxfoundation.org email.

OK.

btw: --noremove-duplicates is also an option. For instance:

$ ./scripts/get_maintainer.pl -f Documentation/usb/usbip_protocol.rst
Valentina Manea <[email protected]> (maintainer:USB OVER IP DRIVER)
Shuah Khan <[email protected]> (maintainer:USB OVER IP DRIVER)
Greg Kroah-Hartman <[email protected]> (supporter:USB SUBSYSTEM)
Jonathan Corbet <[email protected]> (maintainer:DOCUMENTATION)
[email protected] (open list:USB OVER IP DRIVER)
[email protected] (open list:DOCUMENTATION)
[email protected] (open list)

vs:

$ ./scripts/get_maintainer.pl --noremove-duplicates -f Documentation/usb/usbip_protocol.rst
Valentina Manea <[email protected]> (maintainer:USB OVER IP DRIVER)
Shuah Khan <[email protected]> (maintainer:USB OVER IP DRIVER)
Shuah Khan <[email protected]> (maintainer:USB OVER IP DRIVER)
Greg Kroah-Hartman <[email protected]> (supporter:USB SUBSYSTEM)
Jonathan Corbet <[email protected]> (maintainer:DOCUMENTATION)
[email protected] (open list:USB OVER IP DRIVER)
[email protected] (open list:DOCUMENTATION)
[email protected] (open list)
author
#2 lore raw
Quoted 19 lines · Joe Perches
Quoted 2 lines · Shuah Khan

get_maintainer.pl picks only the first email address found in the file. Reorder my email addresses so it finds my linuxfoundation.org email.

OK.

btw: --noremove-duplicates is also an option. For instance:

$ ./scripts/get_maintainer.pl -f Documentation/usb/usbip_protocol.rst
Valentina Manea <[email protected]> (maintainer:USB OVER IP DRIVER)
Shuah Khan <[email protected]> (maintainer:USB OVER IP DRIVER)
Greg Kroah-Hartman <[email protected]> (supporter:USB SUBSYSTEM)
Jonathan Corbet <[email protected]> (maintainer:DOCUMENTATION)
[email protected] (open list:USB OVER IP DRIVER)
[email protected] (open list:DOCUMENTATION)
[email protected] (open list)

vs:

Quoted 10 lines
$ ./scripts/get_maintainer.pl --noremove-duplicates -f Documentation/usb/usbip_protocol.rst
Valentina Manea <[email protected]> (maintainer:USB OVER IP DRIVER)
Shuah Khan <[email protected]> (maintainer:USB OVER IP DRIVER)
Shuah Khan <[email protected]> (maintainer:USB OVER IP DRIVER)
Greg Kroah-Hartman <[email protected]> (supporter:USB SUBSYSTEM)
Jonathan Corbet <[email protected]> (maintainer:DOCUMENTATION)
[email protected] (open list:USB OVER IP DRIVER)
[email protected] (open list:DOCUMENTATION)
[email protected] (open list)

Sadly, people that don't run get_maintainer.pl, leave alone running it with --noremove-duplicates option. So your suggestion doesn't really help me.

My preference is to get patches to both Inboxes if possible which isn't possible unless -noremove-duplicate is default. Having this option as default probably will annoy lot of people . So I am not asking for that.

That being said, I don't understand your comment. Are you recommending using just one email in these entries?

thanks,
-- Shuah

#3 lore raw
Quoted 6 lines · Shuah Khan
Quoted 5 lines · Joe Perches
Quoted 2 lines · Shuah Khan

get_maintainer.pl picks only the first email address found in the file. Reorder my email addresses so it finds my linuxfoundation.org email.

OK.

[]

Quoted 11 lines

Sadly, people that don't run get_maintainer.pl, leave alone running it with --noremove-duplicates option. So your suggestion doesn't really help me.

My preference is to get patches to both Inboxes if possible which isn't possible unless -noremove-duplicate is default. Having this option as default probably will annoy lot of people . So I am not asking for that.

That being said, I don't understand your comment. Are you recommending using just one email in these entries?

Yes. And maybe set an autoforward rule in that email to forward the received email to your other address.

author
#4 lore raw
Quoted 17 lines · Joe Perches
Quoted 6 lines · Shuah Khan
Quoted 5 lines · Joe Perches
Quoted 2 lines · Shuah Khan

get_maintainer.pl picks only the first email address found in the file. Reorder my email addresses so it finds my linuxfoundation.org email.

OK.

[]

Quoted 9 lines

Sadly, people that don't run get_maintainer.pl, leave alone running it with --noremove-duplicates option. So your suggestion doesn't really help me.

My preference is to get patches to both Inboxes if possible which isn't possible unless -noremove-duplicate is default. Having this option as default probably will annoy lot of people . So I am not asking for that.

Quoted 7 lines
Quoted 2 lines

That being said, I don't understand your comment. Are you recommending using just one email in these entries?

Yes. And maybe set an autoforward rule in that email to forward the received email to your other address.

Sounds good.

thanks,
-- Shuah

#5 lore raw
Quoted 18 lines · Shuah Khan
Quoted 17 lines · Joe Perches
Quoted 6 lines · Shuah Khan
Quoted 5 lines · Joe Perches
Quoted 2 lines · Shuah Khan

get_maintainer.pl picks only the first email address found in the file. Reorder my email addresses so it finds my linuxfoundation.org email.

OK.

[]

Quoted 9 lines

Sadly, people that don't run get_maintainer.pl, leave alone running it with --noremove-duplicates option. So your suggestion doesn't really help me.

My preference is to get patches to both Inboxes if possible which isn't possible unless -noremove-duplicate is default. Having this option as default probably will annoy lot of people . So I am not asking for that.

Quoted 8 lines
Quoted 7 lines
Quoted 2 lines

That being said, I don't understand your comment. Are you recommending using just one email in these entries?

Yes. And maybe set an autoforward rule in that email to forward the received email to your other address.

Sounds good.

Another option would be to write your name
slightly differently in the 2 entries.

For instance, add "(LF)" to the linuxfoundation.org entry like:

CPU POWER MONITORING SUBSYSTEM
M: Thomas Renninger <[email protected]>
M: Shuah Khan <[email protected]>
M: Shuah Khan (LF) <[email protected]>
L: [email protected]
S: Maintained
F: tools/power/cpupower/

and then the get_maintainer.pl script won't
collapse the equally named but with different
email addresses into a single entry:

$ ./scripts/get_maintainer.pl -f tools/power/cpupower/
Thomas Renninger <[email protected]> (maintainer:CPU POWER MONITORING SUBSYSTEM)
Shuah Khan <[email protected]> (maintainer:CPU POWER MONITORING SUBSYSTEM)
"Shuah Khan (LF)" <[email protected]> (maintainer:CPU POWER MONITORING SUBSYSTEM)
[email protected] (open list:CPU POWER MONITORING SUBSYSTEM)
[email protected] (open list)
author
#6 lore raw
Quoted 41 lines · Joe Perches
Quoted 18 lines · Shuah Khan
Quoted 17 lines · Joe Perches
Quoted 6 lines · Shuah Khan
Quoted 5 lines · Joe Perches
Quoted 2 lines · Shuah Khan

get_maintainer.pl picks only the first email address found in the file. Reorder my email addresses so it finds my linuxfoundation.org email.

OK.

[]

Quoted 9 lines

Sadly, people that don't run get_maintainer.pl, leave alone running it with --noremove-duplicates option. So your suggestion doesn't really help me.

My preference is to get patches to both Inboxes if possible which isn't possible unless -noremove-duplicate is default. Having this option as default probably will annoy lot of people . So I am not asking for that.

Quoted 8 lines
Quoted 7 lines
Quoted 2 lines

That being said, I don't understand your comment. Are you recommending using just one email in these entries?

Yes. And maybe set an autoforward rule in that email to forward the received email to your other address.

Sounds good.

Another option would be to write your name
slightly differently in the 2 entries.

For instance, add "(LF)" to the linuxfoundation.org entry like:

CPU POWER MONITORING SUBSYSTEM
M: Thomas Renninger <[email protected]>
M: Shuah Khan <[email protected]>
M: Shuah Khan (LF) <[email protected]>
L: [email protected]
S: Maintained
F: tools/power/cpupower/

Quoted 4 lines

and then the get_maintainer.pl script won't
collapse the equally named but with different
email addresses into a single entry:

I like this option.

Quoted 7 lines
$ ./scripts/get_maintainer.pl -f tools/power/cpupower/
Thomas Renninger <[email protected]> (maintainer:CPU POWER MONITORING SUBSYSTEM)
Shuah Khan <[email protected]> (maintainer:CPU POWER MONITORING SUBSYSTEM)
"Shuah Khan (LF)" <[email protected]> (maintainer:CPU POWER MONITORING SUBSYSTEM)
[email protected] (open list:CPU POWER MONITORING SUBSYSTEM)
[email protected] (open list)

Thanks for the idea. I will rework the patch and send it.

thanks,
-- Shuah

#7 lore raw
In reply to Shuah Khan

Hi Shuah,

Em Fri, 22 May 2020 20:19:28 -0600
Shuah Khan <[email protected]> escreveu:

Quoted 2 lines

get_maintainer.pl picks only the first email address found in the file. Reorder my email addresses so it finds my linuxfoundation.org email.

Next time someone would run the ordering script again, this patch would need to be re-applied.

Instead, why don't you just use a single e-mail at the maintainer's entry and place the other one at the .mailmap file?

Quoted 31 lines
---
 MAINTAINERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
MAINTAINERS +2 -2
index ecc0749810b0..dbad8b18bfe6 100644
@@ -4404,8 +4404,8 @@ F:	include/linux/cpuidle.h
 
 CPU POWER MONITORING SUBSYSTEM
 M:	Thomas Renninger <[email protected]>
-M:	Shuah Khan <[email protected]>
 M:	Shuah Khan <[email protected]>
+M:	Shuah Khan <[email protected]>
 L:	[email protected]
 S:	Maintained
 F:	tools/power/cpupower/
@@ -9238,8 +9238,8 @@ F:	include/uapi/linux/sunrpc/
 F:	net/sunrpc/
 
 KERNEL SELFTEST FRAMEWORK
-M:	Shuah Khan <[email protected]>
 M:	Shuah Khan <[email protected]>
+M:	Shuah Khan <[email protected]>
 L:	[email protected]
 S:	Maintained
 Q:	https://patchwork.kernel.org/project/linux-kselftest/list/

MAINTAINERS F: drivers/usb/common/usb-otg-fsm.c · line 17491

Quoted 9 lines
MAINTAINERS +1 -1
@@ -17484,8 +17484,8 @@ F:	drivers/usb/common/usb-otg-fsm.c
 
 USB OVER IP DRIVER
 M:	Valentina Manea <[email protected]>
-M:	Shuah Khan <[email protected]>
 M:	Shuah Khan <[email protected]>
+M:	Shuah Khan <[email protected]>
 L:	[email protected]
 S:	Maintained
 F:	Documentation/usb/usbip_protocol.rst

Thanks,
Mauro

#8 lore raw
Quoted 10 lines · Mauro Carvalho Chehab

Hi Shuah,

Em Fri, 22 May 2020 20:19:28 -0600
Shuah Khan <[email protected]> escreveu:

Quoted 2 lines

get_maintainer.pl picks only the first email address found in the file. Reorder my email addresses so it finds my linuxfoundation.org email.

Next time someone would run the ordering script again, this patch would need to be re-applied.

Not so.
Reordering does not change maintainer emails entries. Reordering only happens to file patterns.