Skip to contentSkip to conversation

workqueue: Fix double kfree(rescuer) in destroy_workqueue()

PATCH New [email protected] 1 participant 1 message May 24, 2020 Workqueue

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 workqueue: Fix double kfree(rescuer) in destroy_workqueue()

From: Zhang Qiang <[email protected]>

When destroy_workqueue if rescuer worker exist,wq->rescuer pointer be kfree. if sanity checks passed. the func call_rcu(&wq->rcu, rcu_free_wq) will be called if the wq->flags & WQ_UNBOUND is false,in rcu_free_wq func wq->rescuer pointer was kfree again.

---
 kernel/workqueue.c | 1 -
 1 file changed, 1 deletion(-)
kernel/workqueue.c +0 -1
index 891ccad5f271..a2451cdcd503 100644
@@ -3491,7 +3491,6 @@ static void rcu_free_wq(struct rcu_head *rcu)
 	else
 		free_workqueue_attrs(wq->unbound_attrs);
 
-	kfree(wq->rescuer);
 	kfree(wq);
 }
 
Signature · 1 line
2.17.0