Skip to contentSkip to conversation

drivers/staging/vt6656/rxtx.c:42:18: warning: unused variable 'vnt_frame_time'

PATCH Superseded kbuild test robot 2 participants 3 messages May 24, 2020 – May 27, 2020 Staging

lore
Share & tools
lore

kbuild test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing
head:   a3975dea1696b7c81319dc4b66e3c378dd47ccfb
commit: 61bb798767e4a55165ab0cdaf72dd7459ebab0cc [319/378] staging: vt6656: vnt_get_rtscts_rsvtime_le replace with rts/cts duration.
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 61bb798767e4a55165ab0cdaf72dd7459ebab0cc
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/staging/vt6656/rxtx.c:42:18: warning: unused variable 'vnt_frame_time' [-Wunused-const-variable]

static const u16 vnt_frame_time[MAX_RATE] = {
^
1 warning generated.

vim +/vnt_frame_time +42 drivers/staging/vt6656/rxtx.c

92b96797118e58 Forest Bond 2009-06-13 41

3436accadc3f17 Malcolm Priestley 2020-04-19 @42  static const u16 vnt_frame_time[MAX_RATE] = {
3436accadc3f17 Malcolm Priestley 2020-04-19  43  	10, 20, 55, 110, 24, 36, 48, 72, 96, 144, 192, 216
3436accadc3f17 Malcolm Priestley 2020-04-19  44  };

3436accadc3f17 Malcolm Priestley 2020-04-19 45

:::::: The code at line 42 was first introduced by commit
:::::: 3436accadc3f179a108071df552a6b82542523b1 staging: vt6656: Move vnt_get_frame_time and vnt_get_phy_field to rxtx

:::::: TO: Malcolm Priestley <[email protected]> :::::: CC: Greg Kroah-Hartman <[email protected]>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#1 lore raw

PATCH 1/1 staging: vt6656: Fix warning: unused variable vnt_frame_time

In commit 3436accadc3f
("staging: vt6656: Move vnt_get_frame_time and vnt_get_phy_field to rxtx") not quite all of the code was removed.

Remove unused vnt_frame_time variable.

---
 drivers/staging/vt6656/rxtx.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/vt6656/rxtx.c +0 -4
index 5530c06ffd40..5dd6b4d2bf20 100644
@@ -39,10 +39,6 @@ static const u16 vnt_time_stampoff[2][MAX_RATE] = {
 #define DATADUR_B       10
 #define DATADUR_A       11
 
-static const u16 vnt_frame_time[MAX_RATE] = {
-	10, 20, 55, 110, 24, 36, 48, 72, 96, 144, 192, 216
-};
-
 static const u8 vnt_phy_signal[] = {
 	0x00,	/* RATE_1M  */
 	0x01,	/* RATE_2M  */
Signature · 1 line
2.27.0.rc0
#2 lore raw

PATCH v2 1/1 staging: vt6656: Fix warning: unused variable vnt_frame_time

In reply to kbuild test robot

In commit 61bb798767e4
("staging: vt6656: vnt_get_rtscts_rsvtime_le replace with rts/cts duration.") not quite all of the code was removed.

Remove unused vnt_frame_time variable.

---
v2 corrected the commit

 drivers/staging/vt6656/rxtx.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/vt6656/rxtx.c +0 -4
index 5530c06ffd40..5dd6b4d2bf20 100644
@@ -39,10 +39,6 @@ static const u16 vnt_time_stampoff[2][MAX_RATE] = {
 #define DATADUR_B       10
 #define DATADUR_A       11
 
-static const u16 vnt_frame_time[MAX_RATE] = {
-	10, 20, 55, 110, 24, 36, 48, 72, 96, 144, 192, 216
-};
-
 static const u8 vnt_phy_signal[] = {
 	0x00,	/* RATE_1M  */
 	0x01,	/* RATE_2M  */
Signature · 1 line
2.27.0.rc0