Skip to contentSkip to conversation

ltp: Add net-tools as rdependency

PATCH In review Daniel D?az 2 participants 3 messages May 25, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ltp: Add net-tools as rdependency

The version of ifconfig provided by Busybox is not enough for some tests. Here's an example of how it fails with test netns_breakns_ns_exec_ipv4_ioctl:
ifconfig: bad address '192.168.0.2/24'
ifconfig: bad address 'inet6'

This works with net-tools' ifconfig.

---
 meta/recipes-extended/ltp/ltp_20200515.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-extended/ltp/ltp_20200515.bb +1 -0
index e82f6b33a1..317a4e461a 100644
@@ -89,6 +89,7 @@ RDEPENDS_${PN} = "\
     ldd \
     libaio \
     logrotate \
+    net-tools \
     perl \
     python3-core \
     procps \
Signature · 1 line
2.20.1
#1 lore raw
Quoted 19 lines · Daniel D?az

The version of ifconfig provided by Busybox is not enough for some tests. Here's an example of how it fails with test netns_breakns_ns_exec_ipv4_ioctl:
ifconfig: bad address '192.168.0.2/24'
ifconfig: bad address 'inet6'

This works with net-tools' ifconfig.

---
 meta/recipes-extended/ltp/ltp_20200515.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-extended/ltp/ltp_20200515.bb +0 -0
index e82f6b33a1..317a4e461a 100644

meta/recipes-extended/ltp/ltp_20200515.bb RDEPENDS_${PN} = "\ · line 95

Quoted 7 lines
meta/recipes-extended/ltp/ltp_20200515.bb +1 -0
@@ -89,6 +89,7 @@ RDEPENDS_${PN} = "\
     ldd \
     libaio \
     logrotate \
+    net-tools \
     perl \
     python3-core \
     procps \

I think there are a few more issues like this too.

https://bugzilla.yoctoproject.org/show_bug.cgi?id=13802
has some logs which show:

/opt/ltp/testcases/bin/run_cpuctl_stress_test.sh: line 242: nice: command not found /opt/ltp/testcases/bin/run_cpuctl_test_fj.sh: line 66: tac: command not found vma05 1 TCONF: 'gdb' not found
memcg_failcnt 1 TCONF: 'bc' not found
Owner=nobody; perms=-rw-------; sudo: lsattr: command not found
sh: systemd-detect-virt: command not found

(some repeated many time)

I'm also worried about the memory size of the VM we run the ltp tests under. Is there a recommended amount of memory they need?

Cheers,

Richard

#2 lore raw

Hello!

Quoted 41 lines · Richard Purdie
Quoted 19 lines · Daniel D?az

The version of ifconfig provided by Busybox is not enough for some tests. Here's an example of how it fails with test netns_breakns_ns_exec_ipv4_ioctl:
ifconfig: bad address '192.168.0.2/24'
ifconfig: bad address 'inet6'

This works with net-tools' ifconfig.

---
 meta/recipes-extended/ltp/ltp_20200515.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-extended/ltp/ltp_20200515.bb +0 -0
index e82f6b33a1..317a4e461a 100644

meta/recipes-extended/ltp/ltp_20200515.bb RDEPENDS_${PN} = "\ · line 95

Quoted 7 lines
meta/recipes-extended/ltp/ltp_20200515.bb +1 -0
@@ -89,6 +89,7 @@ RDEPENDS_${PN} = "\
     ldd \
     libaio \
     logrotate \
+    net-tools \
     perl \
     python3-core \
     procps \

I think there are a few more issues like this too.

https://bugzilla.yoctoproject.org/show_bug.cgi?id=13802
has some logs which show:

/opt/ltp/testcases/bin/run_cpuctl_stress_test.sh: line 242: nice: command not found /opt/ltp/testcases/bin/run_cpuctl_test_fj.sh: line 66: tac: command not found vma05 1 TCONF: 'gdb' not found
memcg_failcnt 1 TCONF: 'bc' not found
Owner=nobody; perms=-rw-------; sudo: lsattr: command not found
sh: systemd-detect-virt: command not found

Quoted 4 lines

(some repeated many time)

I'm also worried about the memory size of the VM we run the ltp tests under. Is there a recommended amount of memory they need?

I wouldn't know -- we run LTP on actual hardware where the minimum RAM is 2 GB; for Qemu we provide 4 GB of guest RAM. Probably Petr (CC'ed) has more insight on that front.

Thanks and greetings!

Daniel Díaz
[email protected]