tools/env/fw_env.h: remove env.h
PATCH 1/1 tools/env/fw_env.h: remove env.h
As reported by Nicolas Carrier on the Buildroot mailing list [1], there is a new build issue while building a program which interacts with the u-boot environment. This program uses the headers of the ubootenv library provided by uboot-tools.
This is a recent change from uboot [2] adding "#include <env.h>" to fw_env.h. Adding env.h require a board configuration to build since it also include compiler.h (and others uboot internal includes).
env.h include seems not needed since env_set() is not used in fw_env tool.
Nicolas removed env.h from fw_env tool and fixed it's build issue.
This problem is present since uboot v2019.10.
[1] http://lists.busybox.net/pipermail/buildroot/2020-April/280307.html
[2] https://gitlab.denx.de/u-boot/u-boot/-/commit/9fb625ce05539fe6876a59ce1dcadb76b33c6f6e
--- tools/env/fw_env.h | 1 - 1 file changed, 1 deletion(-)
tools/env/fw_env.h +0 -1
@@ -4,7 +4,6 @@* Wolfgang Denk, DENX Software Engineering, wd at denx.de. */ -#include <env.h> #include <stdint.h> /*
Signature · 1 line
2.25.4
PATCH 1/1 tools/env/fw_env.h: remove env.h
Quoted 13 lines · Romain Naour
As reported by Nicolas Carrier on the Buildroot mailing list [1], there is a new build issue while building a program which interacts with the u-boot environment. This program uses the headers of the ubootenv library provided by uboot-tools.
This is a recent change from uboot [2] adding "#include <
env.h>" tofw_env.h. Addingenv.hrequire a board configuration to build since it also includecompiler.h(and others uboot internal includes).
env.hinclude seems not needed sinceenv_set()is not used infw_envtool.Nicolas removed
env.hfromfw_envtool and fixed it's build issue.
Quoted 7 lines
This problem is present since uboot v2019.10.
[1] http://lists.busybox.net/pipermail/buildroot/2020-April/280307.html
[2] https://gitlab.denx.de/u-boot/u-boot/-/commit/9fb625ce05539fe6876a59ce1dcadb76b33c6f6eReported-by Nicolas Carrier <[email protected]>Signed-off-by Romain Naour <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200525/42b95074/attachment.sig>