Skip to contentSkip to conversation

video: make vidconsole commands optional

PATCH New Anatolij Gustschin 2 participants 5 messages May 25, 2020 – Jun 19, 2020 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: make vidconsole commands optional

Converting some boards to DM_VIDEO results in build breakage due to increased code size. Make video console specific commands optional to recude binary size.

---
 drivers/video/Kconfig             | 8 ++++++++
 drivers/video/vidconsole-uclass.c | 2 ++
 2 files changed, 10 insertions(+)
drivers/video/Kconfig +8 -0
index 28c22fe525..eb5e26644a 100644
@@ -35,6 +35,14 @@ config BACKLIGHT_GPIO
 	  it understands the standard device tree
 	  (leds/backlight/gpio-backlight.txt)
 
+config CMD_VIDCONSOLE
+	bool "Enable vidconsole commands lcdputs and setcurs"
+	depends on DM_VIDEO
+	default y
+	help
+	  Enabling this will provide 'setcurs' and 'lcdputs' commands which
+	  support cursor positioning and drawing strings on video framebuffer.
+
 config VIDEO_BPP8
 	bool "Support 8-bit-per-pixel displays"
 	depends on DM_VIDEO
drivers/video/vidconsole-uclass.c +2 -0
index d30e6db6f6..901347c467 100644
@@ -613,6 +613,7 @@ UCLASS_DRIVER(vidconsole) = {
 	.per_device_auto_alloc_size	= sizeof(struct vidconsole_priv),
 };
 
+#if CONFIG_IS_ENABLED(CMD_VIDCONSOLE)
 void vidconsole_position_cursor(struct udevice *dev, unsigned col, unsigned row)
 {
 	struct vidconsole_priv *priv = dev_get_uclass_priv(dev);
@@ -673,3 +674,4 @@ U_BOOT_CMD(
 	"print string on video framebuffer",
 	"    <string>"
 );
+#endif /* CONFIG_IS_ENABLED(CMD_VIDCONSOLE) */
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 video: make vidconsole commands optional

Hi Anatolij,

Quoted 4 lines · Anatolij Gustschin

Converting some boards to DM_VIDEO results in build breakage due to increased code size. Make video console specific commands optional to recude binary size.

reduce

Which board is this? I'd just like to check that it is expected.

Quoted 6 lines
---
 drivers/video/Kconfig             | 8 ++++++++
 drivers/video/vidconsole-uclass.c | 2 ++
 2 files changed, 10 insertions(+)

Regards,
Simon

#2 lore raw

PATCH 1/1 video: make vidconsole commands optional

Hi Simon,

On Mon, 25 May 2020 15:37:33 -0600
Simon Glass sjg at chromium.org wrote:
...

Quoted 3 lines
Quoted 1 line

optional to recude binary size.

reduce

I'll fix it in v2, thanks!

Quoted 1 line

Which board is this? I'd just like to check that it is expected.

this is tbs2910 board which makes most trouble currently. I'm trying to make backlight, panel and simple panel code optional as well, this could save us a few more bytes.

...

Quoted 5 lines
Quoted 3 lines
 drivers/video/Kconfig             | 8 ++++++++
 drivers/video/vidconsole-uclass.c | 2 ++
 2 files changed, 10 insertions(+)  

Thanks!

--
Anatolij

#3 lore raw

PATCH 1/1 video: make vidconsole commands optional

Hi Anatolij,

Quoted 10 lines · Anatolij Gustschin

Hi Simon,

On Mon, 25 May 2020 15:37:33 -0600
Simon Glass sjg at chromium.org wrote:
...

Quoted 3 lines
Quoted 1 line

optional to recude binary size.

reduce

Quoted 7 lines

I'll fix it in v2, thanks!

Quoted 1 line

Which board is this? I'd just like to check that it is expected.

this is tbs2910 board which makes most trouble currently. I'm trying to make backlight, panel and simple panel code optional as well, this could save us a few more bytes.

OK I see. Yes, those definitely increase the size.

Regards,
Simon

#4 lore raw

PATCH 1/1 video: make vidconsole commands optional

In reply to Anatolij Gustschin
Quoted 9 lines · On Mon, 25 May 2020 21:47:19 +0200 Anatolij Gustschin agust at denx.de wrote:

Converting some boards to DM_VIDEO results in build breakage due to increased code size. Make video console specific commands optional to recude binary size.

---
 drivers/video/Kconfig             | 8 ++++++++
 drivers/video/vidconsole-uclass.c | 2 ++
 2 files changed, 10 insertions(+)

Applied to u-boot-video/next, thanks!

--
Anatolij