drm/etnaviv: convert get_user_pages() --> pin_user_pages()
Subsystems (2)
PATCH v2 1/1 drm/etnaviv: convert get_user_pages() --> pin_user_pages()
This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls.
There is some helpful background in [2]: basically, this is a small part of fixing a long-standing disconnect between pinning pages, and file systems' use of those pages.
[1] Documentation/core-api/pin_user_pages.rst
[2] "Explicit pinning of user-space pages":
https://lwn.net/Articles/807108/
---
Hi,
Changes since v1:
* Rebased onto Linux 5.7-rc7
* Added: Lucas Stach
thanks
John Hubbard
NVIDIA
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/etnaviv/etnaviv_gem.c +3 -3
@@ -675,10 +675,10 @@ static int etnaviv_gem_userptr_get_pages(struct etnaviv_gem_object *etnaviv_obj)uint64_t ptr = userptr->ptr + pinned *PAGE_SIZE ;struct page **pages = pvec + pinned; - ret =get_user_pages_fast (ptr, num_pages, + ret =pin_user_pages_fast (ptr, num_pages, !userptr->ro ?FOLL_WRITE :0 , pages);if (ret <0 ) { -release_pages (pvec, pinned); +unpin_user_pages (pvec, pinned);kvfree (pvec);return ret; }
@@ -702,7 +702,7 @@ static void etnaviv_gem_userptr_release(struct etnaviv_gem_object *etnaviv_obj)if (etnaviv_obj->pages) {int npages = etnaviv_obj->base.size >>PAGE_SHIFT ; -release_pages (etnaviv_obj->pages, npages); +unpin_user_pages (etnaviv_obj->pages, npages);kvfree (etnaviv_obj->pages); } }
Signature · 6 lines
2.26.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Lucas Stach
maintainerAm Montag, den 25.05.2020, 16:49 -0700 schrieb John Hubbard:
Quoted 9 lines
This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() +
put_page()calls to pin_user_pages*() +unpin_user_pages()calls.There is some helpful background in [2]: basically, this is a small part of fixing a long-standing disconnect between pinning pages, and file systems' use of those pages.
Quoted 6 lines
[1]
Documentation/core-api/pin_user_pages.rst[2] "Explicit pinning of user-space pages":
https://lwn.net/Articles/807108/Signed-off-by John Hubbard <[email protected]>
Thanks, I've applied this to etnaviv/next.
Regards,
Lucas
Quoted 36 lines
---
Hi,
Changes since v1:
* Rebased onto Linux 5.7-rc7
* Added: Lucas Stach
thanks
John Hubbard
NVIDIAdrivers/gpu/drm/etnaviv/etnaviv_gem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/etnaviv/etnaviv_gem.c +2
-2@@ -675,10 +675,10 @@ static int etnaviv_gem_userptr_get_pages(struct etnaviv_gem_object *etnaviv_obj)uint64_t ptr = userptr->ptr + pinned *PAGE_SIZE ;struct page **pages = pvec + pinned; - ret =get_user_pages_fast (ptr, num_pages, + ret =pin_user_pages_fast (ptr, num_pages, !userptr->ro ?FOLL_WRITE :0 , pages);if (ret <0 ) { -release_pages (pvec, pinned); +unpin_user_pages (pvec, pinned);kvfree (pvec);return ret; }
drivers/gpu/drm/etnaviv/etnaviv_gem.c static void etnaviv_gem_userptr_release(struct etnaviv_gem_object *etnaviv_obj) · line 708
Quoted 8 lines
drivers/gpu/drm/etnaviv/etnaviv_gem.c +1
-1@@ -702,7 +702,7 @@ static void etnaviv_gem_userptr_release(struct etnaviv_gem_object *etnaviv_obj)if (etnaviv_obj->pages) {int npages = etnaviv_obj->base.size >>PAGE_SHIFT ; -release_pages (etnaviv_obj->pages, npages); +unpin_user_pages (etnaviv_obj->pages, npages);kvfree (etnaviv_obj->pages); } }
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel