Skip to contentSkip to conversation

package/mesa3d: propagate missing libdrm-freedreno deps

PATCH New James Hilliard 3 participants 3 messages May 26, 2020 – Jun 1, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/mesa3d: propagate missing libdrm-freedreno deps

Libdrm freedreno depends on BR2_arm || BR2_aarch64 || BR2_aarch64_be as such we need to propagate those dependencies to mesa's gallium freedreno driver.

---
Changes v1 -> v2:
- add note about LIBDRM_HAS_ATOMIC dependency

---
 package/mesa3d/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
package/mesa3d/Config.in +6 -0
index dd512d9b76..11d04b7a3f 100644
@@ -111,6 +111,12 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV
 
 config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO
 	bool "Gallium freedreno driver"
+	depends on BR2_arm || BR2_aarch64 || BR2_aarch64_be # libdrm-freedreno
+	# libdrm's freedreno option depends on LIBDRM_HAS_ATOMIC. Propagating
+	# that dependency here causes a circular dependency that Kconfig
+	# can't see is just spurious. However, that dependency is about
+	# the toolchain having sync4 primitives, which is always a given
+	# for arm/aarch64.
 	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
 	select BR2_PACKAGE_LIBDRM_FREEDRENO
 	select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 1/1 package/mesa3d: propagate missing libdrm-freedreno deps

James, All,

On 2020-05-26 14:24 -0600, James Hilliard spake thusly:

Quoted 5 lines

Libdrm freedreno depends on BR2_arm || BR2_aarch64 || BR2_aarch64_be as such we need to propagate those dependencies to mesa's gallium freedreno driver.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 31 lines

---
Changes v1 -> v2:
- add note about LIBDRM_HAS_ATOMIC dependency

---
 package/mesa3d/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
package/mesa3d/Config.in +6 -0
index dd512d9b76..11d04b7a3f 100644
@@ -111,6 +111,12 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV
 
 config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO
 	bool "Gallium freedreno driver"
+	depends on BR2_arm || BR2_aarch64 || BR2_aarch64_be # libdrm-freedreno
+	# libdrm's freedreno option depends on LIBDRM_HAS_ATOMIC. Propagating
+	# that dependency here causes a circular dependency that Kconfig
+	# can't see is just spurious. However, that dependency is about
+	# the toolchain having sync4 primitives, which is always a given
+	# for arm/aarch64.
 	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
 	select BR2_PACKAGE_LIBDRM_FREEDRENO
 	select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v2 1/1 package/mesa3d: propagate missing libdrm-freedreno deps

In reply to James Hilliard
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"James" == James Hilliard <[email protected]> writes:

Libdrm freedreno depends on BR2_arm || BR2_aarch64 || BR2_aarch64_be as such we need to propagate those dependencies to mesa's gallium freedreno driver.

---
Changes v1 -> v2:
- add note about LIBDRM_HAS_ATOMIC dependency

Committed to 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard