libbpf: add API to consume the perf ring buffer content
Subsystems (4)
PATCH v2 1/1 libbpf: add API to consume the perf ring buffer content
This new API, perf_buffer__consume, can be used as follows:
- When you have a perf ring where wakeup_events is higher than 1, and you have remaining data in the rings you would like to pull out on exit (or maybe based on a timeout).
- For low latency cases where you burn a CPU that constantly polls the queues.
---
v2:
- Removed some input checks
- Support spare CPU buffers
- Moved variable "err" up
tools/lib/bpf/libbpf.c | 19 +++++++++++++++++++ tools/lib/bpf/libbpf.h | 1 + tools/lib/bpf/libbpf.map | 1 + 3 files changed, 21 insertions(+)
tools/lib/bpf/libbpf.c +19 -0
@@ -8456,6 +8456,25 @@ int perf_buffer__poll(struct perf_buffer *pb, int timeout_ms)return cnt <0 ? -errno : cnt; } +int perf_buffer__consume (struct perf_buffer *pb) +{ +int i, err; + +for (i =0 ; i < pb->cpu_cnt; i++) { +struct perf_cpu_buf *cpu_buf = pb->cpu_bufs[i]; + +if (!cpu_buf) +continue ; + + err =perf_buffer__process_records (pb, cpu_buf); +if (err) { +pr_warn ("error while processing records: %d\n" , err); +return err; + } + } +return 0 ; +} +struct bpf_prog_info_array_desc {int array_offset;/* e.g. offset of jited_prog_insns */ int count_offset;/* e.g. offset of jited_prog_len */
tools/lib/bpf/libbpf.h +1 -0
@@ -533,6 +533,7 @@ perf_buffer__new_raw(int map_fd, size_t page_cnt, LIBBPF_API void perf_buffer__free(struct perf_buffer *pb); LIBBPF_API int perf_buffer__poll(struct perf_buffer *pb, int timeout_ms); +LIBBPF_API int perf_buffer__consume(struct perf_buffer *pb);typedef enum bpf_perf_event_ret (*bpf_perf_event_print_t)(struct perf_event_header *hdr,
tools/lib/bpf/libbpf.map +1 -0
@@ -262,4 +262,5 @@ LIBBPF_0.0.9 { bpf_link_get_fd_by_id; bpf_link_get_next_id; bpf_program__attach_iter; + perf_buffer__consume; } LIBBPF_0.0.8;
Quoted 10 lines · Eelco Chaudron
This new API,
perf_buffer__consume, can be used as follows:
- When you have a perf ring wherewakeup_eventsis higher than 1, and you have remaining data in the rings you would like to pull out on exit (or maybe based on a timeout).
- For low latency cases where you burn a CPU that constantly polls the queues.Signed-off-by Eelco Chaudron <[email protected]>---
Looks good, thanks. I'd really appreciate if you could follow up with a fix to perf_buffer__free() as well. If not, I will get to it eventually anyway :)
[...]
Quoted 8 lines · Eelco Chaudron
This new API,
perf_buffer__consume, can be used as follows:
- When you have a perf ring wherewakeup_eventsis higher than 1, and you have remaining data in the rings you would like to pull out on exit (or maybe based on a timeout).
- For low latency cases where you burn a CPU that constantly polls the queues.Signed-off-by Eelco Chaudron <[email protected]>
Applied, thanks!