Skip to contentSkip to conversation

drm/amdgpu: Improve the MTYPE comments

PATCH In review Yong Zhao 3 participants 3 messages May 27, 2020 – May 28, 2020

Subsystems (3)
lore
Share & tools
lore

Yong Zhao

author
#0 lore raw

PATCH 1/1 drm/amdgpu: Improve the MTYPE comments

Use words insteads of acronym for better understanding.

---
 include/uapi/drm/amdgpu_drm.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
include/uapi/drm/amdgpu_drm.h +5 -5
index d65f9b4ba05c..0072ddb59747 100644
@@ -564,15 +564,15 @@ struct drm_amdgpu_gem_op {
 #define AMDGPU_VM_MTYPE_MASK		(0xf << 5)
 /* Default MTYPE. Pre-AI must use this.  Recommended for newer ASICs. */
 #define AMDGPU_VM_MTYPE_DEFAULT		(0 << 5)
-/* Use NC MTYPE instead of default MTYPE */
+/* Use Non Coherent MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_NC		(1 << 5)
-/* Use WC MTYPE instead of default MTYPE */
+/* Use Write Combine MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_WC		(2 << 5)
-/* Use CC MTYPE instead of default MTYPE */
+/* Use Cache Coherent MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_CC		(3 << 5)
-/* Use UC MTYPE instead of default MTYPE */
+/* Use UnCached MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_UC		(4 << 5)
-/* Use RW MTYPE instead of default MTYPE */
+/* Use Read Write MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_RW		(5 << 5)
 
 struct drm_amdgpu_gem_va {
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
maintainer Reviewed-by on v1 1/1
#1 lore raw

[AMD Public Use]

________________________________
From: amd-gfx <[email protected]> on behalf of Yong Zhao <[email protected]>
Sent: Tuesday, May 26, 2020 8:57 PM
To: [email protected] <[email protected]>
Cc: Zhao, Yong <[email protected]>
Subject: [PATCH] drm/amdgpu: Improve the MTYPE comments

Use words insteads of acronym for better understanding.

---
 include/uapi/drm/amdgpu_drm.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
include/uapi/drm/amdgpu_drm.h +5 -5
index d65f9b4ba05c..0072ddb59747 100644
@@ -564,15 +564,15 @@ struct drm_amdgpu_gem_op {
 #define AMDGPU_VM_MTYPE_MASK            (0xf << 5)
 /* Default MTYPE. Pre-AI must use this.  Recommended for newer ASICs. */
 #define AMDGPU_VM_MTYPE_DEFAULT         (0 << 5)
-/* Use NC MTYPE instead of default MTYPE */
+/* Use Non Coherent MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_NC              (1 << 5)
-/* Use WC MTYPE instead of default MTYPE */
+/* Use Write Combine MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_WC              (2 << 5)
-/* Use CC MTYPE instead of default MTYPE */
+/* Use Cache Coherent MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_CC              (3 << 5)
-/* Use UC MTYPE instead of default MTYPE */
+/* Use UnCached MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_UC              (4 << 5)
-/* Use RW MTYPE instead of default MTYPE */
+/* Use Read Write MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_RW              (5 << 5)
 
 struct drm_amdgpu_gem_va {

--
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Calexander.deucher%40amd.com%7C03cfa3ceeaba4d63650c08d801d8fd40%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637261378796371099&amp;sdata=kxt8S5LusNmcfRDbv9vgxYlMjPoaA6C3AJIHkXTOq5A%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#2 lore raw
In reply to Yong Zhao

Am 27.05.20 um 02:57 schrieb Yong Zhao:

Quoted 3 lines

Use words insteads of acronym for better understanding.

Good idea, Reviewed-by: Christian König <[email protected]>

Quoted 19 lines
---
  include/uapi/drm/amdgpu_drm.h | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
include/uapi/drm/amdgpu_drm.h +2 -3
index d65f9b4ba05c..0072ddb59747 100644
@@ -564,15 +564,15 @@ struct drm_amdgpu_gem_op {
  #define AMDGPU_VM_MTYPE_MASK		(0xf << 5)
  /* Default MTYPE. Pre-AI must use this.  Recommended for newer ASICs. */
  #define AMDGPU_VM_MTYPE_DEFAULT		(0 << 5)
-/* Use NC MTYPE instead of default MTYPE */
+/* Use Non Coherent MTYPE instead of default MTYPE */
  #define AMDGPU_VM_MTYPE_NC		(1 << 5)
-/* Use WC MTYPE instead of default MTYPE */
+/* Use Write Combine MTYPE instead of default MTYPE */
  #define AMDGPU_VM_MTYPE_WC		(2 << 5)
-/* Use CC MTYPE instead of default MTYPE */

include/uapi/drm/amdgpu_drm.h struct drm_amdgpu_gem_op { · line 578

Quoted 10 lines
include/uapi/drm/amdgpu_drm.h +3 -2
+/* Use Cache Coherent MTYPE instead of default MTYPE */
  #define AMDGPU_VM_MTYPE_CC		(3 << 5)
-/* Use UC MTYPE instead of default MTYPE */
+/* Use UnCached MTYPE instead of default MTYPE */
  #define AMDGPU_VM_MTYPE_UC		(4 << 5)
-/* Use RW MTYPE instead of default MTYPE */
+/* Use Read Write MTYPE instead of default MTYPE */
  #define AMDGPU_VM_MTYPE_RW		(5 << 5)
 
  struct drm_amdgpu_gem_va {

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx