Remove AER HEST table parser
Subsystems (3)
v3 cover Remove AER HEST table parser
From: Kuppuswamy Sathyanarayanan <[email protected]>
Commit c100beb9ccfb ("PCI/AER: Use only _OSC to determine AER ownership") removed HEST dependency in determining the AER ownership status. The following patch set cleansup rest of the HEST table related code from AER driver.
This patchset also includes some minor AER driver fixes.
Changes since v2:
* Fixed commit sha id for patch "PCI/AER: Use only _OSC to determine AER ownership".
Kuppuswamy Sathyanarayanan (5):
PCI/AER: Remove redundant pci_is_pcie() checks.
PCI/AER: Remove redundant dev->aer_cap checks.
ACPI/PCI: Ignore _OSC negotiation result if pcie_ports_native is set. ACPI/PCI: Ignore _OSC DPC negotiation result if pcie_ports_dpc_native
is set.
PCI/AER: Replace pcie_aer_get_firmware_first() with
pcie_aer_is_native()
drivers/acpi/pci_root.c | 28 ++++---- drivers/pci/pcie/aer.c | 139 ++++--------------------------------- drivers/pci/pcie/dpc.c | 2 +- drivers/pci/pcie/portdrv.h | 13 +--- include/linux/pci.h | 2 + 5 files changed, 34 insertions(+), 150 deletions(-)
Signature · 1 line
2.17.1
PATCH v3 1/5 PCI/AER: Remove redundant pci_is_pcie() checks.
From: Kuppuswamy Sathyanarayanan <[email protected]>
AER is a PCIe Extended Capability. So checking for dev->aer_cap will implicitly include check for PCIe device. So remove redundant pci_is_pcie() checks.
--- drivers/pci/pcie/aer.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/pci/pcie/aer.c +1 -10
@@ -139,9 +139,6 @@ static int enable_ecrc_checking(struct pci_dev *dev)int pos;u32 reg32; -if (!pci_is_pcie (dev)) -return -ENODEV ; - pos = dev->aer_cap;if (!pos)return -ENODEV ;
@@ -167,9 +164,6 @@ static int disable_ecrc_checking(struct pci_dev *dev)int pos;u32 reg32; -if (!pci_is_pcie (dev)) -return -ENODEV ; - pos = dev->aer_cap;if (!pos)return -ENODEV ;
@@ -308,7 +302,7 @@ static void aer_set_firmware_first(struct pci_dev *pci_dev)int pcie_aer_get_firmware_first (struct pci_dev *dev) { -if (!pci_is_pcie (dev)) +if (!dev->aer_cap)return 0 ;if (pcie_ports_native)
@@ -411,9 +405,6 @@ int pci_aer_raw_clear_status(struct pci_dev *dev)u32 status;int port_type; -if (!pci_is_pcie (dev)) -return -ENODEV ; - pos = dev->aer_cap;if (!pos)return -EIO ;
Signature · 1 line
2.17.1
PATCH v3 2/5 PCI/AER: Remove redundant dev->aer_cap checks.
In reply to [email protected]From: Kuppuswamy Sathyanarayanan <[email protected]>
pcie_aer_get_firmware_first() includes check for dev->aer_cap. So remove redundant dev->aer_cap checks.
--- drivers/pci/pcie/aer.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
drivers/pci/pcie/aer.c +2 -13
@@ -322,9 +322,6 @@ int pci_enable_pcie_error_reporting(struct pci_dev *dev)if (pcie_aer_get_firmware_first (dev))return -EIO ; -if (!dev->aer_cap) -return -EIO ; -return pcie_capability_set_word (dev,PCI_EXP_DEVCTL ,PCI_EXP_AER_FLAGS ); }EXPORT_SYMBOL_GPL (pci_enable_pcie_error_reporting);
@@ -349,13 +346,9 @@ void pci_aer_clear_device_status(struct pci_dev *dev)int pci_aer_clear_nonfatal_status (struct pci_dev *dev) { -int pos; +int pos = dev->aer_cap;u32 status, sev; - pos = dev->aer_cap; -if (!pos) -return -EIO ; -if (pcie_aer_get_firmware_first (dev))return -EIO ;
@@ -372,13 +365,9 @@ EXPORT_SYMBOL_GPL(pci_aer_clear_nonfatal_status);void pci_aer_clear_fatal_status (struct pci_dev *dev) { -int pos; +int pos = dev->aer_cap;u32 status, sev; - pos = dev->aer_cap; -if (!pos) -return ; -if (pcie_aer_get_firmware_first (dev))return ;
Signature · 1 line
2.17.1
PATCH v3 3/5 ACPI/PCI: Ignore _OSC negotiation result if pcie_ports_native is set.
In reply to [email protected]From: Kuppuswamy Sathyanarayanan <[email protected]>
pcie_ports_native is set only if user requests native handling of PCIe capabilities via pcie_port_setup command line option. User input takes precedence over _OSC based control negotiation result. So consider the _OSC negotiated result only if pcie_ports_native is unset.
--- drivers/acpi/pci_root.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-)
drivers/acpi/pci_root.c +14 -12
@@ -914,18 +914,20 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root, goto out_release_info; host_bridge =to_pci_host_bridge (bus->bridge); -if (!(root->osc_control_set &OSC_PCI_EXPRESS_NATIVE_HP_CONTROL )) - host_bridge->native_pcie_hotplug =0 ; -if (!(root->osc_control_set &OSC_PCI_SHPC_NATIVE_HP_CONTROL )) - host_bridge->native_shpc_hotplug =0 ; -if (!(root->osc_control_set &OSC_PCI_EXPRESS_AER_CONTROL )) - host_bridge->native_aer =0 ; -if (!(root->osc_control_set &OSC_PCI_EXPRESS_PME_CONTROL )) - host_bridge->native_pme =0 ; -if (!(root->osc_control_set &OSC_PCI_EXPRESS_LTR_CONTROL )) - host_bridge->native_ltr =0 ; -if (!(root->osc_control_set &OSC_PCI_EXPRESS_DPC_CONTROL )) - host_bridge->native_dpc =0 ; +if (!pcie_ports_native) { +if (!(root->osc_control_set &OSC_PCI_EXPRESS_NATIVE_HP_CONTROL )) + host_bridge->native_pcie_hotplug =0 ; +if (!(root->osc_control_set &OSC_PCI_SHPC_NATIVE_HP_CONTROL )) + host_bridge->native_shpc_hotplug =0 ; +if (!(root->osc_control_set &OSC_PCI_EXPRESS_AER_CONTROL )) + host_bridge->native_aer =0 ; +if (!(root->osc_control_set &OSC_PCI_EXPRESS_PME_CONTROL )) + host_bridge->native_pme =0 ; +if (!(root->osc_control_set &OSC_PCI_EXPRESS_LTR_CONTROL )) + host_bridge->native_ltr =0 ; +if (!(root->osc_control_set &OSC_PCI_EXPRESS_DPC_CONTROL )) + host_bridge->native_dpc =0 ; + }/* * Evaluate the "PCI Boot Configuration" _DSM Function. If it
Signature · 1 line
2.17.1
PATCH v3 4/5 ACPI/PCI: Ignore _OSC DPC negotiation result if pcie_ports_dpc_native is set.
In reply to [email protected]From: Kuppuswamy Sathyanarayanan <[email protected]>
pcie_ports_dpc_native is set only if user requests native handling of PCIe DPC capability via pcie_port_setup command line option. User input takes precedence over _OSC based control negotiation result. So consider the _OSC negotiated result for DPC ownership only if pcie_ports_dpc_native is unset.
--- drivers/acpi/pci_root.c | 2 ++ include/linux/pci.h | 2 ++ 2 files changed, 4 insertions(+)
drivers/acpi/pci_root.c +2 -0
@@ -925,6 +925,8 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root, host_bridge->native_pme =0 ;if (!(root->osc_control_set &OSC_PCI_EXPRESS_LTR_CONTROL )) host_bridge->native_ltr =0 ; + } +if (!pcie_ports_native && !pcie_ports_dpc_native) {if (!(root->osc_control_set &OSC_PCI_EXPRESS_DPC_CONTROL )) host_bridge->native_dpc =0 ; }
include/linux/pci.h +2 -0
@@ -1547,9 +1547,11 @@ static inline int pci_irqd_intx_xlate(struct irq_domain *d,#ifdef CONFIG_PCIEPORTBUS extern bool pcie_ports_disabled;extern bool pcie_ports_native; +extern bool pcie_ports_dpc_native;#else #define pcie_ports_disabled true#define pcie_ports_native false +#define pcie_ports_dpc_native false#endif #define PCIE_LINK_STATE_L0S BIT(0)
Signature · 1 line
2.17.1
kbuild test robot
build botRe: [PATCH v3 4/5] ACPI/PCI: Ignore _OSC DPC negotiation result if pcie_ports_dpc_native is set.
I love your patch! Yet something to improve:
Hi,
I love your patch! Yet something to improve:
[auto build test ERROR on pci/next]
[also build test ERROR on v5.7-rc7 next-20200526]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/sathyanarayanan-kuppuswamy-linux-intel-com/Remove-AER-HEST-table-parser/20200525-053721 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: arm-gemini_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from drivers/pci/pci-driver.c:7:
>> include/linux/pci.h:1554:31: error: 'false' redeclared as different kind of symbol 1554 | #define pcie_ports_dpc_native false | ^~~~~ >> drivers/pci/pcie/portdrv.h:28:13: note: in expansion of macro 'pcie_ports_dpc_native'
28 | extern bool pcie_ports_dpc_native;
| ^~~~~~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/mod_devicetable.h:12,
from include/linux/pci.h:27,
from drivers/pci/pci-driver.c:7:include/linux/stddef.h:11:2: note: previous definition of 'false' was here 11 | false = 0,
| ^~~~~
vim +/false +1554 include/linux/pci.h
1546
1547 #ifdef CONFIG_PCIEPORTBUS
1548 extern bool pcie_ports_disabled;
1549 extern bool pcie_ports_native;
1550 extern bool pcie_ports_dpc_native;
1551 #else
1552 #define pcie_ports_disabled true
1553 #define pcie_ports_native false
> 1554 #define pcie_ports_dpc_native false
1555 #endif
1556
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
PATCH v3 5/5 PCI/AER: Replace pcie_aer_get_firmware_first() with pcie_aer_is_native()
In reply to [email protected]From: Kuppuswamy Sathyanarayanan <[email protected]>
Commit c100beb9ccfb ("PCI/AER: Use only _OSC to determine AER ownership") removed the dependency of HEST table in determining the status of AER ownership. But AER driver still uses HEST table parsed result in verifying the AER ownership status in some of its API's. So remove HEST table dependency, and instead use pcie_aer_is_native() to verify the AER native ownership status.
Also remove unused HEST table parsing helper functions from AER driver.
We can reintroduce HEST table parser once the usage of FIRMWARE_FIRST bit is clarified in PCI/AER specification.
--- drivers/pci/pcie/aer.c | 113 ++++--------------------------------- drivers/pci/pcie/dpc.c | 2 +- drivers/pci/pcie/portdrv.h | 13 +---- 3 files changed, 13 insertions(+), 115 deletions(-)
drivers/pci/pcie/aer.c +10 -103
@@ -211,115 +211,22 @@ void pcie_ecrc_get_policy(char *str) }#endif /* CONFIG_PCIE_ECRC */ -#ifdef CONFIG_ACPI_APEI -static inline int hest_match_pci (struct acpi_hest_aer_common *p, -struct pci_dev *pci) -{ -return ACPI_HEST_SEGMENT (p->bus) ==pci_domain_nr (pci->bus) && -ACPI_HEST_BUS (p->bus) == pci->bus->number && - p->device ==PCI_SLOT (pci->devfn) && - p->function ==PCI_FUNC (pci->devfn); -} - -static inline bool hest_match_type (struct acpi_hest_header *hest_hdr, -struct pci_dev *dev) -{ -u16 hest_type = hest_hdr->type; -u8 pcie_type =pci_pcie_type (dev); - -if ((hest_type ==ACPI_HEST_TYPE_AER_ROOT_PORT && - pcie_type ==PCI_EXP_TYPE_ROOT_PORT ) || - (hest_type ==ACPI_HEST_TYPE_AER_ENDPOINT && - pcie_type ==PCI_EXP_TYPE_ENDPOINT ) || - (hest_type ==ACPI_HEST_TYPE_AER_BRIDGE && - (dev->class >>16 ) ==PCI_BASE_CLASS_BRIDGE )) -return true; -return false; -} - -struct aer_hest_parse_info { -struct pci_dev *pci_dev; -int firmware_first; -}; - -static int hest_source_is_pcie_aer (struct acpi_hest_header *hest_hdr) -{ -if (hest_hdr->type ==ACPI_HEST_TYPE_AER_ROOT_PORT || - hest_hdr->type ==ACPI_HEST_TYPE_AER_ENDPOINT || - hest_hdr->type ==ACPI_HEST_TYPE_AER_BRIDGE ) -return 1 ; -return 0 ; -} - -static int aer_hest_parse (struct acpi_hest_header *hest_hdr,void *data) -{ -struct aer_hest_parse_info *info = data; -struct acpi_hest_aer_common *p; -int ff; - -if (!hest_source_is_pcie_aer (hest_hdr)) -return 0 ; - - p = (struct acpi_hest_aer_common *)(hest_hdr +1 ); - ff = !!(p->flags &ACPI_HEST_FIRMWARE_FIRST ); - -/* -* If no specific device is supplied, determine whether -* FIRMWARE_FIRST is set for *any* PCIe device. -*/ -if (!info->pci_dev) { - info->firmware_first |= ff; -return 0 ; - } - -/* Otherwise, check the specific device */ -if (p->flags &ACPI_HEST_GLOBAL ) { -if (hest_match_type (hest_hdr, info->pci_dev)) - info->firmware_first = ff; - }else -if (hest_match_pci (p, info->pci_dev)) - info->firmware_first = ff; - -return 0 ; -} +#define PCI_EXP_AER_FLAGS (PCI_EXP_DEVCTL_CERE | PCI_EXP_DEVCTL_NFERE | \ + PCI_EXP_DEVCTL_FERE | PCI_EXP_DEVCTL_URRE) -static void aer_set_firmware_first (struct pci_dev *pci_dev) +int pcie_aer_is_native (struct pci_dev *dev) { -int rc; -struct aer_hest_parse_info info = { - .pci_dev = pci_dev, - .firmware_first =0 , - }; - - rc =apei_hest_parse (aer_hest_parse, &info); +struct pci_host_bridge *host =pci_find_host_bridge (dev->bus); -if (rc) - pci_dev->__aer_firmware_first =0 ; -else - pci_dev->__aer_firmware_first = info.firmware_first; - pci_dev->__aer_firmware_first_valid =1 ; -} - -int pcie_aer_get_firmware_first (struct pci_dev *dev) -{if (!dev->aer_cap)return 0 ; -if (pcie_ports_native) -return 0 ; - -if (!dev->__aer_firmware_first_valid) -aer_set_firmware_first (dev); -return dev->__aer_firmware_first; +return host->native_aer; } -#endif - -#define PCI_EXP_AER_FLAGS (PCI_EXP_DEVCTL_CERE | PCI_EXP_DEVCTL_NFERE | \ - PCI_EXP_DEVCTL_FERE | PCI_EXP_DEVCTL_URRE)int pci_enable_pcie_error_reporting (struct pci_dev *dev) { -if (pcie_aer_get_firmware_first (dev)) +if (!pcie_aer_is_native (dev))return -EIO ;return pcie_capability_set_word (dev,PCI_EXP_DEVCTL ,PCI_EXP_AER_FLAGS );
@@ -328,7 +235,7 @@ EXPORT_SYMBOL_GPL(pci_enable_pcie_error_reporting);int pci_disable_pcie_error_reporting (struct pci_dev *dev) { -if (pcie_aer_get_firmware_first (dev)) +if (!pcie_aer_is_native (dev))return -EIO ; return pcie_capability_clear_word(dev, PCI_EXP_DEVCTL,
@@ -349,7 +256,7 @@ int pci_aer_clear_nonfatal_status(struct pci_dev *dev)int pos = dev->aer_cap;u32 status, sev; -if (pcie_aer_get_firmware_first (dev)) +if (!pcie_aer_is_native (dev))return -EIO ;/* Clear status bits for ERR_NONFATAL errors only */
@@ -368,7 +275,7 @@ void pci_aer_clear_fatal_status(struct pci_dev *dev)int pos = dev->aer_cap;u32 status, sev; -if (pcie_aer_get_firmware_first (dev)) +if (!pcie_aer_is_native (dev))return ;/* Clear status bits for ERR_FATAL errors only */
@@ -415,7 +322,7 @@ int pci_aer_raw_clear_status(struct pci_dev *dev)int pci_aer_clear_status (struct pci_dev *dev) { -if (pcie_aer_get_firmware_first (dev)) +if (!pcie_aer_is_native (dev))return -EIO ;return pci_aer_raw_clear_status (dev);
drivers/pci/pcie/dpc.c +1 -1
@@ -284,7 +284,7 @@ static int dpc_probe(struct pcie_device *dev)int status;u16 ctl, cap; -if (pcie_aer_get_firmware_first (pdev) && !pcie_ports_dpc_native) +if (!pcie_aer_is_native (pdev) && !pcie_ports_dpc_native)return -ENOTSUPP ; status = devm_request_threaded_irq(device, dev->irq, dpc_irq,
drivers/pci/pcie/portdrv.h +2 -11
@@ -29,8 +29,10 @@ extern bool pcie_ports_dpc_native;#ifdef CONFIG_PCIEAER int pcie_aer_init (void ); +int pcie_aer_is_native (struct pci_dev *dev);#else static inline int pcie_aer_init (void ) {return 0 ; } +statuc inline int pcie_aer_is_native(struct pci_dev *dev) { return 0; }#endif #ifdef CONFIG_HOTPLUG_PCI_PCIE
@@ -147,16 +149,5 @@ static inline bool pcie_pme_no_msi(void) { return false; }static inline void pcie_pme_interrupt_enable (struct pci_dev *dev,bool en) {}#endif /* !CONFIG_PCIE_PME */ -#ifdef CONFIG_ACPI_APEI -int pcie_aer_get_firmware_first (struct pci_dev *pci_dev); -#else -static inline int pcie_aer_get_firmware_first (struct pci_dev *pci_dev) -{ -if (pci_dev->__aer_firmware_first_valid) -return pci_dev->__aer_firmware_first; -return 0 ; -} -#endif -struct device *pcie_port_find_device (struct pci_dev *dev,u32 service);#endif /* _PORTDRV_H_ */
Signature · 1 line
2.17.1
kbuild test robot
build botRe: [PATCH v3 5/5] PCI/AER: Replace pcie_aer_get_firmware_first() with pcie_aer_is_native()
I love your patch! Yet something to improve:
Hi,
I love your patch! Yet something to improve:
[auto build test ERROR on pci/next]
[also build test ERROR on next-20200526]
[cannot apply to v5.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/sathyanarayanan-kuppuswamy-linux-intel-com/Remove-AER-HEST-table-parser/20200525-053721 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: arm-gemini_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>, old ones prefixed by <<):
In file included from drivers/pci/pci-driver.c:7:include/linux/pci.h:1554:31: error: 'false' redeclared as different kind of symbol 1554 | #define pcie_ports_dpc_native false
| ^~~~~drivers/pci/pcie/portdrv.h:28:13: note: in expansion of macro 'pcie_ports_dpc_native' 28 | extern bool pcie_ports_dpc_native;
| ^~~~~~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/mod_devicetable.h:12,
from include/linux/pci.h:27,
from drivers/pci/pci-driver.c:7:include/linux/stddef.h:11:2: note: previous definition of 'false' was here 11 | false = 0,
| ^~~~~
In file included from drivers/pci/pci-driver.c:22:
>> drivers/pci/pcie/portdrv.h:35:7: error: expected ';' before 'inline'
35 | statuc inline int pcie_aer_is_native(struct pci_dev *dev) { return 0; }
| ^
| ;vim +35 drivers/pci/pcie/portdrv.h
29
30 #ifdef CONFIG_PCIEAER
31 int pcie_aer_init(void);
32 int pcie_aer_is_native(struct pci_dev *dev);
33 #else
34 static inline int pcie_aer_init(void) { return 0; }
> 35 statuc inline int pcie_aer_is_native(struct pci_dev *dev) { return 0; }
36 #endif
37 ---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org