Skip to contentSkip to conversation

libubootenv: Remove the DEPENDS on mtd-utils

PATCH In review Adrian Bunk 2 participants 2 messages May 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libubootenv: Remove the DEPENDS on mtd-utils

It was only used for pulling in zlib, but this is now a direct dependency.

Also move the DEPENDS to a more common location in the file.

---
 meta/recipes-bsp/u-boot/libubootenv_0.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-bsp/u-boot/libubootenv_0.2.bb +1 -1
index fa90a12bf8..ea29b668e8 100644
@@ -1,5 +1,4 @@
 SUMMARY = "U-Boot libraries and tools to access environment"
-DEPENDS += "mtd-utils zlib"
 
 DESCRIPTION = "This package contains tools and libraries to read \
 and modify U-Boot environment. \
@@ -21,6 +20,7 @@ inherit cmake lib_package
 
 EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release"
 
+DEPENDS = "zlib"
 PROVIDES += "u-boot-fw-utils"
 RPROVIDES_${PN}-bin += "u-boot-fw-utils"
 
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw

Hi Adrian,

Quoted 3 lines · Adrian Bunk

It was only used for pulling in zlib, but this is now a direct dependency.

This is correct - I supposed when I started to implement the library to link against mtd-utils, but this was not possible due to license's incompatibility, and mtd-utils is not necessary at all.

Quoted 19 lines

Also move the DEPENDS to a more common location in the file.

---
 meta/recipes-bsp/u-boot/libubootenv_0.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-bsp/u-boot/libubootenv_0.2.bb +0 -1
index fa90a12bf8..ea29b668e8 100644
@@ -1,5 +1,4 @@
 SUMMARY = "U-Boot libraries and tools to access environment"
-DEPENDS += "mtd-utils zlib"
 
 DESCRIPTION = "This package contains tools and libraries to read \
 and modify U-Boot environment. \

meta/recipes-bsp/u-boot/libubootenv_0.2.bb inherit cmake lib_package · line 26

Quoted 7 lines
meta/recipes-bsp/u-boot/libubootenv_0.2.bb +1 -0
@@ -21,6 +20,7 @@ inherit cmake lib_package
 
 EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release"
 
+DEPENDS = "zlib"
 PROVIDES += "u-boot-fw-utils"
 RPROVIDES_${PN}-bin += "u-boot-fw-utils"
 

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================