Skip to contentSkip to conversation

content: Reserve virtio-nsm device ID

PATCH In review Petre Eftime 3 participants 7 messages May 27, 2020 – Aug 10, 2020 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 content: Reserve virtio-nsm device ID

The NitroSecureModule is a device with a very stripped down Trusted Platform Module functionality, which is used in the context of a Nitro Enclave (see https://lkml.org/lkml/2020/4/21/1020)
to provide boot time measurement and attestation.

Since this device provides some critical cryptographic operations, there are a series of operations which are required to have guarantees of atomicity, ordering and consistency: operations fully succeed or fully fail, including when some external events might interfere in the
process: live migration, crashes, etc; any failure in the critical section requires termination of the enclave it is attached to, so the device needs to be as resilient as possible, simplicity is strongly desired.

To account for that, the device and driver are made to have very few error cases in the critical path and the operations themselves can be rolled back and retried if events happen outside the critical area, while processing a request. The driver itself can be made very simple and thus is easily portable.

Since the requests can be handled directly in the virtio queue, serving most requests requires no additional buffering or memory allocations on the host side.

---
 content.tex | 2 ++
 1 file changed, 2 insertions(+)
content.tex +2 -0
index 91735e3..66c8f2b 100644
@@ -2801,6 +2801,8 @@ \chapter{Device Types}\label{sec:Device Types}
 \hline
 31         &   Video decoder device \\
 \hline
+33         &   NitroSecureModule \\
+\hline
 \end{tabular}
 
 Some of the devices above are unspecified by this document,
Signature · 23 lines
2.20.1




Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
Reviewed-by on v2 1/1
#1 lore raw
Quoted 20 lines · Petre Eftime

The NitroSecureModule is a device with a very stripped down Trusted Platform Module functionality, which is used in the context of a Nitro Enclave (see https://lkml.org/lkml/2020/4/21/1020)
to provide boot time measurement and attestation.

Since this device provides some critical cryptographic operations, there are a series of operations which are required to have guarantees of atomicity, ordering and consistency: operations fully succeed or fully fail, including when some external events might interfere in the
process: live migration, crashes, etc; any failure in the critical section requires termination of the enclave it is attached to, so the device needs to be as resilient as possible, simplicity is strongly desired.

To account for that, the device and driver are made to have very few error cases in the critical path and the operations themselves can be rolled back and retried if events happen outside the critical area, while processing a request. The driver itself can be made very simple and thus is easily portable.

Quoted 8 lines

Since the requests can be handled directly in the virtio queue, serving most requests requires no additional buffering or memory allocations on the host side.

---
 content.tex | 2 ++
 1 file changed, 2 insertions(+)
#2 lore raw
In reply to Petre Eftime
Quoted 34 lines · Petre Eftime

The NitroSecureModule is a device with a very stripped down Trusted Platform Module functionality, which is used in the context of a Nitro Enclave (see https://lkml.org/lkml/2020/4/21/1020)
to provide boot time measurement and attestation.

Since this device provides some critical cryptographic operations, there are a series of operations which are required to have guarantees of atomicity, ordering and consistency: operations fully succeed or fully fail, including when some external events might interfere in the
process: live migration, crashes, etc; any failure in the critical section requires termination of the enclave it is attached to, so the device needs to be as resilient as possible, simplicity is strongly desired.

To account for that, the device and driver are made to have very few error cases in the critical path and the operations themselves can be rolled back and retried if events happen outside the critical area, while processing a request. The driver itself can be made very simple and thus is easily portable.

Since the requests can be handled directly in the virtio queue, serving most requests requires no additional buffering or memory allocations on the host side.

---
  content.tex | 2 ++
  1 file changed, 2 insertions(+)
content.tex +0 -0
index 91735e3..66c8f2b 100644

content.tex \chapter{Device Types}\label{sec:Device Types} · line 2808

Quoted 8 lines
content.tex +2 -0
@@ -2801,6 +2801,8 @@ \chapter{Device Types}\label{sec:Device Types}
  \hline
  31         &   Video decoder device \\
  \hline
+33         &   NitroSecureModule \\
+\hline
  \end{tabular}
 
  Some of the devices above are unspecified by this document,

Hi all,

I've opened a corresponding issue on Github.

|Fixes: https://github.com/oasis-tcs/virtio-spec/issues/81|

|Thank you,|
|Petre Eftime
|

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

#3 lore raw
Quoted 49 lines · Petre
Quoted 34 lines · Petre Eftime

The NitroSecureModule is a device with a very stripped down Trusted Platform Module functionality, which is used in the context of a Nitro Enclave (see https://lkml.org/lkml/2020/4/21/1020)
to provide boot time measurement and attestation.

Since this device provides some critical cryptographic operations, there are a series of operations which are required to have guarantees of atomicity, ordering and consistency: operations fully succeed or fully fail, including when some external events might interfere in the
process: live migration, crashes, etc; any failure in the critical section requires termination of the enclave it is attached to, so the device needs to be as resilient as possible, simplicity is strongly desired.

To account for that, the device and driver are made to have very few error cases in the critical path and the operations themselves can be rolled back and retried if events happen outside the critical area, while processing a request. The driver itself can be made very simple and thus is easily portable.

Since the requests can be handled directly in the virtio queue, serving most requests requires no additional buffering or memory allocations on the host side.

---
  content.tex | 2 ++

  1 file changed, 2 insertions(+)
content.tex +0 -0
index 91735e3..66c8f2b 100644
@@ -2801,6 +2801,8 @@ \chapter{Device Types}\label{sec:Device Types}
Quoted 7 lines

  \hline
  31         &   Video decoder device \\
  \hline
+33         &   NitroSecureModule \\
+\hline
  \end{tabular}
    Some of the devices above are unspecified by this document,

Hi all,

I've opened a corresponding issue on Github.

|Fixes: https://github.com/oasis-tcs/virtio-spec/issues/81|

Quoted 7 lines
|Thank you,|
|Petre Eftime
|

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

Sorry, my mail client decided to add some extra characters.

Thank you,

Petre Eftime

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

#4 lore raw
In reply to Eftime, Petre
Quoted 45 lines · Petre

On 2020-05-27 12:07, Petre Eftime wrote:

The NitroSecureModule is a device with a very stripped down Trusted Platform Module functionality, which is used in the context of a Nitro Enclave (see https://lkml.org/lkml/2020/4/21/1020)
to provide boot time measurement and attestation.

Since this device provides some critical cryptographic operations, there are a series of operations which are required to have guarantees of atomicity, ordering and consistency: operations fully succeed or fully fail, including when some external events might interfere in the
process: live migration, crashes, etc; any failure in the critical section requires termination of the enclave it is attached to, so the device needs to be as resilient as possible, simplicity is strongly desired.

To account for that, the device and driver are made to have very few error cases in the critical path and the operations themselves can be rolled back and retried if events happen outside the critical area, while processing a request. The driver itself can be made very simple and thus is easily portable.

Since the requests can be handled directly in the virtio queue, serving most requests requires no additional buffering or memory allocations on the host side.

---
content.tex | 2 ++
1 file changed, 2 insertions(+)

diff --git a/content.tex b/content.tex
index 91735e3..66c8f2b 100644
--- a/content.tex
+++ b/content.tex
@@ -2801,6 +2801,8 @@ \chapter{Device Types}\label{sec:Device Types}
\hline
31 & Video decoder device \\
\hline
+33 & NitroSecureModule \\
+\hline
\end{tabular}

Some of the devices above are unspecified by this document,

Quoted 8 lines

Hi all,

I've opened a corresponding issue on Github.

Thank you,
Petre Eftime

Looks like no one minds. Do you want the TC to vote on this?

Quoted 5 lines

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#5 lore raw
Quoted 48 lines · Michael S. Tsirkin
Quoted 47 lines · Petre

On 2020-05-27 12:07, Petre Eftime wrote:

The NitroSecureModule is a device with a very stripped down Trusted Platform Module functionality, which is used in the context of a Nitro Enclave (see https://lkml.org/lkml/2020/4/21/1020)
to provide boot time measurement and attestation.

Since this device provides some critical cryptographic operations, there are a series of operations which are required to have guarantees of atomicity, ordering and consistency: operations fully succeed or fully fail, including when some external events might interfere in the
process: live migration, crashes, etc; any failure in the critical section requires termination of the enclave it is attached to, so the device needs to be as resilient as possible, simplicity is strongly desired.

To account for that, the device and driver are made to have very few error cases in the critical path and the operations themselves can be rolled back and retried if events happen outside the critical area, while processing a request. The driver itself can be made very simple and thus is easily portable.

Since the requests can be handled directly in the virtio queue, serving most requests requires no additional buffering or memory allocations on the host side.

---
content.tex | 2 ++
1 file changed, 2 insertions(+)

diff --git a/content.tex b/content.tex
index 91735e3..66c8f2b 100644
--- a/content.tex
+++ b/content.tex
@@ -2801,6 +2801,8 @@ \chapter{Device Types}\label{sec:Device Types}
\hline
31 & Video decoder device \\
\hline
+33 & NitroSecureModule \\
+\hline
\end{tabular}

Some of the devices above are unspecified by this document,

Hi all,

Quoted 9 lines
Quoted 6 lines

I've opened a corresponding issue on Github.

Thank you,
Petre Eftime

Looks like no one minds. Do you want the TC to vote on this?

Yes, would help us get started towards upstreaming the Linux driver for this.

Thank you,
Petre Eftime

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

A message that is not in the archive (sent off-list or not yet received): [email protected]

#7 lore raw
Quoted 70 lines · Alexander Graf
Quoted 67 lines · Petre
Quoted 66 lines · Michael S. Tsirkin
Quoted 54 lines · Petre

On 2020-05-27 12:07, Petre Eftime wrote:

     The NitroSecureModule is a device with a very stripped down      Trusted Platform Module functionality, which is used in the      context of a Nitro Enclave (see
https://lkml.org/lkml/2020/4/21/1020)
     to provide boot time measurement and attestation.

     Since this device provides some critical cryptographic operations,      there are a series of operations which are required to have guarantees
     of atomicity, ordering and consistency: operations fully succeed or fully
     fail, including when some external events might interfere in the      process: live migration, crashes, etc; any failure in the critical      section requires termination of the enclave it is attached to, so      the device needs to be as resilient as possible, simplicity is      strongly desired.

     To account for that, the device and driver are made to have very few
     error cases in the critical path and the operations themselves can be
     rolled back and retried if events happen outside the critical      area, while processing a request. The driver itself can be made very
     simple and thus is easily portable.

     Since the requests can be handled directly in the virtio queue, serving
     most requests requires no additional buffering or memory allocations
     on the host side.

     Signed-off-by: Petre Eftime <[email protected]>      ---
      content.tex | 2 ++
      1 file changed, 2 insertions(+)

     diff --git a/content.tex b/content.tex
     index 91735e3..66c8f2b 100644
     --- a/content.tex
     +++ b/content.tex
     @@ -2801,6 +2801,8 @@ \chapter{Device Types}\label{sec:Device Types}
      \hline
      31         &   Video decoder device \\
      \hline
     +33         &   NitroSecureModule \\
     +\hline
      \end{tabular}

      Some of the devices above are unspecified by this document,

Quoted 8 lines

Hi all,

I've opened a corresponding issue on Github.

Thank you,
Petre Eftime

Looks like no one minds. Do you want the TC to vote on this?

Quoted 8 lines
Quoted 2 lines

Yes, would help us get started towards upstreaming the Linux driver for this.

So what is the next step to get the vote happening? :)

Alex

Missed the answer, sorry. Started vote now.

Quoted 10 lines

Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/