Skip to contentSkip to conversation

powerpc, mpc83xx: add DM_ETH support

PATCH Superseded Heiko Schocher 3 participants 23 messages May 27, 2020 – Sep 30, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

This patch series adds DM ethernet support for mpc83xx based keymile boards.

Travis build:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214

Changes in v2:
- new in v2
- remove RFC
- fixed Codingstyle errors, therefore new patch
powerpc, mpc83xx: fix codingstyle issues for qe_io.c
- moved DM part to drivers/pinctrl
- add comments from Qiang Zhao:
- add device node documentation
- I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c because using drivers/net/fsl_mdio.c leads in none existent udevice mdio at 3320
instead boards with DM ETH support should use now this driver.
- remove RFC tag
- add patch which fixes Codingstyle errors in drivers/qe
- add patch which converts the mpc83xx based boards from keymile to DM_ETH

Heiko Schocher (5):
mpc83xx: remove unneeded extern declaration in cpu_init powerpc, qe: fix codingstyle issues for drivers/qe powerpc, qe: add DTS support for parallel I/O ports net, qe: add DM support for QE UEC ethernet mpc83xx, keymile boards: enable DM_ETH and add DTS

 arch/powerpc/cpu/mpc83xx/Kconfig              |    8 +
 arch/powerpc/cpu/mpc83xx/Makefile             |    2 +
 arch/powerpc/cpu/mpc83xx/cpu_init.c           |   11 +-
 arch/powerpc/cpu/mpc83xx/qe_io.c              |   98 +-
 arch/powerpc/dts/Makefile                     |    8 +
 arch/powerpc/dts/km8309-uboot.dtsi            |   33 +
 arch/powerpc/dts/km8321-uboot.dtsi            |   67 +
 arch/powerpc/dts/km8321.dtsi                  |  220 ++++
 arch/powerpc/dts/km836x-uboot.dtsi            |   61 +
 arch/powerpc/dts/km836x.dtsi                  |  182 +++
 arch/powerpc/dts/kmcoge5ne-uboot.dtsi         |   22 +
 arch/powerpc/dts/kmcoge5ne.dts                |  320 +++++
 arch/powerpc/dts/kmeter1-uboot.dtsi           |   42 +
 arch/powerpc/dts/kmeter1.dts                  |  480 +++++++
 arch/powerpc/dts/kmopti2.dts                  |  161 +++
 arch/powerpc/dts/kmsupc5.dts                  |  139 ++
 arch/powerpc/dts/kmsupm5.dts                  |  129 ++
 arch/powerpc/dts/kmtegr1.dts                  |  392 ++++++
 arch/powerpc/dts/kmtepr2.dts                  |  142 ++
 arch/powerpc/dts/kmtuge1.dts                  |  100 ++
 arch/powerpc/dts/kmtuxa1.dts                  |  100 ++
 board/keymile/km83xx/Kconfig                  |   17 +
 board/keymile/km83xx/MAINTAINERS              |   23 +-
 board/keymile/km83xx/km83xx.c                 |   64 -
 configs/kmcoge5ne_defconfig                   |   11 +-
 configs/kmeter1_defconfig                     |   10 +-
 configs/kmopti2_defconfig                     |   11 +-
 configs/kmsupx5_defconfig                     |   10 +-
 configs/kmtegr1_defconfig                     |   12 +-
 configs/kmtepr2_defconfig                     |   10 +-
 configs/tuge1_defconfig                       |   10 +-
 configs/tuxx1_defconfig                       |   11 +-
 .../soc/fsl/cpm_qe/qe/ucc.txt                 |   53 +
 drivers/net/Kconfig                           |    2 +
 drivers/net/Makefile                          |    1 +
 drivers/net/qe/Kconfig                        |    9 +
 drivers/net/qe/Makefile                       |    5 +
 drivers/net/qe/dm_qe_uec.c                    | 1167 +++++++++++++++++
 drivers/net/qe/dm_qe_uec.h                    |   22 +
 drivers/net/qe/dm_qe_uec_phy.c                |  163 +++
 drivers/net/qe/uccf.c                         |  507 +++++++
 drivers/net/qe/uccf.h                         |  119 ++
 drivers/net/qe/uec.h                          |  693 ++++++++++
 drivers/pinctrl/Kconfig                       |    7 +
 drivers/pinctrl/Makefile                      |    1 +
 drivers/pinctrl/pinctrl-qe-io.c               |  255 ++++
 drivers/qe/qe.c                               |   96 +-
 drivers/qe/uccf.c                             |  449 ++++---
 drivers/qe/uccf.h                             |   90 +-
 drivers/qe/uec.c                              |  598 ++++-----
 drivers/qe/uec.h                              |  381 +++---
 drivers/qe/uec_phy.c                          |  334 ++---
 drivers/qe/uec_phy.h                          |   71 +-
 include/configs/km/km-mpc832x.h               |   14 -
 include/configs/km/km-mpc8360.h               |   14 -
 include/configs/km/km-mpc83xx.h               |   10 -
 include/fsl_qe.h                              |    3 +
 57 files changed, 6826 insertions(+), 1144 deletions(-)
 create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi
 create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi
 create mode 100644 arch/powerpc/dts/km8321.dtsi
 create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi
 create mode 100644 arch/powerpc/dts/km836x.dtsi
 create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi
 create mode 100644 arch/powerpc/dts/kmcoge5ne.dts
 create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi
 create mode 100644 arch/powerpc/dts/kmeter1.dts
 create mode 100644 arch/powerpc/dts/kmopti2.dts
 create mode 100644 arch/powerpc/dts/kmsupc5.dts
 create mode 100644 arch/powerpc/dts/kmsupm5.dts
 create mode 100644 arch/powerpc/dts/kmtegr1.dts
 create mode 100644 arch/powerpc/dts/kmtepr2.dts
 create mode 100644 arch/powerpc/dts/kmtuge1.dts
 create mode 100644 arch/powerpc/dts/kmtuxa1.dts
 create mode 100644 doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt
 create mode 100644 drivers/net/qe/Kconfig
 create mode 100644 drivers/net/qe/Makefile
 create mode 100644 drivers/net/qe/dm_qe_uec.c
 create mode 100644 drivers/net/qe/dm_qe_uec.h
 create mode 100644 drivers/net/qe/dm_qe_uec_phy.c
 create mode 100644 drivers/net/qe/uccf.c
 create mode 100644 drivers/net/qe/uccf.h
 create mode 100644 drivers/net/qe/uec.h
 create mode 100644 drivers/pinctrl/pinctrl-qe-io.c
Signature · 1 line
2.24.1
#1 lore raw

PATCH v2 1/5 mpc83xx: remove unneeded extern declaration in cpu_init

remove
extern void qe_init(uint qe_base);
extern void qe_reset(void);

and include fsl_qe.h instead.

---

Changes in v2:
- new in v2

 arch/powerpc/cpu/mpc83xx/cpu_init.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/powerpc/cpu/mpc83xx/cpu_init.c +1 -2
index 438b14b162..b21b0b0324 100644
@@ -9,6 +9,7 @@
 #include <ioports.h>
 #include <asm/io.h>
 #include <asm/processor.h>
+#include <fsl_qe.h>
 #ifdef CONFIG_USB_EHCI_FSL
 #include <usb/ehci-ci.h>
 #endif
@@ -26,8 +27,6 @@ DECLARE_GLOBAL_DATA_PTR;
 extern qe_iop_conf_t qe_iop_conf_tab[];
 extern void qe_config_iopin(u8 port, u8 pin, int dir,
 			 int open_drain, int assign);
-extern void qe_init(uint qe_base);
-extern void qe_reset(void);
 
 static void config_qe_ioports(void)
 {
Signature · 1 line
2.24.1
#2 lore raw

PATCH v2 2/5 powerpc, qe: fix codingstyle issues for drivers/qe

In reply to Heiko Schocher

fix Codingstyle for files in drivers/qe, remaining following check warnings:

$ ./scripts/checkpatch.pl -f drivers/qe/uec.h
CHECK: Macro argument reuse '_bd' - possible side-effects?
+#define BD_ADVANCE(_bd, _status, _base)        \
+       (((_status) & BD_WRAP) ? (_bd) = \
+        ((struct buffer_descriptor *)(_base)) : ++(_bd))

total: 0 errors, 0 warnings, 1 checks, 692 lines checked

$ ./scripts/checkpatch.pl -f drivers/qe/uec_phy.h
total: 0 errors, 0 warnings, 0 checks, 214 lines checked
$ ./scripts/checkpatch.pl -f drivers/qe/uccf.c
total: 0 errors, 0 warnings, 0 checks, 507 lines checked
$ ./scripts/checkpatch.pl -f drivers/qe/uec.c
total: 0 errors, 0 warnings, 0 checks, 1434 lines checked
$ ./scripts/checkpatch.pl -f drivers/qe/uec_phy.c
total: 0 errors, 0 warnings, 0 checks, 927 lines checked
$ ./scripts/checkpatch.pl -f drivers/qe/qe.c
CHECK: Lines should not end with a '('
+U_BOOT_CMD(

total: 0 errors, 0 warnings, 1 checks, 830 lines checked

---

Changes in v2: None

 arch/powerpc/cpu/mpc83xx/qe_io.c |  63 ++--
 drivers/qe/qe.c                  |  96 ++---
 drivers/qe/uccf.c                | 447 ++++++++++++++---------
 drivers/qe/uccf.h                |  90 ++---
 drivers/qe/uec.c                 | 596 ++++++++++++++++---------------
 drivers/qe/uec.h                 | 381 +++++++++-----------
 drivers/qe/uec_phy.c             | 331 +++++++++--------
 drivers/qe/uec_phy.h             |  71 ++--
 8 files changed, 1073 insertions(+), 1002 deletions(-)
arch/powerpc/cpu/mpc83xx/qe_io.c +33 -30
index 88aa689551..1079ae128a 100644
@@ -14,55 +14,58 @@
 #define	NUM_OF_PINS	32
 void qe_config_iopin(u8 port, u8 pin, int dir, int open_drain, int assign)
 {
-	u32			pin_2bit_mask;
-	u32			pin_2bit_dir;
-	u32			pin_2bit_assign;
-	u32			pin_1bit_mask;
-	u32			tmp_val;
-	volatile immap_t	*im = (volatile immap_t *)CONFIG_SYS_IMMR;
-	volatile qepio83xx_t	*par_io = (volatile qepio83xx_t *)&im->qepio;
+	u32		2bit_mask;
+	u32		2bit_dir;
+	u32		2bit_assign;
+	u32		1bit_mask;
+	u32		tmp_val;
+	immap_t		*im;
+	qepio83xx_t	*par_io;
+	int		offset;
+
+	im = (immap_t *)CONFIG_SYS_IMMR;
+	par_io = (qepio83xx_t *)&im->qepio;
+	offset = (NUM_OF_PINS - (pin % (NUM_OF_PINS / 2) + 1) * 2);
 
 	/* Calculate pin location and 2bit mask and dir */
-	pin_2bit_mask = (u32)(0x3 << (NUM_OF_PINS-(pin%(NUM_OF_PINS/2)+1)*2));
-	pin_2bit_dir = (u32)(dir << (NUM_OF_PINS-(pin%(NUM_OF_PINS/2)+1)*2));
+	2bit_mask = (u32)(0x3 << offset);
+	2bit_dir = (u32)(dir << offset);
 
 	/* Setup the direction */
-	tmp_val = (pin > (NUM_OF_PINS/2) - 1) ? \
+	tmp_val = (pin > (NUM_OF_PINS / 2) - 1) ?
 		in_be32(&par_io->ioport[port].dir2) :
 		in_be32(&par_io->ioport[port].dir1);
 
-	if (pin > (NUM_OF_PINS/2) -1) {
-		out_be32(&par_io->ioport[port].dir2, ~pin_2bit_mask & tmp_val);
-		out_be32(&par_io->ioport[port].dir2, pin_2bit_dir | tmp_val);
+	if (pin > (NUM_OF_PINS / 2) - 1) {
+		out_be32(&par_io->ioport[port].dir2, ~2bit_mask & tmp_val);
+		out_be32(&par_io->ioport[port].dir2, 2bit_dir | tmp_val);
 	} else {
-		out_be32(&par_io->ioport[port].dir1, ~pin_2bit_mask & tmp_val);
-		out_be32(&par_io->ioport[port].dir1, pin_2bit_dir | tmp_val);
+		out_be32(&par_io->ioport[port].dir1, ~2bit_mask & tmp_val);
+		out_be32(&par_io->ioport[port].dir1, 2bit_dir | tmp_val);
 	}
 
 	/* Calculate pin location for 1bit mask */
-	pin_1bit_mask = (u32)(1 << (NUM_OF_PINS - (pin+1)));
+	1bit_mask = (u32)(1 << (NUM_OF_PINS - (pin + 1)));
 
 	/* Setup the open drain */
 	tmp_val = in_be32(&par_io->ioport[port].podr);
-	if (open_drain) {
-		out_be32(&par_io->ioport[port].podr, pin_1bit_mask | tmp_val);
-	} else {
-		out_be32(&par_io->ioport[port].podr, ~pin_1bit_mask & tmp_val);
-	}
+	if (open_drain)
+		out_be32(&par_io->ioport[port].podr, 1bit_mask | tmp_val);
+	else
+		out_be32(&par_io->ioport[port].podr, ~1bit_mask & tmp_val);
 
 	/* Setup the assignment */
-	tmp_val = (pin > (NUM_OF_PINS/2) - 1) ?
-		in_be32(&par_io->ioport[port].ppar2):
+	tmp_val = (pin > (NUM_OF_PINS / 2) - 1) ?
+		in_be32(&par_io->ioport[port].ppar2) :
 		in_be32(&par_io->ioport[port].ppar1);
-	pin_2bit_assign = (u32)(assign
-				<< (NUM_OF_PINS - (pin%(NUM_OF_PINS/2)+1)*2));
+	2bit_assign = (u32)(assign << offset);
 
 	/* Clear and set 2 bits mask */
-	if (pin > (NUM_OF_PINS/2) - 1) {
-		out_be32(&par_io->ioport[port].ppar2, ~pin_2bit_mask & tmp_val);
-		out_be32(&par_io->ioport[port].ppar2, pin_2bit_assign | tmp_val);
+	if (pin > (NUM_OF_PINS / 2) - 1) {
+		out_be32(&par_io->ioport[port].ppar2, ~2bit_mask & tmp_val);
+		out_be32(&par_io->ioport[port].ppar2, 2bit_assign | tmp_val);
 	} else {
-		out_be32(&par_io->ioport[port].ppar1, ~pin_2bit_mask & tmp_val);
-		out_be32(&par_io->ioport[port].ppar1, pin_2bit_assign | tmp_val);
+		out_be32(&par_io->ioport[port].ppar1, ~2bit_mask & tmp_val);
+		out_be32(&par_io->ioport[port].ppar1, 2bit_assign | tmp_val);
 	}
 }
drivers/qe/qe.c +50 -46

258 lines not on this page · raw message

drivers/qe/uccf.c +283 -164

575 lines not on this page · raw message

drivers/qe/uccf.h +46 -44

141 lines not on this page · raw message

drivers/qe/uec.c +299 -297

1,241 lines not on this page · raw message

drivers/qe/uec.h +166 -215

586 lines not on this page · raw message

drivers/qe/uec_phy.c +173 -158

111 lines not on this page · raw message

drivers/qe/uec_phy.h +23 -48

71 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.24.1

Part of the diff is not shown here. View the raw message.

#3 lore raw

PATCH v2 3/5 powerpc, qe: add DTS support for parallel I/O ports

In reply to Heiko Schocher

add DM support for parallel I/O ports on QUICC Engine Block

---
Open questions / discussion:

- I let the old none DM based implementation in code so boards should work with old implementation.

This should be removed if all boards are converted to DM/DTS.

- Unfortunately linux DTS does not use "pinctrl-"
properties, instead "pio-handle" properties.

Even worser old U-Boot code initializes all pins defined in "const qe_iop_conf_t qe_iop_conf_tab[]" table in board code. As linux does the same I decided to also scan through all subnodes containing "pio-map" property and initialize them too.

The proper solution would be to check for "pio-handle" when a device is probed.

Changes in v2:
- remove RFC
- fixed Codingstyle errors, therefore new patch powerpc, mpc83xx: fix codingstyle issues for qe_io.c
- moved DM part to drivers/pinctrl

 arch/powerpc/cpu/mpc83xx/Makefile   |   2 +
 arch/powerpc/cpu/mpc83xx/cpu_init.c |   8 +
 arch/powerpc/cpu/mpc83xx/qe_io.c    |  83 ++++++---
 drivers/pinctrl/Kconfig             |   7 +
 drivers/pinctrl/Makefile            |   1 +
 drivers/pinctrl/pinctrl-qe-io.c     | 255 ++++++++++++++++++++++++++++
 include/fsl_qe.h                    |   3 +
 7 files changed, 334 insertions(+), 25 deletions(-)
 create mode 100644 drivers/pinctrl/pinctrl-qe-io.c
arch/powerpc/cpu/mpc83xx/Makefile +2 -0
index 304029977e..aeb42b109d 100644
@@ -27,7 +27,9 @@ obj-y += cpu_init.o
 obj-y += speed.o
 obj-y += interrupts.o
 obj-y += ecc.o
+ifndef CONFIG_PINCTRL
 obj-$(CONFIG_QE) += qe_io.o
+endif
 obj-$(CONFIG_FSL_SERDES) += serdes.o
 ifndef CONFIG_ARCH_MPC8308
 obj-$(CONFIG_PCI) += pci.o
arch/powerpc/cpu/mpc83xx/cpu_init.c +8 -0
index b21b0b0324..840f907acb 100644
@@ -14,6 +14,9 @@
 #include <usb/ehci-ci.h>
 #endif
 #include <linux/delay.h>
+#ifdef CONFIG_QE
+#include <fsl_qe.h>
+#endif
 
 #include "lblaw/lblaw.h"
 #include "elbc/elbc.h"
@@ -28,6 +31,7 @@ extern qe_iop_conf_t qe_iop_conf_tab[];
 extern void qe_config_iopin(u8 port, u8 pin, int dir,
 			 int open_drain, int assign);
 
+#if !defined(CONFIG_PINCTRL)
 static void config_qe_ioports(void)
 {
 	u8	port, pin;
@@ -44,6 +48,7 @@ static void config_qe_ioports(void)
 	}
 }
 #endif
+#endif
 
 /*
  * Breathe some life into the CPU...
@@ -190,10 +195,13 @@ void cpu_init_f (volatile immap_t * im)
 	__raw_writel(CONFIG_SYS_OBIR, &im->sysconf.obir);
 #endif
 
+#if !defined(CONFIG_PINCTRL)
 #ifdef CONFIG_QE
 	/* Config QE ioports */
 	config_qe_ioports();
 #endif
+#endif
+
 	/* Set up preliminary BR/OR regs */
 	init_early_memctl_regs();
 
arch/powerpc/cpu/mpc83xx/qe_io.c +58 -25

117 lines not on this page · raw message

drivers/pinctrl/Kconfig +7 -0
index 83e39b9de3..06df148b06 100644
@@ -205,6 +205,13 @@ config PINCTRL_QCA953X
 	  the GPIO definitions and pin control functions for each available
 	  multiplex function.
 
+config PINCTRL_QE
+	bool "QE based pinctrl driver, like on mpc83xx"
+	depends on DM
+	help
+	  This option is to enable the QE pinctrl driver for QE based io
+	  controller.
+
 config PINCTRL_ROCKCHIP_RV1108
 	bool "Rockchip rv1108 pin control driver"
 	depends on DM
drivers/pinctrl/Makefile +1 -0
index 4f662c4f6d..7b9a672198 100644
@@ -21,6 +21,7 @@ obj-$(CONFIG_PINCTRL_MESON)	+= meson/
 obj-$(CONFIG_PINCTRL_MTK)	+= mediatek/
 obj-$(CONFIG_PINCTRL_MSCC)	+= mscc/
 obj-$(CONFIG_ARCH_MVEBU)	+= mvebu/
+obj-$(CONFIG_PINCTRL_QE)	+= pinctrl-qe-io.o
 obj-$(CONFIG_PINCTRL_SINGLE)	+= pinctrl-single.o
 obj-$(CONFIG_PINCTRL_STI)	+= pinctrl-sti.o
 obj-$(CONFIG_PINCTRL_STM32)	+= pinctrl_stm32.o
drivers/pinctrl/pinctrl-qe-io.c new file +255 -0

255 lines not on this page · raw message

include/fsl_qe.h +3 -0
index 6e44cbdb56..1c6941347f 100644
@@ -296,4 +296,7 @@ int u_qe_firmware_resume(const struct qe_firmware *firmware,
 			 qe_map_t *qe_immrr);
 #endif
 
+#if defined(CONFIG_PINCTRL)
+int par_io_of_config(struct udevice *dev);
+#endif
 #endif /* __QE_H__ */
Signature · 1 line
2.24.1
#4 lore raw

PATCH v2 4/5 net, qe: add DM support for QE UEC ethernet

In reply to Heiko Schocher

add DM/DTS support for the UEC ethernet on QUICC Engine Block.

---

- I let the old none DM based implementation in code so boards should work with old implementation. This Code should be removed if all boards are converted to DM/DTS.

- add the DM based qe uec driver under drivers/net/qe

- Therefore copied the files uccf.c uccf.h uec.h from drivers/qe. So there are a lot of Codingstyle problems currently. I fix them in next version if this RFC patch is OK or it needs some changes.

- The dm based driver code is now under drivers/net/qe/dm_qe_uec.c Used a lot of functions from drivers/qe/uec.c

- seperated the PHY specific code into seperate file drivers/net/qe/dm_qe_uec_phy.c

Changes in v2:
- add comments from Qiang Zhao:
- add device node documentation
- I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c because using drivers/net/fsl_mdio.c leads in none existent udevice mdio at 3320
instead boards with DM ETH support should use now this driver.
- remove RFC tag

 .../soc/fsl/cpm_qe/qe/ucc.txt                 |   53 +
 drivers/net/Kconfig                           |    2 +
 drivers/net/Makefile                          |    1 +
 drivers/net/qe/Kconfig                        |    9 +
 drivers/net/qe/Makefile                       |    5 +
 drivers/net/qe/dm_qe_uec.c                    | 1167 +++++++++++++++++
 drivers/net/qe/dm_qe_uec.h                    |   22 +
 drivers/net/qe/dm_qe_uec_phy.c                |  163 +++
 drivers/net/qe/uccf.c                         |  507 +++++++
 drivers/net/qe/uccf.h                         |  119 ++
 drivers/net/qe/uec.h                          |  693 ++++++++++
 drivers/qe/uccf.c                             |    2 +
 drivers/qe/uec.c                              |    2 +
 drivers/qe/uec_phy.c                          |    3 +
 14 files changed, 2748 insertions(+)
 create mode 100644 doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt
 create mode 100644 drivers/net/qe/Kconfig
 create mode 100644 drivers/net/qe/Makefile
 create mode 100644 drivers/net/qe/dm_qe_uec.c
 create mode 100644 drivers/net/qe/dm_qe_uec.h
 create mode 100644 drivers/net/qe/dm_qe_uec_phy.c
 create mode 100644 drivers/net/qe/uccf.c
 create mode 100644 drivers/net/qe/uccf.h
 create mode 100644 drivers/net/qe/uec.h
doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt new file +53 -0
new file mode 100644
index 0000000000..2758f86437
@@ -0,0 +1,53 @@
+* UCC (Unified Communications Controllers)
+
+Required properties:
+- compatible : ucc_geth
+- cell-index : the ucc number(1-8), corresponding to UCCx in UM.
+- reg : Offset and length of the register set for the device
+- rx-clock-name: the UCC receive clock source
+  "none": clock source is disabled
+  "brg1" through "brg16": clock source is BRG1-BRG16, respectively
+  "clk1" through "clk24": clock source is CLK1-CLK24, respectively
+- tx-clock-name: the UCC transmit clock source
+  "none": clock source is disabled
+  "brg1" through "brg16": clock source is BRG1-BRG16, respectively
+  "clk1" through "clk24": clock source is CLK1-CLK24, respectively
+The following two properties are deprecated.  rx-clock has been replaced
+with rx-clock-name, and tx-clock has been replaced with tx-clock-name.
+Drivers that currently use the deprecated properties should continue to
+do so, in order to support older device trees, but they should be updated
+to check for the new properties first.
+- rx-clock : represents the UCC receive clock source.
+  0x00 : clock source is disabled;
+  0x1~0x10 : clock source is BRG1~BRG16 respectively;
+  0x11~0x28: clock source is QE_CLK1~QE_CLK24 respectively.
+- tx-clock: represents the UCC transmit clock source;
+  0x00 : clock source is disabled;
+  0x1~0x10 : clock source is BRG1~BRG16 respectively;
+  0x11~0x28: clock source is QE_CLK1~QE_CLK24 respectively.
+- phy-handle : The phandle for the PHY connected to this controller.
+- phy-connection-type : a string naming the controller/PHY interface type,
+  i.e., "mii" (default), "rmii", "gmii", "rgmii", "rgmii-id" (Internal
+  Delay), "rgmii-txid" (delay on TX only), "rgmii-rxid" (delay on RX only),
+  "tbi", or "rtbi".
+- pio-handle : The phandle for the Parallel I/O port configuration.
+
+Deprecated properties:
+- device-id : the ucc number(1-8), corresponding to UCCx in UM.
+    you should use cell-index
+
+Example:
+        ucc at 2000 {
+                device_type = "network";
+                compatible = "ucc_geth";
+                cell-index = <1>;
+                reg = <2000 200>;
+                interrupts = <a0 0>;
+                interrupt-parent = <700>;
+                mac-address = [ 00 04 9f 00 23 23 ];
+                rx-clock = "none";
+                tx-clock = "clk9";
+                phy-handle = <212000>;
+                phy-connection-type = "gmii";
+                pio-handle = <140001>;
+        };
drivers/net/Kconfig +2 -0
index 0b08de0ef4..f984f09450 100644
@@ -391,6 +391,8 @@ config MII
 	help
 	  Enable support of the Media-Independent Interface (MII)
 
+source "drivers/net/qe/Kconfig"
+
 config RTL8139
 	bool "Realtek 8139 series Ethernet controller driver"
 	help
drivers/net/Makefile +1 -0
index 383ed1c64f..6f8957f521 100644
@@ -77,6 +77,7 @@ obj-$(CONFIG_VSC9953) += vsc9953.o
 obj-$(CONFIG_PIC32_ETH) += pic32_mdio.o pic32_eth.o
 obj-$(CONFIG_DWC_ETH_QOS) += dwc_eth_qos.o
 obj-$(CONFIG_FSL_PFE) += pfe_eth/
+obj-y += qe/
 obj-$(CONFIG_SNI_AVE) += sni_ave.o
 obj-y += ti/
 obj-$(CONFIG_MEDIATEK_ETH) += mtk_eth.o
drivers/net/qe/Kconfig new file +9 -0
new file mode 100644
index 0000000000..dec88dea2a
@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (C) 2020 Heiko Schocher <[email protected]>
+
+config QE_UEC
+	bool "NXP QE UEC Ethernet controller"
+	depends on DM_ETH
+	help
+	  This driver supports the NXP QE UEC ethernet controller
drivers/net/qe/Makefile new file +5 -0
new file mode 100644
index 0000000000..7d84757c17
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (C) 2020 Heiko Schocher <[email protected]>
+
+obj-$(CONFIG_QE_UEC) += dm_qe_uec.o dm_qe_uec_phy.o uccf.o
drivers/net/qe/dm_qe_uec.c new file +1167 -0

1,167 lines not on this page · raw message

drivers/net/qe/dm_qe_uec.h new file +22 -0
new file mode 100644
index 0000000000..690093caa2
@@ -0,0 +1,22 @@
+/* SPDX-License-Identifier: GPL-2.0+
+ *
+ * QE UEC ethernet controller driver
+ *
+ * based on drivers/qe/uec.c from NXP
+ *
+ * Copyright (C) 2020 Heiko Schocher <[email protected]>
+ */
+
+#ifndef _DM_QE_UEC_H
+#define _DM_QE_UEC_H
+
+#define qe_uec_dbg(dev, fmt, args...)	debug("%s:" fmt, dev->name, ##args)
+
+#include "uec.h"
+
+/* QE UEC private structure */
+struct qe_uec_priv {
+	struct uec_priv *uec;
+	struct phy_device *phydev;
+};
+#endif
drivers/net/qe/dm_qe_uec_phy.c new file +163 -0

163 lines not on this page · raw message

drivers/net/qe/uccf.c new file +507 -0

507 lines not on this page · raw message

drivers/net/qe/uccf.h new file +119 -0

119 lines not on this page · raw message

drivers/net/qe/uec.h new file +693 -0

693 lines not on this page · raw message

drivers/qe/uccf.c +2 -0
index 306f1ea1db..d5d734439c 100644
@@ -14,6 +14,7 @@
 #include "uccf.h"
 #include <fsl_qe.h>
 
+#if !defined(CONFIG_DM_ETH)
 void ucc_fast_transmit_on_demand(struct ucc_fast_priv *uccf)
 {
 	out_be16(&uccf->uf_regs->utodr, UCC_FAST_TOD);
@@ -505,3 +506,4 @@ int ucc_fast_init(struct ucc_fast_inf *uf_info,
 	*uccf_ret = uccf;
 	return 0;
 }
+#endif
drivers/qe/uec.c +2 -0
index 1ead28f1dd..5f6f159af2 100644
@@ -20,6 +20,7 @@
 #include <fsl_qe.h>
 #include <phy.h>
 
+#if !defined(CONFIG_DM_ETH)
 /* Default UTBIPAR SMI address */
 #ifndef CONFIG_UTBIPAR_INIT_TBIPA
 #define CONFIG_UTBIPAR_INIT_TBIPA 0x1F
@@ -1432,3 +1433,4 @@ int uec_standard_init(bd_t *bis)
 {
 	return uec_eth_init(bis, uec_info, ARRAY_SIZE(uec_info));
 }
+#endif
drivers/qe/uec_phy.c +3 -0
index b5ca5f76f9..9d429c832f 100644
@@ -23,6 +23,8 @@
 #include <fsl_qe.h>
 #include <phy.h>
 
+#if !defined(CONFIG_DM_ETH)
+
 #define ugphy_printk(format, arg...)  \
 	printf(format "\n", ## arg)
 
@@ -925,3 +927,4 @@ void change_phy_interface_mode(struct eth_device *dev,
 	marvell_phy_interface_mode(dev, type, speed);
 #endif
 }
+#endif
Signature · 1 line
2.24.1
#5 lore raw

PATCH v2 5/5 mpc83xx, keymile boards: enable DM_ETH and add DTS

In reply to Heiko Schocher

enable DTS support for keymile mpc83xx based boards.

get rid of compile warning:
===================== WARNING ====================== This board does not use CONFIG_DM_ETH (Driver Model for Ethernet drivers). Please update the board to use CONFIG_DM_ETH before the v2020.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info.
====================================================

Therefore done:
- add DTS for all mpc83xx based boards from keymile mainly they are not mainlined to linux.
- add u-boot specific dtsi
- add stdout-path
- add missing ucc4 par_io definitions, which were in board code, but not in linux DTS
- remove not used ethernet nodes

---

Changes in v2:
- add patch which fixes Codingstyle errors in drivers/qe
- add patch which converts the mpc83xx based boards from keymile to DM_ETH

 arch/powerpc/cpu/mpc83xx/Kconfig      |   8 +
 arch/powerpc/dts/Makefile             |   8 +
 arch/powerpc/dts/km8309-uboot.dtsi    |  33 ++
 arch/powerpc/dts/km8321-uboot.dtsi    |  67 ++++
 arch/powerpc/dts/km8321.dtsi          | 220 ++++++++++++
 arch/powerpc/dts/km836x-uboot.dtsi    |  61 ++++
 arch/powerpc/dts/km836x.dtsi          | 182 ++++++++++
 arch/powerpc/dts/kmcoge5ne-uboot.dtsi |  22 ++
 arch/powerpc/dts/kmcoge5ne.dts        | 320 +++++++++++++++++
 arch/powerpc/dts/kmeter1-uboot.dtsi   |  42 +++
 arch/powerpc/dts/kmeter1.dts          | 480 ++++++++++++++++++++++++++
 arch/powerpc/dts/kmopti2.dts          | 161 +++++++++
 arch/powerpc/dts/kmsupc5.dts          | 139 ++++++++
 arch/powerpc/dts/kmsupm5.dts          | 129 +++++++
 arch/powerpc/dts/kmtegr1.dts          | 392 +++++++++++++++++++++
 arch/powerpc/dts/kmtepr2.dts          | 142 ++++++++
 arch/powerpc/dts/kmtuge1.dts          | 100 ++++++
 arch/powerpc/dts/kmtuxa1.dts          | 100 ++++++
 board/keymile/km83xx/Kconfig          |  17 +
 board/keymile/km83xx/MAINTAINERS      |  23 +-
 board/keymile/km83xx/km83xx.c         |  64 ----
 configs/kmcoge5ne_defconfig           |  11 +-
 configs/kmeter1_defconfig             |  10 +-
 configs/kmopti2_defconfig             |  11 +-
 configs/kmsupx5_defconfig             |  10 +-
 configs/kmtegr1_defconfig             |  12 +-
 configs/kmtepr2_defconfig             |  10 +-
 configs/tuge1_defconfig               |  10 +-
 configs/tuxx1_defconfig               |  11 +-
 include/configs/km/km-mpc832x.h       |  14 -
 include/configs/km/km-mpc8360.h       |  14 -
 include/configs/km/km-mpc83xx.h       |  10 -
 32 files changed, 2694 insertions(+), 139 deletions(-)
 create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi
 create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi
 create mode 100644 arch/powerpc/dts/km8321.dtsi
 create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi
 create mode 100644 arch/powerpc/dts/km836x.dtsi
 create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi
 create mode 100644 arch/powerpc/dts/kmcoge5ne.dts
 create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi
 create mode 100644 arch/powerpc/dts/kmeter1.dts
 create mode 100644 arch/powerpc/dts/kmopti2.dts
 create mode 100644 arch/powerpc/dts/kmsupc5.dts
 create mode 100644 arch/powerpc/dts/kmsupm5.dts
 create mode 100644 arch/powerpc/dts/kmtegr1.dts
 create mode 100644 arch/powerpc/dts/kmtepr2.dts
 create mode 100644 arch/powerpc/dts/kmtuge1.dts
 create mode 100644 arch/powerpc/dts/kmtuxa1.dts
arch/powerpc/cpu/mpc83xx/Kconfig +8 -0
index 18808da37d..2bae08e278 100644
@@ -101,34 +101,42 @@ config TARGET_IDS8313
 config TARGET_KMETER1
 	bool "Support kmeter1"
 	select VENDOR_KM
+	select KM_ENABLE_FULL_DM_DTS_SUPPORT
 
 config TARGET_KMCOGE5NE
 	bool "Support kmcoge5ne"
 	select VENDOR_KM
+	select KM_ENABLE_FULL_DM_DTS_SUPPORT
 
 config TARGET_KMTEGR1
 	bool "Support kmtegr1"
 	select VENDOR_KM
+	select KM_ENABLE_FULL_DM_DTS_SUPPORT
 
 config TARGET_TUXX1
 	bool "Support tuxx1"
 	select VENDOR_KM
+	select KM_ENABLE_FULL_DM_DTS_SUPPORT
 
 config TARGET_KMSUPX5
 	bool "Support kmsupx5"
 	select VENDOR_KM
+	select KM_ENABLE_FULL_DM_DTS_SUPPORT
 
 config TARGET_TUGE1
 	bool "Support tuge1"
 	select VENDOR_KM
+	select KM_ENABLE_FULL_DM_DTS_SUPPORT
 
 config TARGET_KMOPTI2
 	bool "Support kmopti2"
 	select VENDOR_KM
+	select KM_ENABLE_FULL_DM_DTS_SUPPORT
 
 config TARGET_KMTEPR2
 	bool "Support kmtepr2"
 	select VENDOR_KM
+	select KM_ENABLE_FULL_DM_DTS_SUPPORT
 
 config TARGET_TQM834X
 	bool "Support TQM834x"
arch/powerpc/dts/Makefile +8 -0
index 7eb005f450..266d345f72 100644
@@ -1,5 +1,11 @@
 # SPDX-License-Identifier: GPL-2.0+
 
+dtb-$(CONFIG_TARGET_KMCOGE5NE) += kmcoge5ne.dtb
+dtb-$(CONFIG_TARGET_KMETER1) += kmeter1.dtb
+dtb-$(CONFIG_TARGET_KMOPTI2) += kmopti2.dtb
+dtb-$(CONFIG_TARGET_KMSUPX5) += kmsupc5.dtb kmsupm5.dtb
+dtb-$(CONFIG_TARGET_KMTEGR1) += kmtegr1.dtb
+dtb-$(CONFIG_TARGET_KMTEPR2) += kmtepr2.dtb
 dtb-$(CONFIG_TARGET_MPC8548CDS) += mpc8548cds.dtb mpc8548cds_36b.dtb
 dtb-$(CONFIG_TARGET_P1010RDB_PA) += p1010rdb-pa.dtb p1010rdb-pa_36b.dtb
 dtb-$(CONFIG_TARGET_P1010RDB_PB) += p1010rdb-pb.dtb p1010rdb-pb_36b.dtb
@@ -16,6 +22,8 @@ dtb-$(CONFIG_TARGET_T1042D4RDB) += t1042d4rdb.dtb
 dtb-$(CONFIG_TARGET_T2080QDS) += t2080qds.dtb
 dtb-$(CONFIG_TARGET_T2080RDB) += t2080rdb.dtb
 dtb-$(CONFIG_TARGET_T4240RDB) += t4240rdb.dtb
+dtb-$(CONFIG_TARGET_TUGE1) += kmtuge1.dtb
+dtb-$(CONFIG_TARGET_TUXX1) += kmtuxa1.dtb
 dtb-$(CONFIG_TARGET_MCR3000) += mcr3000.dtb
 dtb-$(CONFIG_TARGET_GAZERBEAM) += gazerbeam.dtb
 
arch/powerpc/dts/km8309-uboot.dtsi new file +33 -0
new file mode 100644
index 0000000000..c44ce7d8dc
@@ -0,0 +1,33 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * ABB PGGA 8309 U-Boot specific Device Tree Source parts
+ *
+ * Copyright (C) 2020 Heiko Schocher <[email protected]>
+ *
+ */
+
+/ {
+	cpus {
+		u-boot,dm-pre-reloc;
+		PowerPC,8309 at 0 {
+			u-boot,dm-pre-reloc;
+		};
+	};
+
+	chosen {
+		stdout-path = &serial0;
+	};
+};
+
+&qe {
+	compatible = "fsl,qe", "simple-bus";
+};
+
+&soc {
+	u-boot,dm-pre-reloc;
+};
+
+&serial0 {
+	clock-frequency = <132000000>;
+	u-boot,dm-pre-reloc;
+};
arch/powerpc/dts/km8321-uboot.dtsi new file +67 -0

67 lines not on this page · raw message

arch/powerpc/dts/km8321.dtsi new file +220 -0

220 lines not on this page · raw message

arch/powerpc/dts/km836x-uboot.dtsi new file +61 -0

61 lines not on this page · raw message

arch/powerpc/dts/km836x.dtsi new file +182 -0

182 lines not on this page · raw message

arch/powerpc/dts/kmcoge5ne-uboot.dtsi new file +22 -0
new file mode 100644
index 0000000000..6a5e74f434
@@ -0,0 +1,22 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * ABB PGGA kmcoge5ne U-Boot specific Device Tree Source parts
+ *
+ * Copyright (C) 2020 Heiko Schocher <[email protected]>
+ *
+ */
+
+/ {
+	aliases {
+		/delete-property/ ethernet1;
+		/delete-property/ ethernet2;
+	};
+};
+
+&enet_switch {
+	status = "disabled";
+};
+
+&enet_mate {
+	status = "disabled";
+};
arch/powerpc/dts/kmcoge5ne.dts new file +320 -0

320 lines not on this page · raw message

arch/powerpc/dts/kmeter1-uboot.dtsi new file +42 -0

42 lines not on this page · raw message

arch/powerpc/dts/kmeter1.dts new file +480 -0

480 lines not on this page · raw message

arch/powerpc/dts/kmopti2.dts new file +161 -0

161 lines not on this page · raw message

arch/powerpc/dts/kmsupc5.dts new file +139 -0

139 lines not on this page · raw message

arch/powerpc/dts/kmsupm5.dts new file +129 -0

129 lines not on this page · raw message

arch/powerpc/dts/kmtegr1.dts new file +392 -0

392 lines not on this page · raw message

arch/powerpc/dts/kmtepr2.dts new file +142 -0

142 lines not on this page · raw message

arch/powerpc/dts/kmtuge1.dts new file +100 -0

100 lines not on this page · raw message

arch/powerpc/dts/kmtuxa1.dts new file +100 -0

100 lines not on this page · raw message

board/keymile/km83xx/Kconfig +17 -0
index 94075ce70f..bbafabdcb2 100644
@@ -1,3 +1,20 @@
+menu "KM 83xx Options"
+	depends on MPC83xx
+
+config KM_ENABLE_FULL_DM_DTS_SUPPORT
+	bool "enable full DM/DTS support for KM 83xx boards"
+	default y
+	select CMD_DM
+	select DM
+	select DM_ETH
+	select DM_MDIO
+	select DM_SERIAL
+	select OF_CONTROL
+	select PINCTRL
+	select PINCTRL_QE
+	select PHYLIB
+endmenu
+
 if TARGET_KMETER1
 
 config SYS_BOARD
board/keymile/km83xx/MAINTAINERS +18 -5
index 177c2c4970..0ce6317625 100644
@@ -1,5 +1,6 @@
 KM83XX BOARD
 M:	Holger Brunck <[email protected]>
+M:	Heiko Schocher <[email protected]>
 S:	Maintained
 F:	board/keymile/km83xx/
 F:	include/configs/km8360.h
@@ -7,12 +8,24 @@ F:	configs/kmcoge5ne_defconfig
 F:	configs/kmeter1_defconfig
 F:	include/configs/tuxx1.h
 F:	configs/kmopti2_defconfig
+F:	configs/kmsupx5_defconfig
 F:	configs/kmtepr2_defconfig
 F:	configs/kmtegr1_defconfig
 F:	configs/tuge1_defconfig
 F:	configs/tuxx1_defconfig
-
-KMSUPX5 BOARD
-M:	Heiko Schocher <[email protected]>
-S:	Maintained
-F:	configs/kmsupx5_defconfig
+F:	arch/powerpc/dts/km8309-uboot.dtsi
+F:	arch/powerpc/dts/km8321-uboot.dtsi
+F:	arch/powerpc/dts/km8321.dtsi
+F:	arch/powerpc/dts/km836x-uboot.dtsi
+F:	arch/powerpc/dts/km836x.dtsi
+F:	arch/powerpc/dts/kmcoge5ne-uboot.dtsi
+F:	arch/powerpc/dts/kmcoge5ne.dts
+F:	arch/powerpc/dts/kmeter1-uboot.dtsi
+F:	arch/powerpc/dts/kmeter1.dts
+F:	arch/powerpc/dts/kmopti2.dts
+F:	arch/powerpc/dts/kmsupc5.dts
+F:	arch/powerpc/dts/kmsupm5.dts
+F:	arch/powerpc/dts/kmtegr1.dts
+F:	arch/powerpc/dts/kmtepr2.dts
+F:	arch/powerpc/dts/kmtuge1.dts
+F:	arch/powerpc/dts/kmtuxa1.dts
board/keymile/km83xx/km83xx.c +0 -64

70 lines not on this page · raw message

configs/kmcoge5ne_defconfig +7 -4
index 363099212e..2d7b7ba879 100644
@@ -4,7 +4,6 @@ CONFIG_KM_DEF_NETDEV="eth1"
 CONFIG_ENV_SIZE=0x4000
 CONFIG_ENV_SECT_SIZE=0x20000
 CONFIG_BOOTCOUNT_BOOTLIMIT=3
-CONFIG_SYS_BOOTCOUNT_ADDR=0xE011BFF8
 CONFIG_SYS_CLK_FREQ=66000000
 CONFIG_MPC83xx=y
 CONFIG_HIGH_BATS=y
@@ -156,7 +155,6 @@ CONFIG_ACR_PARKM_USB_I2C1_BOOT=y
 CONFIG_LCRR_DBYP_PLL_BYPASSED=y
 CONFIG_LCRR_EADC_2=y
 CONFIG_LCRR_CLKDIV_4=y
-# CONFIG_SYS_MALLOC_F is not set
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_OF_STDOUT_VIA_ALIAS=y
 CONFIG_MISC_INIT_R=y
@@ -173,6 +171,7 @@ CONFIG_CMD_GREPENV=y
 CONFIG_CMD_EEPROM=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_NAND=y
+# CONFIG_CMD_PINMUX is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
@@ -182,11 +181,13 @@ CONFIG_MTDIDS_DEFAULT="nor0=boot,nand0=app"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=boot:768k(u-boot),128k(env),128k(envred),-(ubi0);app:-(ubi1);"
 CONFIG_CMD_UBI=y
 # CONFIG_CMD_UBIFS is not set
+CONFIG_DEFAULT_DEVICE_TREE="kmcoge5ne"
 CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
 CONFIG_ENV_ADDR=0xF00C0000
 CONFIG_ENV_ADDR_REDUND=0xF00E0000
-CONFIG_DM=y
 CONFIG_BOOTCOUNT_LIMIT=y
+CONFIG_DM_BOOTCOUNT=y
+CONFIG_BOOTCOUNT_MEM=y
 # CONFIG_MMC is not set
 CONFIG_MTD=y
 CONFIG_MTD_NOR_FLASH=y
@@ -196,8 +197,10 @@ CONFIG_FLASH_CFI_MTD=y
 CONFIG_SYS_FLASH_PROTECTION=y
 CONFIG_SYS_FLASH_CFI=y
 CONFIG_MTD_RAW_NAND=y
+CONFIG_DM_ETH_PHY=y
+CONFIG_QE_UEC=y
 # CONFIG_PCI is not set
+# CONFIG_PINCTRL_FULL is not set
 CONFIG_QE=y
 CONFIG_SYS_NS16550=y
 CONFIG_BCH=y
-CONFIG_OF_LIBFDT=y
configs/kmeter1_defconfig +6 -4
index 97c75dc68c..8967ace2e1 100644
@@ -4,7 +4,6 @@ CONFIG_KM_DEF_NETDEV="eth2"
 CONFIG_ENV_SIZE=0x4000
 CONFIG_ENV_SECT_SIZE=0x20000
 CONFIG_BOOTCOUNT_BOOTLIMIT=3
-CONFIG_SYS_BOOTCOUNT_ADDR=0xE011BFF8
 CONFIG_SYS_CLK_FREQ=66000000
 CONFIG_MPC83xx=y
 CONFIG_HIGH_BATS=y
@@ -120,7 +119,6 @@ CONFIG_ACR_PARKM_USB_I2C1_BOOT=y
 CONFIG_LCRR_DBYP_PLL_BYPASSED=y
 CONFIG_LCRR_EADC_2=y
 CONFIG_LCRR_CLKDIV_4=y
-# CONFIG_SYS_MALLOC_F is not set
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_OF_STDOUT_VIA_ALIAS=y
 CONFIG_MISC_INIT_R=y
@@ -136,6 +134,7 @@ CONFIG_CMD_ASKENV=y
 CONFIG_CMD_GREPENV=y
 CONFIG_CMD_EEPROM=y
 CONFIG_CMD_I2C=y
+# CONFIG_CMD_PINMUX is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
@@ -145,11 +144,13 @@ CONFIG_MTDIDS_DEFAULT="nor0=boot"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=boot:768k(u-boot),128k(env),128k(envred),-(ubi0);"
 CONFIG_CMD_UBI=y
 # CONFIG_CMD_UBIFS is not set
+CONFIG_DEFAULT_DEVICE_TREE="kmeter1"
 CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
 CONFIG_ENV_ADDR=0xF00C0000
 CONFIG_ENV_ADDR_REDUND=0xF00E0000
-CONFIG_DM=y
 CONFIG_BOOTCOUNT_LIMIT=y
+CONFIG_DM_BOOTCOUNT=y
+CONFIG_BOOTCOUNT_MEM=y
 # CONFIG_MMC is not set
 CONFIG_MTD=y
 CONFIG_MTD_NOR_FLASH=y
@@ -158,7 +159,8 @@ CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y
 CONFIG_FLASH_CFI_MTD=y
 CONFIG_SYS_FLASH_PROTECTION=y
 CONFIG_SYS_FLASH_CFI=y
+CONFIG_DM_ETH_PHY=y
+CONFIG_QE_UEC=y
 # CONFIG_PCI is not set
 CONFIG_QE=y
 CONFIG_SYS_NS16550=y
-CONFIG_OF_LIBFDT=y
configs/kmopti2_defconfig +7 -4
index 4b0f0e7521..7059facf0e 100644
@@ -3,7 +3,6 @@ CONFIG_SYS_TEXT_BASE=0xF0000000
 CONFIG_ENV_SIZE=0x4000
 CONFIG_ENV_SECT_SIZE=0x20000
 CONFIG_BOOTCOUNT_BOOTLIMIT=3
-CONFIG_SYS_BOOTCOUNT_ADDR=0xE0113FF8
 CONFIG_SYS_CLK_FREQ=66000000
 CONFIG_MPC83xx=y
 CONFIG_HIGH_BATS=y
@@ -139,7 +138,6 @@ CONFIG_ACR_APARK_MASTER=y
 CONFIG_ACR_PARKM_USB_I2C1_BOOT=y
 CONFIG_LCRR_EADC_1=y
 CONFIG_LCRR_CLKDIV_2=y
-# CONFIG_SYS_MALLOC_F is not set
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_OF_STDOUT_VIA_ALIAS=y
 CONFIG_MISC_INIT_R=y
@@ -155,6 +153,7 @@ CONFIG_CMD_ASKENV=y
 CONFIG_CMD_GREPENV=y
 CONFIG_CMD_EEPROM=y
 CONFIG_CMD_I2C=y
+# CONFIG_CMD_PINMUX is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
@@ -164,11 +163,13 @@ CONFIG_MTDIDS_DEFAULT="nor0=boot"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=boot:768k(u-boot),128k(env),128k(envred),-(ubi0);"
 CONFIG_CMD_UBI=y
 # CONFIG_CMD_UBIFS is not set
+CONFIG_DEFAULT_DEVICE_TREE="kmopti2"
 CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
 CONFIG_ENV_ADDR=0xF00C0000
 CONFIG_ENV_ADDR_REDUND=0xF00E0000
-CONFIG_DM=y
 CONFIG_BOOTCOUNT_LIMIT=y
+CONFIG_DM_BOOTCOUNT=y
+CONFIG_BOOTCOUNT_MEM=y
 # CONFIG_MMC is not set
 CONFIG_MTD=y
 CONFIG_MTD_NOR_FLASH=y
@@ -177,7 +178,9 @@ CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y
 CONFIG_FLASH_CFI_MTD=y
 CONFIG_SYS_FLASH_PROTECTION=y
 CONFIG_SYS_FLASH_CFI=y
+CONFIG_DM_ETH_PHY=y
+CONFIG_QE_UEC=y
 # CONFIG_PCI is not set
+# CONFIG_PINCTRL_FULL is not set
 CONFIG_QE=y
 CONFIG_SYS_NS16550=y
-CONFIG_OF_LIBFDT=y
configs/kmsupx5_defconfig +6 -4
index 2e8c2d32f2..d62fc84cf6 100644
@@ -3,7 +3,6 @@ CONFIG_SYS_TEXT_BASE=0xF0000000
 CONFIG_ENV_SIZE=0x4000
 CONFIG_ENV_SECT_SIZE=0x20000
 CONFIG_BOOTCOUNT_BOOTLIMIT=3
-CONFIG_SYS_BOOTCOUNT_ADDR=0xE0113FF8
 CONFIG_SYS_CLK_FREQ=66000000
 CONFIG_MPC83xx=y
 CONFIG_HIGH_BATS=y
@@ -119,7 +118,6 @@ CONFIG_ACR_APARK_MASTER=y
 CONFIG_ACR_PARKM_USB_I2C1_BOOT=y
 CONFIG_LCRR_EADC_1=y
 CONFIG_LCRR_CLKDIV_2=y
-# CONFIG_SYS_MALLOC_F is not set
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_OF_STDOUT_VIA_ALIAS=y
 CONFIG_MISC_INIT_R=y
@@ -144,11 +142,13 @@ CONFIG_MTDIDS_DEFAULT="nor0=boot"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=boot:768k(u-boot),128k(env),128k(envred),-(ubi0);"
 CONFIG_CMD_UBI=y
 # CONFIG_CMD_UBIFS is not set
+CONFIG_DEFAULT_DEVICE_TREE="kmsupm5"
 CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
 CONFIG_ENV_ADDR=0xF00C0000
 CONFIG_ENV_ADDR_REDUND=0xF00E0000
-CONFIG_DM=y
 CONFIG_BOOTCOUNT_LIMIT=y
+CONFIG_DM_BOOTCOUNT=y
+CONFIG_BOOTCOUNT_MEM=y
 # CONFIG_MMC is not set
 CONFIG_MTD=y
 CONFIG_MTD_NOR_FLASH=y
@@ -157,7 +157,9 @@ CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y
 CONFIG_FLASH_CFI_MTD=y
 CONFIG_SYS_FLASH_PROTECTION=y
 CONFIG_SYS_FLASH_CFI=y
+CONFIG_DM_ETH_PHY=y
+CONFIG_QE_UEC=y
 # CONFIG_PCI is not set
+# CONFIG_PINCTRL_FULL is not set
 CONFIG_QE=y
 CONFIG_SYS_NS16550=y
-CONFIG_OF_LIBFDT=y
configs/kmtegr1_defconfig +8 -4
index dc09d238ec..5bb2b05e25 100644
@@ -4,7 +4,6 @@ CONFIG_KM_DEF_NETDEV="eth1"
 CONFIG_ENV_SIZE=0x4000
 CONFIG_ENV_SECT_SIZE=0x20000
 CONFIG_BOOTCOUNT_BOOTLIMIT=3
-CONFIG_SYS_BOOTCOUNT_ADDR=0xE0113FF8
 CONFIG_SYS_CLK_FREQ=66000000
 CONFIG_MPC83xx=y
 CONFIG_HIGH_BATS=y
@@ -118,7 +117,6 @@ CONFIG_ACR_APARK_MASTER=y
 CONFIG_ACR_PARKM_USB_I2C1_BOOT=y
 CONFIG_LCRR_EADC_1=y
 CONFIG_LCRR_CLKDIV_2=y
-# CONFIG_SYS_MALLOC_F is not set
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_OF_STDOUT_VIA_ALIAS=y
 CONFIG_SYS_EXTRA_OPTIONS="KMTEGR1"
@@ -146,11 +144,13 @@ CONFIG_MTDPARTS_DEFAULT="mtdparts=boot:768k(u-boot),256k(qe-fw),128k(env),128k(e
 CONFIG_CMD_DIAG=y
 CONFIG_CMD_UBI=y
 # CONFIG_CMD_UBIFS is not set
+CONFIG_DEFAULT_DEVICE_TREE="kmtegr1"
 CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
 CONFIG_ENV_ADDR=0xF0100000
 CONFIG_ENV_ADDR_REDUND=0xF0120000
-CONFIG_DM=y
 CONFIG_BOOTCOUNT_LIMIT=y
+CONFIG_DM_BOOTCOUNT=y
+CONFIG_BOOTCOUNT_MEM=y
 # CONFIG_MMC is not set
 CONFIG_MTD=y
 CONFIG_MTD_NOR_FLASH=y
@@ -160,9 +160,13 @@ CONFIG_FLASH_CFI_MTD=y
 CONFIG_SYS_FLASH_PROTECTION=y
 CONFIG_SYS_FLASH_CFI=y
 CONFIG_MTD_RAW_NAND=y
+CONFIG_PHY_SMSC=y
+CONFIG_PHY_FIXED=y
+CONFIG_DM_ETH_PHY=y
+CONFIG_QE_UEC=y
 # CONFIG_PCI is not set
+# CONFIG_PINCTRL_FULL is not set
 CONFIG_QE=y
 CONFIG_SYS_QE_FMAN_FW_IN_NOR=y
 CONFIG_SYS_NS16550=y
 CONFIG_BCH=y
-CONFIG_OF_LIBFDT=y
configs/kmtepr2_defconfig +6 -4
index 6159425bba..02888dd1d3 100644
@@ -3,7 +3,6 @@ CONFIG_SYS_TEXT_BASE=0xF0000000
 CONFIG_ENV_SIZE=0x4000
 CONFIG_ENV_SECT_SIZE=0x20000
 CONFIG_BOOTCOUNT_BOOTLIMIT=3
-CONFIG_SYS_BOOTCOUNT_ADDR=0xE0113FF8
 CONFIG_SYS_CLK_FREQ=66000000
 CONFIG_MPC83xx=y
 CONFIG_HIGH_BATS=y
@@ -139,7 +138,6 @@ CONFIG_ACR_APARK_MASTER=y
 CONFIG_ACR_PARKM_USB_I2C1_BOOT=y
 CONFIG_LCRR_EADC_1=y
[… more lines in the raw message]

Lines of this file are not shown. View the raw message.

configs/tuge1_defconfig +6 -4
index 93ff5f0361..7ac97742c5 100644

Lines of this file are not shown. View the raw message.

configs/tuxx1_defconfig +7 -4
index 2e27dc6b3f..77ca2db57a 100644

Lines of this file are not shown. View the raw message.

include/configs/km/km-mpc832x.h +0 -14
index d7186ab919..22dfb5da67 100644

Lines of this file are not shown. View the raw message.

include/configs/km/km-mpc8360.h +0 -14
index bdbb8bf6b5..798b126960 100644

Lines of this file are not shown. View the raw message.

include/configs/km/km-mpc83xx.h +0 -10
index 451baf8b80..7d9012c715 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.24.1

Part of the diff is not shown here. View the raw message.

#6 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

In reply to Heiko Schocher

Hello Mario,

Am 27.05.2020 um 14:43 schrieb Heiko Schocher:

Quoted 109 lines

This patch series adds DM ethernet support for mpc83xx based keymile boards.

Travis build:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214

Changes in v2:
- new in v2
- remove RFC
- fixed Codingstyle errors, therefore new patch
powerpc, mpc83xx: fix codingstyle issues for qe_io.c
- moved DM part to drivers/pinctrl
- add comments from Qiang Zhao:
- add device node documentation
- I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c because using drivers/net/fsl_mdio.c leads in none existent udevice mdio at 3320
instead boards with DM ETH support should use now this driver.
- remove RFC tag
- add patch which fixes Codingstyle errors in drivers/qe
- add patch which converts the mpc83xx based boards from keymile to DM_ETH

Heiko Schocher (5):
mpc83xx: remove unneeded extern declaration in cpu_init powerpc, qe: fix codingstyle issues for drivers/qe powerpc, qe: add DTS support for parallel I/O ports net, qe: add DM support for QE UEC ethernet mpc83xx, keymile boards: enable DM_ETH and add DTS

  arch/powerpc/cpu/mpc83xx/Kconfig              |    8 +
  arch/powerpc/cpu/mpc83xx/Makefile             |    2 +
  arch/powerpc/cpu/mpc83xx/cpu_init.c           |   11 +-
  arch/powerpc/cpu/mpc83xx/qe_io.c              |   98 +-
  arch/powerpc/dts/Makefile                     |    8 +
  arch/powerpc/dts/km8309-uboot.dtsi            |   33 +
  arch/powerpc/dts/km8321-uboot.dtsi            |   67 +
  arch/powerpc/dts/km8321.dtsi                  |  220 ++++
  arch/powerpc/dts/km836x-uboot.dtsi            |   61 +
  arch/powerpc/dts/km836x.dtsi                  |  182 +++
  arch/powerpc/dts/kmcoge5ne-uboot.dtsi         |   22 +
  arch/powerpc/dts/kmcoge5ne.dts                |  320 +++++
  arch/powerpc/dts/kmeter1-uboot.dtsi           |   42 +
  arch/powerpc/dts/kmeter1.dts                  |  480 +++++++
  arch/powerpc/dts/kmopti2.dts                  |  161 +++
  arch/powerpc/dts/kmsupc5.dts                  |  139 ++
  arch/powerpc/dts/kmsupm5.dts                  |  129 ++
  arch/powerpc/dts/kmtegr1.dts                  |  392 ++++++
  arch/powerpc/dts/kmtepr2.dts                  |  142 ++
  arch/powerpc/dts/kmtuge1.dts                  |  100 ++
  arch/powerpc/dts/kmtuxa1.dts                  |  100 ++
  board/keymile/km83xx/Kconfig                  |   17 +
  board/keymile/km83xx/MAINTAINERS              |   23 +-
  board/keymile/km83xx/km83xx.c                 |   64 -
  configs/kmcoge5ne_defconfig                   |   11 +-
  configs/kmeter1_defconfig                     |   10 +-
  configs/kmopti2_defconfig                     |   11 +-
  configs/kmsupx5_defconfig                     |   10 +-
  configs/kmtegr1_defconfig                     |   12 +-
  configs/kmtepr2_defconfig                     |   10 +-
  configs/tuge1_defconfig                       |   10 +-
  configs/tuxx1_defconfig                       |   11 +-
  .../soc/fsl/cpm_qe/qe/ucc.txt                 |   53 +
  drivers/net/Kconfig                           |    2 +
  drivers/net/Makefile                          |    1 +
  drivers/net/qe/Kconfig                        |    9 +
  drivers/net/qe/Makefile                       |    5 +
  drivers/net/qe/dm_qe_uec.c                    | 1167 +++++++++++++++++
  drivers/net/qe/dm_qe_uec.h                    |   22 +
  drivers/net/qe/dm_qe_uec_phy.c                |  163 +++
  drivers/net/qe/uccf.c                         |  507 +++++++
  drivers/net/qe/uccf.h                         |  119 ++
  drivers/net/qe/uec.h                          |  693 ++++++++++
  drivers/pinctrl/Kconfig                       |    7 +
  drivers/pinctrl/Makefile                      |    1 +
  drivers/pinctrl/pinctrl-qe-io.c               |  255 ++++
  drivers/qe/qe.c                               |   96 +-
  drivers/qe/uccf.c                             |  449 ++++---
  drivers/qe/uccf.h                             |   90 +-
  drivers/qe/uec.c                              |  598 ++++-----
  drivers/qe/uec.h                              |  381 +++---
  drivers/qe/uec_phy.c                          |  334 ++---
  drivers/qe/uec_phy.h                          |   71 +-
  include/configs/km/km-mpc832x.h               |   14 -
  include/configs/km/km-mpc8360.h               |   14 -
  include/configs/km/km-mpc83xx.h               |   10 -
  include/fsl_qe.h                              |    3 +
  57 files changed, 6826 insertions(+), 1144 deletions(-)

create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi create mode 100644 arch/powerpc/dts/km8321.dtsi
create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi create mode 100644 arch/powerpc/dts/km836x.dtsi
create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi create mode 100644 arch/powerpc/dts/kmcoge5ne.dts
create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi create mode 100644 arch/powerpc/dts/kmeter1.dts
create mode 100644 arch/powerpc/dts/kmopti2.dts
create mode 100644 arch/powerpc/dts/kmsupc5.dts
create mode 100644 arch/powerpc/dts/kmsupm5.dts
create mode 100644 arch/powerpc/dts/kmtegr1.dts
create mode 100644 arch/powerpc/dts/kmtepr2.dts
create mode 100644 arch/powerpc/dts/kmtuge1.dts
create mode 100644 arch/powerpc/dts/kmtuxa1.dts
create mode 100644 doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt create mode 100644 drivers/net/qe/Kconfig

Quoted 8 lines

create mode 100644 drivers/net/qe/Makefile create mode 100644 drivers/net/qe/dm_qe_uec.c create mode 100644 drivers/net/qe/dm_qe_uec.h create mode 100644 drivers/net/qe/dm_qe_uec_phy.c create mode 100644 drivers/net/qe/uccf.c create mode 100644 drivers/net/qe/uccf.h create mode 100644 drivers/net/qe/uec.h create mode 100644 drivers/pinctrl/pinctrl-qe-io.c

gentle ping!

I got no reviews, comments for this patchseries ...

any comments?

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#7 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Hi Mario,

Am 17.08.2020 um 07:23 schrieb Heiko Schocher:

Quoted 121 lines

Hello Mario,

Am 27.05.2020 um 14:43 schrieb Heiko Schocher:

Quoted 109 lines

This patch series adds DM ethernet support for mpc83xx based keymile boards.

Travis build:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214

Changes in v2:
- new in v2
- remove RFC
- fixed Codingstyle errors, therefore new patch
?? powerpc, mpc83xx: fix codingstyle issues for qe_io.c
- moved DM part to drivers/pinctrl
- add comments from Qiang Zhao:
?? - add device node documentation
?? - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c ???? because using drivers/net/fsl_mdio.c leads in none existent ???? udevice mdio at 3320
???? instead boards with DM ETH support should use now this ???? driver.
- remove RFC tag
- add patch which fixes Codingstyle errors in drivers/qe
- add patch which converts the mpc83xx based boards from
?? keymile to DM_ETH

Heiko Schocher (5):
?? mpc83xx: remove unneeded extern declaration in cpu_init ?? powerpc, qe: fix codingstyle issues for drivers/qe ?? powerpc, qe: add DTS support for parallel I/O ports ?? net, qe: add DM support for QE UEC ethernet
?? mpc83xx, keymile boards: enable DM_ETH and add DTS

? arch/powerpc/cpu/mpc83xx/Kconfig????????????? |??? 8 +
? arch/powerpc/cpu/mpc83xx/Makefile???????????? |??? 2 +
? arch/powerpc/cpu/mpc83xx/cpu_init.c?????????? |?? 11 +-
? arch/powerpc/cpu/mpc83xx/qe_io.c????????????? |?? 98 +-
? arch/powerpc/dts/Makefile???????????????????? |??? 8 +
? arch/powerpc/dts/km8309-uboot.dtsi??????????? |?? 33 +
? arch/powerpc/dts/km8321-uboot.dtsi??????????? |?? 67 +
? arch/powerpc/dts/km8321.dtsi????????????????? |? 220 ++++
? arch/powerpc/dts/km836x-uboot.dtsi??????????? |?? 61 +
? arch/powerpc/dts/km836x.dtsi????????????????? |? 182 +++
? arch/powerpc/dts/kmcoge5ne-uboot.dtsi???????? |?? 22 +
? arch/powerpc/dts/kmcoge5ne.dts??????????????? |? 320 +++++
? arch/powerpc/dts/kmeter1-uboot.dtsi?????????? |?? 42 +
? arch/powerpc/dts/kmeter1.dts????????????????? |? 480 +++++++
? arch/powerpc/dts/kmopti2.dts????????????????? |? 161 +++
? arch/powerpc/dts/kmsupc5.dts????????????????? |? 139 ++
? arch/powerpc/dts/kmsupm5.dts????????????????? |? 129 ++
? arch/powerpc/dts/kmtegr1.dts????????????????? |? 392 ++++++
? arch/powerpc/dts/kmtepr2.dts????????????????? |? 142 ++
? arch/powerpc/dts/kmtuge1.dts????????????????? |? 100 ++
? arch/powerpc/dts/kmtuxa1.dts????????????????? |? 100 ++
? board/keymile/km83xx/Kconfig????????????????? |?? 17 +
? board/keymile/km83xx/MAINTAINERS????????????? |?? 23 +-
? board/keymile/km83xx/km83xx.c???????????????? |?? 64 -
? configs/kmcoge5ne_defconfig?????????????????? |?? 11 +-
? configs/kmeter1_defconfig???????????????????? |?? 10 +-
? configs/kmopti2_defconfig???????????????????? |?? 11 +-
? configs/kmsupx5_defconfig???????????????????? |?? 10 +-
? configs/kmtegr1_defconfig???????????????????? |?? 12 +-
? configs/kmtepr2_defconfig???????????????????? |?? 10 +-
? configs/tuge1_defconfig?????????????????????? |?? 10 +-
? configs/tuxx1_defconfig?????????????????????? |?? 11 +-
? .../soc/fsl/cpm_qe/qe/ucc.txt???????????????? |?? 53 +
? drivers/net/Kconfig?????????????????????????? |??? 2 +
? drivers/net/Makefile????????????????????????? |??? 1 +
? drivers/net/qe/Kconfig??????????????????????? |??? 9 +
? drivers/net/qe/Makefile?????????????????????? |??? 5 +
? drivers/net/qe/dm_qe_uec.c??????????????????? | 1167 +++++++++++++++++
? drivers/net/qe/dm_qe_uec.h??????????????????? |?? 22 +
? drivers/net/qe/dm_qe_uec_phy.c??????????????? |? 163 +++
? drivers/net/qe/uccf.c???????????????????????? |? 507 +++++++
? drivers/net/qe/uccf.h???????????????????????? |? 119 ++
? drivers/net/qe/uec.h????????????????????????? |? 693 ++++++++++
? drivers/pinctrl/Kconfig?????????????????????? |??? 7 +
? drivers/pinctrl/Makefile????????????????????? |??? 1 +
? drivers/pinctrl/pinctrl-qe-io.c?????????????? |? 255 ++++
? drivers/qe/qe.c?????????????????????????????? |?? 96 +-
? drivers/qe/uccf.c???????????????????????????? |? 449 ++++---
? drivers/qe/uccf.h???????????????????????????? |?? 90 +-
? drivers/qe/uec.c????????????????????????????? |? 598 ++++-----
? drivers/qe/uec.h????????????????????????????? |? 381 +++---
? drivers/qe/uec_phy.c????????????????????????? |? 334 ++---
? drivers/qe/uec_phy.h????????????????????????? |?? 71 +-
? include/configs/km/km-mpc832x.h?????????????? |?? 14 -
? include/configs/km/km-mpc8360.h?????????????? |?? 14 -
? include/configs/km/km-mpc83xx.h?????????????? |?? 10 -
? include/fsl_qe.h????????????????????????????? |??? 3 +

? 57 files changed, 6826 insertions(+), 1144 deletions(-)
? create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321.dtsi
? create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km836x.dtsi
? create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi
? create mode 100644 arch/powerpc/dts/kmcoge5ne.dts
? create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi
? create mode 100644 arch/powerpc/dts/kmeter1.dts
? create mode 100644 arch/powerpc/dts/kmopti2.dts
? create mode 100644 arch/powerpc/dts/kmsupc5.dts
? create mode 100644 arch/powerpc/dts/kmsupm5.dts
? create mode 100644 arch/powerpc/dts/kmtegr1.dts
? create mode 100644 arch/powerpc/dts/kmtepr2.dts
? create mode 100644 arch/powerpc/dts/kmtuge1.dts
? create mode 100644 arch/powerpc/dts/kmtuxa1.dts
? create mode 100644 doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt ? create mode 100644 drivers/net/qe/Kconfig

Quoted 8 lines

? create mode 100644 drivers/net/qe/Makefile ? create mode 100644 drivers/net/qe/dm_qe_uec.c ? create mode 100644 drivers/net/qe/dm_qe_uec.h ? create mode 100644 drivers/net/qe/dm_qe_uec_phy.c ? create mode 100644 drivers/net/qe/uccf.c
? create mode 100644 drivers/net/qe/uccf.h
? create mode 100644 drivers/net/qe/uec.h
? create mode 100644 drivers/pinctrl/pinctrl-qe-io.c

Quoted 5 lines

gentle ping!

I got no reviews, comments for this patchseries ...

any comments?

ping?

I have a rebased version in the meantime, but I would wait for any comments...

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#8 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Hello Mario, Tom,

added Tom to cc ...

Am 08.09.2020 um 07:59 schrieb Heiko Schocher:

Quoted 126 lines

Hi Mario,

Am 17.08.2020 um 07:23 schrieb Heiko Schocher:

Quoted 123 lines

Hello Mario,

Am 27.05.2020 um 14:43 schrieb Heiko Schocher:

Quoted 109 lines

This patch series adds DM ethernet support for mpc83xx based keymile boards.

Travis build:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214

Changes in v2:
- new in v2
- remove RFC
- fixed Codingstyle errors, therefore new patch
?? powerpc, mpc83xx: fix codingstyle issues for qe_io.c
- moved DM part to drivers/pinctrl
- add comments from Qiang Zhao:
?? - add device node documentation
?? - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c ???? because using drivers/net/fsl_mdio.c leads in none existent ???? udevice mdio at 3320
???? instead boards with DM ETH support should use now this ???? driver.
- remove RFC tag
- add patch which fixes Codingstyle errors in drivers/qe
- add patch which converts the mpc83xx based boards from
?? keymile to DM_ETH

Heiko Schocher (5):
?? mpc83xx: remove unneeded extern declaration in cpu_init ?? powerpc, qe: fix codingstyle issues for drivers/qe ?? powerpc, qe: add DTS support for parallel I/O ports ?? net, qe: add DM support for QE UEC ethernet
?? mpc83xx, keymile boards: enable DM_ETH and add DTS

? arch/powerpc/cpu/mpc83xx/Kconfig????????????? |??? 8 +
? arch/powerpc/cpu/mpc83xx/Makefile???????????? |??? 2 +
? arch/powerpc/cpu/mpc83xx/cpu_init.c?????????? |?? 11 +-
? arch/powerpc/cpu/mpc83xx/qe_io.c????????????? |?? 98 +-
? arch/powerpc/dts/Makefile???????????????????? |??? 8 +
? arch/powerpc/dts/km8309-uboot.dtsi??????????? |?? 33 +
? arch/powerpc/dts/km8321-uboot.dtsi??????????? |?? 67 +
? arch/powerpc/dts/km8321.dtsi????????????????? |? 220 ++++
? arch/powerpc/dts/km836x-uboot.dtsi??????????? |?? 61 +
? arch/powerpc/dts/km836x.dtsi????????????????? |? 182 +++
? arch/powerpc/dts/kmcoge5ne-uboot.dtsi???????? |?? 22 +
? arch/powerpc/dts/kmcoge5ne.dts??????????????? |? 320 +++++
? arch/powerpc/dts/kmeter1-uboot.dtsi?????????? |?? 42 +
? arch/powerpc/dts/kmeter1.dts????????????????? |? 480 +++++++
? arch/powerpc/dts/kmopti2.dts????????????????? |? 161 +++
? arch/powerpc/dts/kmsupc5.dts????????????????? |? 139 ++
? arch/powerpc/dts/kmsupm5.dts????????????????? |? 129 ++
? arch/powerpc/dts/kmtegr1.dts????????????????? |? 392 ++++++
? arch/powerpc/dts/kmtepr2.dts????????????????? |? 142 ++
? arch/powerpc/dts/kmtuge1.dts????????????????? |? 100 ++
? arch/powerpc/dts/kmtuxa1.dts????????????????? |? 100 ++
? board/keymile/km83xx/Kconfig????????????????? |?? 17 +
? board/keymile/km83xx/MAINTAINERS????????????? |?? 23 +-
? board/keymile/km83xx/km83xx.c???????????????? |?? 64 -
? configs/kmcoge5ne_defconfig?????????????????? |?? 11 +-
? configs/kmeter1_defconfig???????????????????? |?? 10 +-
? configs/kmopti2_defconfig???????????????????? |?? 11 +-
? configs/kmsupx5_defconfig???????????????????? |?? 10 +-
? configs/kmtegr1_defconfig???????????????????? |?? 12 +-
? configs/kmtepr2_defconfig???????????????????? |?? 10 +-
? configs/tuge1_defconfig?????????????????????? |?? 10 +-
? configs/tuxx1_defconfig?????????????????????? |?? 11 +-
? .../soc/fsl/cpm_qe/qe/ucc.txt???????????????? |?? 53 +
? drivers/net/Kconfig?????????????????????????? |??? 2 +
? drivers/net/Makefile????????????????????????? |??? 1 +
? drivers/net/qe/Kconfig??????????????????????? |??? 9 +
? drivers/net/qe/Makefile?????????????????????? |??? 5 +
? drivers/net/qe/dm_qe_uec.c??????????????????? | 1167 +++++++++++++++++
? drivers/net/qe/dm_qe_uec.h??????????????????? |?? 22 +
? drivers/net/qe/dm_qe_uec_phy.c??????????????? |? 163 +++
? drivers/net/qe/uccf.c???????????????????????? |? 507 +++++++
? drivers/net/qe/uccf.h???????????????????????? |? 119 ++
? drivers/net/qe/uec.h????????????????????????? |? 693 ++++++++++
? drivers/pinctrl/Kconfig?????????????????????? |??? 7 +
? drivers/pinctrl/Makefile????????????????????? |??? 1 +
? drivers/pinctrl/pinctrl-qe-io.c?????????????? |? 255 ++++
? drivers/qe/qe.c?????????????????????????????? |?? 96 +-
? drivers/qe/uccf.c???????????????????????????? |? 449 ++++---
? drivers/qe/uccf.h???????????????????????????? |?? 90 +-
? drivers/qe/uec.c????????????????????????????? |? 598 ++++-----
? drivers/qe/uec.h????????????????????????????? |? 381 +++---
? drivers/qe/uec_phy.c????????????????????????? |? 334 ++---
? drivers/qe/uec_phy.h????????????????????????? |?? 71 +-
? include/configs/km/km-mpc832x.h?????????????? |?? 14 -
? include/configs/km/km-mpc8360.h?????????????? |?? 14 -
? include/configs/km/km-mpc83xx.h?????????????? |?? 10 -
? include/fsl_qe.h????????????????????????????? |??? 3 +

? 57 files changed, 6826 insertions(+), 1144 deletions(-)
? create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321.dtsi
? create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km836x.dtsi
? create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi
? create mode 100644 arch/powerpc/dts/kmcoge5ne.dts
? create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi
? create mode 100644 arch/powerpc/dts/kmeter1.dts
? create mode 100644 arch/powerpc/dts/kmopti2.dts
? create mode 100644 arch/powerpc/dts/kmsupc5.dts
? create mode 100644 arch/powerpc/dts/kmsupm5.dts
? create mode 100644 arch/powerpc/dts/kmtegr1.dts
? create mode 100644 arch/powerpc/dts/kmtepr2.dts
? create mode 100644 arch/powerpc/dts/kmtuge1.dts
? create mode 100644 arch/powerpc/dts/kmtuxa1.dts
? create mode 100644 doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt ? create mode 100644 drivers/net/qe/Kconfig

Quoted 8 lines

? create mode 100644 drivers/net/qe/Makefile ? create mode 100644 drivers/net/qe/dm_qe_uec.c ? create mode 100644 drivers/net/qe/dm_qe_uec.h ? create mode 100644 drivers/net/qe/dm_qe_uec_phy.c ? create mode 100644 drivers/net/qe/uccf.c
? create mode 100644 drivers/net/qe/uccf.h
? create mode 100644 drivers/net/qe/uec.h
? create mode 100644 drivers/pinctrl/pinctrl-qe-io.c

gentle ping!

Quoted 8 lines
Quoted 3 lines

I got no reviews, comments for this patchseries ...

any comments?

ping?

I have a rebased version in the meantime, but I would wait for any comments...

gentle ping...

@Tom: Mario seems to busy .. how to proceed here with this patches?

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#9 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Quoted 135 lines · Heiko Schocher

Hello Mario, Tom,

added Tom to cc ...

Am 08.09.2020 um 07:59 schrieb Heiko Schocher:

Quoted 130 lines

Hi Mario,

Am 17.08.2020 um 07:23 schrieb Heiko Schocher:

Quoted 126 lines

Hello Mario,

Am 27.05.2020 um 14:43 schrieb Heiko Schocher:

Quoted 109 lines

This patch series adds DM ethernet support for mpc83xx based keymile boards.

Travis build:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214

Changes in v2:
- new in v2
- remove RFC
- fixed Codingstyle errors, therefore new patch
?? powerpc, mpc83xx: fix codingstyle issues for qe_io.c
- moved DM part to drivers/pinctrl
- add comments from Qiang Zhao:
?? - add device node documentation
?? - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c ???? because using drivers/net/fsl_mdio.c leads in none existent ???? udevice mdio at 3320
???? instead boards with DM ETH support should use now this ???? driver.
- remove RFC tag
- add patch which fixes Codingstyle errors in drivers/qe
- add patch which converts the mpc83xx based boards from
?? keymile to DM_ETH

Heiko Schocher (5):
?? mpc83xx: remove unneeded extern declaration in cpu_init ?? powerpc, qe: fix codingstyle issues for drivers/qe ?? powerpc, qe: add DTS support for parallel I/O ports ?? net, qe: add DM support for QE UEC ethernet
?? mpc83xx, keymile boards: enable DM_ETH and add DTS

? arch/powerpc/cpu/mpc83xx/Kconfig????????????? |??? 8 +
? arch/powerpc/cpu/mpc83xx/Makefile???????????? |??? 2 +
? arch/powerpc/cpu/mpc83xx/cpu_init.c?????????? |?? 11 +-
? arch/powerpc/cpu/mpc83xx/qe_io.c????????????? |?? 98 +-
? arch/powerpc/dts/Makefile???????????????????? |??? 8 +
? arch/powerpc/dts/km8309-uboot.dtsi??????????? |?? 33 +
? arch/powerpc/dts/km8321-uboot.dtsi??????????? |?? 67 +
? arch/powerpc/dts/km8321.dtsi????????????????? |? 220 ++++
? arch/powerpc/dts/km836x-uboot.dtsi??????????? |?? 61 +
? arch/powerpc/dts/km836x.dtsi????????????????? |? 182 +++
? arch/powerpc/dts/kmcoge5ne-uboot.dtsi???????? |?? 22 +
? arch/powerpc/dts/kmcoge5ne.dts??????????????? |? 320 +++++
? arch/powerpc/dts/kmeter1-uboot.dtsi?????????? |?? 42 +
? arch/powerpc/dts/kmeter1.dts????????????????? |? 480 +++++++
? arch/powerpc/dts/kmopti2.dts????????????????? |? 161 +++
? arch/powerpc/dts/kmsupc5.dts????????????????? |? 139 ++
? arch/powerpc/dts/kmsupm5.dts????????????????? |? 129 ++
? arch/powerpc/dts/kmtegr1.dts????????????????? |? 392 ++++++
? arch/powerpc/dts/kmtepr2.dts????????????????? |? 142 ++
? arch/powerpc/dts/kmtuge1.dts????????????????? |? 100 ++
? arch/powerpc/dts/kmtuxa1.dts????????????????? |? 100 ++
? board/keymile/km83xx/Kconfig????????????????? |?? 17 +
? board/keymile/km83xx/MAINTAINERS????????????? |?? 23 +-
? board/keymile/km83xx/km83xx.c???????????????? |?? 64 -
? configs/kmcoge5ne_defconfig?????????????????? |?? 11 +-
? configs/kmeter1_defconfig???????????????????? |?? 10 +-
? configs/kmopti2_defconfig???????????????????? |?? 11 +-
? configs/kmsupx5_defconfig???????????????????? |?? 10 +-
? configs/kmtegr1_defconfig???????????????????? |?? 12 +-
? configs/kmtepr2_defconfig???????????????????? |?? 10 +-
? configs/tuge1_defconfig?????????????????????? |?? 10 +-
? configs/tuxx1_defconfig?????????????????????? |?? 11 +-
? .../soc/fsl/cpm_qe/qe/ucc.txt???????????????? |?? 53 +
? drivers/net/Kconfig?????????????????????????? |??? 2 +
? drivers/net/Makefile????????????????????????? |??? 1 +
? drivers/net/qe/Kconfig??????????????????????? |??? 9 +
? drivers/net/qe/Makefile?????????????????????? |??? 5 +
? drivers/net/qe/dm_qe_uec.c??????????????????? | 1167 +++++++++++++++++
? drivers/net/qe/dm_qe_uec.h??????????????????? |?? 22 +
? drivers/net/qe/dm_qe_uec_phy.c??????????????? |? 163 +++
? drivers/net/qe/uccf.c???????????????????????? |? 507 +++++++
? drivers/net/qe/uccf.h???????????????????????? |? 119 ++
? drivers/net/qe/uec.h????????????????????????? |? 693 ++++++++++
? drivers/pinctrl/Kconfig?????????????????????? |??? 7 +
? drivers/pinctrl/Makefile????????????????????? |??? 1 +
? drivers/pinctrl/pinctrl-qe-io.c?????????????? |? 255 ++++
? drivers/qe/qe.c?????????????????????????????? |?? 96 +-
? drivers/qe/uccf.c???????????????????????????? |? 449 ++++---
? drivers/qe/uccf.h???????????????????????????? |?? 90 +-
? drivers/qe/uec.c????????????????????????????? |? 598 ++++-----
? drivers/qe/uec.h????????????????????????????? |? 381 +++---
? drivers/qe/uec_phy.c????????????????????????? |? 334 ++---
? drivers/qe/uec_phy.h????????????????????????? |?? 71 +-
? include/configs/km/km-mpc832x.h?????????????? |?? 14 -
? include/configs/km/km-mpc8360.h?????????????? |?? 14 -
? include/configs/km/km-mpc83xx.h?????????????? |?? 10 -
? include/fsl_qe.h????????????????????????????? |??? 3 +

? 57 files changed, 6826 insertions(+), 1144 deletions(-)
? create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321.dtsi
? create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km836x.dtsi
? create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi
? create mode 100644 arch/powerpc/dts/kmcoge5ne.dts
? create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi
? create mode 100644 arch/powerpc/dts/kmeter1.dts
? create mode 100644 arch/powerpc/dts/kmopti2.dts
? create mode 100644 arch/powerpc/dts/kmsupc5.dts
? create mode 100644 arch/powerpc/dts/kmsupm5.dts
? create mode 100644 arch/powerpc/dts/kmtegr1.dts
? create mode 100644 arch/powerpc/dts/kmtepr2.dts
? create mode 100644 arch/powerpc/dts/kmtuge1.dts
? create mode 100644 arch/powerpc/dts/kmtuxa1.dts
? create mode 100644 doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt ? create mode 100644 drivers/net/qe/Kconfig

Quoted 8 lines

? create mode 100644 drivers/net/qe/Makefile ? create mode 100644 drivers/net/qe/dm_qe_uec.c ? create mode 100644 drivers/net/qe/dm_qe_uec.h ? create mode 100644 drivers/net/qe/dm_qe_uec_phy.c ? create mode 100644 drivers/net/qe/uccf.c
? create mode 100644 drivers/net/qe/uccf.h
? create mode 100644 drivers/net/qe/uec.h
? create mode 100644 drivers/pinctrl/pinctrl-qe-io.c

gentle ping!

I got no reviews, comments for this patchseries ...

any comments?

Quoted 8 lines
Quoted 4 lines

ping?

I have a rebased version in the meantime, but I would wait for any comments...

gentle ping...

@Tom: Mario seems to busy .. how to proceed here with this patches?

Can you put together something for me to pull in to -next please? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200916/061119db/attachment.sig>
#10 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Hello Tom,

Am 16.09.2020 um 21:01 schrieb Tom Rini:

Quoted 141 lines · Heiko Schocher
Quoted 140 lines

Hello Mario, Tom,

added Tom to cc ...

Am 08.09.2020 um 07:59 schrieb Heiko Schocher:

Quoted 134 lines

Hi Mario,

Am 17.08.2020 um 07:23 schrieb Heiko Schocher:

Quoted 121 lines

Hello Mario,

Am 27.05.2020 um 14:43 schrieb Heiko Schocher:

Quoted 109 lines

This patch series adds DM ethernet support for mpc83xx based keymile boards.

Travis build:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214

Changes in v2:
- new in v2
- remove RFC
- fixed Codingstyle errors, therefore new patch
?? powerpc, mpc83xx: fix codingstyle issues for qe_io.c
- moved DM part to drivers/pinctrl
- add comments from Qiang Zhao:
?? - add device node documentation
?? - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c ???? because using drivers/net/fsl_mdio.c leads in none existent ???? udevice mdio at 3320
???? instead boards with DM ETH support should use now this ???? driver.
- remove RFC tag
- add patch which fixes Codingstyle errors in drivers/qe
- add patch which converts the mpc83xx based boards from
?? keymile to DM_ETH

Heiko Schocher (5):
?? mpc83xx: remove unneeded extern declaration in cpu_init ?? powerpc, qe: fix codingstyle issues for drivers/qe ?? powerpc, qe: add DTS support for parallel I/O ports ?? net, qe: add DM support for QE UEC ethernet
?? mpc83xx, keymile boards: enable DM_ETH and add DTS

 ? arch/powerpc/cpu/mpc83xx/Kconfig????????????? |??? 8 +
 ? arch/powerpc/cpu/mpc83xx/Makefile???????????? |??? 2 +
 ? arch/powerpc/cpu/mpc83xx/cpu_init.c?????????? |?? 11 +-
 ? arch/powerpc/cpu/mpc83xx/qe_io.c????????????? |?? 98 +-
 ? arch/powerpc/dts/Makefile???????????????????? |??? 8 +
 ? arch/powerpc/dts/km8309-uboot.dtsi??????????? |?? 33 +
 ? arch/powerpc/dts/km8321-uboot.dtsi??????????? |?? 67 +
 ? arch/powerpc/dts/km8321.dtsi????????????????? |? 220 ++++
 ? arch/powerpc/dts/km836x-uboot.dtsi??????????? |?? 61 +
 ? arch/powerpc/dts/km836x.dtsi????????????????? |? 182 +++
 ? arch/powerpc/dts/kmcoge5ne-uboot.dtsi???????? |?? 22 +
 ? arch/powerpc/dts/kmcoge5ne.dts??????????????? |? 320 +++++
 ? arch/powerpc/dts/kmeter1-uboot.dtsi?????????? |?? 42 +
 ? arch/powerpc/dts/kmeter1.dts????????????????? |? 480 +++++++
 ? arch/powerpc/dts/kmopti2.dts????????????????? |? 161 +++
 ? arch/powerpc/dts/kmsupc5.dts????????????????? |? 139 ++
 ? arch/powerpc/dts/kmsupm5.dts????????????????? |? 129 ++
 ? arch/powerpc/dts/kmtegr1.dts????????????????? |? 392 ++++++
 ? arch/powerpc/dts/kmtepr2.dts????????????????? |? 142 ++
 ? arch/powerpc/dts/kmtuge1.dts????????????????? |? 100 ++
 ? arch/powerpc/dts/kmtuxa1.dts????????????????? |? 100 ++
 ? board/keymile/km83xx/Kconfig????????????????? |?? 17 +
 ? board/keymile/km83xx/MAINTAINERS????????????? |?? 23 +-
 ? board/keymile/km83xx/km83xx.c???????????????? |?? 64 -
 ? configs/kmcoge5ne_defconfig?????????????????? |?? 11 +-
 ? configs/kmeter1_defconfig???????????????????? |?? 10 +-
 ? configs/kmopti2_defconfig???????????????????? |?? 11 +-
 ? configs/kmsupx5_defconfig???????????????????? |?? 10 +-
 ? configs/kmtegr1_defconfig???????????????????? |?? 12 +-
 ? configs/kmtepr2_defconfig???????????????????? |?? 10 +-
 ? configs/tuge1_defconfig?????????????????????? |?? 10 +-
 ? configs/tuxx1_defconfig?????????????????????? |?? 11 +-
 ? .../soc/fsl/cpm_qe/qe/ucc.txt???????????????? |?? 53 +
 ? drivers/net/Kconfig?????????????????????????? |??? 2 +
 ? drivers/net/Makefile????????????????????????? |??? 1 +
 ? drivers/net/qe/Kconfig??????????????????????? |??? 9 +
 ? drivers/net/qe/Makefile?????????????????????? |??? 5 +
 ? drivers/net/qe/dm_qe_uec.c??????????????????? | 1167 +++++++++++++++++
 ? drivers/net/qe/dm_qe_uec.h??????????????????? |?? 22 +
 ? drivers/net/qe/dm_qe_uec_phy.c??????????????? |? 163 +++
 ? drivers/net/qe/uccf.c???????????????????????? |? 507 +++++++
 ? drivers/net/qe/uccf.h???????????????????????? |? 119 ++
 ? drivers/net/qe/uec.h????????????????????????? |? 693 ++++++++++
 ? drivers/pinctrl/Kconfig?????????????????????? |??? 7 +
 ? drivers/pinctrl/Makefile????????????????????? |??? 1 +
 ? drivers/pinctrl/pinctrl-qe-io.c?????????????? |? 255 ++++
 ? drivers/qe/qe.c?????????????????????????????? |?? 96 +-
 ? drivers/qe/uccf.c???????????????????????????? |? 449 ++++---
 ? drivers/qe/uccf.h???????????????????????????? |?? 90 +-
 ? drivers/qe/uec.c????????????????????????????? |? 598 ++++-----
 ? drivers/qe/uec.h????????????????????????????? |? 381 +++---
 ? drivers/qe/uec_phy.c????????????????????????? |? 334 ++---
 ? drivers/qe/uec_phy.h????????????????????????? |?? 71 +-
 ? include/configs/km/km-mpc832x.h?????????????? |?? 14 -
 ? include/configs/km/km-mpc8360.h?????????????? |?? 14 -
 ? include/configs/km/km-mpc83xx.h?????????????? |?? 10 -
 ? include/fsl_qe.h????????????????????????????? |??? 3 +

? 57 files changed, 6826 insertions(+), 1144 deletions(-)
? create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321.dtsi
? create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km836x.dtsi
? create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi ? create mode 100644 arch/powerpc/dts/kmcoge5ne.dts
? create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi
? create mode 100644 arch/powerpc/dts/kmeter1.dts
? create mode 100644 arch/powerpc/dts/kmopti2.dts
? create mode 100644 arch/powerpc/dts/kmsupc5.dts
? create mode 100644 arch/powerpc/dts/kmsupm5.dts
? create mode 100644 arch/powerpc/dts/kmtegr1.dts
? create mode 100644 arch/powerpc/dts/kmtepr2.dts
? create mode 100644 arch/powerpc/dts/kmtuge1.dts
? create mode 100644 arch/powerpc/dts/kmtuxa1.dts
? create mode 100644 doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt ? create mode 100644 drivers/net/qe/Kconfig

Quoted 8 lines

? create mode 100644 drivers/net/qe/Makefile ? create mode 100644 drivers/net/qe/dm_qe_uec.c ? create mode 100644 drivers/net/qe/dm_qe_uec.h ? create mode 100644 drivers/net/qe/dm_qe_uec_phy.c ? create mode 100644 drivers/net/qe/uccf.c
? create mode 100644 drivers/net/qe/uccf.h
? create mode 100644 drivers/net/qe/uec.h
? create mode 100644 drivers/pinctrl/pinctrl-qe-io.c

Quoted 5 lines

gentle ping!

I got no reviews, comments for this patchseries ...

any comments?

ping?

I have a rebased version in the meantime, but I would wait for any comments...

Quoted 6 lines
Quoted 3 lines

gentle ping...

@Tom: Mario seems to busy .. how to proceed here with this patches?

Can you put together something for me to pull in to -next please? Thanks!

Ok, pushed them to a repo on github:

https://github.com/hsdenx/u-boot-test/tree/kmcoge5ne-dm-ethernet-devel

started travis build for this branch:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/727904421

If all builds fine, I can send a pull request ... is it ok for you if I push this branch to u-boot-i2c kmcoge5ne-dm-ethernet-devel?

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#11 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Quoted 153 lines · Heiko Schocher

Hello Tom,

Am 16.09.2020 um 21:01 schrieb Tom Rini:

Quoted 141 lines · Heiko Schocher
Quoted 140 lines

Hello Mario, Tom,

added Tom to cc ...

Am 08.09.2020 um 07:59 schrieb Heiko Schocher:

Quoted 134 lines

Hi Mario,

Am 17.08.2020 um 07:23 schrieb Heiko Schocher:

Quoted 121 lines

Hello Mario,

Am 27.05.2020 um 14:43 schrieb Heiko Schocher:

Quoted 109 lines

This patch series adds DM ethernet support for mpc83xx based keymile boards.

Travis build:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214

Changes in v2:
- new in v2
- remove RFC
- fixed Codingstyle errors, therefore new patch
?? powerpc, mpc83xx: fix codingstyle issues for qe_io.c
- moved DM part to drivers/pinctrl
- add comments from Qiang Zhao:
?? - add device node documentation
?? - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c ???? because using drivers/net/fsl_mdio.c leads in none existent ???? udevice mdio at 3320
???? instead boards with DM ETH support should use now this ???? driver.
- remove RFC tag
- add patch which fixes Codingstyle errors in drivers/qe
- add patch which converts the mpc83xx based boards from
?? keymile to DM_ETH

Heiko Schocher (5):
?? mpc83xx: remove unneeded extern declaration in cpu_init ?? powerpc, qe: fix codingstyle issues for drivers/qe ?? powerpc, qe: add DTS support for parallel I/O ports ?? net, qe: add DM support for QE UEC ethernet
?? mpc83xx, keymile boards: enable DM_ETH and add DTS

 ? arch/powerpc/cpu/mpc83xx/Kconfig????????????? |??? 8 +
 ? arch/powerpc/cpu/mpc83xx/Makefile???????????? |??? 2 +
 ? arch/powerpc/cpu/mpc83xx/cpu_init.c?????????? |?? 11 +-
 ? arch/powerpc/cpu/mpc83xx/qe_io.c????????????? |?? 98 +-
 ? arch/powerpc/dts/Makefile???????????????????? |??? 8 +
 ? arch/powerpc/dts/km8309-uboot.dtsi??????????? |?? 33 +
 ? arch/powerpc/dts/km8321-uboot.dtsi??????????? |?? 67 +
 ? arch/powerpc/dts/km8321.dtsi????????????????? |? 220 ++++
 ? arch/powerpc/dts/km836x-uboot.dtsi??????????? |?? 61 +
 ? arch/powerpc/dts/km836x.dtsi????????????????? |? 182 +++
 ? arch/powerpc/dts/kmcoge5ne-uboot.dtsi???????? |?? 22 +
 ? arch/powerpc/dts/kmcoge5ne.dts??????????????? |? 320 +++++
 ? arch/powerpc/dts/kmeter1-uboot.dtsi?????????? |?? 42 +
 ? arch/powerpc/dts/kmeter1.dts????????????????? |? 480 +++++++
 ? arch/powerpc/dts/kmopti2.dts????????????????? |? 161 +++
 ? arch/powerpc/dts/kmsupc5.dts????????????????? |? 139 ++
 ? arch/powerpc/dts/kmsupm5.dts????????????????? |? 129 ++
 ? arch/powerpc/dts/kmtegr1.dts????????????????? |? 392 ++++++
 ? arch/powerpc/dts/kmtepr2.dts????????????????? |? 142 ++
 ? arch/powerpc/dts/kmtuge1.dts????????????????? |? 100 ++
 ? arch/powerpc/dts/kmtuxa1.dts????????????????? |? 100 ++
 ? board/keymile/km83xx/Kconfig????????????????? |?? 17 +
 ? board/keymile/km83xx/MAINTAINERS????????????? |?? 23 +-
 ? board/keymile/km83xx/km83xx.c???????????????? |?? 64 -
 ? configs/kmcoge5ne_defconfig?????????????????? |?? 11 +-
 ? configs/kmeter1_defconfig???????????????????? |?? 10 +-
 ? configs/kmopti2_defconfig???????????????????? |?? 11 +-
 ? configs/kmsupx5_defconfig???????????????????? |?? 10 +-
 ? configs/kmtegr1_defconfig???????????????????? |?? 12 +-
 ? configs/kmtepr2_defconfig???????????????????? |?? 10 +-
 ? configs/tuge1_defconfig?????????????????????? |?? 10 +-
 ? configs/tuxx1_defconfig?????????????????????? |?? 11 +-
 ? .../soc/fsl/cpm_qe/qe/ucc.txt???????????????? |?? 53 +
 ? drivers/net/Kconfig?????????????????????????? |??? 2 +
 ? drivers/net/Makefile????????????????????????? |??? 1 +
 ? drivers/net/qe/Kconfig??????????????????????? |??? 9 +
 ? drivers/net/qe/Makefile?????????????????????? |??? 5 +
 ? drivers/net/qe/dm_qe_uec.c??????????????????? | 1167 +++++++++++++++++
 ? drivers/net/qe/dm_qe_uec.h??????????????????? |?? 22 +
 ? drivers/net/qe/dm_qe_uec_phy.c??????????????? |? 163 +++
 ? drivers/net/qe/uccf.c???????????????????????? |? 507 +++++++
 ? drivers/net/qe/uccf.h???????????????????????? |? 119 ++
 ? drivers/net/qe/uec.h????????????????????????? |? 693 ++++++++++
 ? drivers/pinctrl/Kconfig?????????????????????? |??? 7 +
 ? drivers/pinctrl/Makefile????????????????????? |??? 1 +
 ? drivers/pinctrl/pinctrl-qe-io.c?????????????? |? 255 ++++
 ? drivers/qe/qe.c?????????????????????????????? |?? 96 +-
 ? drivers/qe/uccf.c???????????????????????????? |? 449 ++++---
 ? drivers/qe/uccf.h???????????????????????????? |?? 90 +-
 ? drivers/qe/uec.c????????????????????????????? |? 598 ++++-----
 ? drivers/qe/uec.h????????????????????????????? |? 381 +++---
 ? drivers/qe/uec_phy.c????????????????????????? |? 334 ++---
 ? drivers/qe/uec_phy.h????????????????????????? |?? 71 +-
 ? include/configs/km/km-mpc832x.h?????????????? |?? 14 -
 ? include/configs/km/km-mpc8360.h?????????????? |?? 14 -
 ? include/configs/km/km-mpc83xx.h?????????????? |?? 10 -
 ? include/fsl_qe.h????????????????????????????? |??? 3 +

? 57 files changed, 6826 insertions(+), 1144 deletions(-)
? create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321.dtsi
? create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km836x.dtsi
? create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi ? create mode 100644 arch/powerpc/dts/kmcoge5ne.dts
? create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi
? create mode 100644 arch/powerpc/dts/kmeter1.dts
? create mode 100644 arch/powerpc/dts/kmopti2.dts
? create mode 100644 arch/powerpc/dts/kmsupc5.dts
? create mode 100644 arch/powerpc/dts/kmsupm5.dts
? create mode 100644 arch/powerpc/dts/kmtegr1.dts
? create mode 100644 arch/powerpc/dts/kmtepr2.dts
? create mode 100644 arch/powerpc/dts/kmtuge1.dts
? create mode 100644 arch/powerpc/dts/kmtuxa1.dts
? create mode 100644 doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt ? create mode 100644 drivers/net/qe/Kconfig

Quoted 8 lines

? create mode 100644 drivers/net/qe/Makefile ? create mode 100644 drivers/net/qe/dm_qe_uec.c ? create mode 100644 drivers/net/qe/dm_qe_uec.h ? create mode 100644 drivers/net/qe/dm_qe_uec_phy.c ? create mode 100644 drivers/net/qe/uccf.c
? create mode 100644 drivers/net/qe/uccf.h
? create mode 100644 drivers/net/qe/uec.h
? create mode 100644 drivers/pinctrl/pinctrl-qe-io.c

Quoted 5 lines

gentle ping!

I got no reviews, comments for this patchseries ...

any comments?

ping?

I have a rebased version in the meantime, but I would wait for any comments...

Quoted 6 lines
Quoted 3 lines

gentle ping...

@Tom: Mario seems to busy .. how to proceed here with this patches?

Can you put together something for me to pull in to -next please? Thanks!

Ok, pushed them to a repo on github:

Quoted 7 lines

https://github.com/hsdenx/u-boot-test/tree/kmcoge5ne-dm-ethernet-devel

started travis build for this branch:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/727904421

If all builds fine, I can send a pull request ... is it ok for you if I push this branch to u-boot-i2c kmcoge5ne-dm-ethernet-devel?

Works for me, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200917/35b6f2f9/attachment.sig>
#12 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Hello Tom,

Am 17.09.2020 um 14:51 schrieb Tom Rini:

Quoted 156 lines · Heiko Schocher
Quoted 155 lines

Hello Tom,

Am 16.09.2020 um 21:01 schrieb Tom Rini:

Quoted 141 lines · Heiko Schocher
Quoted 140 lines

Hello Mario, Tom,

added Tom to cc ...

Am 08.09.2020 um 07:59 schrieb Heiko Schocher:

Quoted 134 lines

Hi Mario,

Am 17.08.2020 um 07:23 schrieb Heiko Schocher:

Quoted 121 lines

Hello Mario,

Am 27.05.2020 um 14:43 schrieb Heiko Schocher:

Quoted 109 lines

This patch series adds DM ethernet support for mpc83xx based keymile boards.

Travis build:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214

Changes in v2:
- new in v2
- remove RFC
- fixed Codingstyle errors, therefore new patch
?? powerpc, mpc83xx: fix codingstyle issues for qe_io.c
- moved DM part to drivers/pinctrl
- add comments from Qiang Zhao:
?? - add device node documentation
?? - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c ???? because using drivers/net/fsl_mdio.c leads in none existent ???? udevice mdio at 3320
???? instead boards with DM ETH support should use now this ???? driver.
- remove RFC tag
- add patch which fixes Codingstyle errors in drivers/qe
- add patch which converts the mpc83xx based boards from
?? keymile to DM_ETH

Heiko Schocher (5):
?? mpc83xx: remove unneeded extern declaration in cpu_init ?? powerpc, qe: fix codingstyle issues for drivers/qe ?? powerpc, qe: add DTS support for parallel I/O ports ?? net, qe: add DM support for QE UEC ethernet ?? mpc83xx, keymile boards: enable DM_ETH and add DTS

  ? arch/powerpc/cpu/mpc83xx/Kconfig????????????? |??? 8 +
  ? arch/powerpc/cpu/mpc83xx/Makefile???????????? |??? 2 +
  ? arch/powerpc/cpu/mpc83xx/cpu_init.c?????????? |?? 11 +-
  ? arch/powerpc/cpu/mpc83xx/qe_io.c????????????? |?? 98 +-
  ? arch/powerpc/dts/Makefile???????????????????? |??? 8 +
  ? arch/powerpc/dts/km8309-uboot.dtsi??????????? |?? 33 +
  ? arch/powerpc/dts/km8321-uboot.dtsi??????????? |?? 67 +
  ? arch/powerpc/dts/km8321.dtsi????????????????? |? 220 ++++
  ? arch/powerpc/dts/km836x-uboot.dtsi??????????? |?? 61 +
  ? arch/powerpc/dts/km836x.dtsi????????????????? |? 182 +++
  ? arch/powerpc/dts/kmcoge5ne-uboot.dtsi???????? |?? 22 +
  ? arch/powerpc/dts/kmcoge5ne.dts??????????????? |? 320 +++++
  ? arch/powerpc/dts/kmeter1-uboot.dtsi?????????? |?? 42 +
  ? arch/powerpc/dts/kmeter1.dts????????????????? |? 480 +++++++
  ? arch/powerpc/dts/kmopti2.dts????????????????? |? 161 +++
  ? arch/powerpc/dts/kmsupc5.dts????????????????? |? 139 ++
  ? arch/powerpc/dts/kmsupm5.dts????????????????? |? 129 ++
  ? arch/powerpc/dts/kmtegr1.dts????????????????? |? 392 ++++++
  ? arch/powerpc/dts/kmtepr2.dts????????????????? |? 142 ++
  ? arch/powerpc/dts/kmtuge1.dts????????????????? |? 100 ++
  ? arch/powerpc/dts/kmtuxa1.dts????????????????? |? 100 ++
  ? board/keymile/km83xx/Kconfig????????????????? |?? 17 +
  ? board/keymile/km83xx/MAINTAINERS????????????? |?? 23 +-
  ? board/keymile/km83xx/km83xx.c???????????????? |?? 64 -
  ? configs/kmcoge5ne_defconfig?????????????????? |?? 11 +-
  ? configs/kmeter1_defconfig???????????????????? |?? 10 +-
  ? configs/kmopti2_defconfig???????????????????? |?? 11 +-
  ? configs/kmsupx5_defconfig???????????????????? |?? 10 +-
  ? configs/kmtegr1_defconfig???????????????????? |?? 12 +-
  ? configs/kmtepr2_defconfig???????????????????? |?? 10 +-
  ? configs/tuge1_defconfig?????????????????????? |?? 10 +-
  ? configs/tuxx1_defconfig?????????????????????? |?? 11 +-
  ? .../soc/fsl/cpm_qe/qe/ucc.txt???????????????? |?? 53 +
  ? drivers/net/Kconfig?????????????????????????? |??? 2 +
  ? drivers/net/Makefile????????????????????????? |??? 1 +
  ? drivers/net/qe/Kconfig??????????????????????? |??? 9 +
  ? drivers/net/qe/Makefile?????????????????????? |??? 5 +
  ? drivers/net/qe/dm_qe_uec.c??????????????????? | 1167 +++++++++++++++++
  ? drivers/net/qe/dm_qe_uec.h??????????????????? |?? 22 +
  ? drivers/net/qe/dm_qe_uec_phy.c??????????????? |? 163 +++
  ? drivers/net/qe/uccf.c???????????????????????? |? 507 +++++++
  ? drivers/net/qe/uccf.h???????????????????????? |? 119 ++
  ? drivers/net/qe/uec.h????????????????????????? |? 693 ++++++++++
  ? drivers/pinctrl/Kconfig?????????????????????? |??? 7 +
  ? drivers/pinctrl/Makefile????????????????????? |??? 1 +
  ? drivers/pinctrl/pinctrl-qe-io.c?????????????? |? 255 ++++
  ? drivers/qe/qe.c?????????????????????????????? |?? 96 +-
  ? drivers/qe/uccf.c???????????????????????????? |? 449 ++++---
  ? drivers/qe/uccf.h???????????????????????????? |?? 90 +-
  ? drivers/qe/uec.c????????????????????????????? |? 598 ++++-----
  ? drivers/qe/uec.h????????????????????????????? |? 381 +++---
  ? drivers/qe/uec_phy.c????????????????????????? |? 334 ++---
  ? drivers/qe/uec_phy.h????????????????????????? |?? 71 +-
  ? include/configs/km/km-mpc832x.h?????????????? |?? 14 -
  ? include/configs/km/km-mpc8360.h?????????????? |?? 14 -
  ? include/configs/km/km-mpc83xx.h?????????????? |?? 10 -
  ? include/fsl_qe.h????????????????????????????? |??? 3 +

? 57 files changed, 6826 insertions(+), 1144 deletions(-)
? create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321.dtsi
? create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km836x.dtsi
? create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi ? create mode 100644 arch/powerpc/dts/kmcoge5ne.dts
? create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi
? create mode 100644 arch/powerpc/dts/kmeter1.dts
? create mode 100644 arch/powerpc/dts/kmopti2.dts
? create mode 100644 arch/powerpc/dts/kmsupc5.dts
? create mode 100644 arch/powerpc/dts/kmsupm5.dts
? create mode 100644 arch/powerpc/dts/kmtegr1.dts
? create mode 100644 arch/powerpc/dts/kmtepr2.dts
? create mode 100644 arch/powerpc/dts/kmtuge1.dts
? create mode 100644 arch/powerpc/dts/kmtuxa1.dts
? create mode 100644 doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt ? create mode 100644 drivers/net/qe/Kconfig

Quoted 8 lines

? create mode 100644 drivers/net/qe/Makefile ? create mode 100644 drivers/net/qe/dm_qe_uec.c ? create mode 100644 drivers/net/qe/dm_qe_uec.h ? create mode 100644 drivers/net/qe/dm_qe_uec_phy.c ? create mode 100644 drivers/net/qe/uccf.c ? create mode 100644 drivers/net/qe/uccf.h ? create mode 100644 drivers/net/qe/uec.h
? create mode 100644 drivers/pinctrl/pinctrl-qe-io.c

Quoted 5 lines

gentle ping!

I got no reviews, comments for this patchseries ...

any comments?

ping?

I have a rebased version in the meantime, but I would wait for any comments...

Quoted 6 lines
Quoted 3 lines

gentle ping...

@Tom: Mario seems to busy .. how to proceed here with this patches?

Can you put together something for me to pull in to -next please? Thanks!

Ok, pushed them to a repo on github:

https://github.com/hsdenx/u-boot-test/tree/kmcoge5ne-dm-ethernet-devel

Quoted 7 lines
Quoted 5 lines

started travis build for this branch:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/727904421

If all builds fine, I can send a pull request ... is it ok for you if I push this branch to u-boot-i2c kmcoge5ne-dm-ethernet-devel?

Works for me, thanks!

Ok, travis build is fine, so here the pull request:

The following changes since commit bd4e8944cf7e36f8ad39466c40f8fc197c9df1c5:

Merge tag 'ti-v2021.01-next' of https://gitlab.denx.de/u-boot/custodians/u-boot-ti into next
(2020-09-15 15:22:00 -0400)

are available in the Git repository at:

https://gitlab.denx.de/u-boot/custodians/u-boot-i2c.git tags/for-v2021.01-next

for you to fetch changes up to 7bdfe8592956439743cad3c2d3ff5f24c4dd5aa9:

mpc83xx, keymile boards: enable DM_ETH and add DTS (2020-09-17 06:09:54 +0200)

----------------------------------------------------------------
mpc83xx, keymile boards: enable DM_ETH and add DTS
- mpc83xx: remove unneeded extern declaration in cpu_init
- powerpc, qe: fix codingstyle issues for drivers/qe
- powerpc, qe: add DTS support for parallel I/O ports
- net, qe: add DM support for QE UEC ethernet
- add DTS for all mpc83xx based boards from keymile mainly they are not mainlined to linux.
- add u-boot specific dtsi

- add stdout-path

- add missing ucc4 par_io definitions, which were in board code, but not in linux DTS
- remove not used ethernet nodes

----------------------------------------------------------------
Heiko Schocher (5):
mpc83xx: remove unneeded extern declaration in cpu_init powerpc, qe: fix codingstyle issues for drivers/qe powerpc, qe: add DTS support for parallel I/O ports net, qe: add DM support for QE UEC ethernet mpc83xx, keymile boards: enable DM_ETH and add DTS

  arch/powerpc/cpu/mpc83xx/Kconfig                   |    8 +
  arch/powerpc/cpu/mpc83xx/Makefile                  |    2 +
  arch/powerpc/cpu/mpc83xx/cpu_init.c                |   11 +-
  arch/powerpc/cpu/mpc83xx/qe_io.c                   |   98 +++++++---
  arch/powerpc/dts/Makefile                          |    8 +
  arch/powerpc/dts/km8309-uboot.dtsi                 |   33 ++++
  arch/powerpc/dts/km8321-uboot.dtsi                 |   67 +++++++
  arch/powerpc/dts/km8321.dtsi                       |  220 +++++++++++++++++++++
  arch/powerpc/dts/km836x-uboot.dtsi                 |   61 ++++++
  arch/powerpc/dts/km836x.dtsi                       |  182 ++++++++++++++++++
  arch/powerpc/dts/kmcoge5ne-uboot.dtsi              |   22 +++
  arch/powerpc/dts/kmcoge5ne.dts                     |  320 +++++++++++++++++++++++++++++++
  arch/powerpc/dts/kmeter1-uboot.dtsi                |   42 ++++
  arch/powerpc/dts/kmeter1.dts                       |  480 
++++++++++++++++++++++++++++++++++++++++++++++
  arch/powerpc/dts/kmopti2.dts                       |  161 ++++++++++++++++
  arch/powerpc/dts/kmsupc5.dts                       |  139 ++++++++++++++
  arch/powerpc/dts/kmsupm5.dts                       |  129 +++++++++++++
  arch/powerpc/dts/kmtegr1.dts                       |  392 ++++++++++++++++++++++++++++++++++++++
  arch/powerpc/dts/kmtepr2.dts                       |  142 ++++++++++++++
  arch/powerpc/dts/kmtuge1.dts                       |  100 ++++++++++
  arch/powerpc/dts/kmtuxa1.dts                       |  100 ++++++++++
  board/keymile/km83xx/Kconfig                       |   17 ++
  board/keymile/km83xx/MAINTAINERS                   |   23 ++-
  board/keymile/km83xx/km83xx.c                      |   64 -------
  configs/kmcoge5ne_defconfig                        |   11 +-
  configs/kmeter1_defconfig                          |   10 +-
  configs/kmopti2_defconfig                          |   11 +-
  configs/kmsupx5_defconfig                          |   10 +-
  configs/kmtegr1_defconfig                          |   12 +-
  configs/kmtepr2_defconfig                          |   10 +-
  configs/tuge1_defconfig                            |   10 +-
  configs/tuxx1_defconfig                            |   11 +-
  doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt |   53 ++++++
  drivers/net/Kconfig                                |    2 +
  drivers/net/Makefile                               |    1 +
  drivers/net/qe/Kconfig                             |    9 +
  drivers/net/qe/Makefile                            |    5 +
  drivers/net/qe/dm_qe_uec.c                         | 1167 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  drivers/net/qe/dm_qe_uec.h                         |   22 +++
  drivers/net/qe/dm_qe_uec_phy.c                     |  163 ++++++++++++++++
  drivers/net/qe/uccf.c                              |  507 
+++++++++++++++++++++++++++++++++++++++++++++++++
  drivers/net/qe/uccf.h                              |  119 ++++++++++++
  drivers/net/qe/uec.h                               |  693 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  drivers/pinctrl/Kconfig                            |    7 +
  drivers/pinctrl/Makefile                           |    1 +
  drivers/pinctrl/pinctrl-qe-io.c                    |  255 +++++++++++++++++++++++++
  drivers/qe/Kconfig                                 |    2 +-
  drivers/qe/qe.c                                    |   96 +++++-----
  drivers/qe/uccf.c                                  |  449 +++++++++++++++++++++++++++----------------
  drivers/qe/uccf.h                                  |   90 ++++-----
  drivers/qe/uec.c                                   |  598 
++++++++++++++++++++++++++++-----------------------------
  drivers/qe/uec.h                                   |  381 ++++++++++++++++---------------------
  drivers/qe/uec_phy.c                               |  334 ++++++++++++++++----------------
  drivers/qe/uec_phy.h                               |   71 +++----
  include/configs/km/km-mpc832x.h                    |   14 --
  include/configs/km/km-mpc8360.h                    |   14 --
  include/configs/km/km-mpc83xx.h                    |   10 -
  include/fsl_qe.h                                   |    3 +
  58 files changed, 6827 insertions(+), 1145 deletions(-)

create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi create mode 100644 arch/powerpc/dts/km8321.dtsi
create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi create mode 100644 arch/powerpc/dts/km836x.dtsi
create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi create mode 100644 arch/powerpc/dts/kmcoge5ne.dts
create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi create mode 100644 arch/powerpc/dts/kmeter1.dts
create mode 100644 arch/powerpc/dts/kmopti2.dts
create mode 100644 arch/powerpc/dts/kmsupc5.dts
create mode 100644 arch/powerpc/dts/kmsupm5.dts
create mode 100644 arch/powerpc/dts/kmtegr1.dts
create mode 100644 arch/powerpc/dts/kmtepr2.dts
create mode 100644 arch/powerpc/dts/kmtuge1.dts
create mode 100644 arch/powerpc/dts/kmtuxa1.dts
create mode 100644 doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt create mode 100644 drivers/net/qe/Kconfig
create mode 100644 drivers/net/qe/Makefile
create mode 100644 drivers/net/qe/dm_qe_uec.c
create mode 100644 drivers/net/qe/dm_qe_uec.h
create mode 100644 drivers/net/qe/dm_qe_uec_phy.c
create mode 100644 drivers/net/qe/uccf.c
create mode 100644 drivers/net/qe/uccf.h
create mode 100644 drivers/net/qe/uec.h
create mode 100644 drivers/pinctrl/pinctrl-qe-io.c

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#13 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Quoted 175 lines · Heiko Schocher

Hello Tom,

Am 17.09.2020 um 14:51 schrieb Tom Rini:

Quoted 156 lines · Heiko Schocher
Quoted 155 lines

Hello Tom,

Am 16.09.2020 um 21:01 schrieb Tom Rini:

Quoted 141 lines · Heiko Schocher
Quoted 140 lines

Hello Mario, Tom,

added Tom to cc ...

Am 08.09.2020 um 07:59 schrieb Heiko Schocher:

Quoted 134 lines

Hi Mario,

Am 17.08.2020 um 07:23 schrieb Heiko Schocher:

Quoted 121 lines

Hello Mario,

Am 27.05.2020 um 14:43 schrieb Heiko Schocher:

Quoted 109 lines

This patch series adds DM ethernet support for mpc83xx based keymile boards.

Travis build:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214

Changes in v2:
- new in v2
- remove RFC
- fixed Codingstyle errors, therefore new patch
?? powerpc, mpc83xx: fix codingstyle issues for qe_io.c
- moved DM part to drivers/pinctrl
- add comments from Qiang Zhao:
?? - add device node documentation
?? - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c ???? because using drivers/net/fsl_mdio.c leads in none existent ???? udevice mdio at 3320
???? instead boards with DM ETH support should use now this ???? driver.
- remove RFC tag
- add patch which fixes Codingstyle errors in drivers/qe
- add patch which converts the mpc83xx based boards from
?? keymile to DM_ETH

Heiko Schocher (5):
?? mpc83xx: remove unneeded extern declaration in cpu_init ?? powerpc, qe: fix codingstyle issues for drivers/qe ?? powerpc, qe: add DTS support for parallel I/O ports ?? net, qe: add DM support for QE UEC ethernet ?? mpc83xx, keymile boards: enable DM_ETH and add DTS

  ? arch/powerpc/cpu/mpc83xx/Kconfig????????????? |??? 8 +
  ? arch/powerpc/cpu/mpc83xx/Makefile???????????? |??? 2 +
  ? arch/powerpc/cpu/mpc83xx/cpu_init.c?????????? |?? 11 +-
  ? arch/powerpc/cpu/mpc83xx/qe_io.c????????????? |?? 98 +-
  ? arch/powerpc/dts/Makefile???????????????????? |??? 8 +
  ? arch/powerpc/dts/km8309-uboot.dtsi??????????? |?? 33 +
  ? arch/powerpc/dts/km8321-uboot.dtsi??????????? |?? 67 +
  ? arch/powerpc/dts/km8321.dtsi????????????????? |? 220 ++++
  ? arch/powerpc/dts/km836x-uboot.dtsi??????????? |?? 61 +
  ? arch/powerpc/dts/km836x.dtsi????????????????? |? 182 +++
  ? arch/powerpc/dts/kmcoge5ne-uboot.dtsi???????? |?? 22 +
  ? arch/powerpc/dts/kmcoge5ne.dts??????????????? |? 320 +++++
  ? arch/powerpc/dts/kmeter1-uboot.dtsi?????????? |?? 42 +
  ? arch/powerpc/dts/kmeter1.dts????????????????? |? 480 +++++++
  ? arch/powerpc/dts/kmopti2.dts????????????????? |? 161 +++
  ? arch/powerpc/dts/kmsupc5.dts????????????????? |? 139 ++
  ? arch/powerpc/dts/kmsupm5.dts????????????????? |? 129 ++
  ? arch/powerpc/dts/kmtegr1.dts????????????????? |? 392 ++++++
  ? arch/powerpc/dts/kmtepr2.dts????????????????? |? 142 ++
  ? arch/powerpc/dts/kmtuge1.dts????????????????? |? 100 ++
  ? arch/powerpc/dts/kmtuxa1.dts????????????????? |? 100 ++
  ? board/keymile/km83xx/Kconfig????????????????? |?? 17 +
  ? board/keymile/km83xx/MAINTAINERS????????????? |?? 23 +-
  ? board/keymile/km83xx/km83xx.c???????????????? |?? 64 -
  ? configs/kmcoge5ne_defconfig?????????????????? |?? 11 +-
  ? configs/kmeter1_defconfig???????????????????? |?? 10 +-
  ? configs/kmopti2_defconfig???????????????????? |?? 11 +-
  ? configs/kmsupx5_defconfig???????????????????? |?? 10 +-
  ? configs/kmtegr1_defconfig???????????????????? |?? 12 +-
  ? configs/kmtepr2_defconfig???????????????????? |?? 10 +-
  ? configs/tuge1_defconfig?????????????????????? |?? 10 +-
  ? configs/tuxx1_defconfig?????????????????????? |?? 11 +-
  ? .../soc/fsl/cpm_qe/qe/ucc.txt???????????????? |?? 53 +
  ? drivers/net/Kconfig?????????????????????????? |??? 2 +
  ? drivers/net/Makefile????????????????????????? |??? 1 +
  ? drivers/net/qe/Kconfig??????????????????????? |??? 9 +
  ? drivers/net/qe/Makefile?????????????????????? |??? 5 +
  ? drivers/net/qe/dm_qe_uec.c??????????????????? | 1167 +++++++++++++++++
  ? drivers/net/qe/dm_qe_uec.h??????????????????? |?? 22 +
  ? drivers/net/qe/dm_qe_uec_phy.c??????????????? |? 163 +++
  ? drivers/net/qe/uccf.c???????????????????????? |? 507 +++++++
  ? drivers/net/qe/uccf.h???????????????????????? |? 119 ++
  ? drivers/net/qe/uec.h????????????????????????? |? 693 ++++++++++
  ? drivers/pinctrl/Kconfig?????????????????????? |??? 7 +
  ? drivers/pinctrl/Makefile????????????????????? |??? 1 +
  ? drivers/pinctrl/pinctrl-qe-io.c?????????????? |? 255 ++++
  ? drivers/qe/qe.c?????????????????????????????? |?? 96 +-
  ? drivers/qe/uccf.c???????????????????????????? |? 449 ++++---
  ? drivers/qe/uccf.h???????????????????????????? |?? 90 +-
  ? drivers/qe/uec.c????????????????????????????? |? 598 ++++-----
  ? drivers/qe/uec.h????????????????????????????? |? 381 +++---
  ? drivers/qe/uec_phy.c????????????????????????? |? 334 ++---
  ? drivers/qe/uec_phy.h????????????????????????? |?? 71 +-
  ? include/configs/km/km-mpc832x.h?????????????? |?? 14 -
  ? include/configs/km/km-mpc8360.h?????????????? |?? 14 -
  ? include/configs/km/km-mpc83xx.h?????????????? |?? 10 -
  ? include/fsl_qe.h????????????????????????????? |??? 3 +

? 57 files changed, 6826 insertions(+), 1144 deletions(-)
? create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km8321.dtsi
? create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi
? create mode 100644 arch/powerpc/dts/km836x.dtsi
? create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi ? create mode 100644 arch/powerpc/dts/kmcoge5ne.dts
? create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi
? create mode 100644 arch/powerpc/dts/kmeter1.dts
? create mode 100644 arch/powerpc/dts/kmopti2.dts
? create mode 100644 arch/powerpc/dts/kmsupc5.dts
? create mode 100644 arch/powerpc/dts/kmsupm5.dts
? create mode 100644 arch/powerpc/dts/kmtegr1.dts
? create mode 100644 arch/powerpc/dts/kmtepr2.dts
? create mode 100644 arch/powerpc/dts/kmtuge1.dts
? create mode 100644 arch/powerpc/dts/kmtuxa1.dts
? create mode 100644 doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt ? create mode 100644 drivers/net/qe/Kconfig

Quoted 8 lines

? create mode 100644 drivers/net/qe/Makefile ? create mode 100644 drivers/net/qe/dm_qe_uec.c ? create mode 100644 drivers/net/qe/dm_qe_uec.h ? create mode 100644 drivers/net/qe/dm_qe_uec_phy.c ? create mode 100644 drivers/net/qe/uccf.c ? create mode 100644 drivers/net/qe/uccf.h ? create mode 100644 drivers/net/qe/uec.h
? create mode 100644 drivers/pinctrl/pinctrl-qe-io.c

Quoted 5 lines

gentle ping!

I got no reviews, comments for this patchseries ...

any comments?

ping?

I have a rebased version in the meantime, but I would wait for any comments...

Quoted 6 lines
Quoted 3 lines

gentle ping...

@Tom: Mario seems to busy .. how to proceed here with this patches?

Can you put together something for me to pull in to -next please? Thanks!

Ok, pushed them to a repo on github:

https://github.com/hsdenx/u-boot-test/tree/kmcoge5ne-dm-ethernet-devel

Quoted 7 lines
Quoted 5 lines

started travis build for this branch:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/727904421

If all builds fine, I can send a pull request ... is it ok for you if I push this branch to u-boot-i2c kmcoge5ne-dm-ethernet-devel?

Works for me, thanks!

Ok, travis build is fine, so here the pull request:

The following changes since commit bd4e8944cf7e36f8ad39466c40f8fc197c9df1c5:

Merge tag 'ti-v2021.01-next' of
https://gitlab.denx.de/u-boot/custodians/u-boot-ti into next (2020-09-15 15:22:00 -0400)

Quoted 8 lines

are available in the Git repository at:

https://gitlab.denx.de/u-boot/custodians/u-boot-i2c.git tags/for-v2021.01-next

for you to fetch changes up to 7bdfe8592956439743cad3c2d3ff5f24c4dd5aa9:

mpc83xx, keymile boards: enable DM_ETH and add DTS (2020-09-17 06:09:54 +0200)

Applied to u-boot/next, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200917/6d2960a9/attachment.sig>
#14 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

In reply to Heiko Schocher
Quoted 15 lines · Heiko Schocher

Hello Mario, Tom,

added Tom to cc ...

Am 08.09.2020 um 07:59 schrieb Heiko Schocher:

Quoted 9 lines

Hi Mario,

Am 17.08.2020 um 07:23 schrieb Heiko Schocher:

Quoted 6 lines

Hello Mario,

Am 27.05.2020 um 14:43 schrieb Heiko Schocher:

Quoted 3 lines

This patch series adds DM ethernet support for mpc83xx based keymile boards.

Quoted 8 lines
Quoted 4 lines

ping?

I have a rebased version in the meantime, but I would wait for any comments...

gentle ping...

@Tom: Mario seems to busy .. how to proceed here with this patches?

We have a mpc8309-based board, currently using a U-Boot based on v2020.04. If you have a git tree I can pull these patches from I'll try to test them on our hardware.

Rasmus

#15 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Hello Rasmus,

Am 16.09.2020 um 21:35 schrieb Rasmus Villemoes:

Quoted 21 lines · Heiko Schocher
Quoted 20 lines

Hello Mario, Tom,

added Tom to cc ...

Am 08.09.2020 um 07:59 schrieb Heiko Schocher:

Quoted 14 lines

Hi Mario,

Am 17.08.2020 um 07:23 schrieb Heiko Schocher:

Quoted 6 lines

Hello Mario,

Am 27.05.2020 um 14:43 schrieb Heiko Schocher:

Quoted 3 lines

This patch series adds DM ethernet support for mpc83xx based keymile boards.

ping?

I have a rebased version in the meantime, but I would wait for any comments...

Quoted 7 lines
Quoted 3 lines

gentle ping...

@Tom: Mario seems to busy .. how to proceed here with this patches?

We have a mpc8309-based board, currently using a U-Boot based on v2020.04. If you have a git tree I can pull these patches from I'll try to test them on our hardware.

Pushed them (rebased to next) to:

https://github.com/hsdenx/u-boot-test/tree/kmcoge5ne-dm-ethernet-devel

started travis build for this branch:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/727904421

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#16 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Quoted 8 lines · Heiko Schocher

Hello Rasmus,

Am 16.09.2020 um 21:35 schrieb Rasmus Villemoes:

Quoted 4 lines

We have a mpc8309-based board, currently using a U-Boot based on v2020.04. If you have a git tree I can pull these patches from I'll try to test them on our hardware.

Quoted 6 lines

Pushed them (rebased to next) to:

https://github.com/hsdenx/u-boot-test/tree/kmcoge5ne-dm-ethernet-devel

started travis build for this branch:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/727904421

Thanks, it took me a bit longer rebasing our private patches to -next than I thought, but I'm starting to look at those now. The first thing I notice is this:

-       u32                     pin_2bit_mask;
-       u32                     pin_2bit_dir;
-       u32                     pin_2bit_assign;
-       u32                     pin_1bit_mask;
+       u32             2bit_mask;
+       u32             2bit_dir;
+       u32             2bit_assign;
+       u32             1bit_mask;

That doesn't compile (can't start identifier with digit), but you fix it up later. Any chance you can make these patches bisectable? Especially a patch that claims to be about fixing coding style shouldn't introduce build errors.

Thanks,
Rasmus

#17 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Hi Rasmus,

Am 21.09.2020 um 10:40 schrieb Rasmus Villemoes:

Quoted 29 lines · Heiko Schocher
Quoted 8 lines

Hello Rasmus,

Am 16.09.2020 um 21:35 schrieb Rasmus Villemoes:

Quoted 4 lines

We have a mpc8309-based board, currently using a U-Boot based on v2020.04. If you have a git tree I can pull these patches from I'll try to test them on our hardware.

Quoted 6 lines

Pushed them (rebased to next) to:

https://github.com/hsdenx/u-boot-test/tree/kmcoge5ne-dm-ethernet-devel

started travis build for this branch:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/727904421

Thanks, it took me a bit longer rebasing our private patches to -next than I thought, but I'm starting to look at those now. The first thing I notice is this:

(quoted diff) +4 -4
-       u32                     pin_2bit_mask;
-       u32                     pin_2bit_dir;
-       u32                     pin_2bit_assign;
-       u32                     pin_1bit_mask;
+       u32             2bit_mask;
+       u32             2bit_dir;
+       u32             2bit_assign;
+       u32             1bit_mask;
Quoted 1 line

That doesn't compile (can't start identifier with digit), but you fix it

Autsch ...

Quoted 3 lines

up later. Any chance you can make these patches bisectable? Especially a patch that claims to be about fixing coding style shouldn't introduce build errors.

I am sorry about that, but Tom already pulled the patches into next...

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#18 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Hi Heiko

I'm struggling somewhat with getting our mpc8309-derived board converted to DM_ETH. I just get

Net: No ethernet found.

where I used to get

Net: UEC0, UEC1, UEC2

and there's no errors or other diagnostics printed (I've also tried adding #define DEBUG 1 to the .c files under drivers/net/qe/, still nothing).

The board already used OF_CONTROL, so I've tried extending the device-tree based partly on you changes for the km boards, partly from our linux device tree - the two mostly agree:

@@ -25,6 +25,8 @@
i2c0 = &i2c0;
i2c1 = &i2c1;
spi0 = &spi0;
+ ethernet0 = &enet0;
+ ethernet2 = &enet2;
};

chosen {
@@ -315,6 +317,95 @@
clocks = <&clocks MPC83XX_CLK_SDHC>; clock-names = "per";
};
+
+ ipic: pic at 700 {
+ compatible = "fsl,ipic";
+ interrupt-controller;
+ #address-cells = <0>;
+ #interrupt-cells = <2>;
+ reg = <0x700 0x100>;
+ device_type = "ipic";
+ };
};
-};

+ qe: qe at e0100000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ device_type = "qe";
+ compatible = "fsl,qe";
+ ranges = <0x0 0xe0100000 0x00100000>;
+ reg = <0xe0100000 0x480>;
+ brg-frequency = <0>;
+ bus-frequency = <396000000>;
+
+ muram at 10000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "fsl,qe-muram", "fsl,cpm-muram";
+ ranges = <0x0 0x00010000 0x00004000>;
+
+ data-only at 0 {
+ compatible = "fsl,qe-muram-data",
+ "fsl,cpm-muram-data";
+ reg = <0x0 0x4000>;
+ };
+ };
+
+ qeic: interrupt-controller at 80 {
+ interrupt-controller;
+ compatible = "fsl,qe-ic";
+ #address-cells = <0>;
+ #interrupt-cells = <1>;
+ reg = <0x80 0x80>;
+ big-endian;
+ interrupts = <32 8 33 8>;
+ interrupt-parent = <&ipic>;
+ };
+
+ enet0: ethernet at 2000 {
+ device_type = "network";
+ compatible = "ucc_geth";
+ cell-index = <1>;
+ reg = <0x2000 0x200>;
+ interrupts = <32>;
+ interrupt-parent = <&qeic>;
+ local-mac-address = [ 00 00 00 00 00 00 ];
+ rx-clock-name = "clk9";
+ tx-clock-name = "clk10";
+ fixed-link = <1 1 100 0 0>;
+ };
+
+ enet2: ethernet at 2200 {
+ device_type = "network";
+ compatible = "ucc_geth";
+ cell-index = <3>;
+ reg = <0x2200 0x200>;
+ interrupts = <34>;
+ interrupt-parent = <&qeic>;
+ local-mac-address = [ 00 00 00 00 00 00 ];
+ rx-clock-name = "clk11";
+ tx-clock-name = "clk12";
+ phy-handle = <&phy1>;
+ phy-connection-type = "mii";
+ };
+
+ mdio0: mdio at 2120 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x2120 0x18>;
+ compatible = "fsl,ucc-mdio";
+
+ phy0: ethernet-phy at 00 {
+ reg = <0x01>;
+ device_type = "ethernet-phy";
+ };
+ phy1: ethernet-phy at 01 {
+ reg = <0x02>;
+ device_type = "ethernet-phy";
+ };
+ };
+
+
+ };
+
+};

The defconfig is updated with

CONFIG_MTD_UBI_FASTMAP_AUTOCONVERT=1
CONFIG_PHYLIB=y
CONFIG_PHY_MARVELL=y
+CONFIG_DM_ETH=y
+CONFIG_DM_MDIO=y
+CONFIG_DM_ETH_PHY=y
CONFIG_MII=y
+CONFIG_QE_UEC=y

and finally I've removed the UEC_ETH definitions from the board config header:

-/*
- * Ethernet setup
- */
-
-/* enable uec ethernet */
-#define CONFIG_UEC_ETH
-
-/* eth1 */
-#define CONFIG_UEC_ETH1
-#define CONFIG_SYS_UEC1_UCC_NUM 0
-#define CONFIG_SYS_UEC1_RX_CLK QE_CLK9
-#define CONFIG_SYS_UEC1_TX_CLK QE_CLK10
-#define CONFIG_SYS_UEC1_ETH_TYPE FAST_ETH
-#define CONFIG_SYS_UEC1_PHY_ADDR 0x11
-#define CONFIG_SYS_UEC1_INTERFACE_TYPE PHY_INTERFACE_MODE_MII
-#define CONFIG_SYS_UEC1_INTERFACE_SPEED 100
-
-/* eth2 */
-#define CONFIG_UEC_ETH2
-#define CONFIG_SYS_UEC2_UCC_NUM 1
-#define CONFIG_SYS_UEC2_RX_CLK QE_CLK7
-#define CONFIG_SYS_UEC2_TX_CLK QE_CLK8
-#define CONFIG_SYS_UEC2_ETH_TYPE FAST_ETH
-#define CONFIG_SYS_UEC2_PHY_ADDR 0x13
-#define CONFIG_SYS_UEC2_INTERFACE_TYPE PHY_INTERFACE_MODE_MII
-#define CONFIG_SYS_UEC2_INTERFACE_SPEED 100
-
-/* eth3 */
-#define CONFIG_UEC_ETH3
-#define CONFIG_SYS_UEC3_UCC_NUM 2
-#define CONFIG_SYS_UEC3_RX_CLK QE_CLK11
-#define CONFIG_SYS_UEC3_TX_CLK QE_CLK12
-#define CONFIG_SYS_UEC3_ETH_TYPE FAST_ETH
-#define CONFIG_SYS_UEC3_PHY_ADDR 0x12
-#define CONFIG_SYS_UEC3_INTERFACE_TYPE PHY_INTERFACE_MODE_MII
-#define CONFIG_SYS_UEC3_INTERFACE_SPEED 100
-

I only define two ethernet devices in DT above - the third (middle one) is used for ethercat and irrelevant in U-Boot.

I have not set CONFIG_PINCTRL{,_QE} since our qe_iop_conf_tab is just

const qe_iop_conf_t qe_iop_conf_tab[] = {
       {0,  0, 0, 0, QE_IOP_TAB_END}, /* END of table */
};

so config_qe_ioports() should be a no-op.

Can you see something obviously wrong with the above, and/or do you have some hints as for what I can do to figure out why the drivers apparently do not pick up the devices from DT? 'dm drivers' does list

ucc_geth                  033 eth                  <none>
qe_uec_mdio               051 mdio                 <none>

Thanks,
Rasmus

#19 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Hi Rasmus,

Am 22.09.2020 um 16:34 schrieb Rasmus Villemoes:

Quoted 10 lines

Hi Heiko

I'm struggling somewhat with getting our mpc8309-derived board converted to DM_ETH. I just get

Net: No ethernet found.

where I used to get

Net: UEC0, UEC1, UEC2

:-(

Ok, I currently have no access to the hardware, I wait for the customer to give me access, will take until next week ... so I can only review currently code changes...

BTW: I hope to get daily access, so I can add at least one board to my daily U-Boot tbot tests, see:

http://xeidos.ddns.net/ubtestresults/home

Quoted 104 lines

and there's no errors or other diagnostics printed (I've also tried adding #define DEBUG 1 to the .c files under drivers/net/qe/, still nothing).

The board already used OF_CONTROL, so I've tried extending the device-tree based partly on you changes for the km boards, partly from our linux device tree - the two mostly agree:

(quoted diff) +82 -1
@@ -25,6 +25,8 @@
  		i2c0 = &i2c0;
  		i2c1 = &i2c1;
  		spi0 = &spi0;
+		ethernet0 = &enet0;
+		ethernet2 = &enet2;
  	};
 
  	chosen {
@@ -315,6 +317,95 @@
  			clocks = <&clocks MPC83XX_CLK_SDHC>;
  			clock-names = "per";
  		};
+
+		ipic: pic at 700 {
+			compatible = "fsl,ipic";
+			interrupt-controller;
+			#address-cells = <0>;
+			#interrupt-cells = <2>;
+			reg = <0x700 0x100>;
+			device_type = "ipic";
+		};
  	};
-};
 
+	qe: qe at e0100000 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		device_type = "qe";
+		compatible = "fsl,qe";
+		ranges = <0x0 0xe0100000 0x00100000>;
+		reg = <0xe0100000 0x480>;
+		brg-frequency = <0>;
+		bus-frequency = <396000000>;
+
+		muram at 10000 {
+			#address-cells = <1>;
+			#size-cells = <1>;
+			compatible = "fsl,qe-muram", "fsl,cpm-muram";
+			ranges = <0x0 0x00010000 0x00004000>;
+
+			data-only at 0 {
+				compatible = "fsl,qe-muram-data",
+					     "fsl,cpm-muram-data";
+				reg = <0x0 0x4000>;
+			};
+		};
+
+		qeic: interrupt-controller at 80 {
+			interrupt-controller;
+			compatible = "fsl,qe-ic";
+			#address-cells = <0>;
+			#interrupt-cells = <1>;
+			reg = <0x80 0x80>;
+			big-endian;
+			interrupts = <32 8 33 8>;
+			interrupt-parent = <&ipic>;
+		};
+
+		enet0: ethernet at 2000 {
+			device_type = "network";
+			compatible = "ucc_geth";
+			cell-index = <1>;
+			reg = <0x2000 0x200>;
+			interrupts = <32>;
+			interrupt-parent = <&qeic>;
+			local-mac-address = [ 00 00 00 00 00 00 ];
+			rx-clock-name = "clk9";
+			tx-clock-name = "clk10";
+			fixed-link = <1 1 100 0 0>;
+		};
+
+		enet2: ethernet at 2200 {
+			device_type = "network";
+			compatible = "ucc_geth";
+			cell-index = <3>;
+			reg = <0x2200 0x200>;
+			interrupts = <34>;
+			interrupt-parent = <&qeic>;
+			local-mac-address = [ 00 00 00 00 00 00 ];
+			rx-clock-name = "clk11";
+			tx-clock-name = "clk12";
+			phy-handle = <&phy1>;
+			phy-connection-type = "mii";
+		};
+
+		mdio0: mdio at 2120 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x2120 0x18>;
+			compatible = "fsl,ucc-mdio";
+
+			phy0: ethernet-phy at 00 {
+				reg = <0x01>;
+				device_type = "ethernet-phy";
+			};

Review line 411

Quoted 10 lines
(quoted diff) +10 -0
+			phy1: ethernet-phy at 01 {
+				reg = <0x02>;
+				device_type = "ethernet-phy";
+			};
+		};
+
+
+	};
+
+};

Does this work with linux? If so, it should be OK....

I miss something like:

https://gitlab.denx.de/u-boot/u-boot/-/commit/7bdfe8592956439743cad3c2d3ff5f24c4dd5aa9#8fd63f1c0ee54bb5ed6e0446595997296ab56205

Important here:

&qe {
	compatible = "fsl,qe", "simple-bus";
};

Review

Quoted 11 lines

The defconfig is updated with

CONFIG_MTD_UBI_FASTMAP_AUTOCONVERT=1
CONFIG_PHYLIB=y
CONFIG_PHY_MARVELL=y

(quoted diff) +4 -0
+CONFIG_DM_ETH=y
+CONFIG_DM_MDIO=y
+CONFIG_DM_ETH_PHY=y
  CONFIG_MII=y
+CONFIG_QE_UEC=y

Looks good...

Quoted 44 lines

and finally I've removed the UEC_ETH definitions from the board config header:

(quoted diff) +0 -37
-/*
- * Ethernet setup
- */
-
-/* enable uec ethernet */
-#define CONFIG_UEC_ETH
-
-/* eth1 */
-#define CONFIG_UEC_ETH1
-#define CONFIG_SYS_UEC1_UCC_NUM		0
-#define CONFIG_SYS_UEC1_RX_CLK		QE_CLK9
-#define CONFIG_SYS_UEC1_TX_CLK		QE_CLK10
-#define CONFIG_SYS_UEC1_ETH_TYPE	FAST_ETH
-#define CONFIG_SYS_UEC1_PHY_ADDR	0x11
-#define CONFIG_SYS_UEC1_INTERFACE_TYPE	PHY_INTERFACE_MODE_MII
-#define CONFIG_SYS_UEC1_INTERFACE_SPEED	100
-
-/* eth2 */
-#define CONFIG_UEC_ETH2
-#define CONFIG_SYS_UEC2_UCC_NUM		1
-#define CONFIG_SYS_UEC2_RX_CLK		QE_CLK7
-#define CONFIG_SYS_UEC2_TX_CLK		QE_CLK8
-#define CONFIG_SYS_UEC2_ETH_TYPE	FAST_ETH
-#define CONFIG_SYS_UEC2_PHY_ADDR	0x13
-#define CONFIG_SYS_UEC2_INTERFACE_TYPE	PHY_INTERFACE_MODE_MII
-#define CONFIG_SYS_UEC2_INTERFACE_SPEED	100
-
-/* eth3 */
-#define CONFIG_UEC_ETH3
-#define CONFIG_SYS_UEC3_UCC_NUM		2
-#define CONFIG_SYS_UEC3_RX_CLK		QE_CLK11
-#define CONFIG_SYS_UEC3_TX_CLK		QE_CLK12
-#define CONFIG_SYS_UEC3_ETH_TYPE	FAST_ETH
-#define CONFIG_SYS_UEC3_PHY_ADDR	0x12
-#define CONFIG_SYS_UEC3_INTERFACE_TYPE	PHY_INTERFACE_MODE_MII
-#define CONFIG_SYS_UEC3_INTERFACE_SPEED	100
-

I only define two ethernet devices in DT above - the third (middle one) is used for ethercat and irrelevant in U-Boot.

Quoted 7 lines

I have not set CONFIG_PINCTRL{,_QE} since our qe_iop_conf_tab is just

const qe_iop_conf_t qe_iop_conf_tab[] = {
        {0,  0, 0, 0, QE_IOP_TAB_END}, /* END of table */
};

so config_qe_ioports() should be a no-op.

Okay...

Quoted 6 lines

Can you see something obviously wrong with the above, and/or do you have some hints as for what I can do to figure out why the drivers apparently do not pick up the devices from DT? 'dm drivers' does list

ucc_geth                  033 eth                  <none>
qe_uec_mdio               051 mdio                 <none>

Here from an old log (mpc8360 based):

=> dm tree^M
Class Index Probed Driver Name^M
-----------------------------------------------------------^M

  root          0  [ + ]   root_driver           root_driver^M
  simple_bus    0  [ + ]   generic_simple_bus    |-- soc8360 at e0000000^M
  serial        0  [ + ]   ns16550_serial        |   |-- serial at 4500^M
  pinctrl       0  [ + ]   par-io-pinctrl        |   |-- par_io at 1400^M
  simple_bus    1  [ + ]   generic_simple_bus    |   `-- qe at 100000^M
  eth           0  [   ]   ucc_geth              |       |-- ucc at 2000^M
  eth           1  [   ]   ucc_geth              |       |-- ucc at 3000^M
  eth           2  [ + ]   ucc_geth              |       |-- ucc at 3200^M
  eth           3  [   ]   ucc_geth              |       |-- ucc at 2400^M
  eth           4  [   ]   ucc_geth              |       |-- ucc at 3400^M
  eth           5  [   ]   ucc_geth              |       |-- ucc at 2600^M
  eth           6  [   ]   ucc_geth              |       `-- ucc at 3600^M
  simple_bus    2  [   ]   generic_simple_bus    `-- localbus at e0005000^M

=>

Hmm... hard to say, you may enable debug output in ./drivers/core/root.c

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#20 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Quoted 19 lines · Heiko Schocher

Hi Rasmus,

Am 22.09.2020 um 16:34 schrieb Rasmus Villemoes:

Quoted 11 lines

The board already used OF_CONTROL, so I've tried extending the device-tree based partly on you changes for the km boards, partly from our linux device tree - the two mostly agree:

+??? qe: qe at e0100000 {
+??????? #address-cells = <1>;
+??????? #size-cells = <1>;
+??????? device_type = "qe";
+??????? compatible = "fsl,qe";
+??????? ranges = <0x0 0xe0100000 0x00100000>;
+??????? reg = <0xe0100000 0x480>;

Does this work with linux? If so, it should be OK....

I miss something like:

Quoted 7 lines

https://gitlab.denx.de/u-boot/u-boot/-/commit/7bdfe8592956439743cad3c2d3ff5f24c4dd5aa9#8fd63f1c0ee54bb5ed6e0446595997296ab56205

Important here:

&qe {
????compatible = "fsl,qe", "simple-bus";
};

That helped, thanks. In our linux device tree we just have "fsl,qe", which works because linux has an actual driver for that. Is there a reason you didn't just include the "simple-bus" string in the .dtsi files, instead of fixing it in each .dts that includes the .dtsi?

Quoted 13 lines
Quoted 11 lines

The defconfig is updated with

? CONFIG_MTD_UBI_FASTMAP_AUTOCONVERT=1
? CONFIG_PHYLIB=y
? CONFIG_PHY_MARVELL=y

(quoted diff) +3 -0
+CONFIG_DM_ETH=y
+CONFIG_DM_MDIO=y
+CONFIG_DM_ETH_PHY=y

? CONFIG_MII=y
+CONFIG_QE_UEC=y

?Looks good...

So, I also added CONFIG_PHY_FIXED, and changed from the deprecated old-style

  fixed-link = <1 1 100 0 0>;

(which I can't find any U-Boot code that would parse) to the new-style

			fixed-link {
				speed = <100>;
				full-duplex;
			};

Perhaps I need to explain a little more about the board: It has a marvell 88e6250 switch, the above fixed-link is from one of the cpu's ethernet devices to the switch's cpu port. In order to get traffic flowing, we used to manually do a few mii commands to instruct the switch to open the cpu port and one specific outwards port, i.e. we have something like

phy1_up=mii write 17 19 3100; mii write 17 18 9620; mii write 19 04 007F cpu_up=mii write 1D 01 0033; mii write 1D 04 007F prep_switch=mii device UEC2; run phy1_up cpu_up ...

So I used to be able to do

=> run prep_switch
=> ping $serverip
UEC: PHY is Fixed PHY (ffffffff)
UEC0: Full Duplex
UEC0: Speed 100BT
UEC0: Link is up
Using UEC0 device
host 192.168.174.2 is alive

Now, I've updated the prep_switch etc. commands to use "mdio write mdio at 2120 ...", and that part I think works - when I run the phy1_up, the link LED does get lit, and using mdio read I can read back both the registers I wrote as well as the switch's identification registers, so I'm pretty sure I'm talking to the right thing. But when I then try the ping command, nothing:

=> ping $serverip
ping failed; host 192.168.174.2 is not alive

Any hints?

Thanks,
Rasmus

#21 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Hello Rasmus,

Am 24.09.2020 um 08:55 schrieb Rasmus Villemoes:

Quoted 24 lines · Heiko Schocher
Quoted 23 lines

Hi Rasmus,

Am 22.09.2020 um 16:34 schrieb Rasmus Villemoes:

Quoted 11 lines

The board already used OF_CONTROL, so I've tried extending the device-tree based partly on you changes for the km boards, partly from our linux device tree - the two mostly agree:

+??? qe: qe at e0100000 {
+??????? #address-cells = <1>;
+??????? #size-cells = <1>;
+??????? device_type = "qe";
+??????? compatible = "fsl,qe";
+??????? ranges = <0x0 0xe0100000 0x00100000>;
+??????? reg = <0xe0100000 0x480>;

Does this work with linux? If so, it should be OK....

I miss something like:

https://gitlab.denx.de/u-boot/u-boot/-/commit/7bdfe8592956439743cad3c2d3ff5f24c4dd5aa9#8fd63f1c0ee54bb5ed6e0446595997296ab56205

Important here:

Quoted 8 lines
Quoted 3 lines

&qe {
????compatible = "fsl,qe", "simple-bus";
};

That helped, thanks. In our linux device tree we just have "fsl,qe", which works because linux has an actual driver for that. Is there a reason you didn't just include the "simple-bus" string in the .dtsi files, instead of fixing it in each .dts that includes the .dtsi?

No, seems there is more room for optimizations :-)

Quoted 17 lines
Quoted 4 lines
Quoted 4 lines

The defconfig is updated with

Quoted 10 lines

Review

Quoted 8 lines

? CONFIG_MTD_UBI_FASTMAP_AUTOCONVERT=1
? CONFIG_PHYLIB=y
? CONFIG_PHY_MARVELL=y

(quoted diff) +4 -0
+CONFIG_DM_ETH=y
+CONFIG_DM_MDIO=y
+CONFIG_DM_ETH_PHY=y
 ? CONFIG_MII=y
+CONFIG_QE_UEC=y

?Looks good...

So, I also added CONFIG_PHY_FIXED, and changed from the deprecated old-style

Quoted 8 lines
   fixed-link = <1 1 100 0 0>;

(which I can't find any U-Boot code that would parse) to the new-style

			fixed-link {
				speed = <100>;
				full-duplex;
			};

Ok!

Quoted 9 lines

Perhaps I need to explain a little more about the board: It has a marvell 88e6250 switch, the above fixed-link is from one of the cpu's ethernet devices to the switch's cpu port. In order to get traffic flowing, we used to manually do a few mii commands to instruct the switch to open the cpu port and one specific outwards port, i.e. we have something like

phy1_up=mii write 17 19 3100; mii write 17 18 9620; mii write 19 04 007F
cpu_up=mii write 1D 01 0033; mii write 1D 04 007F > prep_switch=mii device UEC2; run phy1_up cpu_up ...

Why not adding this into a phy driver?

Quoted 18 lines

So I used to be able to do

=> run prep_switch
=> ping $serverip
UEC: PHY is Fixed PHY (ffffffff)
UEC0: Full Duplex
UEC0: Speed 100BT
UEC0: Link is up
Using UEC0 device
host 192.168.174.2 is alive

Now, I've updated the prep_switch etc. commands to use "mdio write mdio at 2120 ...", and that part I think works - when I run the phy1_up, the link LED does get lit, and using mdio read I can read back both the registers I wrote as well as the switch's identification registers, so I'm pretty sure I'm talking to the right thing. But when I then try the ping command, nothing:

Quoted 4 lines

=> ping $serverip
ping failed; host 192.168.174.2 is not alive

Any hints?

So, you see that your ethernet and so also mdio driver is probed?

Can you post a "dm tree" output?

Without looking onto hardware it is hard to say ... you need to debug into ethernet driver, may compare register setup with old driver....

May a problem with pinsetup? Or clock setup?

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#22 lore raw

v2 cover powerpc, mpc83xx: add DM_ETH support

Hello Rasmus,

just for your information...

I had the chance to test current next branch on the MPC8360 based kmcoge5ne board ... I hope to get this board into my automated testsetup soon...

Here the logs:

U-Boot 2020.10-rc4-00088-gc428a44124-dirty (Sep 30 2020 - 12:06:01 +0200)

Reset Status:

CPU:   e300c1, MPC8360A, Rev: 2.1 at 528 MHz, CSB: 264 MHz
Model: kmcoge5ne
Board: ABB kmcoge5ne with PIGGY.
I2C:   ready
DRAM:  512 MiB (DDR2, 64-bit, ECC off, 264 MHz)
POST memory PASSED
Flash: 64 MiB
NAND:  128 MiB
Loading Environment from Flash... OK
In:    serial at 4500
Out:   serial at 4500
Err:   serial at 4500
Net:   eth0: ucc at 3200

Hit <SPACE> key to stop autoboot in 2s
=>

=> setenv serverip 192.168.1.2
=> setenv ipaddr 192.168.1.1
=> bd
boot_params = 0x00000000

DRAM bank   = 0x00000000
-> start    = 0x00000000
-> size     = 0x20000000
flashstart  = 0xf0000000
flashsize   = 0x04000000
flashoffset = 0x00073000
baudrate    = 115200 bps
relocaddr   = 0x1ff83000
reloc off   = 0x2ff83000
Build       = 32-bit
current eth = ucc at 3200
ethaddr     = 00:e0:df:6e:34:80
IP addr     = 192.168.1.1
fdt_blob    = 0x1fb7cea0
new_fdt     = 0x1fb7cea0
fdt_size    = 0x00002000
lmb_dump_all:
     memory.cnt             = 0x1
     memory.size            = 0x0
     memory.reg[0x0].base   = 0x0
                    .size   = 0x20000000
     reserved.cnt           = 0x1
     reserved.size          = 0x0
     reserved.reg[0x0].base = 0x1fb7bb90
                      .size = 0x484470
busfreq     =    264 MHz
bootflags   = 0x00000000
intfreq     =    528 MHz
=> dm tree
  Class     Index  Probed  Driver                Name
-----------------------------------------------------------
  root          0  [ + ]   root_driver           root_driver
  simple_bus    0  [ + ]   simple_bus            |-- soc8360 at e0000000
  serial        0  [ + ]   ns16550_serial        |   |-- serial at 4500
  pinctrl       0  [ + ]   par-io-pinctrl        |   |-- par_io at 1400
  simple_bus    1  [ + ]   simple_bus            |   `-- qe at 100000
  bootcount     0  [ + ]   bootcount-mem         |       |-- bootcount at 0x1bff8
  eth           0  [ + ]   ucc_geth              |       |-- ucc at 3200
  mdio          0  [ + ]   qe_uec_mdio           |       `-- mdio at 3320
  simple_bus    2  [   ]   simple_bus            `-- localbus at e0005000

=> dm
dm - Driver model low level access

Usage:

dm tree          Dump driver model tree ('*' = activated)
dm uclass        Dump list of instances for each uclass
dm devres        Dump list of device resources for each device
dm drivers       Dump list of drivers with uclass and instances
dm compat        Dump list of drivers with compatibility strings
dm static        Dump list of drivers with static platform data

=> dm uclass
uclass 0: root
0 * root_driver @ 1fb7f028, seq 0, (req -1)

uclass 23: bootcount
0 * bootcount at 0x1bff8 @ 1fb7f2b0, seq 0, (req -1)

uclass 33: eth
0 * ucc at 3200 @ 1fb7f338, seq 0, (req 0)

uclass 34: eth_phy_generic
uclass 51: mdio
0 * mdio at 3320 @ 1fb7f3d0, seq 0, (req -1)

uclass 57: nop
uclass 69: pinctrl
0 * par_io at 1400 @ 1fb7f1c0, seq 0, (req -1)

uclass 81: serial
0 * serial at 4500 @ 1fb7f128, seq 0, (req 0)

uclass 82: simple_bus
0 * soc8360 at e0000000 @ 1fb7f0a0, seq 0, (req -1)
1 * qe at 100000 @ 1fb7f228, seq 1, (req -1)
2 localbus at e0005000 @ 1fb7f428

=> dm devres
=> dm drivers
Driver uid uclass Devices
----------------------------------------------------------

bootcount-mem             023 bootcount            bootcount at 0x1bff8
eth_phy_generic_drv       034 eth_phy_generic      <none>
ucc_geth                  033 eth                  ucc at 3200
qe_uec_mdio               051 mdio                 mdio at 3320
ns16550_serial            081 serial               serial at 4500
par-io-pinctrl            069 pinctrl              par_io at 1400
root_driver               000 root                 root_driver
simple_bus                082 simple_bus           soc8360 at e0000000
                                                    qe at 100000
                                                    localbus at e0005000

=> dm compat
Driver Compatible
--------------------------------
bootcount-mem u-boot,bootcount
eth_phy_generic_drv

ucc_geth              ucc_geth
qe_uec_mdio           fsl,ucc-mdio
ns16550_serial        ns16550
                       ns16550a
                       ingenic,jz4780-uart
                       nvidia,tegra20-uart
                       snps,dw-apb-uart

par-io-pinctrl fsl,mpc8360-par_io
root_driver
simple_bus simple-bus
simple-mfd
=> dm static
Driver Address
---------------------------------
=> bd
boot_params = 0x00000000

DRAM bank   = 0x00000000
-> start    = 0x00000000
-> size     = 0x20000000
flashstart  = 0xf0000000
flashsize   = 0x04000000
flashoffset = 0x00073000
baudrate    = 115200 bps
relocaddr   = 0x1ff83000
reloc off   = 0x2ff83000
Build       = 32-bit
current eth = ucc at 3200
ethaddr     = 00:e0:df:6e:34:80
IP addr     = 192.168.1.1
fdt_blob    = 0x1fb7cea0
new_fdt     = 0x1fb7cea0
fdt_size    = 0x00002000
lmb_dump_all:
     memory.cnt             = 0x1
     memory.size            = 0x0
     memory.reg[0x0].base   = 0x0
                    .size   = 0x20000000
     reserved.cnt           = 0x1
     reserved.size          = 0x0
     reserved.reg[0x0].base = 0x1fb7bb90
                      .size = 0x484470
busfreq     =    264 MHz
bootflags   = 0x00000000
intfreq     =    528 MHz

=> tftp 100000 kmcoge5ne/20200930/u-boot.bin
Using ucc at 3200 device
TFTP from server 192.168.1.2; our IP address is 192.168.1.1 Filename 'kmcoge5ne/20200930/u-boot.bin'.
Load address: 0x100000
Loading: #################################

          1.9 MiB/s
done
Bytes transferred = 475739 (7425b hex)
=> md 100000
00100000: 04040404 04040404 04040404 04040404    ................
00100010: 00000000 00000000 86868686 86868686    ................
00100020: 00000000 00000000 60606060 60606060    ........````````
00100030: 00000000 00000000 06060606 06060606    ................
00100040: 27051956 552d426f 6f742032 3032302e    '..VU-Boot 2020.
00100050: 31302d72 63342d30 30303838 2d676334    10-rc4-00088-gc4
00100060: 32386134 34313234 2d646972 74792028    28a44124-dirty (
00100070: 53657020 33302032 30323020 2d203132    Sep 30 2020 - 12
00100080: 3a30363a 3031202b 30323030 29000000    :06:01 +0200)...
00100090: 7ca000a6 60a50030 7ca00124 4c00012c    |...`..0|..$L..,
001000a0: 4e800020 7c8802a6 7c6000a6 70600030    N.. |...|`..p`.0
001000b0: 4d820020 7c630078 7c9a03a6 7c7b03a6    M.. |c.x|...|{..
001000c0: 4c000064 00000000 00000000 00000000    L..d............
001000d0: 00000000 00000000 00000000 00000000    ................
001000e0: 00000000 00000000 00000000 00000000    ................
001000f0: 00000000 00000000 00000000 00000000    ................
=>
00100100: 3c80ff40 60000000 7ca000a6 48000005    <..@`...|...H...
00100110: 7ce802a6 3c60e000 60630000 80c40000    |...<`..`c......
00100120: 4c00012c 90640000 80c70000 4c00012c    L..,.d......L..,
00100130: 80c30000 4c00012c 48003041 48003611    ....L..,H.0AH.6.
00100140: 3c80f000 60840000 38a40154 7ca803a6    <...`...8..T|...
00100150: 4e800020 48003645 48003099 7c0004ac    N.. H.6EH.0.|...
00100160: 4bffff31 7c0004ac 4800327d 7c0004ac    K..1|...H.2}|...
00100170: 4800355d 7c0004ac 3c60e600 60630f00    H.5]|...<`..`c..
00100180: 38830100 38000000 3884ffff 98040000    8...8...8.......
00100190: 7c032040 4082fff4 3863fc00 906400ac    |. @@...8c...d..
001001a0: 38000000 9403fffc 9403fffc 7c611b78    8...........|a.x
001001b0: 48000005 7d8802a6 800c3654 7d806214    H...}.....6T}.b.
001001c0: 480686f9 7fc802a6 3c60e000 48003bbd    H.......<`..H.;.
001001d0: 38600000 48015b95 00000000 00000000    8`..H.[.........
001001e0: 00000000 00000000 00000000 00000000    ................
001001f0: 00000000 00000000 00000000 00000000    ................

=>

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de