dt-bindings: media: venus: Add an optional power domain for perf voting
Subsystems (5)
PATCH v2 1/1 dt-bindings: media: venus: Add an optional power domain for perf voting
Add an optional power domain which when specified can be used for setting the performance state of Venus.
--- Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++- Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml +5 -1
@@ -25,12 +25,16 @@ properties: maxItems: 1 power-domains: - maxItems: 2 + minItems: 2 + maxItems: 3 power-domain-names: + minItems: 2 + maxItems: 3 items: - const: venus - const: vcodec0 + - const: opp-pd clocks: maxItems: 5
Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml +5 -1
@@ -25,13 +25,17 @@ properties: maxItems: 1 power-domains: - maxItems: 3 + minItems: 3 + maxItems: 4 power-domain-names: + minItems: 3 + maxItems: 4 items: - const: venus - const: vcodec0 - const: vcodec1 + - const: opp-pd clocks: maxItems: 7
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Rob Herring
maintainerQuoted 18 lines · Rajendra Nayak
Add an optional power domain which when specified can be used for setting the performance state of Venus.
Signed-off-by Rajendra Nayak <[email protected]>--- Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++- Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml +0
-1@@ -25,12 +25,16 @@ properties: maxItems: 1 power-domains: - maxItems: 2
Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml properties: · line 37
Quoted 10 lines
Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml +5
-0+ minItems: 2 + maxItems: 3 power-domain-names: + minItems: 2 + maxItems: 3 items: - const: venus - const: vcodec0 + - const: opp-pd
Humm, looks suspicious. This is a phyical power island in this block? Because that's what 'power-domains' are supposed to represent. Not $os pm-domain construct.
Rob
Quoted 22 lines · Rob Herring
Quoted 21 lines · Rajendra Nayak
Add an optional power domain which when specified can be used for setting the performance state of Venus.
Signed-off-by Rajendra Nayak <[email protected]>--- Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++- Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml +2
-1@@ -25,12 +25,16 @@ properties: maxItems: 1 power-domains: - maxItems: 2 + minItems: 2 + maxItems: 3
Quoted 9 lines
Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml properties: · line 37
Quoted 7 lines
Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml +3
-0power-domain-names: + minItems: 2 + maxItems: 3 items: - const: venus - const: vcodec0 + - const: opp-pdHumm, looks suspicious. This is a phyical power island in this block?
yes, this is used to represent the physical 'cx' power island in the SoC (Its a shared power island, not a power island specific to this block) that can be scaled to different 'performance levels' based on the frequency the codec is expected to run at.
Quoted 5 lines
Because that's what 'power-domains' are supposed to represent. Not $os pm-domain construct.
Rob
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quoted 32 lines · Rajendra Nayak
Quoted 21 lines · Rob Herring
Quoted 20 lines · Rajendra Nayak
Add an optional power domain which when specified can be used for setting the performance state of Venus.
Signed-off-by Rajendra Nayak <[email protected]>---
Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++-Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml| 6 +++++-2 files changed, 10 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml +0
-0@@ -25,12 +25,16 @@ properties:maxItems: 1
power-domains:
- maxItems: 2
+ minItems: 2
+ maxItems: 3
power-domain-names:Quoted 8 lines
Quoted 6 lines
+ minItems: 2
+ maxItems: 3
items:
- const: venus
- const: vcodec0
+ - const: opp-pdHumm, looks suspicious. This is a phyical power island in this block?
Quoted 4 lines
yes, this is used to represent the physical 'cx' power island in the SoC (Its a shared power island, not a power island specific to this block) that can be scaled to different 'performance levels' based on the frequency the codec is expected to run at.
Rob, Did you have any other concerns here? Should I be re-posting this?
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quoted 34 lines · Rajendra Nayak
Quoted 32 lines · Rajendra Nayak
Quoted 29 lines · Rob Herring
Quoted 18 lines · Rajendra Nayak
Add an optional power domain which when specified can be used for setting the performance state of Venus.
Signed-off-by Rajendra Nayak <[email protected]>---
Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++-Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml| 6 +++++-2 files changed, 10 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml +0
-0@@ -25,12 +25,16 @@ properties:maxItems: 1
power-domains:
- maxItems: 2
+ minItems: 2Quoted 8 lines
+ maxItems: 3
power-domain-names:
+ minItems: 2
+ maxItems: 3
items:
- const: venus
- const: vcodec0
+ - const: opp-pdHumm, looks suspicious. This is a phyical power island in this block?
Quoted 6 lines
Quoted 4 lines
yes, this is used to represent the physical 'cx' power island in the SoC (Its a shared power island, not a power island specific to this block) that can be scaled to different 'performance levels' based on the frequency the codec is expected to run at.
Rob, Did you have any other concerns here? Should I be re-posting this?
Rob, ping.
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation