Skip to contentSkip to conversation

x86/kvm: Remove defunct KVM_DEBUG_FS Kconfig

PATCH Applied Sean Christopherson 2 participants 2 messages May 28, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/kvm: Remove defunct KVM_DEBUG_FS Kconfig

Remove KVM_DEBUG_FS, which can easily be misconstrued as controlling KVM-as-a-host. The sole user of CONFIG_KVM_DEBUG_FS was removed by commit cfd8983f03c7b ("x86, locking/spinlocks: Remove ticket (spin)lock implementation").

---
 arch/x86/Kconfig      | 8 --------
 arch/x86/kernel/kvm.c | 1 -
 2 files changed, 9 deletions(-)
arch/x86/Kconfig +0 -8
index 1197b5596d5ad..0ccf4e76acfe8 100644
@@ -818,14 +818,6 @@ config PVH
 	  This option enables the PVH entry point for guest virtual machines
 	  as specified in the x86/HVM direct boot ABI.
 
-config KVM_DEBUG_FS
-	bool "Enable debug information for KVM Guests in debugfs"
-	depends on KVM_GUEST && DEBUG_FS
-	---help---
-	  This option enables collection of various statistics for KVM guest.
-	  Statistics are displayed in debugfs filesystem. Enabling this option
-	  may incur significant overhead.
-
 config PARAVIRT_TIME_ACCOUNTING
 	bool "Paravirtual steal time accounting"
 	depends on PARAVIRT
arch/x86/kernel/kvm.c +0 -1
index 6efe0410fb728..89ba09228eaf5 100644
@@ -21,7 +21,6 @@
 #include <linux/sched.h>
 #include <linux/slab.h>
 #include <linux/kprobes.h>
-#include <linux/debugfs.h>
 #include <linux/nmi.h>
 #include <linux/swait.h>
 #include <asm/timer.h>
Signature · 1 line
2.26.0
maintainer Applied
#1 lore raw
Quoted 36 lines · Sean Christopherson

Remove KVM_DEBUG_FS, which can easily be misconstrued as controlling KVM-as-a-host. The sole user of CONFIG_KVM_DEBUG_FS was removed by commit cfd8983f03c7b ("x86, locking/spinlocks: Remove ticket (spin)lock implementation").

---
 arch/x86/Kconfig      | 8 --------
 arch/x86/kernel/kvm.c | 1 -
 2 files changed, 9 deletions(-)
arch/x86/Kconfig +0 -8
index 1197b5596d5ad..0ccf4e76acfe8 100644
@@ -818,14 +818,6 @@ config PVH
 	  This option enables the PVH entry point for guest virtual machines
 	  as specified in the x86/HVM direct boot ABI.
 
-config KVM_DEBUG_FS
-	bool "Enable debug information for KVM Guests in debugfs"
-	depends on KVM_GUEST && DEBUG_FS
-	---help---
-	  This option enables collection of various statistics for KVM guest.
-	  Statistics are displayed in debugfs filesystem. Enabling this option
-	  may incur significant overhead.
-
 config PARAVIRT_TIME_ACCOUNTING
 	bool "Paravirtual steal time accounting"
 	depends on PARAVIRT
arch/x86/kernel/kvm.c +0 -0
index 6efe0410fb728..89ba09228eaf5 100644

arch/x86/kernel/kvm.c line 26

Quoted 7 lines
arch/x86/kernel/kvm.c +0 -1
@@ -21,7 +21,6 @@
 #include <linux/sched.h>
 #include <linux/slab.h>
 #include <linux/kprobes.h>
-#include <linux/debugfs.h>
 #include <linux/nmi.h>
 #include <linux/swait.h>
 #include <asm/timer.h>

Queued, thanks.

Paolo