powerpc/bpf: Enable bpf_probe_read{, str}() on powerpc again
PATCH 1/1 powerpc/bpf: Enable bpf_probe_read{, str}() on powerpc again
The commit 0ebeea8ca8a4d1d453a ("bpf: Restrict bpf_probe_read{, str}() only to archs where they work") caused that bpf_probe_read{, str}() functions were not longer available on architectures where the same logical address might have different content in kernel and user memory mapping. These architectures should use probe_read_{user,kernel}_str helpers.
For backward compatibility, the problematic functions are still available on architectures where the user and kernel address spaces are not overlapping. This is defined CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE.
At the moment, these backward compatible functions are enabled only on x86_64, arm, and arm64. Let's do it also on powerpc that has the non overlapping address space as well.
To: Michael Ellerman <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Daniel Borkmann <[email protected]>
Cc: Alexei Starovoitov <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Cc: Brendan Gregg <[email protected]>
Cc: Christoph Hellwig <[email protected]>
--- arch/powerpc/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/powerpc/Kconfig +1 -0
@@ -126,6 +126,7 @@ config PPC select ARCH_HAS_MMIOWB if PPC64 select ARCH_HAS_PHYS_TO_DMA select ARCH_HAS_PMEM_API + select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE select ARCH_HAS_PTE_DEVMAP if PPC_BOOK3S_64 select ARCH_HAS_PTE_SPECIAL select ARCH_HAS_MEMBARRIER_CALLBACKS
Signature · 1 line
2.26.2
Michael Ellerman
reviewerQuoted 10 lines · Petr Mladek
The commit
0ebeea8ca8a4d1d453a("bpf: Restrict bpf_probe_read{, str}() only to archs where they work") caused that bpf_probe_read{, str}() functions were not longer available on architectures where the same logical address might have different content in kernel and user memory mapping. These architectures should use probe_read_{user,kernel}_str helpers.For backward compatibility, the problematic functions are still available on architectures where the user and kernel address spaces are not overlapping. This is defined
CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE.
Quoted 5 lines
At the moment, these backward compatible functions are enabled only on
x86_64, arm, and arm64. Let's do it also on powerpc that has the non overlapping address space as well.Signed-off-by Petr Mladek <[email protected]>
This seems like it should have a Fixes: tag and go into v5.7?
cheers
Quoted 14 lines
arch/powerpc/Kconfig +1
-0@@ -126,6 +126,7 @@ config PPC select ARCH_HAS_MMIOWB if PPC64 select ARCH_HAS_PHYS_TO_DMA select ARCH_HAS_PMEM_API + select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE select ARCH_HAS_PTE_DEVMAP if PPC_BOOK3S_64 select ARCH_HAS_PTE_SPECIAL select ARCH_HAS_MEMBARRIER_CALLBACKSSignature · 1 line
2.26.2
Quoted 11 lines · Michael Ellerman
Quoted 10 lines · Petr Mladek
The commit
0ebeea8ca8a4d1d453a("bpf: Restrict bpf_probe_read{, str}() only to archs where they work") caused that bpf_probe_read{, str}() functions were not longer available on architectures where the same logical address might have different content in kernel and user memory mapping. These architectures should use probe_read_{user,kernel}_str helpers.For backward compatibility, the problematic functions are still available on architectures where the user and kernel address spaces are not overlapping. This is defined
CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE.
Quoted 7 lines
Quoted 5 lines
At the moment, these backward compatible functions are enabled only on
x86_64, arm, and arm64. Let's do it also on powerpc that has the non overlapping address space as well.Signed-off-by Petr Mladek <[email protected]>This seems like it should have a Fixes: tag and go into v5.7?
Good point:
And yes, it should ideally go into v5.7 either directly or via stable.
Should I resend the patch with Fixes and
Cc: [email protected] #v45.7 lines, please?
Best Regards,
Petr
Quoted 20 lines · Petr Mladek
Quoted 11 lines · Michael Ellerman
Quoted 10 lines · Petr Mladek
The commit
0ebeea8ca8a4d1d453a("bpf: Restrict bpf_probe_read{, str}() only to archs where they work") caused that bpf_probe_read{, str}() functions were not longer available on architectures where the same logical address might have different content in kernel and user memory mapping. These architectures should use probe_read_{user,kernel}_str helpers.For backward compatibility, the problematic functions are still available on architectures where the user and kernel address spaces are not overlapping. This is defined
CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE.Quoted 7 lines
Quoted 5 lines
At the moment, these backward compatible functions are enabled only on
x86_64, arm, and arm64. Let's do it also on powerpc that has the non overlapping address space as well.Signed-off-by Petr Mladek <[email protected]>This seems like it should have a Fixes: tag and go into v5.7?
Quoted 8 lines
Good point:
Fixes commit 0ebeea8ca8a4d1d4 ("bpf: Restrict bpf_probe_read{, str}() only to archs where they work")And yes, it should ideally go into v5.7 either directly or via stable.
Should I resend the patch with Fixes and
Cc: [email protected] #v45.7 lines, please?
If it goes into v5.7 then it doesn't need a Cc: stable, and I guess a
Fixes: tag is nice to have but not so important as it already mentions the commit that caused the problem. So a resend probably isn't necessary.
Daniel can you pick this up, or should I?
cheers
Daniel Borkmann
maintainerQuoted 30 lines · Michael Ellerman
Quoted 20 lines · Petr Mladek
Quoted 11 lines · Michael Ellerman
Quoted 10 lines · Petr Mladek
The commit
0ebeea8ca8a4d1d453a("bpf: Restrict bpf_probe_read{, str}() only to archs where they work") caused that bpf_probe_read{, str}() functions were not longer available on architectures where the same logical address might have different content in kernel and user memory mapping. These architectures should use probe_read_{user,kernel}_str helpers.For backward compatibility, the problematic functions are still available on architectures where the user and kernel address spaces are not overlapping. This is defined
CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE.Quoted 7 lines
Quoted 5 lines
At the moment, these backward compatible functions are enabled only on
x86_64, arm, and arm64. Let's do it also on powerpc that has the non overlapping address space as well.Signed-off-by Petr Mladek <[email protected]>This seems like it should have a Fixes: tag and go into v5.7?
Quoted 8 lines
Good point:
Fixes commit 0ebeea8ca8a4d1d4 ("bpf: Restrict bpf_probe_read{, str}() only to archs where they work")And yes, it should ideally go into v5.7 either directly or via stable.
Should I resend the patch with Fixes and
Cc: [email protected] #v45.7 lines, please?
Quoted 8 lines
If it goes into v5.7 then it doesn't need a Cc: stable, and I guess a
Fixes: tag is nice to have but not so important as it already mentions the commit that caused the problem. So a resend probably isn't necessary.Acked-by Michael Ellerman <[email protected]>Daniel can you pick this up, or should I?
Yeah I'll take it into bpf tree for v5.7.
Thanks everyone,
Daniel
Michael Ellerman
reviewerQuoted 36 lines · Daniel Borkmann
Quoted 35 lines · Michael Ellerman
Quoted 20 lines · Petr Mladek
Quoted 11 lines · Michael Ellerman
Quoted 10 lines · Petr Mladek
The commit
0ebeea8ca8a4d1d453a("bpf: Restrict bpf_probe_read{, str}() only to archs where they work") caused that bpf_probe_read{, str}() functions were not longer available on architectures where the same logical address might have different content in kernel and user memory mapping. These architectures should use probe_read_{user,kernel}_str helpers.For backward compatibility, the problematic functions are still available on architectures where the user and kernel address spaces are not overlapping. This is defined
CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE.Quoted 7 lines
Quoted 5 lines
At the moment, these backward compatible functions are enabled only on
x86_64, arm, and arm64. Let's do it also on powerpc that has the non overlapping address space as well.Signed-off-by Petr Mladek <[email protected]>This seems like it should have a Fixes: tag and go into v5.7?
Quoted 8 lines
Good point:
Fixes commit 0ebeea8ca8a4d1d4 ("bpf: Restrict bpf_probe_read{, str}() only to archs where they work")And yes, it should ideally go into v5.7 either directly or via stable.
Should I resend the patch with Fixes and
Cc: [email protected] #v45.7 lines, please?If it goes into v5.7 then it doesn't need a Cc: stable, and I guess a
Fixes: tag is nice to have but not so important as it already mentions the commit that caused the problem. So a resend probably isn't necessary.
Quoted 5 lines
Quoted 3 lines
Acked-by Michael Ellerman <[email protected]>Daniel can you pick this up, or should I?
Yeah I'll take it into bpf tree for v5.7.
Thanks.
cheers