mm page_fault: Reduce code complexity
Subsystems (2)
PATCH 1/1 mm page_fault: Reduce code complexity
From: YangHui <[email protected]>
if pte_alloc_one failed alloc a page, do_fault_around will return 0. and it will come into __do_fault(), it also pte_alloc_one a page. in __do_fault and do_fault_around, pte_alloc_one did the same thing, if do_fault_around alloc page filed,we just let it return. there is no need to come into __do_fault to do repetitive pte_alloc_one.
--- mm/memory.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
mm/memory.c +3 -1
@@ -3799,8 +3799,10 @@ static vm_fault_t do_fault_around(struct vm_fault *vmf)if (pmd_none (*vmf->pmd)) { vmf->prealloc_pte =pte_alloc_one (vmf->vma->vm_mm); -if (!vmf->prealloc_pte) +if (!vmf->prealloc_pte) { + ret =VM_FAULT_OOM ; goto out; + }smp_wmb ();/* See comment in __pte_alloc() */ }
Signature · 1 line
2.7.4
Quoted 7 lines · hui yang
From: YangHui <[email protected]>
if
pte_alloc_onefailed alloc a page,do_fault_aroundwill return 0. and it will come into__do_fault(), it alsopte_alloc_onea page. in__do_faultanddo_fault_around,pte_alloc_onedid the same thing, ifdo_fault_aroundalloc page filed,we just let it return. there is no need to come into__do_faultto do repetitivepte_alloc_one.
This really isn't "Reduce code complexity" though. It's "Fail early when memory allocation fails". And, honestly, I don't see the point of doing this. You've optimised an incredibly rare failure path.