dt-bindings: Added device tree binding for max98390
Subsystems (2)
PATCH v6 1/2 dt-bindings: Added device tree binding for max98390
Add DT binding of max98390 amplifier driver.
---
Changed since V5:
* Change txt to yaml and fix up the examples.
Changed since V4:
* No changes.
Changed since V3:
* No changes.
Changed since V2:
* No changes.
Changed since V1:
* Modified sample text in example
.../bindings/sound/maxim,max98390.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/maxim,max98390.yaml
Documentation/devicetree/bindings/sound/maxim,max98390.yaml new file +39 -0
@@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/maxim,max98390.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim Integrated MAX98390 Speaker Amplifier with Integrated Dynamic Speaker Management + +maintainers: + - Steve Lee <[email protected]> + +properties: + compatible: + const: maxim,max98390 + + reg: + maxItems: 1 + description: I2C address of the device. + + temperature_calib: + $ref: /schemas/types.yaml#/definitions/uint32 + description: The calculated temperature data was measured while doing the calibration. Data : Temp / 100 * 2^12 + + r0_calib: + $ref: /schemas/types.yaml#/definitions/uint32 + description: This is r0 calibration data which was measured in factory mode. + +required: + - compatible + - reg + +examples: + - | + max98390: amplifier@38 { + compatible = "maxim,max98390"; + reg = <0x38>; + maxim,temperature_calib = <1024>; + maxim,r0_calib = <100232>; + };
Signature · 1 line
2.17.1
Rob Herring
maintainerQuoted 15 lines · Steve Lee
Add DT binding of max98390 amplifier driver.
Signed-off-by Steve Lee <[email protected]>---
Changed since V5:
* Change txt to yaml and fix up the examples.
Changed since V4:
* No changes.
Changed since V3:
* No changes.
Changed since V2:
* No changes.
Changed since V1:
* Modified sample text in example
Quoted 4 lines
.../bindings/sound/maxim,max98390.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/maxim,max98390.yaml
My bot found errors running 'make dt_binding_check' on your patch:
Documentation/devicetree/bindings/sound/maxim,max98390.yaml: mapping values are not allowed in this context
in "<unicode string>", line 22, column 97Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/sound/maxim,max98390.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/sound/maxim,max98390.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs.... /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/maxim,max98390.yaml: ignoring, error parsing file
warning: no schema found in file: ./Documentation/devicetree/bindings/sound/maxim,max98390.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/maxim,max98390.yaml: ignoring, error parsing file
warning: no schema found in file: ./Documentation/devicetree/bindings/sound/maxim,max98390.yaml
Makefile:1300: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1299651
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
Quoted 37 lines · Rob Herring
Quoted 15 lines · Steve Lee
Add DT binding of max98390 amplifier driver.
Signed-off-by Steve Lee <[email protected]>---
Changed since V5:
* Change txt to yaml and fix up the examples.
Changed since V4:
* No changes.
Changed since V3:
* No changes.
Changed since V2:
* No changes.
Changed since V1:
* Modified sample text in exampleQuoted 4 lines
.../bindings/sound/maxim,max98390.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/maxim,max98390.yamlMy bot found errors running 'make
dt_binding_check' on your patch:
Documentation/devicetree/bindings/sound/maxim,max98390.yaml: mapping values are not allowed in this context
in "<unicode string>", line 22, column 97Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/sound/maxim,max98390.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/sound/maxim,max98390.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs.... /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/maxim,max98390.yaml: ignoring, error parsing file
warning: no schema found in file:./Documentation/devicetree/bindings/sound/maxim,max98390.yaml/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/maxim,max98390.yaml: ignoring, error parsing file
warning: no schema found in file:./Documentation/devicetree/bindings/sound/maxim,max98390.yaml
Makefile:1300: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2
Quoted 9 lines
See https://patchwork.ozlabs.org/patch/1299651
If you already ran 'make
dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date:pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
Thanks for feedback. I re-submit with after dt binding check again.
Rob Herring
maintainerQuoted 35 lines · Steve Lee
Add DT binding of max98390 amplifier driver.
Signed-off-by Steve Lee <[email protected]>---
Changed since V5:
* Change txt to yaml and fix up the examples.
Changed since V4:
* No changes.
Changed since V3:
* No changes.
Changed since V2:
* No changes.
Changed since V1:
* Modified sample text in example.../bindings/sound/maxim,max98390.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/maxim,max98390.yamlDocumentation/devicetree/bindings/sound/maxim,max98390.yaml new file +10
-0@@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/maxim,max98390.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim Integrated MAX98390 Speaker Amplifier with Integrated Dynamic Speaker Management + +maintainers: + - Steve Lee <[email protected]>
Documentation/devicetree/bindings/sound/maxim,max98390.yaml line 20
Quoted 10 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml new file +10
-0+ +properties: + compatible: + const: maxim,max98390 + + reg: + maxItems: 1 + description: I2C address of the device. + + temperature_calib:
s/_/-/
And missing 'maxim' prefix.
Documentation/devicetree/bindings/sound/maxim,max98390.yaml line 22
Quoted 2 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml new file +2
-0+ $ref: /schemas/types.yaml#/definitions/uint32 + description: The calculated temperature data was measured while doing the calibration. Data : Temp / 100 * 2^12
Any constraints? 0-2^32 are valid values?
Documentation/devicetree/bindings/sound/maxim,max98390.yaml line 24
Quoted 2 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml new file +2
-0+ + r0_calib:
Same here.
Documentation/devicetree/bindings/sound/maxim,max98390.yaml line 30
Quoted 6 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml new file +6
-0+ $ref: /schemas/types.yaml#/definitions/uint32 + description: This is r0 calibration data which was measured in factory mode. + +required: + - compatible + - reg
Add:
additionalProperties: false
Quoted 12 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml new file +9
-0+ +examples: + - | + max98390: amplifier@38 { + compatible = "maxim,max98390"; + reg = <0x38>; + maxim,temperature_calib = <1024>; + maxim,r0_calib = <100232>; + };Signature · 1 line
2.17.1
Quoted 41 lines · Rob Herring
Quoted 39 lines · Steve Lee
Add DT binding of max98390 amplifier driver.
Signed-off-by Steve Lee <[email protected]>---
Changed since V5:
* Change txt to yaml and fix up the examples.
Changed since V4:
* No changes.
Changed since V3:
* No changes.
Changed since V2:
* No changes.
Changed since V1:
* Modified sample text in example.../bindings/sound/maxim,max98390.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/maxim,max98390.yamlDocumentation/devicetree/bindings/sound/maxim,max98390.yaml new file +14
-0@@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/maxim,max98390.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim Integrated MAX98390 Speaker Amplifier with Integrated Dynamic Speaker Management + +maintainers: + - Steve Lee <[email protected]> + +properties: + compatible: + const: maxim,max98390
Quoted 8 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml line 20
Quoted 6 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml new file +6
-0+ + reg: + maxItems: 1 + description: I2C address of the device. + + temperature_calib:s/_/-/
This is follow as coreboot in Chromium OS case.
I'd follow this name unchanged.
Quoted 2 lines
And missing 'maxim' prefix.
Added missed prefix maxim prefix.
Quoted 5 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml line 22
Quoted 3 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml new file +2
-0+ $ref: /schemas/types.yaml#/definitions/uint32 + description: The calculated temperature data was measured while doing the calibration. Data : Temp / 100 * 2^12Any constraints? 0-2^32 are valid values?
I added range of the values
Quoted 5 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml line 24
Quoted 3 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml new file +2
-0+ + r0_calib:Same here.
I added range of the values.
Quoted 11 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml line 30
Quoted 7 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml new file +6
-0+ $ref: /schemas/types.yaml#/definitions/uint32 + description: This is r0 calibration data which was measured in factory mode. + +required: + - compatible + - regAdd:
additionalProperties: false
I have added this.
Quoted 13 lines
Quoted 13 lines
Documentation/devicetree/bindings/sound/maxim,max98390.yaml new file +9
-1+ +examples: + - | + max98390: amplifier@38 { + compatible = "maxim,max98390"; + reg = <0x38>; + maxim,temperature_calib = <1024>; + maxim,r0_calib = <100232>; + }; --2.17.1