perf record: Respect --no-switch-events
Adrian Hunter
reviewerPATCH 1/2 perf record: Respect --no-switch-events
Context switch events are added automatically by Intel PT and Coresight. Make it possible to suppress them. That is useful for tracing the scheduler without the disturbance that the switch event processing creates.
Example:
Prerequisites:
$ which perf
~/bin/perf
$ sudo setcap "cap_sys_rawio,cap_sys_admin,cap_sys_ptrace,cap_syslog,cap_ipc_lock=ep" ~/bin/perf
$ sudo chmod +r /proc/kcoreBefore:
$ perf record --no-switch-events --kcore -a -e intel_pt//k -- sleep 0.001
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.938 MB perf.data ]
$ perf script -D | grep PERF_RECORD_SWITCH | wc -l
572After:
$ perf record --no-switch-events --kcore -a -e intel_pt//k -- sleep 0.001
Warning:
Intel Processor Trace decoding will not be possible except for kernel tracing!
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.838 MB perf.data ]
$ perf script -D | grep PERF_RECORD_SWITCH | wc -l
0 $ sudo chmod go-r /proc/kcore
$ sudo setcap -r ~/bin/perf--- tools/perf/Documentation/perf-record.txt | 4 +++- tools/perf/arch/arm/util/cs-etm.c | 3 ++- tools/perf/arch/x86/util/intel-pt.c | 3 ++- tools/perf/builtin-record.c | 5 +++-- tools/perf/util/record.h | 6 ++++++ 5 files changed, 16 insertions(+), 5 deletions(-)
tools/perf/Documentation/perf-record.txt +3 -1
@@ -458,7 +458,9 @@ This option sets the time out limit. The default value is 500 ms. --switch-events:: Record context switch events i.e. events of type PERF_RECORD_SWITCH or -PERF_RECORD_SWITCH_CPU_WIDE. +PERF_RECORD_SWITCH_CPU_WIDE. In some cases (e.g. Intel PT or CoreSight) +switch events will be enabled automatically, which can be suppressed by +by the option --no-switch-events. --clang-path=PATH:: Path to clang binary to use for compiling BPF scriptlets.
tools/perf/arch/arm/util/cs-etm.c +2 -1
@@ -265,7 +265,8 @@ static int cs_etm_recording_options(struct auxtrace_record *itr, ptr->evlist = evlist; ptr->snapshot_mode = opts->auxtrace_snapshot_mode; -if (perf_can_record_switch_events ()) +if (!record_opts__no_switch_events (opts) && +perf_can_record_switch_events ()) opts->record_switch_events = true;evlist__for_each_entry (evlist, evsel) {
tools/perf/arch/x86/util/intel-pt.c +2 -1
@@ -779,7 +779,8 @@ static int intel_pt_recording_options(struct auxtrace_record *itr,* Per-cpu recording needs sched_switch events to distinguish different * threads. */ -if (have_timing_info && !perf_cpu_map__empty (cpus)) { +if (have_timing_info && !perf_cpu_map__empty (cpus) && + !record_opts__no_switch_events (opts)) {if (perf_can_record_switch_events ()) {bool cpu_wide = !target__none (&opts->target) && !target__has_task (&opts->target);
tools/perf/builtin-record.c +3 -2
@@ -2490,8 +2490,9 @@ static struct option __record_options[] = { "Record namespaces events"),OPT_BOOLEAN (0 ,"all-cgroups" , &record.opts.record_cgroup,"Record cgroup events" ), -OPT_BOOLEAN (0 ,"switch-events" , &record.opts.record_switch_events, -"Record context switch events" ), +OPT_BOOLEAN_SET (0 ,"switch-events" , &record.opts.record_switch_events, + &record.opts.record_switch_events_set, +"Record context switch events" ),OPT_BOOLEAN_FLAG (0 ,"all-kernel" , &record.opts.all_kernel,"Configure all used events to run in kernel space." , PARSE_OPT_EXCLUSIVE),
tools/perf/util/record.h +6 -0
@@ -36,6 +36,7 @@ struct record_opts {bool record_namespaces;bool record_cgroup;bool record_switch_events; +bool record_switch_events_set;bool all_kernel;bool all_user;bool kernel_callchains;
@@ -77,4 +78,9 @@ extern struct option *record_options;int record__parse_freq (const struct option *opt,const char *str,int unset); +static inline bool record_opts__no_switch_events (const struct record_opts *opts) +{ +return opts->record_switch_events_set && !opts->record_switch_events; +} +#endif // _PERF_RECORD_H
Signature · 1 line
2.17.1
Adrian Hunter
reviewerPATCH 2/2 perf intel-pt: Refine kernel decoding only warning message
Stop the message displaying when user space is not being traced.
Example:
Prerequisites:
sudo setcap "cap_sys_rawio,cap_sys_admin,cap_sys_ptrace,cap_syslog,cap_ipc_lock=ep" ~/bin/perf sudo chmod +r /proc/kcore
Before:
$ perf record --no-switch-events --kcore -a -e intel_pt//k -- sleep 0.001
Warning:
Intel Processor Trace decoding will not be possible except for kernel tracing!
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.838 MB perf.data ]After:
$ perf record --no-switch-events --kcore -a -e intel_pt//k -- sleep 0.001
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 1.068 MB perf.data ] $ sudo chmod go-r /proc/kcore
$ sudo setcap -r ~/bin/perf--- tools/perf/arch/x86/util/intel-pt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/arch/x86/util/intel-pt.c +2 -1
@@ -879,7 +879,8 @@ static int intel_pt_recording_options(struct auxtrace_record *itr,* per-cpu with no sched_switch (except workload-only). */ if (!ptr->have_sched_switch && !perf_cpu_map__empty (cpus) && - !target__none (&opts->target)) + !target__none (&opts->target) && + !intel_pt_evsel->core.attr.exclude_user)ui__warning ("Intel Processor Trace decoding will not be possible except for kernel tracing!\n" );return 0 ;
Signature · 1 line
2.17.1
Arnaldo Carvalho de Melo
maintainerRe: [PATCH 2/2] perf intel-pt: Refine kernel decoding only warning message
Em Thu, May 28, 2020 at 03:08:59PM +0300, Adrian Hunter escreveu:
Quoted 17 lines
Stop the message displaying when user space is not being traced.
Example:
Prerequisites:
sudo setcap "cap_sys_rawio,cap_sys_admin,cap_sys_ptrace,cap_syslog,cap_ipc_lock=ep" ~/bin/perf sudo chmod +r
/proc/kcoreBefore:
$ perf record --no-switch-events --kcore -a -e intel_pt//k -- sleep 0.001 Warning: Intel Processor Trace decoding will not be possible except for kernel tracing! [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.838 MB perf.data ]
Quoted 8 lines
After:
$ perf record --no-switch-events --kcore -a -e intel_pt//k -- sleep 0.001 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 1.068 MB perf.data ]$ sudo chmod go-r /proc/kcore $ sudo setcap -r ~/bin/perf
Thanks, tested as root and applied.
- Arnaldo
Quoted 22 lines
Signed-off-by Adrian Hunter <[email protected]>--- tools/perf/arch/x86/util/intel-pt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)tools/perf/arch/x86/util/intel-pt.c +2
-1@@ -879,7 +879,8 @@ static int intel_pt_recording_options(struct auxtrace_record *itr,* per-cpu with no sched_switch (except workload-only). */ if (!ptr->have_sched_switch && !perf_cpu_map__empty (cpus) && - !target__none (&opts->target)) + !target__none (&opts->target) && + !intel_pt_evsel->core.attr.exclude_user)ui__warning ("Intel Processor Trace decoding will not be possible except for kernel tracing!\n" );return 0 ;Signature · 1 line
2.17.1
Signature · 1 line
- Arnaldo
Arnaldo Carvalho de Melo
maintainerEm Thu, May 28, 2020 at 03:08:58PM +0300, Adrian Hunter escreveu:
Quoted 32 lines
Context switch events are added automatically by Intel PT and Coresight. Make it possible to suppress them. That is useful for tracing the scheduler without the disturbance that the switch event processing creates.
Example:
Prerequisites:
$ which perf ~/bin/perf $ sudo setcap "cap_sys_rawio,cap_sys_admin,cap_sys_ptrace,cap_syslog,cap_ipc_lock=ep" ~/bin/perf $ sudo chmod +r /proc/kcoreBefore:
$ perf record --no-switch-events --kcore -a -e intel_pt//k -- sleep 0.001 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.938 MB perf.data ] $ perf script -D | grep PERF_RECORD_SWITCH | wc -l 572After:
$ perf record --no-switch-events --kcore -a -e intel_pt//k -- sleep 0.001 Warning: Intel Processor Trace decoding will not be possible except for kernel tracing! [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.838 MB perf.data ] $ perf script -D | grep PERF_RECORD_SWITCH | wc -l 0
Quoted 2 lines
$ sudo chmod go-r /proc/kcore
$ sudo setcap -r ~/bin/perfThanks, tested as root and applied.
- Arnaldo
Quoted 93 lines
Signed-off-by Adrian Hunter <[email protected]>--- tools/perf/Documentation/perf-record.txt | 4 +++- tools/perf/arch/arm/util/cs-etm.c | 3 ++- tools/perf/arch/x86/util/intel-pt.c | 3 ++- tools/perf/builtin-record.c | 5 +++-- tools/perf/util/record.h | 6 ++++++ 5 files changed, 16 insertions(+), 5 deletions(-)tools/perf/Documentation/perf-record.txt +3
-1@@ -458,7 +458,9 @@ This option sets the time out limit. The default value is 500 ms. --switch-events:: Record context switch events i.e. events of type PERF_RECORD_SWITCH or -PERF_RECORD_SWITCH_CPU_WIDE. +PERF_RECORD_SWITCH_CPU_WIDE. In some cases (e.g. Intel PT or CoreSight) +switch events will be enabled automatically, which can be suppressed by +by the option --no-switch-events. --clang-path=PATH:: Path to clang binary to use for compiling BPF scriptlets.tools/perf/arch/arm/util/cs-etm.c +2
-1@@ -265,7 +265,8 @@ static int cs_etm_recording_options(struct auxtrace_record *itr, ptr->evlist = evlist; ptr->snapshot_mode = opts->auxtrace_snapshot_mode; -if (perf_can_record_switch_events ()) +if (!record_opts__no_switch_events (opts) && +perf_can_record_switch_events ()) opts->record_switch_events = true;evlist__for_each_entry (evlist, evsel) {tools/perf/arch/x86/util/intel-pt.c +2
-1@@ -779,7 +779,8 @@ static int intel_pt_recording_options(struct auxtrace_record *itr,* Per-cpu recording needs sched_switch events to distinguish different * threads. */ -if (have_timing_info && !perf_cpu_map__empty (cpus)) { +if (have_timing_info && !perf_cpu_map__empty (cpus) && + !record_opts__no_switch_events (opts)) {if (perf_can_record_switch_events ()) {bool cpu_wide = !target__none (&opts->target) && !target__has_task (&opts->target);tools/perf/builtin-record.c +3
-2@@ -2490,8 +2490,9 @@ static struct option __record_options[] = { "Record namespaces events"),OPT_BOOLEAN (0 ,"all-cgroups" , &record.opts.record_cgroup,"Record cgroup events" ), -OPT_BOOLEAN (0 ,"switch-events" , &record.opts.record_switch_events, -"Record context switch events" ), +OPT_BOOLEAN_SET (0 ,"switch-events" , &record.opts.record_switch_events, + &record.opts.record_switch_events_set, +"Record context switch events" ),OPT_BOOLEAN_FLAG (0 ,"all-kernel" , &record.opts.all_kernel,"Configure all used events to run in kernel space." , PARSE_OPT_EXCLUSIVE),tools/perf/util/record.h +6
-0@@ -36,6 +36,7 @@ struct record_opts {bool record_namespaces;bool record_cgroup;bool record_switch_events; +bool record_switch_events_set;bool all_kernel;bool all_user;bool kernel_callchains;@@ -77,4 +78,9 @@ extern struct option *record_options;int record__parse_freq (const struct option *opt,const char *str,int unset); +static inline bool record_opts__no_switch_events (const struct record_opts *opts) +{ +return opts->record_switch_events_set && !opts->record_switch_events; +} +#endif // _PERF_RECORD_H Signature · 1 line
2.17.1
Signature · 1 line
- Arnaldo