libxl: stop libxl_domain_info() consuming massive amounts of stack
PATCH v2 1/1 libxl: stop libxl_domain_info() consuming massive amounts of stack
From: Paul Durrant <[email protected]>
Currently an array of 1024 xc_domaininfo_t is declared on stack. That alone consumes ~112k. Since libxl_domain_info() creates a new gc this patch simply uses it to allocate the array instead.
---
Cc: Ian Jackson <[email protected]>
Cc: Wei Liu <[email protected]>
Cc: Anthony PERARD <[email protected]>
This is small and IMO it would be nice to have this in 4.14 but I'd like an opinion from a maintainer too.
v2:
- Use GCNEW_ARRAY
--- tools/libxl/libxl_domain.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/libxl/libxl_domain.c +3 -1
@@ -314,11 +314,13 @@ libxl_dominfo * libxl_list_domain(libxl_ctx *ctx, int *nb_domain_out) {libxl_dominfo *ptr =NULL ;int i, ret; -xc_domaininfo_t info[1024 ]; +xc_domaininfo_t *info;int size =0 ;uint32_t domid =0 ;GC_INIT (ctx); +GCNEW_ARRAY (info,1024 ); +while ((ret =xc_domain_getinfolist (ctx->xch, domid,1024 , info)) >0 ) { ptr =libxl__realloc (NOGC , ptr, (size + ret) *sizeof (libxl_dominfo));for (i =0 ; i < ret; i++) {
Signature · 1 line
2.17.1
Paul Durrant writes ("[PATCH v2] libxl: stop libxl_domain_info() consuming massive amounts of stack"):
Quoted 6 lines
From: Paul Durrant <[email protected]>
Currently an array of 1024
xc_domaininfo_tis declared on stack. That alone consumes ~112k. Sincelibxl_domain_info()creates a new gc this patch simply uses it to allocate the array instead.
Quoted 8 lines
Signed-off-by Paul Durrant <[email protected]>---
Cc: Ian Jackson <[email protected]>
Cc: Wei Liu <[email protected]>
Cc: Anthony PERARD <[email protected]>This is small and IMO it would be nice to have this in 4.14 but I'd like an opinion from a maintainer too.
I agree that this is 4.14 material.
Ian.