Skip to contentSkip to conversation

gloox: new package

PATCH New Yair Ben-Avraham 2 participants 2 messages May 19, 2020 – May 28, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 gloox: new package

gloox is a rock-solid, full-featured Jabber/XMPP client library, written in clean ANSI C++. It makes writing spec-compliant clients easy and allows for hassle-free integration of Jabber/XMPP functionality into existing applications. gloox is released under the GNU GPLv3. Commercial licensing and support are available.

---
 package/Config.in        |  1 +
 package/gloox/Config.in  | 16 ++++++++++++++
 package/gloox/gloox.hash |  3 +++
 package/gloox/gloox.mk   | 47 ++++++++++++++++++++++++++++++++++++++++
 4 files changed, 67 insertions(+)
 create mode 100644 package/gloox/Config.in
 create mode 100644 package/gloox/gloox.hash
 create mode 100644 package/gloox/gloox.mk
package/Config.in +1 -0
index c245abbc42..637e6cbb6a 100644
@@ -2039,6 +2039,7 @@ menu "Networking applications"
 	source "package/freeswitch-mod-bcg729/Config.in"
 	source "package/gerbera/Config.in"
 	source "package/gesftpserver/Config.in"
+	source "package/gloox/Config.in"
 	source "package/glorytun/Config.in"
 	source "package/gupnp-tools/Config.in"
 	source "package/gutenprint/Config.in"
package/gloox/Config.in new file +16 -0
new file mode 100644
index 0000000000..91e9f06e34
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_GLOOX
+	bool "gloox"
+	depends on BR2_INSTALL_LIBSTDCPP
+	select BR2_PACKAGE_MPC
+	help
+	  gloox is a portable high-level Jabber/XMPP library for C++. It
+	  is fully compliant with the XMPP RFCs, supports all of the
+	  XMPP features (including SRV lookups, TLS, SASL, roster
+	  management, and privacy lists), and implements several XEPs
+	  that make it ideal for writing any kind of Jabber/XMPP client
+	  or component.
+
+	  https://camaya.net/gloox/
+
+comment "gloox needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/gloox/gloox.hash new file +3 -0
new file mode 100644
index 0000000000..ee42c079b2
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256  97cb6a0c07e320ffa4a7c66e8ab06b2361086271dc87ed2398befef4e8435f8a  gloox-1.0.23.tar.bz2
+sha256  40a20c41c8dabb8ba61bea983fa8f2f6989e67fac56bb62c2249053807fd26af  LICENSE
package/gloox/gloox.mk new file +47 -0

47 lines not on this page · raw message

--
2.20.1

#1 lore raw

PATCH v3 1/1 gloox: new package

Hello Yair,

Quoted 7 lines · On Tue, 19 May 2020 08:26:30 +0000 Yair Ben-Avraham <[email protected]>…

gloox is a rock-solid, full-featured Jabber/XMPP client library, written in clean ANSI C++. It makes writing spec-compliant clients easy and allows for hassle-free integration of Jabber/XMPP functionality into existing applications. gloox is released under the GNU GPLv3. Commercial licensing and support are available.

I've applied your patch to our next branch, but after fixing a few things. See below.

Quoted 6 lines
---
 package/Config.in        |  1 +
 package/gloox/Config.in  | 16 ++++++++++++++
 package/gloox/gloox.hash |  3 +++
 package/gloox/gloox.mk   | 47 ++++++++++++++++++++++++++++++++++++++++
 4 files changed, 67 insertions(+)

Your forgot to add an entry to the DEVELOPERS file, so I've done so.

Quoted 10 lines
package/gloox/gloox.mk new file +4 -0
new file mode 100644
index 0000000000..a7df492566
@@ -0,0 +1,47 @@
+################################################################################
+#
+# gloox
+#

package/gloox/gloox.mk line 14

Quoted 10 lines
package/gloox/gloox.mk new file +10 -0
+################################################################################
+
+GLOOX_VERSION = 1.0.23
+GLOOX_SOURCE = gloox-$(GLOOX_VERSION).tar.bz2
+GLOOX_SITE = https://camaya.net/download
+GLOOX_LICENSE = GPL-3.0 with OpenSSL exception
+GLOOX_LICENSE_FILES = LICENSE
+GLOOX_INSTALL_STAGING = YES
+
+GLOOX_DEPENDENCIES += mpc

No need for += here, = is fine as it's an unconditional dependency.

package/gloox/gloox.mk line 20

Quoted 5 lines
package/gloox/gloox.mk new file +5 -0
+GLOOX_CXXFLAGS = $(TARGET_CXXFLAGS)
+
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+GLOOX_CXXFLAGS += -O0
+endif

This GLOOX_CXXFLAGS variable was not used anywhere. In a previous iteration, you correctly had:

GLOOX_CONF_ENV += CXXFLAGS="$(GLOOX_CFLAGS)"

So I've re-added that.

Quoted 15 lines
package/gloox/gloox.mk new file +15 -0
+
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+GLOOX_CONF_ENV += LIBS=-latomic
+endif
+
+ifeq ($(BR2_PACKAGE_ZLIB),y)
+GLOOX_CONF_OPTS += --with-zlib
+GLOOX_DEPENDENCIES += zlib
+else
+GLOOX_CONF_OPTS += --without-zlib
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+GLOOX_CONF_OPTS += --with-openssl --without-gnutls
+GLOOX_DEPENDENCIES += openssl

package/gloox/gloox.mk line 45

Quoted 10 lines
package/gloox/gloox.mk new file +10 -0
+else ifeq ($(BR2_PACKAGE_GNUTLS),y)
+GLOOX_CONF_OPTS += --with-gnutls --without-openssl
+GLOOX_DEPENDENCIES += gnutls
+else
+GLOOX_CONF_OPTS += --without-gnutls --without-openssl
+endif
+
+GLOOX_CONF_OPTS += \
+	--without-libidn \
+	--enable-getaddrinfo

No need for += here as well, and I've moved this up, together with the unconditional definitions earlier in the file.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com