Skip to contentSkip to conversation

powerpc: Fix misleading small cores print

PATCH Applied Michael Neuling 3 participants 3 messages May 28, 2020 – Jun 9, 2020 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: Fix misleading small cores print

Currently when we boot on a big core system, we get this print:

  [    0.040500] Using small cores at SMT level

This is misleading as we've actually detected big cores.

This patch clears up the print to say we've detect big cores but are using small cores for scheduling.

---
 arch/powerpc/kernel/smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kernel/smp.c +1 -1
index 6d2a3a3666..c820c95162 100644
@@ -1383,7 +1383,7 @@ void __init smp_cpus_done(unsigned int max_cpus)
 
 #ifdef CONFIG_SCHED_SMT
 	if (has_big_cores) {
-		pr_info("Using small cores at SMT level\n");
+		pr_info("Big cores detected but using small core scheduling\n");
 		power9_topology[0].mask = smallcore_smt_mask;
 		powerpc_topology[0].mask = smallcore_smt_mask;
 	}
Signature · 1 line
2.26.2
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Michael Neuling

Currently when we boot on a big core system, we get this print:

  [    0.040500] Using small cores at SMT level

This is misleading as we've actually detected big cores.

This patch clears up the print to say we've detect big cores but are using small cores for scheduling.

Thanks for making the print more meaningful.

Quoted 2 lines

FWIW,

Quoted 20 lines
---
 arch/powerpc/kernel/smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kernel/smp.c +1 -1
index 6d2a3a3666..c820c95162 100644
@@ -1383,7 +1383,7 @@ void __init smp_cpus_done(unsigned int max_cpus)
 
 #ifdef CONFIG_SCHED_SMT
 	if (has_big_cores) {
-		pr_info("Using small cores at SMT level\n");
+		pr_info("Big cores detected but using small core scheduling\n");
 		power9_topology[0].mask = smallcore_smt_mask;
 		powerpc_topology[0].mask = smallcore_smt_mask;
 	}
Signature · 1 line
2.26.2
#2 lore raw
In reply to Michael Neuling
Quoted 7 lines · Michael Neuling

Currently when we boot on a big core system, we get this print:

  [    0.040500] Using small cores at SMT level

This is misleading as we've actually detected big cores.

This patch clears up the print to say we've detect big cores but are using small cores for scheduling.

Applied to powerpc/next.

[1/1] powerpc: Fix misleading small cores print

      https://git.kernel.org/powerpc/c/82a7cebdd95cffa55449d6c1d97cc9b743a66056

cheers