net: phy: marvell: unlock after phy_select_page() failure
Subsystems (4)
PATCH 1/1 net: phy: marvell: unlock after phy_select_page() failure
We need to call phy_restore_page() even if phy_select_page() fails. Otherwise we are holding the phy_lock_mdio_bus() lock. This requirement is documented at the start of the phy_select_page() function.
--- drivers/net/phy/marvell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/phy/marvell.c +1 -1
@@ -1867,7 +1867,7 @@ static int marvell_vct5_amplitude_graph(struct phy_device *phydev)*/ page =phy_select_page (phydev,MII_MARVELL_VCT5_PAGE );if (page <0 ) -return page; + goto restore_page; for (distance = priv->first; distance <= priv->last;
Signature · 1 line
2.26.2
Quoted 6 lines · Dan Carpenter
We need to call
phy_restore_page()even ifphy_select_page()fails. Otherwise we are holding thephy_lock_mdio_bus()lock. This requirement is documented at the start of thephy_select_page()function.Fixes a618e86da91d ("net : phy: marvell: Speedup TDR data retrieval by only changing page once")Signed-off-by Dan Carpenter <[email protected]>
Andrew
From: Dan Carpenter <[email protected]>
Date: Fri, 29 May 2020 13:02:07 +0300
Quoted 6 lines
We need to call
phy_restore_page()even ifphy_select_page()fails. Otherwise we are holding thephy_lock_mdio_bus()lock. This requirement is documented at the start of thephy_select_page()function.Fixes a618e86da91d ("net : phy: marvell: Speedup TDR data retrieval by only changing page once")Signed-off-by Dan Carpenter <[email protected]>
Applied, thanks.