mwifiex: Parse all API_VER_ID properties
Subsystems (3)
PATCH 1/1 mwifiex: Parse all API_VER_ID properties
During initialization of SD8997 wifi chip kernel prints warnings:
mwifiex_sdio mmc0:0001:1: Unknown api_id: 3
mwifiex_sdio mmc0:0001:1: Unknown api_id: 4
This patch adds support for parsing all api ids provided by SD8997 firmware.
--- drivers/net/wireless/marvell/mwifiex/cmdevt.c | 17 +++++++++++++++-- drivers/net/wireless/marvell/mwifiex/fw.h | 2 ++ 2 files changed, 17 insertions(+), 2 deletions(-)
drivers/net/wireless/marvell/mwifiex/cmdevt.c +15 -2
@@ -1581,8 +1581,21 @@ int mwifiex_ret_get_hw_spec(struct mwifiex_private *priv, adapter->fw_api_ver = api_rev->major_ver;mwifiex_dbg (adapter,INFO , -"Firmware api version %d\n" , - adapter->fw_api_ver); +"Firmware api version %d.%d\n" , + adapter->fw_api_ver, + api_rev->minor_ver); +break ; +case UAP_FW_API_VER_ID : +mwifiex_dbg (adapter,INFO , +"uAP api version %d.%d\n" , + api_rev->major_ver, + api_rev->minor_ver); +break ; +case CHANRPT_API_VER_ID : +mwifiex_dbg (adapter,INFO , +"channel report api version %d.%d\n" , + api_rev->major_ver, + api_rev->minor_ver);break ;default : mwifiex_dbg(adapter, FATAL,
drivers/net/wireless/marvell/mwifiex/fw.h +2 -0
@@ -1052,6 +1052,8 @@ struct host_cmd_ds_802_11_ps_mode_enh {enum API_VER_ID {KEY_API_VER_ID =1 ,FW_API_VER_ID =2 , +UAP_FW_API_VER_ID =3 , +CHANRPT_API_VER_ID =4 , };struct hw_spec_api_rev {
Signature · 1 line
2.20.1
Quoted 5 lines · On Thursday 21 May 2020 14:34:44 Pali Rohár wrote:
During initialization of SD8997 wifi chip kernel prints warnings:
mwifiex_sdiommc0:0001:1: Unknownapi_id: 3
mwifiex_sdiommc0:0001:1: Unknownapi_id: 4
Quoted 9 lines
This patch adds support for parsing all api ids provided by SD8997 firmware.
Signed-off-by Pali Rohár <[email protected]>--- drivers/net/wireless/marvell/mwifiex/cmdevt.c | 17 +++++++++++++++-- drivers/net/wireless/marvell/mwifiex/fw.h | 2 ++ 2 files changed, 17 insertions(+), 2 deletions(-)
Hello! Could you please look at this trivial patch?
Quoted 44 lines
drivers/net/wireless/marvell/mwifiex/cmdevt.c +15
-2@@ -1581,8 +1581,21 @@ int mwifiex_ret_get_hw_spec(struct mwifiex_private *priv, adapter->fw_api_ver = api_rev->major_ver;mwifiex_dbg (adapter,INFO , -"Firmware api version %d\n" , - adapter->fw_api_ver); +"Firmware api version %d.%d\n" , + adapter->fw_api_ver, + api_rev->minor_ver); +break ; +case UAP_FW_API_VER_ID : +mwifiex_dbg (adapter,INFO , +"uAP api version %d.%d\n" , + api_rev->major_ver, + api_rev->minor_ver); +break ; +case CHANRPT_API_VER_ID : +mwifiex_dbg (adapter,INFO , +"channel report api version %d.%d\n" , + api_rev->major_ver, + api_rev->minor_ver);break ;default : mwifiex_dbg(adapter, FATAL,drivers/net/wireless/marvell/mwifiex/fw.h +2
-0@@ -1052,6 +1052,8 @@ struct host_cmd_ds_802_11_ps_mode_enh {enum API_VER_ID {KEY_API_VER_ID =1 ,FW_API_VER_ID =2 , +UAP_FW_API_VER_ID =3 , +CHANRPT_API_VER_ID =4 , };struct hw_spec_api_rev {Signature · 1 line
2.20.1
Ganapathi Bhat
Acked-byHi Pali,
Quoted 1 line
Hello! Could you please look at this trivial patch?
The change look good.
Quoted 10 lines · Pali Rohár
During initialization of SD8997 wifi chip kernel prints warnings:
mwifiex_sdiommc0:0001:1: Unknownapi_id: 3
mwifiex_sdiommc0:0001:1: Unknownapi_id: 4This patch adds support for parsing all api ids provided by SD8997 firmware.
Signed-off-by Pali Rohár <[email protected]>Acked-by Ganapathi Bhat <[email protected]>
Patch applied to wireless-drivers-next.git, thanks.
86cffb2c0a59 mwifiex: Parse all API_VER_ID properties
Signature · 3 lines
https://patchwork.kernel.org/patch/11562833/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches