rtc: abx80x: Provide debug feedback for invalid dt properties
PATCH v2 1/1 rtc: abx80x: Provide debug feedback for invalid dt properties
When the user provides an invalid value for tc-diode or tc-resistor generate a debug message instead of silently ignoring it.
Signed-off-by Kevin P. Fleming <[email protected]>
Cc Alessandro Zummo <[email protected]>
Cc Alexandre Belloni <[email protected]>
---
v2: Removed extraneous parameter for abx80x_dt_trickle_cfg.
v2: Changed dev_err() to dev_dbg() as requested.
drivers/rtc/rtc-abx80x.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)
drivers/rtc/rtc-abx80x.c +11 -6
@@ -554,8 +554,9 @@ static const struct rtc_class_ops abx80x_rtc_ops = { .ioctl = abx80x_ioctl, }; -static int abx80x_dt_trickle_cfg (struct device_node *np) +static int abx80x_dt_trickle_cfg (struct i2c_client *client) { +struct device_node *np = client->dev.of_node;const char *diode;int trickle_cfg =0 ;int i, ret;
@@ -565,12 +566,14 @@ static int abx80x_dt_trickle_cfg(struct device_node *np)if (ret)return ret; -if (!strcmp (diode,"standard" )) +if (!strcmp (diode,"standard" )) { trickle_cfg |=ABX8XX_TRICKLE_STANDARD_DIODE ; -else if (!strcmp (diode,"schottky" )) + }else if (!strcmp (diode,"schottky" )) { trickle_cfg |=ABX8XX_TRICKLE_SCHOTTKY_DIODE ; -else + }else { +dev_dbg (&client->dev,"Invalid tc-diode value: %s\n" , diode);return -EINVAL ; + } ret =of_property_read_u32 (np,"abracon,tc-resistor" , &tmp);if (ret)
@@ -580,8 +583,10 @@ static int abx80x_dt_trickle_cfg(struct device_node *np)if (trickle_resistors[i] == tmp)break ; -if (i ==sizeof (trickle_resistors)) +if (i ==sizeof (trickle_resistors)) { +dev_dbg (&client->dev,"Invalid tc-resistor value: %u\n" , tmp);return -EINVAL ; + }return (trickle_cfg | i); }
@@ -793,7 +798,7 @@ static int abx80x_probe(struct i2c_client *client, }if (np && abx80x_caps[part].has_tc) - trickle_cfg =abx80x_dt_trickle_cfg (np); + trickle_cfg =abx80x_dt_trickle_cfg (client);if (trickle_cfg >0 ) { dev_info(&client->dev, "Enabling trickle charger: %02x\n",
Signature · 1 line
2.26.2
Quoted 3 lines · Kevin P. Fleming
When the user provides an invalid value for tc-diode or tc-resistor generate a debug message instead of silently ignoring it.
Applied, thanks!
[1/1] rtc: abx80x: Provide debug feedback for invalid dt properties
commit: 6e429f6b8c6b8f40874c50c1e8485783dd0f97a8
Best regards,
Signature · 1 line
Alexandre Belloni <[email protected]>