usb: ohci: Add header file for ARCH_DMA_MINALIGN
Subsystems (3)
PATCH 1/2 usb: ohci: Add header file for ARCH_DMA_MINALIGN
This is defined in the asm/cache.h header file. Update this header file to include it so it gets the same value consistently across U-Boot.
This fixes 'usb host' on omapl138_lcdk.
---
drivers/usb/host/ohci.h | 1 + 1 file changed, 1 insertion(+)
drivers/usb/host/ohci.h +1 -0
@@ -11,6 +11,7 @@* e.g. PCI controllers need this */ +#include <asm/cache.h> #include <asm/io.h> #ifdef CONFIG_SYS_OHCI_SWAP_REG_ACCESS
Signature · 1 line
2.27.0.rc0.183.gde8f92d652-goog
PATCH 2/2 dma-mapping: Add header file for ARCH_DMA_MINALIGN
This is defined in the asm/cache.h header file. Update this header file to include it.
---
include/linux/dma-mapping.h | 1 + 1 file changed, 1 insertion(+)
include/linux/dma-mapping.h +1 -0
@@ -2,6 +2,7 @@#ifndef _LINUX_DMA_MAPPING_H#define _LINUX_DMA_MAPPING_H +#include <asm/cache.h> #include <linux/dma-direction.h> #include <linux/types.h> #include <asm/dma-mapping.h>
Signature · 1 line
2.27.0.rc0.183.gde8f92d652-goog
PATCH 2/2 dma-mapping: Add header file for ARCH_DMA_MINALIGN
Quoted 4 lines · Simon Glass
This is defined in the
asm/cache.hheader file. Update this header file to include it.Signed-off-by Simon Glass <[email protected]>
There's also drivers/usb/host/ohci.h and lib/elf.c which also reference ARCH_DMA_MINALIGN without also logically pulling it in, I'll fix those.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200530/6db53a76/attachment.sig>
PATCH 2/2 dma-mapping: Add header file for ARCH_DMA_MINALIGN
Quoted 11 lines · Tom Rini
Quoted 4 lines · Simon Glass
This is defined in the
asm/cache.hheader file. Update this header file to include it.Signed-off-by Simon Glass <[email protected]>Reviewed-by Tom Rini <[email protected]>There's also
drivers/usb/host/ohci.handlib/elf.cwhich also referenceARCH_DMA_MINALIGNwithout also logically pulling it in, I'll fix those.
Dunno how I missed that 1/2 is what fixed that one, sorry. And lib/elf.c is a problem in theory but would be a fail to build if not pulled in logically so I'll leave it be for now.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200530/a9625b92/attachment.sig>
PATCH 2/2 dma-mapping: Add header file for ARCH_DMA_MINALIGN
Quoted 9 lines · Tom Rini
Quoted 7 lines · Tom Rini
Quoted 4 lines · Simon Glass
This is defined in the
asm/cache.hheader file. Update this header file to include it.Signed-off-by Simon Glass <[email protected]>
Quoted 11 lines
Quoted 4 lines
Reviewed-by Tom Rini <[email protected]>There's also
drivers/usb/host/ohci.handlib/elf.cwhich also referenceARCH_DMA_MINALIGNwithout also logically pulling it in, I'll fix those.Dunno how I missed that 1/2 is what fixed that one, sorry. And
lib/elf.cis a problem in theory but would be a fail to build if not pulled in logically so I'll leave it be for now.--
Tom
PATCH 2/2 dma-mapping: Add header file for ARCH_DMA_MINALIGN
In reply to Tom RiniHi Tom,
Quoted 9 lines · Tom Rini
Quoted 7 lines · Tom Rini
Quoted 4 lines · Simon Glass
This is defined in the
asm/cache.hheader file. Update this header file to include it.Signed-off-by Simon Glass <[email protected]>
Quoted 8 lines
Quoted 4 lines
Reviewed-by Tom Rini <[email protected]>There's also
drivers/usb/host/ohci.handlib/elf.cwhich also referenceARCH_DMA_MINALIGNwithout also logically pulling it in, I'll fix those.Dunno how I missed that 1/2 is what fixed that one, sorry. And
lib/elf.cis a problem in theory but would be a fail to build if not pulled in logically so I'll leave it be for now.
Yes I think the issue is the #ifdef default. Probably that should be removed at some point as it is quite risky to have that sort of thing.
Regards,
Simon
PATCH 2/2 dma-mapping: Add header file for ARCH_DMA_MINALIGN
In reply to Simon GlassQuoted 6 lines · Simon Glass
This is defined in the
asm/cache.hheader file. Update this header file to include it.Signed-off-by Simon Glass <[email protected]>Reviewed-by Tom Rini <[email protected]>Tested-by Adam Ford <[email protected]> #da850-evm
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200603/c038aef5/attachment.sig>
PATCH 1/2 usb: ohci: Add header file for ARCH_DMA_MINALIGN
In reply to Simon GlassQuoted 5 lines · Simon Glass
This is defined in the
asm/cache.hheader file. Update this header file to include it so it gets the same value consistently across U-Boot.This fixes 'usb host' on
omapl138_lcdk.
Thank you. This series also fixes the da850-evm.
Quoted 2 lines
Fixes 90526e9fbac ("common: Drop net.h from common header")
Quoted 22 lines
Reported-by Adam Ford <[email protected]>Signed-off-by Simon Glass <[email protected]>---
drivers/usb/host/ohci.h | 1 + 1 file changed, 1 insertion(+)drivers/usb/host/ohci.h +1
-1@@ -11,6 +11,7 @@* e.g. PCI controllers need this */ +#include <asm/cache.h> #include <asm/io.h> #ifdef CONFIG_SYS_OHCI_SWAP_REG_ACCESS --2.27.0.rc0.183.gde8f92d652-goog
PATCH 1/2 usb: ohci: Add header file for ARCH_DMA_MINALIGN
In reply to Simon GlassQuoted 8 lines · Simon Glass
This is defined in the
asm/cache.hheader file. Update this header file to include it so it gets the same value consistently across U-Boot.This fixes 'usb host' on
omapl138_lcdk.Fixes 90526e9fbac ("common: Drop net.h from common header")Reported-by Adam Ford <[email protected]>Signed-off-by Simon Glass <[email protected]>
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200530/04c04b61/attachment.sig>
PATCH 1/2 usb: ohci: Add header file for ARCH_DMA_MINALIGN
In reply to Simon GlassQuoted 10 lines · Simon Glass
This is defined in the
asm/cache.hheader file. Update this header file to include it so it gets the same value consistently across U-Boot.This fixes 'usb host' on
omapl138_lcdk.Fixes 90526e9fbac ("common: Drop net.h from common header")Reported-by Adam Ford <[email protected]>Signed-off-by Simon Glass <[email protected]>Tested-by Adam Ford <[email protected]>Reviewed-by Tom Rini <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200603/96f276ea/attachment.sig>