Skip to contentSkip to conversation

usb: ohci: Add header file for ARCH_DMA_MINALIGN

PATCH New Simon Glass 3 participants 10 messages May 30, 2020 – Jun 3, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 usb: ohci: Add header file for ARCH_DMA_MINALIGN

This is defined in the asm/cache.h header file. Update this header file to include it so it gets the same value consistently across U-Boot.

This fixes 'usb host' on omapl138_lcdk.

Fixes 90526e9fbac ("common: Drop net.h from common header")

---

 drivers/usb/host/ohci.h | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/host/ohci.h +1 -0
index 9b264bd92a..a38cd25eb8 100644
@@ -11,6 +11,7 @@
  * e.g. PCI controllers need this
  */
 
+#include <asm/cache.h>
 #include <asm/io.h>
 
 #ifdef CONFIG_SYS_OHCI_SWAP_REG_ACCESS
Signature · 1 line
2.27.0.rc0.183.gde8f92d652-goog
#1 lore raw

PATCH 2/2 dma-mapping: Add header file for ARCH_DMA_MINALIGN

This is defined in the asm/cache.h header file. Update this header file to include it.

---

 include/linux/dma-mapping.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/dma-mapping.h +1 -0
index 20b6d60dd8..6a107d52e0 100644
@@ -2,6 +2,7 @@
 #ifndef _LINUX_DMA_MAPPING_H
 #define _LINUX_DMA_MAPPING_H
 
+#include <asm/cache.h>
 #include <linux/dma-direction.h>
 #include <linux/types.h>
 #include <asm/dma-mapping.h>
Signature · 1 line
2.27.0.rc0.183.gde8f92d652-goog
#2 lore raw

PATCH 2/2 dma-mapping: Add header file for ARCH_DMA_MINALIGN

Quoted 4 lines · Simon Glass

This is defined in the asm/cache.h header file. Update this header file to include it.

There's also drivers/usb/host/ohci.h and lib/elf.c which also reference ARCH_DMA_MINALIGN without also logically pulling it in, I'll fix those.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200530/6db53a76/attachment.sig>
#3 lore raw

PATCH 2/2 dma-mapping: Add header file for ARCH_DMA_MINALIGN

Quoted 11 lines · Tom Rini
Quoted 4 lines · Simon Glass

This is defined in the asm/cache.h header file. Update this header file to include it.

There's also drivers/usb/host/ohci.h and lib/elf.c which also reference ARCH_DMA_MINALIGN without also logically pulling it in, I'll fix those.

Dunno how I missed that 1/2 is what fixed that one, sorry. And lib/elf.c is a problem in theory but would be a fail to build if not pulled in logically so I'll leave it be for now.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200530/a9625b92/attachment.sig>
#4 lore raw

PATCH 2/2 dma-mapping: Add header file for ARCH_DMA_MINALIGN

Quoted 9 lines · Tom Rini
Quoted 7 lines · Tom Rini
Quoted 4 lines · Simon Glass

This is defined in the asm/cache.h header file. Update this header file to include it.

Quoted 11 lines
Quoted 4 lines

There's also drivers/usb/host/ohci.h and lib/elf.c which also reference ARCH_DMA_MINALIGN without also logically pulling it in, I'll fix those.

Dunno how I missed that 1/2 is what fixed that one, sorry. And lib/elf.c is a problem in theory but would be a fail to build if not pulled in logically so I'll leave it be for now.

--
Tom

#5 lore raw

PATCH 2/2 dma-mapping: Add header file for ARCH_DMA_MINALIGN

In reply to Tom Rini

Hi Tom,

Quoted 9 lines · Tom Rini
Quoted 7 lines · Tom Rini
Quoted 4 lines · Simon Glass

This is defined in the asm/cache.h header file. Update this header file to include it.

Quoted 8 lines
Quoted 4 lines

There's also drivers/usb/host/ohci.h and lib/elf.c which also reference ARCH_DMA_MINALIGN without also logically pulling it in, I'll fix those.

Dunno how I missed that 1/2 is what fixed that one, sorry. And lib/elf.c is a problem in theory but would be a fail to build if not pulled in logically so I'll leave it be for now.

Yes I think the issue is the #ifdef default. Probably that should be removed at some point as it is quite risky to have that sort of thing.

Regards,
Simon

#6 lore raw

PATCH 2/2 dma-mapping: Add header file for ARCH_DMA_MINALIGN

In reply to Simon Glass
Quoted 6 lines · Simon Glass

This is defined in the asm/cache.h header file. Update this header file to include it.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200603/c038aef5/attachment.sig>
#7 lore raw

PATCH 1/2 usb: ohci: Add header file for ARCH_DMA_MINALIGN

In reply to Simon Glass
Quoted 5 lines · Simon Glass

This is defined in the asm/cache.h header file. Update this header file to include it so it gets the same value consistently across U-Boot.

This fixes 'usb host' on omapl138_lcdk.

Thank you. This series also fixes the da850-evm.

Quoted 2 lines
Fixes 90526e9fbac ("common: Drop net.h from common header")
Quoted 22 lines

---

 drivers/usb/host/ohci.h | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/host/ohci.h +1 -1
index 9b264bd92a..a38cd25eb8 100644
@@ -11,6 +11,7 @@
  * e.g. PCI controllers need this
  */
 
+#include <asm/cache.h>
 #include <asm/io.h>
 
 #ifdef CONFIG_SYS_OHCI_SWAP_REG_ACCESS
--

2.27.0.rc0.183.gde8f92d652-goog

#8 lore raw

PATCH 1/2 usb: ohci: Add header file for ARCH_DMA_MINALIGN

In reply to Simon Glass
Quoted 8 lines · Simon Glass

This is defined in the asm/cache.h header file. Update this header file to include it so it gets the same value consistently across U-Boot.

This fixes 'usb host' on omapl138_lcdk.

Fixes 90526e9fbac ("common: Drop net.h from common header")
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200530/04c04b61/attachment.sig>
#9 lore raw

PATCH 1/2 usb: ohci: Add header file for ARCH_DMA_MINALIGN

In reply to Simon Glass
Quoted 10 lines · Simon Glass

This is defined in the asm/cache.h header file. Update this header file to include it so it gets the same value consistently across U-Boot.

This fixes 'usb host' on omapl138_lcdk.

Fixes 90526e9fbac ("common: Drop net.h from common header")

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200603/96f276ea/attachment.sig>