Running unionmount testsuite from xfstests
cover Running unionmount testsuite from xfstests
Eryu,
unionmount testsuite has a lot more test coverage than the overlay xfstests, but it has a lot less exposure to testers.
The various test setups that I have added to unionmount testsuite since I took over the maintanace of the testsuite have even smaller exposure to testers.
These patches add overlay tests that are used as a harness to run different setups of unionmount testsuite. I have been using this method for over two year for testing my overlayfs branches.
What does it take to install unionmount testsuite? As README.overlay says:
git clone https://github.com/amir73il/unionmount-testsuite.git
ln -s $PWD/unionmount-testsuite <path-to-xfstests>/src/
Thanks,
Amir.
Amir Goldstein (3):
overlay: run unionmount testsuite test cases
overlay: add unionmount tests with multi lower layers
overlay: add unionmount tests with nested overlay
README.overlay | 15 ++++++++++++ common/config | 2 ++ common/overlay | 54 +++++++++++++++++++++++++++++++++++++++++++ tests/overlay/100 | 38 ++++++++++++++++++++++++++++++ tests/overlay/100.out | 2 ++ tests/overlay/101 | 39 +++++++++++++++++++++++++++++++ tests/overlay/101.out | 2 ++ tests/overlay/102 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/102.out | 2 ++ tests/overlay/103 | 38 ++++++++++++++++++++++++++++++ tests/overlay/103.out | 2 ++ tests/overlay/104 | 39 +++++++++++++++++++++++++++++++ tests/overlay/104.out | 2 ++ tests/overlay/105 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/105.out | 2 ++ tests/overlay/106 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/106.out | 2 ++ tests/overlay/107 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/107.out | 2 ++ tests/overlay/108 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/108.out | 2 ++ tests/overlay/109 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/109.out | 2 ++ tests/overlay/110 | 39 +++++++++++++++++++++++++++++++ tests/overlay/110.out | 2 ++ tests/overlay/111 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/111.out | 2 ++ tests/overlay/112 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/112.out | 2 ++ tests/overlay/113 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/113.out | 2 ++ tests/overlay/114 | 39 +++++++++++++++++++++++++++++++ tests/overlay/114.out | 2 ++ tests/overlay/115 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/115.out | 2 ++ tests/overlay/116 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/116.out | 2 ++ tests/overlay/117 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/117.out | 2 ++ tests/overlay/group | 18 +++++++++++++++ 40 files changed, 843 insertions(+) create mode 100755 tests/overlay/100 create mode 100644 tests/overlay/100.out create mode 100755 tests/overlay/101 create mode 100644 tests/overlay/101.out create mode 100755 tests/overlay/102 create mode 100644 tests/overlay/102.out create mode 100755 tests/overlay/103 create mode 100644 tests/overlay/103.out create mode 100755 tests/overlay/104 create mode 100644 tests/overlay/104.out create mode 100755 tests/overlay/105 create mode 100644 tests/overlay/105.out create mode 100755 tests/overlay/106 create mode 100644 tests/overlay/106.out create mode 100755 tests/overlay/107 create mode 100644 tests/overlay/107.out create mode 100755 tests/overlay/108 create mode 100644 tests/overlay/108.out create mode 100755 tests/overlay/109 create mode 100644 tests/overlay/109.out create mode 100755 tests/overlay/110 create mode 100644 tests/overlay/110.out create mode 100755 tests/overlay/111 create mode 100644 tests/overlay/111.out create mode 100755 tests/overlay/112 create mode 100644 tests/overlay/112.out create mode 100755 tests/overlay/113 create mode 100644 tests/overlay/113.out create mode 100755 tests/overlay/114 create mode 100644 tests/overlay/114.out create mode 100755 tests/overlay/115 create mode 100644 tests/overlay/115.out create mode 100755 tests/overlay/116 create mode 100644 tests/overlay/116.out create mode 100755 tests/overlay/117 create mode 100644 tests/overlay/117.out
Signature · 1 line
2.17.1
PATCH 1/3 overlay: run unionmount testsuite test cases
Add support for running unionmount-testsuite from xfstests. This requires that unionmount-testsuite is installed under src dir or that UNIONMOUNT_TESTSUITE variable points to the location of the testsuite. It also requires a recent version of unionmount-testsuite that supports setting basedir path via UNIONMOUNT_* environment variables.
Add tests for three basic configurations:
1. overlay with upper/lower on same fs
2. overlay with upper/lower not on same fs without xino
3. overlay with upper/lower not on same fs with xino
The samefs test uses scratch partition for lower/upper layers. The non samefs tests use the scratch partition for upper layer and the test partition for lower layer.
--- README.overlay | 15 ++++++++++++ common/config | 2 ++ common/overlay | 54 +++++++++++++++++++++++++++++++++++++++++++ tests/overlay/100 | 38 ++++++++++++++++++++++++++++++ tests/overlay/100.out | 2 ++ tests/overlay/101 | 39 +++++++++++++++++++++++++++++++ tests/overlay/101.out | 2 ++ tests/overlay/102 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/102.out | 2 ++ tests/overlay/group | 3 +++ 10 files changed, 197 insertions(+) create mode 100755 tests/overlay/100 create mode 100644 tests/overlay/100.out create mode 100755 tests/overlay/101 create mode 100644 tests/overlay/101.out create mode 100755 tests/overlay/102 create mode 100644 tests/overlay/102.out
README.overlay +15 -0
@@ -50,3 +50,18 @@ In the example above, MOUNT_OPTIONS will be used to mount the base scratch fs, TEST_FS_MOUNT_OPTS will be used to mount the base test fs, OVERLAY_MOUNT_OPTIONS will be used to mount both test and scratch overlay and OVERLAY_FSCK_OPTIONS will be used to check both test and scratch overlay. + + +Unionmount Testsuite +==================== + +xfstests can be used as a test harness to run unionmount testsuite test cases +and provide extended test coverage for overlayfs. + +To enable running unionmount testsuite, clone the git repository from: + https://github.com/amir73il/unionmount-testsuite.git +under the xfstests src directory, or set the environment variable +UNIONMOUNT_TESTSUITE to the local path where the repository was cloned. + +Run './check -overlay -g overlay/union' to execute all the unionmount testsuite +test cases.
common/config +2 -0
@@ -71,6 +71,8 @@ export OVL_LOWER="ovl-lower" export OVL_WORK="ovl-work" # overlay mount point parent must be the base fs root export OVL_MNT="ovl-mnt" +# By default unionmount-testsuite is expected under src +export UNIONMOUNT_TESTSUITE=${UNIONMOUNT_TESTSUITE:=$here/src/unionmount-testsuite} # From e2fsprogs/e2fsck/e2fsck.h: # Exit code used by fsck-type programs
common/overlay +54 -0
57 lines not on this page · raw message
tests/overlay/100 new file +38 -0
@@ -0,0 +1,38 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 CTERA Networks. All Rights Reserved. +# +# FS QA Test 100 +# +# Run unionmount testsuite to verify correctness +# with single lower layer on same fs as upper +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_unionmount_testsuite_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs overlay +_supported_os Linux +_require_scratch +_require_unionmount_testsuite + +_unionmount_testsuite_run --ov --samefs --verify + +# success, all done +echo "Silence is golden" +status=0 +exit
tests/overlay/100.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 100 +Silence is golden
tests/overlay/101 new file +39 -0
@@ -0,0 +1,39 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 CTERA Networks. All Rights Reserved. +# +# FS QA Test 101 +# +# Run unionmount testsuite to verify correctness +# with single lower layer not on same fs as upper +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_unionmount_testsuite_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs overlay +_supported_os Linux +_require_test +_require_scratch +_require_unionmount_testsuite + +_unionmount_testsuite_run --ov --verify + +# success, all done +echo "Silence is golden" +status=0 +exit
tests/overlay/101.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 101 +Silence is golden
tests/overlay/102 new file +40 -0
@@ -0,0 +1,40 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 CTERA Networks. All Rights Reserved. +# +# FS QA Test 102 +# +# Run unionmount testsuite to verify correctness +# with single lower layer not on same fs as upper +# with xino enabled +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_unionmount_testsuite_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs overlay +_supported_os Linux +_require_test +_require_scratch +_require_unionmount_testsuite + +_unionmount_testsuite_run --ov --xino --verify + +# success, all done +echo "Silence is golden" +status=0 +exit
tests/overlay/102.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 102 +Silence is golden
tests/overlay/group +3 -0
@@ -77,3 +77,6 @@ 072 auto quick copyup hardlink 073 auto quick whiteout 074 auto quick exportfs dangerous +100 auto quick union samefs +101 auto quick union nonsamefs +102 auto quick union nonsamefs xino
Signature · 1 line
2.17.1
PATCH 2/3 overlay: add unionmount tests with multi lower layers
In reply to Amir GoldsteinThe tests with multi lower layers rotate the upper layer into a lower layer on specific operations such as mkdir, rename and link. That provides test coverage for redirect_dir and index features.
The following variations are covered:
1. All layers all on scratch fs (--ov=10 --samefs)
2. All layers on scratch fs expect for lowermost on test fs (--ov=10)
3. Lowermost layer on test fs, one layer on tmpfs and the rest on sratch fs (--ov=10 --maxfs=1)
4. Lowermost layer on test fs, one layer on scratch fs and the rest are unique tmpfs instances (--ov=10 --maxfs=10)
--- tests/overlay/103 | 38 ++++++++++++++++++++++++++++++++++++++ tests/overlay/103.out | 2 ++ tests/overlay/104 | 39 +++++++++++++++++++++++++++++++++++++++ tests/overlay/104.out | 2 ++ tests/overlay/105 | 40 ++++++++++++++++++++++++++++++++++++++++ tests/overlay/105.out | 2 ++ tests/overlay/106 | 41 +++++++++++++++++++++++++++++++++++++++++ tests/overlay/106.out | 2 ++ tests/overlay/107 | 41 +++++++++++++++++++++++++++++++++++++++++ tests/overlay/107.out | 2 ++ tests/overlay/108 | 41 +++++++++++++++++++++++++++++++++++++++++ tests/overlay/108.out | 2 ++ tests/overlay/109 | 41 +++++++++++++++++++++++++++++++++++++++++ tests/overlay/109.out | 2 ++ tests/overlay/group | 7 +++++++ 15 files changed, 302 insertions(+) create mode 100755 tests/overlay/103 create mode 100644 tests/overlay/103.out create mode 100755 tests/overlay/104 create mode 100644 tests/overlay/104.out create mode 100755 tests/overlay/105 create mode 100644 tests/overlay/105.out create mode 100755 tests/overlay/106 create mode 100644 tests/overlay/106.out create mode 100755 tests/overlay/107 create mode 100644 tests/overlay/107.out create mode 100755 tests/overlay/108 create mode 100644 tests/overlay/108.out create mode 100755 tests/overlay/109 create mode 100644 tests/overlay/109.out
tests/overlay/103 new file +38 -0
@@ -0,0 +1,38 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 CTERA Networks. All Rights Reserved. +# +# FS QA Test 103 +# +# Run unionmount testsuite to verify correctness +# with multi lower layers on same fs as upper +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_unionmount_testsuite_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs overlay +_supported_os Linux +_require_scratch +_require_unionmount_testsuite + +_unionmount_testsuite_run --ov=10 --samefs --verify + +# success, all done +echo "Silence is golden" +status=0 +exit
tests/overlay/103.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 103 +Silence is golden
tests/overlay/104 new file +39 -0
@@ -0,0 +1,39 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 CTERA Networks. All Rights Reserved. +# +# FS QA Test 104 +# +# Run unionmount testsuite to verify correctness +# with multi lower layers, lowermost on unique fs +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_unionmount_testsuite_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs overlay +_supported_os Linux +_require_test +_require_scratch +_require_unionmount_testsuite + +_unionmount_testsuite_run --ov=10 --verify + +# success, all done +echo "Silence is golden" +status=0 +exit
tests/overlay/104.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 104 +Silence is golden
tests/overlay/105 new file +40 -0
@@ -0,0 +1,40 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 CTERA Networks. All Rights Reserved. +# +# FS QA Test 105 +# +# Run unionmount testsuite to verify correctness +# with multi lower layers, lowermost on unique fs, +# with xino enabled +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_unionmount_testsuite_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs overlay +_supported_os Linux +_require_test +_require_scratch +_require_unionmount_testsuite + +_unionmount_testsuite_run --ov=10 --xino --verify + +# success, all done +echo "Silence is golden" +status=0 +exit
tests/overlay/105.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 105 +Silence is golden
tests/overlay/106 new file +41 -0
41 lines not on this page · raw message
tests/overlay/106.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 106 +Silence is golden
tests/overlay/107 new file +41 -0
41 lines not on this page · raw message
tests/overlay/107.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 107 +Silence is golden
tests/overlay/108 new file +41 -0
41 lines not on this page · raw message
tests/overlay/108.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 108 +Silence is golden
tests/overlay/109 new file +41 -0
41 lines not on this page · raw message
tests/overlay/109.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 109 +Silence is golden
tests/overlay/group +7 -0
@@ -80,3 +80,10 @@ 100 auto quick union samefs 101 auto quick union nonsamefs 102 auto quick union nonsamefs xino +103 auto union rotate samefs +104 auto union rotate nonsamefs +105 auto union rotate nonsamefs xino +106 auto union rotate nonsamefs +107 auto union rotate nonsamefs xino +108 auto union rotate nonsamefs +109 auto union rotate nonsamefs xino
Signature · 1 line
2.17.1
PATCH 3/3 overlay: add unionmount tests with nested overlay
In reply to Amir GoldsteinThese tests use an overlay mount as lower layer for a nested overlay. That provides test coverage for a lower layer with null uuid and lower layer with real inode numbers that use the high xino bits.
--- tests/overlay/110 | 39 +++++++++++++++++++++++++++++++++++++++ tests/overlay/110.out | 2 ++ tests/overlay/111 | 40 ++++++++++++++++++++++++++++++++++++++++ tests/overlay/111.out | 2 ++ tests/overlay/112 | 40 ++++++++++++++++++++++++++++++++++++++++ tests/overlay/112.out | 2 ++ tests/overlay/113 | 41 +++++++++++++++++++++++++++++++++++++++++ tests/overlay/113.out | 2 ++ tests/overlay/114 | 39 +++++++++++++++++++++++++++++++++++++++ tests/overlay/114.out | 2 ++ tests/overlay/115 | 40 ++++++++++++++++++++++++++++++++++++++++ tests/overlay/115.out | 2 ++ tests/overlay/116 | 40 ++++++++++++++++++++++++++++++++++++++++ tests/overlay/116.out | 2 ++ tests/overlay/117 | 41 +++++++++++++++++++++++++++++++++++++++++ tests/overlay/117.out | 2 ++ tests/overlay/group | 8 ++++++++ 17 files changed, 344 insertions(+) create mode 100755 tests/overlay/110 create mode 100644 tests/overlay/110.out create mode 100755 tests/overlay/111 create mode 100644 tests/overlay/111.out create mode 100755 tests/overlay/112 create mode 100644 tests/overlay/112.out create mode 100755 tests/overlay/113 create mode 100644 tests/overlay/113.out create mode 100755 tests/overlay/114 create mode 100644 tests/overlay/114.out create mode 100755 tests/overlay/115 create mode 100644 tests/overlay/115.out create mode 100755 tests/overlay/116 create mode 100644 tests/overlay/116.out create mode 100755 tests/overlay/117 create mode 100644 tests/overlay/117.out
tests/overlay/110 new file +39 -0
@@ -0,0 +1,39 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 CTERA Networks. All Rights Reserved. +# +# FS QA Test 110 +# +# Run unionmount testsuite on a nested overlay filesystem +# with single lower overlay layer, whose layers are +# on same fs +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_unionmount_testsuite_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs overlay +_supported_os Linux +_require_scratch +_require_unionmount_testsuite + +_unionmount_testsuite_run --ovov --samefs --verify + +# success, all done +echo "Silence is golden" +status=0 +exit
tests/overlay/110.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 110 +Silence is golden
tests/overlay/111 new file +40 -0
@@ -0,0 +1,40 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 CTERA Networks. All Rights Reserved. +# +# FS QA Test 111 +# +# Run unionmount testsuite on a nested overlay filesystem +# with single lower overlay layer, whose layers are +# on same fs +# with xino enabled (xino overflow not expected) +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_unionmount_testsuite_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs overlay +_supported_os Linux +_require_scratch +_require_unionmount_testsuite + +_unionmount_testsuite_run --ovov --samefs --xino --verify + +# success, all done +echo "Silence is golden" +status=0 +exit
tests/overlay/111.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 111 +Silence is golden
tests/overlay/112 new file +40 -0
@@ -0,0 +1,40 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 CTERA Networks. All Rights Reserved. +# +# FS QA Test 112 +# +# Run unionmount testsuite on a nested overlay filesystem +# with single lower overlay layer, whose layers are +# not on same fs +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_unionmount_testsuite_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs overlay +_supported_os Linux +_require_test +_require_scratch +_require_unionmount_testsuite + +_unionmount_testsuite_run --ovov --verify + +# success, all done +echo "Silence is golden" +status=0 +exit
tests/overlay/112.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 112 +Silence is golden
tests/overlay/113 new file +41 -0
41 lines not on this page · raw message
tests/overlay/113.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 113 +Silence is golden
tests/overlay/114 new file +39 -0
@@ -0,0 +1,39 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 CTERA Networks. All Rights Reserved. +# +# FS QA Test 114 +# +# Run unionmount testsuite on a nested overlay filesystem +# with multi lower layers, lowermost is an overlay layer, +# whose layers are on same fs +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_unionmount_testsuite_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs overlay +_supported_os Linux +_require_scratch +_require_unionmount_testsuite + +_unionmount_testsuite_run --ovov=10 --samefs --verify + +# success, all done +echo "Silence is golden" +status=0 +exit
tests/overlay/114.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 114 +Silence is golden
tests/overlay/115 new file +40 -0
@@ -0,0 +1,40 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 CTERA Networks. All Rights Reserved. +# +# FS QA Test 115 +# +# Run unionmount testsuite on a nested overlay filesystem +# with multi lower layers, lowermost is an overlay layer, +# whose layers are on same fs +# with xino enabled (xino overflow not expected) +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_unionmount_testsuite_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs overlay +_supported_os Linux +_require_scratch +_require_unionmount_testsuite + +_unionmount_testsuite_run --ovov=10 --samefs --xino --verify + +# success, all done +echo "Silence is golden" +status=0 +exit
tests/overlay/115.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 115 +Silence is golden
tests/overlay/116 new file +40 -0
@@ -0,0 +1,40 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 CTERA Networks. All Rights Reserved. +# +# FS QA Test 116 +# +# Run unionmount testsuite on a nested overlay filesystem +# with multi lower layers, lowermost is an overlay layer, +# whose layers are not on same fs +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_unionmount_testsuite_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs overlay +_supported_os Linux +_require_test +_require_scratch +_require_unionmount_testsuite + +_unionmount_testsuite_run --ovov=10 --verify + +# success, all done +echo "Silence is golden" +status=0 +exit
tests/overlay/116.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 116 +Silence is golden
tests/overlay/117 new file +41 -0
41 lines not on this page · raw message
tests/overlay/117.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 117 +Silence is golden
tests/overlay/group +8 -0
@@ -87,3 +87,11 @@ 107 auto union rotate nonsamefs xino 108 auto union rotate nonsamefs 109 auto union rotate nonsamefs xino +110 auto quick union nested samefs +111 auto quick union nested samefs xino +112 auto quick union nested nonsamefs +113 auto quick union nested nonsamefs xino +114 auto union rotate nested samefs +115 auto union rotate nested samefs xino +116 auto union rotate nested nonsamefs +117 auto union rotate nested nonsamefs xino
Signature · 1 line
2.17.1
Quoted 5 lines · Amir Goldstein
Eryu,
unionmount testsuite has a lot more test coverage than the overlay xfstests, but it has a lot less exposure to testers.
Quoted 7 lines
The various test setups that I have added to unionmount testsuite since I took over the maintanace of the testsuite have even smaller exposure to testers.
These patches add overlay tests that are used as a harness to run different setups of unionmount testsuite. I have been using this method for over two year for testing my overlayfs branches.
Hi Amir,
Is there a git branch somewhere with these changes. Its easier to pull that one in and test.
Vivek
Quoted 96 lines
What does it take to install unionmount testsuite? As README.overlay says:
git clone https://github.com/amir73il/unionmount-testsuite.git
ln -s $PWD/unionmount-testsuite <path-to-xfstests>/src/Thanks,
Amir.Amir Goldstein (3):
overlay: run unionmount testsuite test cases
overlay: add unionmount tests with multi lower layers
overlay: add unionmount tests with nested overlayREADME.overlay | 15 ++++++++++++ common/config | 2 ++ common/overlay | 54 +++++++++++++++++++++++++++++++++++++++++++ tests/overlay/100 | 38 ++++++++++++++++++++++++++++++ tests/overlay/100.out | 2 ++ tests/overlay/101 | 39 +++++++++++++++++++++++++++++++ tests/overlay/101.out | 2 ++ tests/overlay/102 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/102.out | 2 ++ tests/overlay/103 | 38 ++++++++++++++++++++++++++++++ tests/overlay/103.out | 2 ++ tests/overlay/104 | 39 +++++++++++++++++++++++++++++++ tests/overlay/104.out | 2 ++ tests/overlay/105 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/105.out | 2 ++ tests/overlay/106 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/106.out | 2 ++ tests/overlay/107 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/107.out | 2 ++ tests/overlay/108 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/108.out | 2 ++ tests/overlay/109 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/109.out | 2 ++ tests/overlay/110 | 39 +++++++++++++++++++++++++++++++ tests/overlay/110.out | 2 ++ tests/overlay/111 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/111.out | 2 ++ tests/overlay/112 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/112.out | 2 ++ tests/overlay/113 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/113.out | 2 ++ tests/overlay/114 | 39 +++++++++++++++++++++++++++++++ tests/overlay/114.out | 2 ++ tests/overlay/115 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/115.out | 2 ++ tests/overlay/116 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/116.out | 2 ++ tests/overlay/117 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/117.out | 2 ++ tests/overlay/group | 18 +++++++++++++++ 40 files changed, 843 insertions(+) create mode 100755 tests/overlay/100 create mode 100644 tests/overlay/100.out create mode 100755 tests/overlay/101 create mode 100644 tests/overlay/101.out create mode 100755 tests/overlay/102 create mode 100644 tests/overlay/102.out create mode 100755 tests/overlay/103 create mode 100644 tests/overlay/103.out create mode 100755 tests/overlay/104 create mode 100644 tests/overlay/104.out create mode 100755 tests/overlay/105 create mode 100644 tests/overlay/105.out create mode 100755 tests/overlay/106 create mode 100644 tests/overlay/106.out create mode 100755 tests/overlay/107 create mode 100644 tests/overlay/107.out create mode 100755 tests/overlay/108 create mode 100644 tests/overlay/108.out create mode 100755 tests/overlay/109 create mode 100644 tests/overlay/109.out create mode 100755 tests/overlay/110 create mode 100644 tests/overlay/110.out create mode 100755 tests/overlay/111 create mode 100644 tests/overlay/111.out create mode 100755 tests/overlay/112 create mode 100644 tests/overlay/112.out create mode 100755 tests/overlay/113 create mode 100644 tests/overlay/113.out create mode 100755 tests/overlay/114 create mode 100644 tests/overlay/114.out create mode 100755 tests/overlay/115 create mode 100644 tests/overlay/115.out create mode 100755 tests/overlay/116 create mode 100644 tests/overlay/116.out create mode 100755 tests/overlay/117 create mode 100644 tests/overlay/117.outSignature · 1 line
2.17.1
Quoted 11 lines · Vivek Goyal
Quoted 9 lines · Amir Goldstein
Eryu,
unionmount testsuite has a lot more test coverage than the overlay xfstests, but it has a lot less exposure to testers.
The various test setups that I have added to unionmount testsuite since I took over the maintanace of the testsuite have even smaller exposure to testers.
Quoted 9 lines
Quoted 3 lines
These patches add overlay tests that are used as a harness to run different setups of unionmount testsuite. I have been using this method for over two year for testing my overlayfs branches.
Hi Amir,
Is there a git branch somewhere with these changes. Its easier to pull that one in and test.
Of course. Forgot to mention.
https://github.com/amir73il/xfstests/commits/unionmount
Thanks,
Amir.
Hi Amir,
Quoted 13 lines · Amir Goldstein
Eryu,
unionmount testsuite has a lot more test coverage than the overlay xfstests, but it has a lot less exposure to testers.
The various test setups that I have added to unionmount testsuite since I took over the maintanace of the testsuite have even smaller exposure to testers.
These patches add overlay tests that are used as a harness to run different setups of unionmount testsuite. I have been using this method for over two year for testing my overlayfs branches.
Quoted 5 lines
What does it take to install unionmount testsuite? As README.overlay says:
git clone https://github.com/amir73il/unionmount-testsuite.git
ln -s $PWD/unionmount-testsuite <path-to-xfstests>/src/
I'm really sorry for the long-long delay..
The test itself looks really good to me, my only concern is that the updates in unionmount repo are not visible to fstests, and may cause new failures, which are out of fstests' control. But I'm not sure if this really is a problem for people.
I came up with two options anyway
- add unionmount tests as a submodule of fstests
- put unionmount tests in fstests
I'd like to hear what people think about this patchset, any other comments & suggestions are welcomed!
Thanks,
Eryu
Quoted 90 lines
Thanks,
Amir.Amir Goldstein (3):
overlay: run unionmount testsuite test cases
overlay: add unionmount tests with multi lower layers
overlay: add unionmount tests with nested overlayREADME.overlay | 15 ++++++++++++ common/config | 2 ++ common/overlay | 54 +++++++++++++++++++++++++++++++++++++++++++ tests/overlay/100 | 38 ++++++++++++++++++++++++++++++ tests/overlay/100.out | 2 ++ tests/overlay/101 | 39 +++++++++++++++++++++++++++++++ tests/overlay/101.out | 2 ++ tests/overlay/102 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/102.out | 2 ++ tests/overlay/103 | 38 ++++++++++++++++++++++++++++++ tests/overlay/103.out | 2 ++ tests/overlay/104 | 39 +++++++++++++++++++++++++++++++ tests/overlay/104.out | 2 ++ tests/overlay/105 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/105.out | 2 ++ tests/overlay/106 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/106.out | 2 ++ tests/overlay/107 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/107.out | 2 ++ tests/overlay/108 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/108.out | 2 ++ tests/overlay/109 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/109.out | 2 ++ tests/overlay/110 | 39 +++++++++++++++++++++++++++++++ tests/overlay/110.out | 2 ++ tests/overlay/111 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/111.out | 2 ++ tests/overlay/112 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/112.out | 2 ++ tests/overlay/113 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/113.out | 2 ++ tests/overlay/114 | 39 +++++++++++++++++++++++++++++++ tests/overlay/114.out | 2 ++ tests/overlay/115 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/115.out | 2 ++ tests/overlay/116 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/116.out | 2 ++ tests/overlay/117 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/117.out | 2 ++ tests/overlay/group | 18 +++++++++++++++ 40 files changed, 843 insertions(+) create mode 100755 tests/overlay/100 create mode 100644 tests/overlay/100.out create mode 100755 tests/overlay/101 create mode 100644 tests/overlay/101.out create mode 100755 tests/overlay/102 create mode 100644 tests/overlay/102.out create mode 100755 tests/overlay/103 create mode 100644 tests/overlay/103.out create mode 100755 tests/overlay/104 create mode 100644 tests/overlay/104.out create mode 100755 tests/overlay/105 create mode 100644 tests/overlay/105.out create mode 100755 tests/overlay/106 create mode 100644 tests/overlay/106.out create mode 100755 tests/overlay/107 create mode 100644 tests/overlay/107.out create mode 100755 tests/overlay/108 create mode 100644 tests/overlay/108.out create mode 100755 tests/overlay/109 create mode 100644 tests/overlay/109.out create mode 100755 tests/overlay/110 create mode 100644 tests/overlay/110.out create mode 100755 tests/overlay/111 create mode 100644 tests/overlay/111.out create mode 100755 tests/overlay/112 create mode 100644 tests/overlay/112.out create mode 100755 tests/overlay/113 create mode 100644 tests/overlay/113.out create mode 100755 tests/overlay/114 create mode 100644 tests/overlay/114.out create mode 100755 tests/overlay/115 create mode 100644 tests/overlay/115.out create mode 100755 tests/overlay/116 create mode 100644 tests/overlay/116.out create mode 100755 tests/overlay/117 create mode 100644 tests/overlay/117.outSignature · 1 line
2.17.1
Quoted 17 lines · Eryu Guan
Hi Amir,
Quoted 13 lines · Amir Goldstein
Eryu,
unionmount testsuite has a lot more test coverage than the overlay xfstests, but it has a lot less exposure to testers.
The various test setups that I have added to unionmount testsuite since I took over the maintanace of the testsuite have even smaller exposure to testers.
These patches add overlay tests that are used as a harness to run different setups of unionmount testsuite. I have been using this method for over two year for testing my overlayfs branches.
Quoted 8 lines
Quoted 5 lines
What does it take to install unionmount testsuite? As README.overlay says:
git clone https://github.com/amir73il/unionmount-testsuite.git
ln -s $PWD/unionmount-testsuite <path-to-xfstests>/src/I'm really sorry for the long-long delay..
No worries.
Quoted 9 lines
The test itself looks really good to me, my only concern is that the updates in unionmount repo are not visible to fstests, and may cause new failures, which are out of fstests' control. But I'm not sure if this really is a problem for people.
I came up with two options anyway
- add unionmount tests as a submodule of fstests
- put unionmount tests in fstests
I suppose you mean git submodule?
IMO that's a fairly good option.
I suspect that some people would want to continue running unionmount independently of xfstests and I have some development branches, so it's convenient to keep the unionmount repo independent of xfstests repo and use git submodule as the "pull request" method between us, for keeping control of the flow of changes from my repo in the hands of xfstests maintainer.
But as I wrote before, I am also fine with "handing over" the official upstream of unionmount src to xfstests project and be the "sub-maintainer" for that module, but I think there is going to be more chatter with that option compared to the submodule option. Another argument in favor of submodule, is that we can always graduate unionmount in the future from submodule to built-in.
Thanks,
Amir.
Quoted 96 lines
I'd like to hear what people think about this patchset, any other comments & suggestions are welcomed!
Thanks,
EryuQuoted 90 lines
Thanks,
Amir.Amir Goldstein (3):
overlay: run unionmount testsuite test cases
overlay: add unionmount tests with multi lower layers
overlay: add unionmount tests with nested overlayREADME.overlay | 15 ++++++++++++ common/config | 2 ++ common/overlay | 54 +++++++++++++++++++++++++++++++++++++++++++ tests/overlay/100 | 38 ++++++++++++++++++++++++++++++ tests/overlay/100.out | 2 ++ tests/overlay/101 | 39 +++++++++++++++++++++++++++++++ tests/overlay/101.out | 2 ++ tests/overlay/102 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/102.out | 2 ++ tests/overlay/103 | 38 ++++++++++++++++++++++++++++++ tests/overlay/103.out | 2 ++ tests/overlay/104 | 39 +++++++++++++++++++++++++++++++ tests/overlay/104.out | 2 ++ tests/overlay/105 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/105.out | 2 ++ tests/overlay/106 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/106.out | 2 ++ tests/overlay/107 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/107.out | 2 ++ tests/overlay/108 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/108.out | 2 ++ tests/overlay/109 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/109.out | 2 ++ tests/overlay/110 | 39 +++++++++++++++++++++++++++++++ tests/overlay/110.out | 2 ++ tests/overlay/111 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/111.out | 2 ++ tests/overlay/112 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/112.out | 2 ++ tests/overlay/113 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/113.out | 2 ++ tests/overlay/114 | 39 +++++++++++++++++++++++++++++++ tests/overlay/114.out | 2 ++ tests/overlay/115 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/115.out | 2 ++ tests/overlay/116 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/116.out | 2 ++ tests/overlay/117 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/117.out | 2 ++ tests/overlay/group | 18 +++++++++++++++ 40 files changed, 843 insertions(+) create mode 100755 tests/overlay/100 create mode 100644 tests/overlay/100.out create mode 100755 tests/overlay/101 create mode 100644 tests/overlay/101.out create mode 100755 tests/overlay/102 create mode 100644 tests/overlay/102.out create mode 100755 tests/overlay/103 create mode 100644 tests/overlay/103.out create mode 100755 tests/overlay/104 create mode 100644 tests/overlay/104.out create mode 100755 tests/overlay/105 create mode 100644 tests/overlay/105.out create mode 100755 tests/overlay/106 create mode 100644 tests/overlay/106.out create mode 100755 tests/overlay/107 create mode 100644 tests/overlay/107.out create mode 100755 tests/overlay/108 create mode 100644 tests/overlay/108.out create mode 100755 tests/overlay/109 create mode 100644 tests/overlay/109.out create mode 100755 tests/overlay/110 create mode 100644 tests/overlay/110.out create mode 100755 tests/overlay/111 create mode 100644 tests/overlay/111.out create mode 100755 tests/overlay/112 create mode 100644 tests/overlay/112.out create mode 100755 tests/overlay/113 create mode 100644 tests/overlay/113.out create mode 100755 tests/overlay/114 create mode 100644 tests/overlay/114.out create mode 100755 tests/overlay/115 create mode 100644 tests/overlay/115.out create mode 100755 tests/overlay/116 create mode 100644 tests/overlay/116.out create mode 100755 tests/overlay/117 create mode 100644 tests/overlay/117.out--
2.17.1
Quoted 34 lines · Amir Goldstein
Quoted 17 lines · Eryu Guan
Hi Amir,
Quoted 13 lines · Amir Goldstein
Eryu,
unionmount testsuite has a lot more test coverage than the overlay xfstests, but it has a lot less exposure to testers.
The various test setups that I have added to unionmount testsuite since I took over the maintanace of the testsuite have even smaller exposure to testers.
These patches add overlay tests that are used as a harness to run different setups of unionmount testsuite. I have been using this method for over two year for testing my overlayfs branches.
Quoted 8 lines
Quoted 5 lines
What does it take to install unionmount testsuite? As README.overlay says:
git clone https://github.com/amir73il/unionmount-testsuite.git
ln -s $PWD/unionmount-testsuite <path-to-xfstests>/src/I'm really sorry for the long-long delay..
No worries.
Quoted 5 lines
The test itself looks really good to me, my only concern is that the updates in unionmount repo are not visible to fstests, and may cause new failures, which are out of fstests' control. But I'm not sure if this really is a problem for people.
Quoted 6 lines
Quoted 4 lines
I came up with two options anyway
- add unionmount tests as a submodule of fstests
- put unionmount tests in fstestsI suppose you mean git submodule?
Exactly.
But I think I'd merge it as-is, git submodule brings more maintain burden on both maintainers and users, especially users that usually don't care about overlay tests. Users that care about overlay tests should setup unionmount tests explicitly and know that's unionmount tests if there's any test failure.
Quoted 8 lines
IMO that's a fairly good option.
I suspect that some people would want to continue running unionmount independently of xfstests and I have some development branches, so it's convenient to keep the unionmount repo independent of xfstests repo and use git submodule as the "pull request" method between us, for keeping control of the flow of changes from my repo in the hands of xfstests maintainer.
Quoted 6 lines
But as I wrote before, I am also fine with "handing over" the official upstream of unionmount src to xfstests project and be the "sub-maintainer" for that module, but I think there is going to be more chatter with that option compared to the submodule option. Another argument in favor of submodule, is that we can always graduate unionmount in the future from submodule to built-in.
Agreed, I think making unionmount tests a built-in would be good in the future.
Thanks!
Eryu
Quoted 100 lines
Thanks,
Amir.Quoted 96 lines
I'd like to hear what people think about this patchset, any other comments & suggestions are welcomed!
Thanks,
EryuQuoted 90 lines
Thanks,
Amir.Amir Goldstein (3):
overlay: run unionmount testsuite test cases
overlay: add unionmount tests with multi lower layers
overlay: add unionmount tests with nested overlayREADME.overlay | 15 ++++++++++++ common/config | 2 ++ common/overlay | 54 +++++++++++++++++++++++++++++++++++++++++++ tests/overlay/100 | 38 ++++++++++++++++++++++++++++++ tests/overlay/100.out | 2 ++ tests/overlay/101 | 39 +++++++++++++++++++++++++++++++ tests/overlay/101.out | 2 ++ tests/overlay/102 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/102.out | 2 ++ tests/overlay/103 | 38 ++++++++++++++++++++++++++++++ tests/overlay/103.out | 2 ++ tests/overlay/104 | 39 +++++++++++++++++++++++++++++++ tests/overlay/104.out | 2 ++ tests/overlay/105 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/105.out | 2 ++ tests/overlay/106 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/106.out | 2 ++ tests/overlay/107 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/107.out | 2 ++ tests/overlay/108 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/108.out | 2 ++ tests/overlay/109 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/109.out | 2 ++ tests/overlay/110 | 39 +++++++++++++++++++++++++++++++ tests/overlay/110.out | 2 ++ tests/overlay/111 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/111.out | 2 ++ tests/overlay/112 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/112.out | 2 ++ tests/overlay/113 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/113.out | 2 ++ tests/overlay/114 | 39 +++++++++++++++++++++++++++++++ tests/overlay/114.out | 2 ++ tests/overlay/115 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/115.out | 2 ++ tests/overlay/116 | 40 ++++++++++++++++++++++++++++++++ tests/overlay/116.out | 2 ++ tests/overlay/117 | 41 ++++++++++++++++++++++++++++++++ tests/overlay/117.out | 2 ++ tests/overlay/group | 18 +++++++++++++++ 40 files changed, 843 insertions(+) create mode 100755 tests/overlay/100 create mode 100644 tests/overlay/100.out create mode 100755 tests/overlay/101 create mode 100644 tests/overlay/101.out create mode 100755 tests/overlay/102 create mode 100644 tests/overlay/102.out create mode 100755 tests/overlay/103 create mode 100644 tests/overlay/103.out create mode 100755 tests/overlay/104 create mode 100644 tests/overlay/104.out create mode 100755 tests/overlay/105 create mode 100644 tests/overlay/105.out create mode 100755 tests/overlay/106 create mode 100644 tests/overlay/106.out create mode 100755 tests/overlay/107 create mode 100644 tests/overlay/107.out create mode 100755 tests/overlay/108 create mode 100644 tests/overlay/108.out create mode 100755 tests/overlay/109 create mode 100644 tests/overlay/109.out create mode 100755 tests/overlay/110 create mode 100644 tests/overlay/110.out create mode 100755 tests/overlay/111 create mode 100644 tests/overlay/111.out create mode 100755 tests/overlay/112 create mode 100644 tests/overlay/112.out create mode 100755 tests/overlay/113 create mode 100644 tests/overlay/113.out create mode 100755 tests/overlay/114 create mode 100644 tests/overlay/114.out create mode 100755 tests/overlay/115 create mode 100644 tests/overlay/115.out create mode 100755 tests/overlay/116 create mode 100644 tests/overlay/116.out create mode 100755 tests/overlay/117 create mode 100644 tests/overlay/117.out--
2.17.1
Quoted 13 lines
Quoted 6 lines
Quoted 6 lines
The test itself looks really good to me, my only concern is that the updates in unionmount repo are not visible to fstests, and may cause new failures, which are out of fstests' control. But I'm not sure if this really is a problem for people.
Quoted 6 lines
Quoted 4 lines
I came up with two options anyway
- add unionmount tests as a submodule of fstests
- put unionmount tests in fstestsI suppose you mean git submodule?
Quoted 8 lines
Exactly.
But I think I'd merge it as-is, git submodule brings more maintain burden on both maintainers and users, especially users that usually don't care about overlay tests. Users that care about overlay tests should setup unionmount tests explicitly and know that's unionmount tests if there's any test failure.
Great!
I see you also kept my 100+N test numbering, which is very convenient :-)
I have a patch on my dev branch to run unionmount test cases with metacopy enabled that Vivek requested.
Will post it this week.
Thanks!
Amir.