package/qt5/qt5webengine: don't link with libstdc++.a on the host
PATCH 1/1 package/qt5/qt5webengine: don't link with libstdc++.a on the host
While cross-compiling, qt5webengine is building a host tool but want to link the libstdc++ statically. This requires to install libstdc++-static package on the host (Fedora package name).
Otherwise the link fail with:
[185/185] LINK gn
FAILED: gn
/usr/bin/g++ -O3 -fdata-sections -ffunction-sections -Wl,--gc-sections -Wl,-strip-all -Wl,--as-needed -static-libstdc++ -pthread -o gn -Wl,--start-group tools/gn/gn_main.o base.a gn_lib.a -Wl,--end-group -ldl /usr/bin/ld?: unable to find -lstdc++
[...]
Project ERROR: GN build error!
Add --no-static-libstdc++ argument to gn.pro to link to libstdc++.so.6 instead of libstdc++.a.
--no-static-libstdc++ has been added by [1] but it force linking statically by default.
--- ...ro-don-t-link-statically-with-libstc.patch | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 package/qt5/qt5webengine/0001-gn.pro-don-t-link-statically-with-libstc.patch
package/qt5/qt5webengine/0001-gn.pro-don-t-link-statically-with-libstc.patch new file +51 -0
@@ -0,0 +1,51 @@ +From 7ae73da23ad998bd1e63ad213cf7a02e61191951 Mon Sep 17 00:00:00 2001 +From: Romain Naour <[email protected]> +Date: Sat, 23 May 2020 19:01:19 +0200 +Subject: [PATCH] gn.pro: don't link statically with libstc++ +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +While cross-compiling, qt5webengine is building a host tool but +want to link the libstdc++ statically. This requires to install +libstdc++-static package on the host (Fedora package name). + +Otherwise the link fail with: + + [185/185] LINK gn + FAILED: gn + /usr/bin/g++ -O3 -fdata-sections -ffunction-sections -Wl,--gc-sections -Wl,-strip-all -Wl,--as-needed -static-libstdc++ -pthread -o gn -Wl,--start-group tools/gn/gn_main.o base.a gn_lib.a -Wl,--end-group -ldl + /usr/bin/ld?: unable to find -lstdc++ + [...] + Project ERROR: GN build error! + +Add --no-static-libstdc++ argument to gn.pro to link to +libstdc++.so.6 instead of libstdc++.a. + +--no-static-libstdc++ has been added by [1] but it force +linking statically by default. + +[1] https://github.com/qt/qtwebengine-chromium/commit/cfab9198a9917f42cf08b1caf84ab9b71aac1911#diff-905c8f054808213577c0a92d1b704615 + +Signed-off-by: Romain Naour <[email protected]> +--- + src/buildtools/gn.pro | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/src/buildtools/gn.pro b/src/buildtools/gn.pro +index 033202e6..5dd8e241 100644 +--- a/src/buildtools/gn.pro ++++ b/src/buildtools/gn.pro +@@ -20,7 +20,8 @@ build_pass|!debug_and_release { + + gn_gen_args = --no-last-commit-position --out-path $$out_path \ + --cc \"$$which($$QMAKE_CC)\" --cxx \"$$which($$QMAKE_CXX)\" \ +- --ld \"$$which($$QMAKE_LINK)\" ++ --ld \"$$which($$QMAKE_LINK)\" \ ++ --no-static-libstdc++ + + msvc:!clang_cl: gn_gen_args += --use-lto + +-- +2.25.4 +
Signature · 1 line
2.25.4
PATCH 1/1 package/qt5/qt5webengine: don't link with libstdc++.a on the host
Hi Peter,
Le 24/05/2020 ? 17:58, Romain Naour a ?crit?:
Quoted 13 lines
While cross-compiling, qt5webengine is building a host tool but want to link the libstdc++ statically. This requires to install libstdc++-static package on the host (Fedora package name).
Otherwise the link fail with:
[185/185] LINK gn
FAILED: gn
/usr/bin/g++-O3 -fdata-sections -ffunction-sections -Wl,--gc-sections -Wl,-strip-all -Wl,--as-needed -static-libstdc++ -pthread -o gn -Wl,--start-grouptools/gn/gn_main.obase.a gn_lib.a -Wl,--end-group -ldl/usr/bin/ld?: unable to find -lstdc++
[...]
Project ERROR: GN build error!
Quoted 7 lines
Add --no-static-libstdc++ argument to gn.pro to link to libstdc++.so.6 instead of libstdc++.a.
--no-static-libstdc++ has been added by [1] but it force linking statically by default.
Did you noticed this issue while building for qt5declarative issue? On my pc, the static glibc wasn't installed.
What do you think?
Best regards,
Romain
Quoted 65 lines
Signed-off-by Romain Naour <[email protected]>Cc Ga?l Portay <[email protected]>--- ...ro-don-t-link-statically-with-libstc.patch | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 package/qt5/qt5webengine/0001-gn.pro-don-t-link-statically-with-libstc.patchpackage/qt5/qt5webengine/0001-gn.pro-don-t-link-statically-with-libstc.patch new file +51
-0@@ -0,0 +1,51 @@ +From 7ae73da23ad998bd1e63ad213cf7a02e61191951 Mon Sep 17 00:00:00 2001 +From: Romain Naour <[email protected]> +Date: Sat, 23 May 2020 19:01:19 +0200 +Subject: [PATCH] gn.pro: don't link statically with libstc++ +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +While cross-compiling, qt5webengine is building a host tool but +want to link the libstdc++ statically. This requires to install +libstdc++-static package on the host (Fedora package name). + +Otherwise the link fail with: + + [185/185] LINK gn + FAILED: gn + /usr/bin/g++ -O3 -fdata-sections -ffunction-sections -Wl,--gc-sections -Wl,-strip-all -Wl,--as-needed -static-libstdc++ -pthread -o gn -Wl,--start-group tools/gn/gn_main.o base.a gn_lib.a -Wl,--end-group -ldl + /usr/bin/ld?: unable to find -lstdc++ + [...] + Project ERROR: GN build error! + +Add --no-static-libstdc++ argument to gn.pro to link to +libstdc++.so.6 instead of libstdc++.a. + +--no-static-libstdc++ has been added by [1] but it force +linking statically by default. + +[1] https://github.com/qt/qtwebengine-chromium/commit/cfab9198a9917f42cf08b1caf84ab9b71aac1911#diff-905c8f054808213577c0a92d1b704615 + +Signed-off-by: Romain Naour <[email protected]> +--- + src/buildtools/gn.pro | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/src/buildtools/gn.pro b/src/buildtools/gn.pro +index 033202e6..5dd8e241 100644 +--- a/src/buildtools/gn.pro ++++ b/src/buildtools/gn.pro +@@ -20,7 +20,8 @@ build_pass|!debug_and_release { + + gn_gen_args = --no-last-commit-position --out-path $$out_path \ + --cc \"$$which($$QMAKE_CC)\" --cxx \"$$which($$QMAKE_CXX)\" \ +- --ld \"$$which($$QMAKE_LINK)\" ++ --ld \"$$which($$QMAKE_LINK)\" \ ++ --no-static-libstdc++ + + msvc:!clang_cl: gn_gen_args += --use-lto + +-- +2.25.4 +
PATCH 1/1 package/qt5/qt5webengine: don't link with libstdc++.a on the host
Hello Romain,
Quoted 19 lines · Romain Naour
Hi Peter,
Le 24/05/2020 ? 17:58, Romain Naour a ?crit?:
Quoted 16 lines
While cross-compiling, qt5webengine is building a host tool but want to link the libstdc++ statically. This requires to install libstdc++-static package on the host (Fedora package name).
Otherwise the link fail with:
[185/185] LINK gn
FAILED: gn
/usr/bin/g++-O3 -fdata-sections -ffunction-sections -Wl,--gc-sections -Wl,-strip-all -Wl,--as-needed -static-libstdc++ -pthread -o gn -Wl,--start-grouptools/gn/gn_main.obase.a gn_lib.a -Wl,--end-group -ldl/usr/bin/ld?: unable to find -lstdc++
[...]
Project ERROR: GN build error!Add --no-static-libstdc++ argument to gn.pro to link to libstdc++.so.6 instead of libstdc++.a.
Quoted 7 lines
Quoted 4 lines
--no-static-libstdc++ has been added by [1] but it force linking statically by default.
Did you noticed this issue while building for qt5declarative issue? On my pc, the static glibc wasn't installed.
I think the problem is qt5webengine specific as it is the only package compiling a host build tool GN....
Never observed the problem with qt5webengine, maybe because on OpenSUSE there is a static libstdc++ provided with the 'normal' libstdc++ devel package, eg.
$ rpm -qf /usr/lib64/gcc/x86_64-suse-linux/9/libstdc++.a libstdc++6-devel-gcc9-9.3.1+git1296-1.7.x86_64
Regards,
Peter
Quoted 72 lines
What do you think?
Best regards,
RomainQuoted 65 lines
Signed-off-by Romain Naour <[email protected]>Cc Ga?l Portay <[email protected]>--- ...ro-don-t-link-statically-with-libstc.patch | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 package/qt5/qt5webengine/0001-gn.pro-don-t-link-statically-with-libstc.patchpackage/qt5/qt5webengine/0001-gn.pro-don-t-link-statically-with-libstc.patch new file +51
-0@@ -0,0 +1,51 @@ +From 7ae73da23ad998bd1e63ad213cf7a02e61191951 Mon Sep 17 00:00:00 2001 +From: Romain Naour <[email protected]> +Date: Sat, 23 May 2020 19:01:19 +0200 +Subject: [PATCH] gn.pro: don't link statically with libstc++ +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +While cross-compiling, qt5webengine is building a host tool but +want to link the libstdc++ statically. This requires to install +libstdc++-static package on the host (Fedora package name). + +Otherwise the link fail with: + + [185/185] LINK gn + FAILED: gn + /usr/bin/g++ -O3 -fdata-sections -ffunction-sections -Wl,--gc-sections -Wl,-strip-all -Wl,--as-needed -static-libstdc++ -pthread -o gn -Wl,--start-group tools/gn/gn_main.o base.a gn_lib.a -Wl,--end-group -ldl + /usr/bin/ld?: unable to find -lstdc++ + [...] + Project ERROR: GN build error! + +Add --no-static-libstdc++ argument to gn.pro to link to +libstdc++.so.6 instead of libstdc++.a. + +--no-static-libstdc++ has been added by [1] but it force +linking statically by default. + +[1] https://github.com/qt/qtwebengine-chromium/commit/cfab9198a9917f42cf08b1caf84ab9b71aac1911#diff-905c8f054808213577c0a92d1b704615 + +Signed-off-by: Romain Naour <[email protected]> +--- + src/buildtools/gn.pro | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/src/buildtools/gn.pro b/src/buildtools/gn.pro +index 033202e6..5dd8e241 100644 +--- a/src/buildtools/gn.pro ++++ b/src/buildtools/gn.pro +@@ -20,7 +20,8 @@ build_pass|!debug_and_release { + + gn_gen_args = --no-last-commit-position --out-path $$out_path \ + --cc \"$$which($$QMAKE_CC)\" --cxx \"$$which($$QMAKE_CXX)\" \ +- --ld \"$$which($$QMAKE_LINK)\" ++ --ld \"$$which($$QMAKE_LINK)\" \ ++ --no-static-libstdc++ + + msvc:!clang_cl: gn_gen_args += --use-lto + +-- +2.25.4 +
PATCH 1/1 package/qt5/qt5webengine: don't link with libstdc++.a on the host
Hi Peter,
Le 26/05/2020 ? 23:13, Peter Seiderer a ?crit?:
Quoted 31 lines
Hello Romain,
Quoted 19 lines · Romain Naour
Hi Peter,
Le 24/05/2020 ? 17:58, Romain Naour a ?crit?:
Quoted 16 lines
While cross-compiling, qt5webengine is building a host tool but want to link the libstdc++ statically. This requires to install libstdc++-static package on the host (Fedora package name).
Otherwise the link fail with:
[185/185] LINK gn
FAILED: gn
/usr/bin/g++-O3 -fdata-sections -ffunction-sections -Wl,--gc-sections -Wl,-strip-all -Wl,--as-needed -static-libstdc++ -pthread -o gn -Wl,--start-grouptools/gn/gn_main.obase.a gn_lib.a -Wl,--end-group -ldl/usr/bin/ld?: unable to find -lstdc++
[...]
Project ERROR: GN build error!Add --no-static-libstdc++ argument to gn.pro to link to libstdc++.so.6 instead of libstdc++.a.
Quoted 7 lines
Quoted 4 lines
--no-static-libstdc++ has been added by [1] but it force linking statically by default.
Did you noticed this issue while building for qt5declarative issue? On my pc, the static glibc wasn't installed.
Quoted 7 lines
I think the problem is qt5webengine specific as it is the only package compiling a host build tool GN....
Never observed the problem with qt5webengine, maybe because on OpenSUSE there is a static libstdc++ provided with the 'normal' libstdc++ devel package, eg.
$ rpm -qf /usr/lib64/gcc/x86_64-suse-linux/9/libstdc++.a libstdc++6-devel-gcc9-9.3.1+git1296-1.7.x86_64
I'm using Fedora, and the packaging between Linux distros can be quite different. See for example, perl packaging in Debian (all in one) and the perl packaging in Fedora (several dozen of packages).
For the libstdc++, the libstdc++-devel package doesn't provide the static library. I have to install libstdc++-static package for that.
Best regards,
Romain
Quoted 4 lines
Regards,
Peter
PATCH 1/1 package/qt5/qt5webengine: don't link with libstdc++.a on the host
In reply to Romain Naourpackage/qt5/qt5webengine/0001-gn.pro-don-t-link-statically-with-libstc.patch line 45
Quoted 5 lines · On Sun, 24 May 2020 17:58:18 +0200 Romain Naour <[email protected]> wrote:
package/qt5/qt5webengine/0001-gn.pro-don-t-link-statically-with-libstc.patch new file +5
-0+ gn_gen_args = --no-last-commit-position --out-path $$out_path \ + --cc \"$$which($$QMAKE_CC)\" --cxx \"$$which($$QMAKE_CXX)\" \ +- --ld \"$$which($$QMAKE_LINK)\" ++ --ld \"$$which($$QMAKE_LINK)\" \ ++ --no-static-libstdc++
If we have to pass this, doesn't it mean that the host tools are built statically ? Why are they built statically ? They really shouldn't be built statically at all. I believe this is what should be fixed, rather than just avoiding specifically from linking statically with libstdc++.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/qt5/qt5webengine: don't link with libstdc++.a on the host
Hi Thomas,
Le 29/05/2020 ? 23:34, Thomas Petazzoni a ?crit?:
Quoted 9 lines
package/qt5/qt5webengine/0001-gn.pro-don-t-link-statically-with-libstc.patch line 45
Quoted 5 lines · On Sun, 24 May 2020 17:58:18 +0200 Romain Naour <[email protected]> wrote:
package/qt5/qt5webengine/0001-gn.pro-don-t-link-statically-with-libstc.patch new file +5
-0+ gn_gen_args = --no-last-commit-position --out-path $$out_path \ + --cc \"$$which($$QMAKE_CC)\" --cxx \"$$which($$QMAKE_CXX)\" \ +- --ld \"$$which($$QMAKE_LINK)\" ++ --ld \"$$which($$QMAKE_LINK)\" \ ++ --no-static-libstdc++
Quoted 4 lines
If we have to pass this, doesn't it mean that the host tools are built statically ? Why are they built statically ? They really shouldn't be built statically at all. I believe this is what should be fixed, rather than just avoiding specifically from linking statically with libstdc++.
Without this option host tools are built statically because this option is enabled by default.
Adding --no-static-libstdc++ allow to link dynamically with libc.so.6.
Best regards,
Romain
Quoted 3 lines
Thomas
PATCH 1/1 package/qt5/qt5webengine: don't link with libstdc++.a on the host
Quoted 7 lines · On Fri, 29 May 2020 23:48:09 +0200 Romain Naour <[email protected]> wrote:
Quoted 4 lines
If we have to pass this, doesn't it mean that the host tools are built statically ? Why are they built statically ? They really shouldn't be built statically at all. I believe this is what should be fixed, rather than just avoiding specifically from linking statically with libstdc++.
Without this option host tools are built statically because this option is enabled by default.
Can't we remove this, and instead link dynamically the host tools ?
Quoted 1 line
Adding --no-static-libstdc++ allow to link dynamically with libc.so.6.
--no-static-libstdc++ changes how we link against libc.so.6 ? Shouldn't it only affect how we link against libstdc++.so ?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/qt5/qt5webengine: don't link with libstdc++.a on the host
Hello Thomas,
Le 31/05/2020 ? 15:08, Thomas Petazzoni a ?crit?:
Quoted 8 lines
Quoted 5 lines · On Fri, 29 May 2020 23:48:09 +0200 Romain Naour <[email protected]> wrote:
Quoted 4 lines
If we have to pass this, doesn't it mean that the host tools are built statically ? Why are they built statically ? They really shouldn't be built statically at all. I believe this is what should be fixed, rather than just avoiding specifically from linking statically with libstdc++.
Quoted 4 lines
Quoted 2 lines
Without this option host tools are built statically because this option is enabled by default.
Can't we remove this, and instead link dynamically the host tools ?
Sorry, I don't understand.
When --no-static-libstdc++ was added [1], it's default value was "false". It means link statically libstdc++ if --no-static-libstdc++ is not provided on the command line.
Quoted 5 lines
Quoted 2 lines
Adding --no-static-libstdc++ allow to link dynamically with libc.so.6.
--no-static-libstdc++ changes how we link against libc.so.6 ? Shouldn't it only affect how we link against libstdc++.so ?
Sorry, I meant libstdc++.so here... not libc.so.6.
Best regards,
Romain
Quoted 3 lines
Thomas
Yann E. MORIN
AppliedPATCH 1/1 package/qt5/qt5webengine: don't link with libstdc++.a on the host
In reply to Romain NaourRomain, All,
On 2020-05-24 17:58 +0200, Romain Naour spake thusly:
Quoted 16 lines
While cross-compiling, qt5webengine is building a host tool but want to link the libstdc++ statically. This requires to install libstdc++-static package on the host (Fedora package name).
Otherwise the link fail with:
[185/185] LINK gn
FAILED: gn
/usr/bin/g++-O3 -fdata-sections -ffunction-sections -Wl,--gc-sections -Wl,-strip-all -Wl,--as-needed -static-libstdc++ -pthread -o gn -Wl,--start-grouptools/gn/gn_main.obase.a gn_lib.a -Wl,--end-group -ldl/usr/bin/ld?: unable to find -lstdc++
[...]
Project ERROR: GN build error!Add --no-static-libstdc++ argument to gn.pro to link to libstdc++.so.6 instead of libstdc++.a.
Quoted 7 lines
--no-static-libstdc++ has been added by [1] but it force linking statically by default.
Signed-off-by Romain Naour <[email protected]>Cc Ga?l Portay <[email protected]>
Applied to master, after rewriting the commit log with the extra details and explanations you provided as replies in the thread. Thanks! :-)
Regards,
Yann E. MORIN.
Quoted 69 lines
--- ...ro-don-t-link-statically-with-libstc.patch | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 package/qt5/qt5webengine/0001-gn.pro-don-t-link-statically-with-libstc.patchpackage/qt5/qt5webengine/0001-gn.pro-don-t-link-statically-with-libstc.patch new file +51
-0@@ -0,0 +1,51 @@ +From 7ae73da23ad998bd1e63ad213cf7a02e61191951 Mon Sep 17 00:00:00 2001 +From: Romain Naour <[email protected]> +Date: Sat, 23 May 2020 19:01:19 +0200 +Subject: [PATCH] gn.pro: don't link statically with libstc++ +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +While cross-compiling, qt5webengine is building a host tool but +want to link the libstdc++ statically. This requires to install +libstdc++-static package on the host (Fedora package name). + +Otherwise the link fail with: + + [185/185] LINK gn + FAILED: gn + /usr/bin/g++ -O3 -fdata-sections -ffunction-sections -Wl,--gc-sections -Wl,-strip-all -Wl,--as-needed -static-libstdc++ -pthread -o gn -Wl,--start-group tools/gn/gn_main.o base.a gn_lib.a -Wl,--end-group -ldl + /usr/bin/ld?: unable to find -lstdc++ + [...] + Project ERROR: GN build error! + +Add --no-static-libstdc++ argument to gn.pro to link to +libstdc++.so.6 instead of libstdc++.a. + +--no-static-libstdc++ has been added by [1] but it force +linking statically by default. + +[1] https://github.com/qt/qtwebengine-chromium/commit/cfab9198a9917f42cf08b1caf84ab9b71aac1911#diff-905c8f054808213577c0a92d1b704615 + +Signed-off-by: Romain Naour <[email protected]> +--- + src/buildtools/gn.pro | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/src/buildtools/gn.pro b/src/buildtools/gn.pro +index 033202e6..5dd8e241 100644 +--- a/src/buildtools/gn.pro ++++ b/src/buildtools/gn.pro +@@ -20,7 +20,8 @@ build_pass|!debug_and_release { + + gn_gen_args = --no-last-commit-position --out-path $$out_path \ + --cc \"$$which($$QMAKE_CC)\" --cxx \"$$which($$QMAKE_CXX)\" \ +- --ld \"$$which($$QMAKE_LINK)\" ++ --ld \"$$which($$QMAKE_LINK)\" \ ++ --no-static-libstdc++ + + msvc:!clang_cl: gn_gen_args += --use-lto + +-- +2.25.4 +Signature · 6 lines
2.25.4 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'