Skip to contentSkip to conversation

drm: add a few simple panels

PATCH In review Sam Ravnborg 4 participants 16 messages Jun 1, 2020 – Jun 9, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover drm: add a few simple panels

Push a few patches that has been sitting in my tree for far too long time.
Adds a few more panels to panel-simple, including documentation of the compatible.

I have added the last few people that added new panels to panel-simple to the cc list,
in the hope to speed up the review process a little.

Sam

Sam Ravnborg (6):
dt-bindings: panel: add Seiko 70WVW2T 7" panel
drm: panel-simple: add Seiko 70WVW2T 7" simple panel
dt-bindings: panel: add Hitachi 3,5" QVGA panel
drm: panel-simple: add Hitachi 3.5" QVGA panel
dt-bindings: panel: add LOGIC Technologies panels
drm: panel-simple: add LOGIC Technologies panels

 .../bindings/display/panel/panel-simple.yaml       |   8 ++
 drivers/gpu/drm/panel/panel-simple.c               | 127 +++++++++++++++++++++
 2 files changed, 135 insertions(+)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#1 lore raw

PATCH 1/6 dt-bindings: panel: add Seiko 70WVW2T 7" panel

Add compatible for Seiko Instruments 7" TFT LCD.
This panel is a dumb panel that matches the panel-simple binding.

Cc Søren Andersen <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +2 -0
index d6cca1479633..60cc093fbd75 100644
@@ -239,6 +239,8 @@ properties:
       - sharp,ls020b1dd01d
         # Shelly SCA07010-BFN-LNN 7.0" WVGA TFT LCD panel
       - shelly,sca07010-bfn-lnn
+        # Seiko Instruments Inc. 7.0" WVGA (800x480) TFT with Touch-Panel
+      - sii,70wvw2t
         # Starry KR070PE2T 7" WVGA TFT LCD panel
       - starry,kr070pe2t
         # Starry 12.2" (1920x1200 pixels) TFT LCD panel
Signature · 1 line
2.25.1
maintainer Acked-by on v1 1/6
#2 lore raw

Re: [PATCH v1 1/6] dt-bindings: panel: add Seiko 70WVW2T 7" panel

Quoted 11 lines · Sam Ravnborg

Add compatible for Seiko Instruments 7" TFT LCD.
This panel is a dumb panel that matches the panel-simple binding.

Cc Søren Andersen <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

PATCH 2/6 drm: panel-simple: add Seiko 70WVW2T 7" simple panel

In reply to Sam Ravnborg

The Seiko 70WVW2T is a discontinued product, but may be used somewhere. Tested on a proprietary product.

Cc Søren Andersen <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +28 -0
index b067f66cea0e..8624bb80108c 100644
@@ -3194,6 +3194,31 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = {
 	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
 };
 
+static const struct drm_display_mode sii_70wvw2t_mode = {
+	.clock = 33000,
+	.hdisplay = 800,
+	.hsync_start = 800 + 256,
+	.hsync_end = 800 + 256 + 0,
+	.htotal = 800 + 256 + 0 + 0,
+	.vdisplay = 480,
+	.vsync_start = 480 + 0,
+	.vsync_end = 480 + 0 + 0,
+	.vtotal = 480 + 0 + 0 + 45,
+	.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc sii_70wvw2t = {
+	.modes = &sii_70wvw2t_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 152,
+		.height = 91,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_PIXDATA_POSEDGE,
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
 static const struct drm_display_mode starry_kr070pe2t_mode = {
 	.clock = 33000,
 	.hdisplay = 800,
@@ -3877,6 +3902,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "shelly,sca07010-bfn-lnn",
 		.data = &shelly_sca07010_bfn_lnn,
+	}, {
+		.compatible = "sii,70wvw2t",
+		.data = &sii_70wvw2t,
 	}, {
 		.compatible = "starry,kr070pe2t",
 		.data = &starry_kr070pe2t,
Signature · 1 line
2.25.1
#4 lore raw

Re: [PATCH v1 2/6] drm: panel-simple: add Seiko 70WVW2T 7" simple panel

Hi,

Quoted 20 lines · Sam Ravnborg

The Seiko 70WVW2T is a discontinued product, but may be used somewhere. Tested on a proprietary product.

Cc Søren Andersen <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +0 -0
index b067f66cea0e..8624bb80108c 100644
@@ -3194,6 +3194,31 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = {
        .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
 };
 

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc shelly_sca07010_bfn_lnn = { · line 3206

Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10 -0
+static const struct drm_display_mode sii_70wvw2t_mode = {
+       .clock = 33000,
+       .hdisplay = 800,
+       .hsync_start = 800 + 256,
+       .hsync_end = 800 + 256 + 0,
+       .htotal = 800 + 256 + 0 + 0,
+       .vdisplay = 480,
+       .vsync_start = 480 + 0,
+       .vsync_end = 480 + 0 + 0,
+       .vtotal = 480 + 0 + 0 + 45,

Important to have a "vrefresh"?

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc shelly_sca07010_bfn_lnn = { · line 3212

Quoted 6 lines
drivers/gpu/drm/panel/panel-simple.c +6 -0
+       .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc sii_70wvw2t = {
+       .modes = &sii_70wvw2t_mode,
+       .num_modes = 1,

Do we want "bpc = 6"?

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc shelly_sca07010_bfn_lnn = { · line 3217

Quoted 5 lines
drivers/gpu/drm/panel/panel-simple.c +5 -0
+       .size = {
+               .width = 152,
+               .height = 91,
+       },
+       .bus_format = MEDIA_BUS_FMT_RGB888_1X24,

Should this be a 666 format? Random internet-found data sheet says 262K colors...

#5 lore raw

Re: [PATCH v1 2/6] drm: panel-simple: add Seiko 70WVW2T 7" simple panel

Quoted 24 lines · Doug Anderson

Hi,

Quoted 20 lines · Sam Ravnborg

The Seiko 70WVW2T is a discontinued product, but may be used somewhere. Tested on a proprietary product.

Cc Søren Andersen <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +0 -0
index b067f66cea0e..8624bb80108c 100644
@@ -3194,6 +3194,31 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = {
        .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
 };
 
Quoted 13 lines

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc shelly_sca07010_bfn_lnn = { · line 3206

Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10 -0
+static const struct drm_display_mode sii_70wvw2t_mode = {
+       .clock = 33000,
+       .hdisplay = 800,
+       .hsync_start = 800 + 256,
+       .hsync_end = 800 + 256 + 0,
+       .htotal = 800 + 256 + 0 + 0,
+       .vdisplay = 480,
+       .vsync_start = 480 + 0,
+       .vsync_end = 480 + 0 + 0,
+       .vtotal = 480 + 0 + 0 + 45,

Important to have a "vrefresh"?

Ville posted a series (most of which already landed) getting removing vrefresh all together. The overall idea is to compute it, in the rare case it's needed.

Quoted 10 lines

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc shelly_sca07010_bfn_lnn = { · line 3212

Quoted 7 lines
drivers/gpu/drm/panel/panel-simple.c +6 -0
+       .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc sii_70wvw2t = {
+       .modes = &sii_70wvw2t_mode,
+       .num_modes = 1,

Do we want "bpc = 6"?

The largest user of bpc is userspace - the data gets copied via the ioctls.

A secondary, and quite limited, user are drivers exposing the "max bpc" connector property. From a quick look: amdgpu, the synopsys dw-hdmi bridge and i915 do so. In case the data missing, atomics assume a max 8 bpc.

Quoted 9 lines

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc shelly_sca07010_bfn_lnn = { · line 3217

Quoted 6 lines
drivers/gpu/drm/panel/panel-simple.c +5 -0
+       .size = {
+               .width = 152,
+               .height = 91,
+       },
+       .bus_format = MEDIA_BUS_FMT_RGB888_1X24,

Should this be a 666 format? Random internet-found data sheet says 262K colors...

Good catch. Would be nice to have a spec sheet link (even if random) in the commit message.

HTH
-Emil
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#6 lore raw

Re: [PATCH v1 2/6] drm: panel-simple: add Seiko 70WVW2T 7" simple panel

In reply to Doug Anderson

Hi Doug.

Quoted 47 lines · Doug Anderson

Hi,

Quoted 20 lines · Sam Ravnborg

The Seiko 70WVW2T is a discontinued product, but may be used somewhere. Tested on a proprietary product.

Cc Søren Andersen <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +0 -0
index b067f66cea0e..8624bb80108c 100644
@@ -3194,6 +3194,31 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = {
        .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
 };
 

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc shelly_sca07010_bfn_lnn = { · line 3206

Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10 -0
+static const struct drm_display_mode sii_70wvw2t_mode = {
+       .clock = 33000,
+       .hdisplay = 800,
+       .hsync_start = 800 + 256,
+       .hsync_end = 800 + 256 + 0,
+       .htotal = 800 + 256 + 0 + 0,
+       .vdisplay = 480,
+       .vsync_start = 480 + 0,
+       .vsync_end = 480 + 0 + 0,
+       .vtotal = 480 + 0 + 0 + 45,

Important to have a "vrefresh"?

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc shelly_sca07010_bfn_lnn = { · line 3212

Quoted 6 lines
drivers/gpu/drm/panel/panel-simple.c +6 -0
+       .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc sii_70wvw2t = {
+       .modes = &sii_70wvw2t_mode,
+       .num_modes = 1,

Do we want "bpc = 6"?

Quoted 8 lines

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc shelly_sca07010_bfn_lnn = { · line 3217

Quoted 5 lines
drivers/gpu/drm/panel/panel-simple.c +5 -0
+       .size = {
+               .width = 152,
+               .height = 91,
+       },
+       .bus_format = MEDIA_BUS_FMT_RGB888_1X24,

Should this be a 666 format? Random internet-found data sheet says 262K colors...

Thanks for catching this!
You are indeed right, this is MEDIA_BUS_FMT_RGB666_1X18 and only bpc = 6. My bad excuse is that other displays for the same HW is RGB888 and bpc = 8.

Will fix and repost.

Sam

#7 lore raw

PATCH 3/6 dt-bindings: panel: add Hitachi 3,5" QVGA panel

In reply to Sam Ravnborg

This panel is used on evaluation boards for Atmel at91sam9261 and at91sam6263.

The panel is named: TX09D71VM1CCA

The panel is a dumb panel that matches the panel-simple binding

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +2 -0
index 60cc093fbd75..6fe0ac86696d 100644
@@ -133,6 +133,8 @@ properties:
       - hannstar,hsd070pww1
         # HannStar Display Corp. HSD100PXN1 10.1" XGA LVDS panel
       - hannstar,hsd100pxn1
+        # Hitachi Ltd. Corporation 3,5" QVGA (240x320) TFT LCD panel
+      - hit,tx09d71vm1cca
         # Hitachi Ltd. Corporation 9" WVGA (800x480) TFT LCD panel
       - hit,tx23d38vm0caa
         # InfoVision Optoelectronics M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel
Signature · 1 line
2.25.1
maintainer Acked-by on v1 3/6
#8 lore raw

Re: [PATCH v1 3/6] dt-bindings: panel: add Hitachi 3,5" QVGA panel

Quoted 5 lines · Sam Ravnborg

This panel is used on evaluation boards for Atmel at91sam9261 and at91sam6263.

The panel is named: TX09D71VM1CCA

Quoted 9 lines

The panel is a dumb panel that matches the panel-simple binding

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#9 lore raw

PATCH 4/6 drm: panel-simple: add Hitachi 3.5" QVGA panel

In reply to Sam Ravnborg

This panel is used on evaluation boards for Atmel at91sam9261 and at91sam6263.

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +29 -0
index 8624bb80108c..25c96639631f 100644
@@ -1813,6 +1813,32 @@ static const struct panel_desc hannstar_hsd100pxn1 = {
 	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
+static const struct drm_display_mode hitachi_tx09d71vm1cca_mode = {
+	.clock = 4965000,
+	.hdisplay = 240,
+	.hsync_start = 240 + 0,
+	.hsync_end = 240 + 0 + 5,
+	.htotal = 240 + 0 + 5 + 1,
+	.vdisplay = 320,
+	.vsync_start = 320 + 0,
+	.vsync_end = 320 + 0 + 1,
+	.vtotal = 320 + 0 + 1 + 1,
+	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc hitachi_tx09d71vm1cca = {
+	.modes = &hitachi_tx09d71vm1cca_mode,
+	.num_modes = 1,
+	.bpc = 6,
+	.size = {
+		.width = 54,
+		.height = 72,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
 static const struct drm_display_mode hitachi_tx23d38vm0caa_mode = {
 	.clock = 33333,
 	.hdisplay = 800,
@@ -3737,6 +3763,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "hannstar,hsd100pxn1",
 		.data = &hannstar_hsd100pxn1,
+	}, {
+		.compatible = "hit,tx09d71vm1cca",
+		.data = &hitachi_tx09d71vm1cca,
 	}, {
 		.compatible = "hit,tx23d38vm0caa",
 		.data = &hitachi_tx23d38vm0caa
Signature · 1 line
2.25.1
#10 lore raw

Re: [PATCH v1 4/6] drm: panel-simple: add Hitachi 3.5" QVGA panel

Hi,

Quoted 16 lines · Sam Ravnborg

This panel is used on evaluation boards for Atmel at91sam9261 and at91sam6263.

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +0 -0
index 8624bb80108c..25c96639631f 100644

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc hannstar_hsd100pxn1 = { · line 1817

Quoted 5 lines
drivers/gpu/drm/panel/panel-simple.c +2 -0
@@ -1813,6 +1813,32 @@ static const struct panel_desc hannstar_hsd100pxn1 = {
        .connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
+static const struct drm_display_mode hitachi_tx09d71vm1cca_mode = {
+       .clock = 4965000,

This is the pixel clock in kHz, right? So it runs at almost 5 Terahertz?

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc hannstar_hsd100pxn1 = { · line 1825

Quoted 8 lines
drivers/gpu/drm/panel/panel-simple.c +8 -0
+       .hdisplay = 240,
+       .hsync_start = 240 + 0,
+       .hsync_end = 240 + 0 + 5,
+       .htotal = 240 + 0 + 5 + 1,
+       .vdisplay = 320,
+       .vsync_start = 320 + 0,
+       .vsync_end = 320 + 0 + 1,
+       .vtotal = 320 + 0 + 1 + 1,

Some random datasheet I found has really different numbers. If the numbers above are what everyone is using then I suppose it's fine, just curious why the mismatch.

Also: should you provide "vrefresh"?

-Doug
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#11 lore raw

Re: [PATCH v1 4/6] drm: panel-simple: add Hitachi 3.5" QVGA panel

Hi Doug.

Quoted 37 lines · Doug Anderson

Hi,

Quoted 16 lines · Sam Ravnborg

This panel is used on evaluation boards for Atmel at91sam9261 and at91sam6263.

Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +0 -0
index 8624bb80108c..25c96639631f 100644

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc hannstar_hsd100pxn1 = { · line 1817

Quoted 5 lines
drivers/gpu/drm/panel/panel-simple.c +2 -0
@@ -1813,6 +1813,32 @@ static const struct panel_desc hannstar_hsd100pxn1 = {
        .connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
+static const struct drm_display_mode hitachi_tx09d71vm1cca_mode = {
+       .clock = 4965000,

This is the pixel clock in kHz, right? So it runs at almost 5 Terahertz?

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc hannstar_hsd100pxn1 = { · line 1825

Quoted 8 lines
drivers/gpu/drm/panel/panel-simple.c +8 -0
+       .hdisplay = 240,
+       .hsync_start = 240 + 0,
+       .hsync_end = 240 + 0 + 5,
+       .htotal = 240 + 0 + 5 + 1,
+       .vdisplay = 320,
+       .vsync_start = 320 + 0,
+       .vsync_end = 320 + 0 + 1,
+       .vtotal = 320 + 0 + 1 + 1,
Quoted 3 lines

Some random datasheet I found has really different numbers. If the numbers above are what everyone is using then I suppose it's fine, just curious why the mismatch.

The timing comes from:
arch/arm/boot/dts/at91sam9263ek.dts - that include display timings for the panel on the evaluation board.
I did not verify any datasheet - I just blindly copied what was there. And clock was obviously not properly adjusted to khz.

Will fix in v2 - will also try to find a datasheet this time.

Thanks for noticing!

Sam

#12 lore raw

PATCH 5/6 dt-bindings: panel: add LOGIC Technologies panels

In reply to Sam Ravnborg

Add support for the following panels from LOGIC Technologies, Inc:
- LTTD800480070-L2RT
- LTTD800480070-L6WH-RT

The LTTD800480 L2RT is discontinued, but it may be used in existing products.

Both panels are dumb panels that matches the panel-simple binding.

Cc Søren Andersen <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 .../devicetree/bindings/display/panel/panel-simple.yaml       | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +4 -0
index 6fe0ac86696d..a4910d4af96b 100644
@@ -183,6 +183,10 @@ properties:
       - logictechno,lt161010-2nhr
         # Logic Technologies LT170410-2WHC 10.1" 1280x800 IPS TFT Cap Touch Mod.
       - logictechno,lt170410-2whc
+        # LOGIC Technologies Inc. LTTD800480070-L2RT 7" (800x480) TFT LCD panel
+      - logictechno,lttd800480070-l2rt
+        # LOGIC Technologies Inc. LTTD800480070-L6WH-RT 7" (800x480) TFT LCD panel
+      - logictechno,lttd800480070-l6wh-rt
         # Mitsubishi "AA070MC01 7.0" WVGA TFT LCD panel
       - mitsubishi,aa070mc01-ca1
         # NEC LCD Technologies, Ltd. 12.1" WXGA (1280x800) LVDS TFT LCD panel
Signature · 1 line
2.25.1
maintainer Acked-by on v1 5/6
#13 lore raw

Re: [PATCH v1 5/6] dt-bindings: panel: add LOGIC Technologies panels

Quoted 9 lines · Sam Ravnborg

Add support for the following panels from LOGIC Technologies, Inc:
- LTTD800480070-L2RT
- LTTD800480070-L6WH-RT

The LTTD800480 L2RT is discontinued, but it may be used in existing products.

Both panels are dumb panels that matches the panel-simple binding.

Quoted 8 lines
Cc Søren Andersen <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 .../devicetree/bindings/display/panel/panel-simple.yaml       | 4 ++++
 1 file changed, 4 insertions(+)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#14 lore raw

PATCH 6/6 drm: panel-simple: add LOGIC Technologies panels

In reply to Sam Ravnborg

Add support for the following panels from LOGIC Technologies, Inc:
- LTTD800480070-L2RT
- LTTD800480070-L6WH-RT

The LTTD800480 L2RT is discontinued, but it may be used by existing products.

Cc Søren Andersen <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 70 ++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +70 -0
index 25c96639631f..70d54164b1ae 100644
@@ -2428,6 +2428,70 @@ static const struct panel_desc logictechno_lt170410_2whc = {
 	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
+static const struct drm_display_mode logictechno_lttd800480070_l2rt_mode = {
+	.clock = 33000,
+	.hdisplay = 800,
+	.hsync_start = 800 + 112,
+	.hsync_end = 800 + 112 + 3,
+	.htotal = 800 + 112 + 3 + 85,
+	.vdisplay = 480,
+	.vsync_start = 480 + 38,
+	.vsync_end = 480 + 38 + 3,
+	.vtotal = 480 + 38 + 3 + 29,
+	.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc logictechno_lttd800480070_l2rt = {
+	.modes = &logictechno_lttd800480070_l2rt_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 154,
+		.height = 86,
+	},
+	.delay = {
+		.prepare = 45,
+		.enable = 100,
+		.disable = 100,
+		.unprepare = 45
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_PIXDATA_POSEDGE,
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
+static const struct drm_display_mode logictechno_lttd800480070_l6wh_rt_mode = {
+	.clock = 33000,
+	.hdisplay = 800,
+	.hsync_start = 800 + 154,
+	.hsync_end = 800 + 154 + 3,
+	.htotal = 800 + 154 + 3 + 43,
+	.vdisplay = 480,
+	.vsync_start = 480 + 47,
+	.vsync_end = 480 + 47 + 3,
+	.vtotal = 480 + 47 + 3 + 20,
+	.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc logictechno_lttd800480070_l6wh_rt = {
+	.modes = &logictechno_lttd800480070_l6wh_rt_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 154,
+		.height = 86,
+	},
+	.delay = {
+		.prepare = 45,
+		.enable = 100,
+		.disable = 100,
+		.unprepare = 45
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_PIXDATA_POSEDGE,
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
 static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
 	.clock = 30400,
 	.hdisplay = 800,
@@ -3841,6 +3905,12 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "logictechno,lt170410-2whc",
 		.data = &logictechno_lt170410_2whc,
+	}, {
+		.compatible = "logictechno,lttd800480070-l2rt",
+		.data = &logictechno_lttd800480070_l2rt,
+	}, {
+		.compatible = "logictechno,lttd800480070-l6wh-rt",
+		.data = &logictechno_lttd800480070_l6wh_rt,
 	}, {
 		.compatible = "mitsubishi,aa070mc01-ca1",
 		.data = &mitsubishi_aa070mc01,
Signature · 1 line
2.25.1
#15 lore raw

Re: [PATCH v1 6/6] drm: panel-simple: add LOGIC Technologies panels

Hi,

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc logictechno_lt170410_2whc = { · line 2473

Quoted 12 lines · Sam Ravnborg
drivers/gpu/drm/panel/panel-simple.c +11 -0
+static const struct drm_display_mode logictechno_lttd800480070_l6wh_rt_mode = {
+       .clock = 33000,
+       .hdisplay = 800,
+       .hsync_start = 800 + 154,
+       .hsync_end = 800 + 154 + 3,
+       .htotal = 800 + 154 + 3 + 43,
+       .vdisplay = 480,
+       .vsync_start = 480 + 47,
+       .vsync_end = 480 + 47 + 3,
+       .vtotal = 480 + 47 + 3 + 20,
+       .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,

This is different than the "typ" mode from the random spreadsheet I found on the internet:

https://logictechno.com/wp-content/uploads/2016/11/LTTD800480070-L6WH-RT-v1.1.pdf

As per my other comments, I wonder how important "vrefresh" is and if we should include it.

-Doug