net/axgbe: add support for set MTU API
PATCH 1/1 net/axgbe: add support for set MTU API
From: gnandiba <[email protected]>
This patch adds support for set_mtu API which can be used to change the Maximum Transmission unit (MTU) from application.
--- drivers/net/axgbe/axgbe_ethdev.c | 32 +++++++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-)
drivers/net/axgbe/axgbe_ethdev.c +31 -1
@@ -73,6 +73,7 @@ static void axgbe_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,static void axgbe_txq_info_get (struct rte_eth_dev *dev,uint16_t queue_id,struct rte_eth_txq_info *qinfo);const uint32_t *axgbe_dev_supported_ptypes_get (struct rte_eth_dev *dev); +static int axgb_mtu_set (struct rte_eth_dev *dev,uint16_t mtu);struct axgbe_xstats {char name[RTE_ETH_XSTATS_NAME_SIZE ];
@@ -214,6 +215,7 @@ static const struct eth_dev_ops axgbe_eth_dev_ops = { .dev_supported_ptypes_get = axgbe_dev_supported_ptypes_get, .rx_descriptor_status = axgbe_dev_rx_descriptor_status, .tx_descriptor_status = axgbe_dev_tx_descriptor_status, + .mtu_set = axgb_mtu_set, };static int axgbe_phy_reset (struct axgbe_port *pdata)
@@ -1254,7 +1256,35 @@ axgbe_dev_supported_ptypes_get(struct rte_eth_dev *dev)return ptypes;return NULL ; } - +static int axgb_mtu_set (struct rte_eth_dev *dev,uint16_t mtu) +{ +struct rte_eth_dev_info dev_info; +struct axgbe_port *pdata = dev->data->dev_private; +uint32_t frame_size = mtu +RTE_ETHER_HDR_LEN +RTE_ETHER_CRC_LEN ; +unsigned int val =0 ; +axgbe_dev_info_get (dev, &dev_info); +/* check that mtu is within the allowed range */ +if ((mtu <RTE_ETHER_MIN_MTU ) || (frame_size > dev_info.max_rx_pktlen)) +return -EINVAL ; +/* mtu setting is forbidden if port is start */ +if (dev->data->dev_started) { +PMD_DRV_LOG (ERR ,"port %d must be stopped before configuration" , + dev->data->port_id); +return -EBUSY ; + } +if (frame_size >RTE_ETHER_MAX_LEN ) { + dev->data->dev_conf.rxmode.offloads |= +DEV_RX_OFFLOAD_JUMBO_FRAME ; + val =1 ; + }else { + dev->data->dev_conf.rxmode.offloads &= + ~DEV_RX_OFFLOAD_JUMBO_FRAME ; + val =0 ; + } +AXGMAC_IOWRITE_BITS (pdata,MAC_RCR ,JE , val); + dev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size; +return 0 ; +}static void axgbe_get_all_hw_features (struct axgbe_port *pdata) {unsigned int mac_hfr0, mac_hfr1, mac_hfr2;
Signature · 1 line
2.17.1
[AMD Public Use]
-----Original Message-----
From: Nandibasappa, Girish <[email protected]>
Sent: Monday, June 1, 2020 8:19 PM
To: [email protected]
Cc: Somalapuram, Amaranath <[email protected]>
Subject: [PATCH v1] net/axgbe: add support for set MTU API
From: gnandiba <[email protected]>
This patch adds support for set_mtu API which can be used to change the Maximum Transmission unit (MTU) from application.
--- drivers/net/axgbe/axgbe_ethdev.c | 32 +++++++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-)
drivers/net/axgbe/axgbe_ethdev.c +2 -0
@@ -73,6 +73,7 @@ static void axgbe_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id, static void axgbe_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id, struct rte_eth_txq_info *qinfo);const uint32_t *axgbe_dev_supported_ptypes_get (struct rte_eth_dev *dev); +static int axgb_mtu_set (struct rte_eth_dev *dev,uint16_t mtu);struct axgbe_xstats {char name[RTE_ETH_XSTATS_NAME_SIZE ];
@@ -214,6 +215,7 @@ static const struct eth_dev_ops axgbe_eth_dev_ops = { .dev_supported_ptypes_get = axgbe_dev_supported_ptypes_get, .rx_descriptor_status = axgbe_dev_rx_descriptor_status, .tx_descriptor_status = axgbe_dev_tx_descriptor_status, +.mtu_set= axgb_mtu_set, }; static int axgbe_phy_reset(struct axgbe_port *pdata) @@ -1254,7 +1256,35 @@ axgbe_dev_supported_ptypes_get(struct rte_eth_dev *dev)
return ptypes;
return NULL;
}
-
+static int axgb_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { +struct rte_eth_dev_info dev_info;
+struct axgbe_port *pdata = dev->data->dev_private; +uint32_t frame_size = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN; +unsigned int val = 0;
+axgbe_dev_info_get(dev, &dev_info);
+/* check that mtu is within the allowed range */
+if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) +return -EINVAL;
+/* mtu setting is forbidden if port is start */
+if (dev->data->dev_started) {
+PMD_DRV_LOG(ERR, "port %d must be stopped before configuration", +dev->data->port_id);
+return -EBUSY;
+}
+if (frame_size > RTE_ETHER_MAX_LEN) { +dev->data->dev_conf.rxmode.offloads |= +DEV_RX_OFFLOAD_JUMBO_FRAME;
+val = 1;
+} else {
+dev->data->dev_conf.rxmode.offloads &= +~DEV_RX_OFFLOAD_JUMBO_FRAME;
+val = 0;
+}
+AXGMAC_IOWRITE_BITS(pdata, MAC_RCR, JE, val); +dev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size; +return 0;
+}
static void axgbe_get_all_hw_features(struct axgbe_port *pdata) { unsigned int mac_hfr0, mac_hfr1, mac_hfr2;
--
2.17.1
Ferruh Yigit
AppliedQuoted 6 lines · On 6/1/2020 3:48 PM, [email protected] wrote:
From: gnandiba <[email protected]>
This patch adds support for
set_mtuAPI which can be used to change the Maximum Transmission unit (MTU) from application.Signed-off-by gnandiba <[email protected]>
Please use "Name Surname <email>" format, for this time I am updating it as following using identity from previous contribution:
"Signed-off-by: Girish Nandibasappa <[email protected]>"
Applied to dpdk-next-net/master, thanks.
<...>
Quoted 5 lines
drivers/net/axgbe/axgbe_ethdev.c +0
-1@@ -1254,7 +1256,35 @@ axgbe_dev_supported_ptypes_get(struct rte_eth_dev *dev)return ptypes;return NULL ; } -
drivers/net/axgbe/axgbe_ethdev.c axgbe_dev_supported_ptypes_get(struct rte_eth_dev *dev) · line 1268
Quoted 10 lines
drivers/net/axgbe/axgbe_ethdev.c +10
-0+static int axgb_mtu_set (struct rte_eth_dev *dev,uint16_t mtu) +{ +struct rte_eth_dev_info dev_info; +struct axgbe_port *pdata = dev->data->dev_private; +uint32_t frame_size = mtu +RTE_ETHER_HDR_LEN +RTE_ETHER_CRC_LEN ; +unsigned int val =0 ; +axgbe_dev_info_get (dev, &dev_info); +/* check that mtu is within the allowed range */ +if ((mtu <RTE_ETHER_MIN_MTU ) || (frame_size > dev_info.max_rx_pktlen)) +return -EINVAL ;
Removed unnecessary parentheses while merging, please run "./devtools/checkpatches.sh" before submitting the patch, which shows below warning (also patchwork shows same warnings:
http://mails.dpdk.org/archives/test-report/2020-June/134309.html)
### net/axgbe: support setting MTU
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU'
#45: FILE: drivers/net/axgbe/axgbe_ethdev.c:1411:
+ if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen'
#45: FILE: drivers/net/axgbe/axgbe_ethdev.c:1411:
+ if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))