workqueue: reduce the sizeof pool_workqueue
cover workqueue: reduce the sizeof pool_workqueue
The major memory ussage in workqueue is on the pool_workqueue. The pool_workqueue has alignment requirement which often leads to padding.
Reducing the memory usage for the pool_workqueue is valuable.
And 32bit system often has less memory, less workqueues, less works, less concurrent flush_workqueue()s, so we can slash the flush color on 32bit system to reduce memory usage
Before patch:
The sizeof the struct pool_workqueue is 256 bytes, only 136 bytes is in use in 32bit system
After patch:
The sizeof the struct pool_workqueue is 128 bytes, only 104 bytes is in use in 32bit system, there is still room for future usage.
Setting WORK_STRUCT_COLOR_BITS to 3 can't reduce the sizeof the struct pool_workqueue in 64bit system, unless combined with big refactor for unbound pwq.
Lai Jiangshan (4):
workqueue: fix a piece of comment about reserved bits for work flags
workqueue: use BUILD_BUG_ON() for compile time test instead of
WARN_ON()
workqueue: add a BUILD_BUG_ON() to check the size of struct
pool_workqueue
workqueue: slash half memory usage in 32bit system
include/linux/workqueue.h | 8 +++++++- kernel/workqueue.c | 10 +++++++++- 2 files changed, 16 insertions(+), 2 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/4 workqueue: fix a piece of comment about reserved bits for work flags
8a2e8e5dec7e("workqueue: fix cwq->nr_active underflow") allocated one more bit from the work flags, and it updated partial of the comments (128 bytes -> 256 bytes), but it failed to update the info about the number of reserved bits.
--- include/linux/workqueue.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/workqueue.h +1 -1
@@ -62,7 +62,7 @@ enum { WORK_CPU_UNBOUND = NR_CPUS,/* -* Reserve 7 bits off of pwq pointer w/ debugobjects turned off. +* Reserve 8 bits off of pwq pointer w/ debugobjects turned off. * This makes pwqs aligned to 256 bytes and allows 15 workqueue * flush colors. */
Signature · 1 line
2.20.1
PATCH 2/4 workqueue: use BUILD_BUG_ON() for compile time test instead of WARN_ON()
In reply to Lai JiangshanAny runtime WARN_ON() has to be fixed, and BUILD_BUG_ON() can help you nitice it earlier.
--- kernel/workqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/workqueue.c +1 -1
@@ -5905,7 +5905,7 @@ void __init workqueue_init_early(void)int hk_flags =HK_FLAG_DOMAIN |HK_FLAG_WQ ;int i, cpu; -WARN_ON (__alignof__(struct pool_workqueue ) < __alignof__(long long )); +BUILD_BUG_ON (__alignof__(struct pool_workqueue ) < __alignof__(long long ));BUG_ON (!alloc_cpumask_var (&wq_unbound_cpumask,GFP_KERNEL ));cpumask_copy (wq_unbound_cpumask,housekeeping_cpumask (hk_flags));
Signature · 1 line
2.20.1
Tejun Heo
maintainerRe: [PATCH 2/4] workqueue: use BUILD_BUG_ON() for compile time test instead of WARN_ON()
Quoted 4 lines · Lai Jiangshan
Any runtime
WARN_ON()has to be fixed, andBUILD_BUG_ON()can help you nitice it earlier.Signed-off-by Lai Jiangshan <[email protected]>
Applied 1-2 to wq/for-5.8.
Thanks.
Signature · 1 line
tejun
PATCH 3/4 workqueue: add a BUILD_BUG_ON() to check the size of struct pool_workqueue
In reply to Lai JiangshanCurrently, the size of struct pool_workqueue is smaller than the smellest requirement (1 << WORK_STRUCT_FLAG_BITS). When the size of struct pool_workqueue is increasing in future development and exceed the smellest requirement a little, it will be a big waste due to alignment.
Add a check in case we don't skimp enough in future.
--- kernel/workqueue.c | 8 ++++++++ 1 file changed, 8 insertions(+)
kernel/workqueue.c +8 -0
@@ -5907,6 +5907,14 @@ void __init workqueue_init_early(void)BUILD_BUG_ON (__alignof__(struct pool_workqueue ) < __alignof__(long long )); +/* +* If it complains when being built, there might be considerable +* memory waste in struct pool_workqueue. Whatever the reason is, +* an updated check here or a re-arrangement in +* struct pool_workqueue is required. +*/ +BUILD_BUG_ON (sizeof (struct pool_workqueue ) > (1 <<WORK_STRUCT_FLAG_BITS )); +BUG_ON (!alloc_cpumask_var (&wq_unbound_cpumask,GFP_KERNEL ));cpumask_copy (wq_unbound_cpumask,housekeeping_cpumask (hk_flags));
Signature · 1 line
2.20.1
PATCH 4/4 workqueue: slash half memory usage in 32bit system
In reply to Lai JiangshanThe major memory ussage in workqueue is on the pool_workqueue. The pool_workqueue has alignment requirement which often leads to padding.
Reducing the memory usage for the pool_workqueue is valuable.
And 32bit system often has less memory, less workqueues, less works, less concurrent flush_workqueue()s, so we can slash the flush color on 32bit system to reduce memory usage
Before patch:
The sizeof the struct pool_workqueue is 256 bytes, only 136 bytes is in use in 32bit system
After patch:
The sizeof the struct pool_workqueue is 128 bytes, only 104 bytes is in use in 32bit system, there is still room for future usage.
Setting WORK_STRUCT_COLOR_BITS to 3 can't reduce the sizeof the struct pool_workqueue in 64bit system, unless combined with big refactor for unbound pwq.
--- include/linux/workqueue.h | 6 ++++++ 1 file changed, 6 insertions(+)
include/linux/workqueue.h +6 -0
@@ -39,7 +39,11 @@ enum { WORK_STRUCT_COLOR_SHIFT = 4, /* color for workqueue flushing */#endif +#if BITS_PER_LONG ==32 +WORK_STRUCT_COLOR_BITS =3 , +#elseWORK_STRUCT_COLOR_BITS =4 , +#endifWORK_STRUCT_PENDING =1 <<WORK_STRUCT_PENDING_BIT , WORK_STRUCT_DELAYED = 1 << WORK_STRUCT_DELAYED_BIT,
@@ -65,6 +69,8 @@ enum {* Reserve 8 bits off of pwq pointer w/ debugobjects turned off. * This makes pwqs aligned to 256 bytes and allows 15 workqueue * flush colors. +* For 32 bit system, the numbers are 7 bits, 128 bytes, 7 colors +* respectively. */ WORK_STRUCT_FLAG_BITS =WORK_STRUCT_COLOR_SHIFT + WORK_STRUCT_COLOR_BITS,
Signature · 1 line
2.20.1
Tejun Heo
maintainerRe: [PATCH 4/4] workqueue: slash half memory usage in 32bit system
Quoted 14 lines · Lai Jiangshan
The major memory ussage in workqueue is on the
pool_workqueue. Thepool_workqueuehas alignment requirement which often leads to padding.Reducing the memory usage for the
pool_workqueueis valuable.And 32bit system often has less memory, less workqueues, less works, less concurrent flush_workqueue()s, so we can slash the flush color on 32bit system to reduce memory usage
Before patch:
The sizeof the structpool_workqueueis 256 bytes, only 136 bytes is in use in 32bit system
Quoted 8 lines
After patch:
The sizeof the structpool_workqueueis 128 bytes, only 104 bytes is in use in 32bit system, there is still room for future usage.Setting
WORK_STRUCT_COLOR_BITSto 3 can't reduce the sizeof the structpool_workqueuein 64bit system, unless combined with big refactor for unbound pwq.
Have you calculated how much memory is actually saved this way on a typical system?
Thanks.
Signature · 1 line
tejun
Lai Jiangshan
reviewerRe: [PATCH 4/4] workqueue: slash half memory usage in 32bit system
Quoted 21 lines · Tejun Heo
Quoted 19 lines · Lai Jiangshan
The major memory ussage in workqueue is on the
pool_workqueue. Thepool_workqueuehas alignment requirement which often leads to padding.Reducing the memory usage for the
pool_workqueueis valuable.And 32bit system often has less memory, less workqueues, less works, less concurrent flush_workqueue()s, so we can slash the flush color on 32bit system to reduce memory usage
Before patch:
The sizeof the structpool_workqueueis 256 bytes, only 136 bytes is in use in 32bit systemAfter patch:
The sizeof the structpool_workqueueis 128 bytes, only 104 bytes is in use in 32bit system, there is still room for future usage.
Quoted 6 lines
Quoted 3 lines
Setting
WORK_STRUCT_COLOR_BITSto 3 can't reduce the sizeof the structpool_workqueuein 64bit system, unless combined with big refactor for unbound pwq.Have you calculated how much memory is actually saved this way on a typical system?
It is not noticable from the "free" command.
By counting the number of allocated pwq (mainly percpu pwq), it saves 20k in my simple kvm guest (4cpu).
I guess it highly various in different boxes with various kernel modules loaded.
Quoted 5 lines
Thanks.
--
tejun
Tejun Heo
maintainerRe: [PATCH 4/4] workqueue: slash half memory usage in 32bit system
Hello,
Quoted 5 lines · Lai Jiangshan
It is not noticable from the "free" command.
By counting the number of allocated pwq (mainly percpu pwq), it saves 20k in my simple kvm guest (4cpu).
I guess it highly various in different boxes with various kernel modules loaded.
Hmm... I find it difficult to judge in any direction. 32 bit machines are smaller and have less of everything - including CPUs and workqueues themselves, so while changing configuration for 32bit systems would reduce memory usage the impact isn't gonna be that big either and I have no data supporting whether the reduction is gonna help or hurt.
Thanks.
Signature · 1 line
tejun