Skip to contentSkip to conversation

spi: tegra20-slink: add missing pm_runtime_put if pm_runtime_get_sync fails

PATCH New Navid Emamdoost 1 participant 1 message Jun 2, 2020

Subsystems (3)
SPI Tegra architecture support Tegra SPI driver
lore
Share & tools
lore

Navid Emamdoost

author
#0 lore raw

PATCH 1/1 spi: tegra20-slink: add missing pm_runtime_put if pm_runtime_get_sync fails

Call to pm_runtime_get_sync increments counter even in case of failure leading to incorrect ref count.
Call pm_runtime_put if pm_runtime_get_sync fails.

Signed-off-by Navid Emamdoost <[email protected]>
---
 drivers/spi/spi-tegra20-slink.c | 1 +
 1 file changed, 1 insertion(+)
drivers/spi/spi-tegra20-slink.c +1 -0
index 7f4d932dade7..9509b7cb14e4 100644
@@ -756,6 +756,7 @@ static int tegra_slink_setup(struct spi_device *spi)
 	ret = pm_runtime_get_sync(tspi->dev);
 	if (ret < 0) {
 		dev_err(tspi->dev, "pm runtime failed, e = %d\n", ret);
+		pm_runtime_put(tspi->dev);
 		return ret;
 	}
Signature · 1 line
2.17.1