Skip to contentSkip to conversation

spi: tegra20-slink: add missing pm_runtime_put

PATCH In review Navid Emamdoost 2 participants 2 messages Jun 2, 2020 – Jun 5, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: tegra20-slink: add missing pm_runtime_put

Call to pm_runtime_get_sync increments counter even in case of failure leading to incorrect ref count.
Call pm_runtime_put if pm_runtime_get_sync fails.

---
 drivers/spi/spi-tegra20-slink.c | 1 +
 1 file changed, 1 insertion(+)
drivers/spi/spi-tegra20-slink.c +1 -0
index 7f4d932dade7..0675b36d647b 100644
@@ -1192,6 +1192,7 @@ static int tegra_slink_resume(struct device *dev)
 	ret = pm_runtime_get_sync(dev);
 	if (ret < 0) {
 		dev_err(dev, "pm runtime failed, e = %d\n", ret);
+		pm_runtime_put(dev);
 		return ret;
 	}
 	tegra_slink_writel(tspi, tspi->command_reg, SLINK_COMMAND);
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 14 lines · Navid Emamdoost

Call to pm_runtime_get_sync increments counter even in case of failure leading to incorrect ref count.
Call pm_runtime_put if pm_runtime_get_sync fails.

---
 drivers/spi/spi-tegra20-slink.c | 1 +
 1 file changed, 1 insertion(+)
drivers/spi/spi-tegra20-slink.c +0 -0
index 7f4d932dade7..0675b36d647b 100644

drivers/spi/spi-tegra20-slink.c static int tegra_slink_resume(struct device *dev) · line 1198

Quoted 7 lines
drivers/spi/spi-tegra20-slink.c +1 -0
@@ -1192,6 +1192,7 @@ static int tegra_slink_resume(struct device *dev)
 	ret = pm_runtime_get_sync(dev);
 	if (ret < 0) {
 		dev_err(dev, "pm runtime failed, e = %d\n", ret);
+		pm_runtime_put(dev);
 		return ret;
 	}
 	tegra_slink_writel(tspi, tspi->command_reg, SLINK_COMMAND);

Please squash this patch with the other 2 that are fixing the same issues in the same driver.

Jon

Signature · 1 line
nvpublic