Skip to contentSkip to conversation

MAINTAINERS: Add Lee Jones as reviewer for the PWM subsystem

PATCH In review Thierry Reding 3 participants 6 messages Jun 2, 2020 – Jun 3, 2020 PWM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Add Lee Jones as reviewer for the PWM subsystem

Lee has kindly offered his help in sharing the patch review workload for the PWM subsystem. If this works out well between Lee, Uwe and myself it may be a good idea to maintain the subsystem as a group.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index e64e5db31497..b8889bed5d1e 100644
@@ -13736,6 +13736,7 @@ F:	drivers/media/rc/pwm-ir-tx.c
 PWM SUBSYSTEM
 M:	Thierry Reding <[email protected]>
 R:	Uwe Kleine-König <[email protected]>
+M:	Lee Jones <[email protected]>
 L:	[email protected]
 S:	Maintained
 Q:	https://patchwork.ozlabs.org/project/linux-pwm/list/
Signature · 1 line
2.24.1
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Thierry Reding

Lee has kindly offered his help in sharing the patch review workload for the PWM subsystem. If this works out well between Lee, Uwe and myself it may be a good idea to maintain the subsystem as a group.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Works for me.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#2 lore raw
In reply to Thierry Reding
Quoted 14 lines · Thierry Reding

Lee has kindly offered his help in sharing the patch review workload for the PWM subsystem. If this works out well between Lee, Uwe and myself it may be a good idea to maintain the subsystem as a group.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index e64e5db31497..b8889bed5d1e 100644

MAINTAINERS F: drivers/media/rc/pwm-ir-tx.c · line 13739

Quoted 4 lines
MAINTAINERS +1 -0
@@ -13736,6 +13736,7 @@ F:	drivers/media/rc/pwm-ir-tx.c
 PWM SUBSYSTEM
 M:	Thierry Reding <[email protected]>
 R:	Uwe Kleine-König <[email protected]>
+M:	Lee Jones <[email protected]>

I'm bit surprised that Lee got M: which I have a R:. The commit log talks about reviewer not maintainer.

While I'm not sure that there is a practical difference it makes me a bit sad.

Best regards
Uwe

#3 lore raw
Quoted 23 lines · Uwe Kleine-König
Quoted 14 lines · Thierry Reding

Lee has kindly offered his help in sharing the patch review workload for the PWM subsystem. If this works out well between Lee, Uwe and myself it may be a good idea to maintain the subsystem as a group.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index e64e5db31497..b8889bed5d1e 100644

MAINTAINERS F: drivers/media/rc/pwm-ir-tx.c · line 13739

Quoted 4 lines
MAINTAINERS +1 -0
@@ -13736,6 +13736,7 @@ F:	drivers/media/rc/pwm-ir-tx.c
 PWM SUBSYSTEM
 M:	Thierry Reding <[email protected]>
 R:	Uwe Kleine-König <[email protected]>
+M:	Lee Jones <[email protected]>

I'm bit surprised that Lee got M: which I have a R:. The commit log talks about reviewer not maintainer.

Quoted 2 lines

While I'm not sure that there is a practical difference it makes me a bit sad.

That was not the intention. According to the notes at the top of the MAINTAINERS file, recipients on M: lines will be added in the To:
header, while R: lines will be added in the Cc: header. That's really the only difference.

In practical terms this may be helpful for filtering where email where you are on the To: line can be prioritized over those where you are on the Cc: line.

Thierry

#4 lore raw
Quoted 27 lines · Thierry Reding
Quoted 23 lines · Uwe Kleine-König
Quoted 14 lines · Thierry Reding

Lee has kindly offered his help in sharing the patch review workload for the PWM subsystem. If this works out well between Lee, Uwe and myself it may be a good idea to maintain the subsystem as a group.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index e64e5db31497..b8889bed5d1e 100644

MAINTAINERS F: drivers/media/rc/pwm-ir-tx.c · line 13739

Quoted 4 lines
MAINTAINERS +1 -0
@@ -13736,6 +13736,7 @@ F:	drivers/media/rc/pwm-ir-tx.c
 PWM SUBSYSTEM
 M:	Thierry Reding <[email protected]>
 R:	Uwe Kleine-König <[email protected]>
+M:	Lee Jones <[email protected]>

I'm bit surprised that Lee got M: which I have a R:. The commit log talks about reviewer not maintainer.

Quoted 2 lines

While I'm not sure that there is a practical difference it makes me a bit sad.

Quoted 8 lines

That was not the intention. According to the notes at the top of the MAINTAINERS file, recipients on M: lines will be added in the To:
header, while R: lines will be added in the Cc: header. That's really the only difference.

In practical terms this may be helpful for filtering where email where you are on the To: line can be prioritized over those where you are on the Cc: line.

Exactly right.

It's a common misconception that M: means 'Maintainer'. It doesn't.
M: simply means "Mail-to". It has nothing to do with maintainership levels/hierarchy and everything to do with mail filtering.

Nothing to be sad about.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#5 lore raw
Quoted 38 lines · Lee Jones
Quoted 27 lines · Thierry Reding
Quoted 23 lines · Uwe Kleine-König
Quoted 14 lines · Thierry Reding

Lee has kindly offered his help in sharing the patch review workload for the PWM subsystem. If this works out well between Lee, Uwe and myself it may be a good idea to maintain the subsystem as a group.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index e64e5db31497..b8889bed5d1e 100644

MAINTAINERS F: drivers/media/rc/pwm-ir-tx.c · line 13739

Quoted 4 lines
MAINTAINERS +1 -0
@@ -13736,6 +13736,7 @@ F:	drivers/media/rc/pwm-ir-tx.c
 PWM SUBSYSTEM
 M:	Thierry Reding <[email protected]>
 R:	Uwe Kleine-König <[email protected]>
+M:	Lee Jones <[email protected]>

I'm bit surprised that Lee got M: which I have a R:. The commit log talks about reviewer not maintainer.

Quoted 2 lines

While I'm not sure that there is a practical difference it makes me a bit sad.

Quoted 8 lines

That was not the intention. According to the notes at the top of the MAINTAINERS file, recipients on M: lines will be added in the To:
header, while R: lines will be added in the Cc: header. That's really the only difference.

In practical terms this may be helpful for filtering where email where you are on the To: line can be prioritized over those where you are on the Cc: line.

Quoted 5 lines

Exactly right.

It's a common misconception that M: means 'Maintainer'. It doesn't.
M: simply means "Mail-to". It has nothing to do with maintainership levels/hierarchy and everything to do with mail filtering.

Although maybe someone should tell scripts/get_maintainer.pl that!

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog