slip: not call free_netdev before rtnl_unlock in slip_open
PATCH 2/2 slip: not call free_netdev before rtnl_unlock in slip_open
From: yangerkun <[email protected]>
commit f596c87005f7b1baeb7d62d9a9e25d68c3dfae10 upstream.
As the description before netdev_run_todo, we cannot call free_netdev before rtnl_unlock, fix it by reorder the code.
Signed-off-by yangerkun <[email protected]>
Reviewed-by Oliver Hartkopp <[email protected]>
Signed-off-by David S. Miller <[email protected]>
[bwh: Backported to <4.11: free_netdev() is called through sl_free_netdev()]
Signed-off-by Ben Hutchings <[email protected]>
--- drivers/net/slip/slip.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/slip/slip.c +3 -0
@@ -867,7 +867,10 @@ static int slip_open(struct tty_struct *tty) sl->tty =NULL ; tty->disc_data =NULL ;clear_bit (SLF_INUSE , &sl->flags); +/* do not call free_netdev before rtnl_unlock */ +rtnl_unlock ();sl_free_netdev (sl->dev); +return err; err_exit:rtnl_unlock ();