Skip to contentSkip to conversation

linux-next: build failure after merge of the akpm tree

PATCH Stephen Rothwell 2 participants 2 messages Jun 2, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the akpm tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:

ERROR: modpost: ".probe_user_write" [arch/powerpc/kvm/kvm-hv.ko] undefined!

Caused by patch

"maccess: unexport probe_kernel_write and probe_user_write"

"These two functions are not used by any modular code." turns out to not be true :-(

I have added this patch:

From: Stephen Rothwell <[email protected]>
Date: Tue, 2 Jun 2020 19:54:05 +1000
Subject: [PATCH] turns out that probe_user_write is used in modular code

---
 mm/maccess.c | 1 +
 1 file changed, 1 insertion(+)
mm/maccess.c +1 -0
index ddfda8e6f4a5..88845eda5047 100644
@@ -246,6 +246,7 @@ long probe_user_write(void __user *dst, const void *src, size_t size)
 		return -EFAULT;
 	return 0;
 }
+EXPORT_SYMBOL_GPL(probe_user_write);
 
 /**
  * strncpy_from_user_nofault: - Copy a NUL terminated string from unsafe user
Signature · 5 lines
2.26.2

-- 
Cheers,
Stephen Rothwell
maintainer
#1 lore raw
Quoted 12 lines · On Tue, 2 Jun 2020 19:57:41 +1000 Stephen Rothwell <[email protected]> wrote:

Subject: [PATCH] turns out that probe_user_write is used in modular code

---
 mm/maccess.c | 1 +
 1 file changed, 1 insertion(+)
mm/maccess.c +0 -0
index ddfda8e6f4a5..88845eda5047 100644

mm/maccess.c long probe_user_write(void __user *dst, const void *src, size_t size) · line 249

Quoted 4 lines
mm/maccess.c +1 -0
@@ -246,6 +246,7 @@ long probe_user_write(void __user *dst, const void *src, size_t size)
 		return -EFAULT;
 	return 0;
 }
+EXPORT_SYMBOL_GPL(probe_user_write);

Thanks, I shall squish that in and make the appropriate changelog update.