Enable generic math code for more arches
v3 cover Enable generic math code for more arches
Hi,
This was suggested by Adhemerval Zanella as part of ARC hard float review.
changes since v2:
- Add new defines (0) to s390 too as suggested by Stephan
- Handle USE_FMA_BUILTIN in both sysdeps/ieee754/{dbl-64,ldbl-128}/s_fma.c
- Add diff output for all arches build tested
build-glibc-many tested for following
aarch64-linux-gnu
arm-linux-gnueabi
arm-linux-gnueabihf
hppa-linux-gnu
x86_64-linux-gnu
riscv64-linux-gnu-rv64imac-lp64
riscv64-linux-gnu-rv64imafdc-lp64
powerpc-linux-gnu
microblaze-linux-gnu
nios2-linux-gnu
hppa-linux-gnu
s390x-linux-gnu"
Thx,
-Vineet
Vineet Gupta (4):
iee754: provide gcc builtins based generic sqrt functions
iee754: provide gcc builtins based generic fma functions aarch/fpu: use generic builtins based math functions powerpc/fpu: use generic fma functions
sysdeps/aarch64/fpu/e_sqrt.c | 27 -------- sysdeps/aarch64/fpu/e_sqrtf.c | 27 -------- sysdeps/aarch64/fpu/math-use-builtins.h | 71 +++++++++++++++++++++ sysdeps/aarch64/fpu/s_floor.c | 29 --------- sysdeps/aarch64/fpu/s_floorf.c | 29 --------- sysdeps/aarch64/fpu/s_fma.c | 28 -------- sysdeps/aarch64/fpu/s_fmaf.c | 28 -------- sysdeps/aarch64/fpu/s_nearbyint.c | 28 -------- sysdeps/aarch64/fpu/s_nearbyintf.c | 28 -------- sysdeps/aarch64/fpu/s_rint.c | 29 --------- sysdeps/aarch64/fpu/s_rintf.c | 29 --------- sysdeps/aarch64/fpu/s_round.c | 29 --------- sysdeps/aarch64/fpu/s_roundf.c | 29 --------- sysdeps/aarch64/fpu/s_trunc.c | 29 --------- sysdeps/aarch64/fpu/s_truncf.c | 29 --------- sysdeps/generic/math-use-builtins.h | 8 +++ sysdeps/ieee754/dbl-64/e_sqrt.c | 6 ++ sysdeps/ieee754/dbl-64/s_fma.c | 6 ++ sysdeps/ieee754/dbl-64/s_fmaf.c | 6 ++ sysdeps/ieee754/float128/float128_private.h | 2 + sysdeps/ieee754/flt-32/e_sqrtf.c | 16 +++-- sysdeps/ieee754/ldbl-128/s_fma.c | 5 ++ sysdeps/ieee754/ldbl-128/s_fmal.c | 5 ++ sysdeps/powerpc/fpu/math-use-builtins.h | 69 ++++++++++++++++++++ sysdeps/powerpc/fpu/s_fma.c | 27 -------- sysdeps/powerpc/fpu/s_fmaf.c | 27 -------- sysdeps/s390/fpu/math-use-builtins.h | 8 +++ 27 files changed, 196 insertions(+), 458 deletions(-) delete mode 100644 sysdeps/aarch64/fpu/e_sqrt.c delete mode 100644 sysdeps/aarch64/fpu/e_sqrtf.c create mode 100644 sysdeps/aarch64/fpu/math-use-builtins.h delete mode 100644 sysdeps/aarch64/fpu/s_floor.c delete mode 100644 sysdeps/aarch64/fpu/s_floorf.c delete mode 100644 sysdeps/aarch64/fpu/s_fma.c delete mode 100644 sysdeps/aarch64/fpu/s_fmaf.c delete mode 100644 sysdeps/aarch64/fpu/s_nearbyint.c delete mode 100644 sysdeps/aarch64/fpu/s_nearbyintf.c delete mode 100644 sysdeps/aarch64/fpu/s_rint.c delete mode 100644 sysdeps/aarch64/fpu/s_rintf.c delete mode 100644 sysdeps/aarch64/fpu/s_round.c delete mode 100644 sysdeps/aarch64/fpu/s_roundf.c delete mode 100644 sysdeps/aarch64/fpu/s_trunc.c delete mode 100644 sysdeps/aarch64/fpu/s_truncf.c create mode 100644 sysdeps/powerpc/fpu/math-use-builtins.h delete mode 100644 sysdeps/powerpc/fpu/s_fma.c delete mode 100644 sysdeps/powerpc/fpu/s_fmaf.c
Signature · 7 lines
2.20.1 _______________________________________________ linux-snps-arc mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-snps-arc
PATCH v3 1/4 iee754: provide gcc builtins based generic sqrt functions
--- sysdeps/generic/math-use-builtins.h | 3 +++ sysdeps/ieee754/dbl-64/e_sqrt.c | 6 ++++++ sysdeps/ieee754/flt-32/e_sqrtf.c | 16 ++++++++++------ sysdeps/s390/fpu/math-use-builtins.h | 3 +++ 4 files changed, 22 insertions(+), 6 deletions(-)
sysdeps/generic/math-use-builtins.h +3 -0
@@ -60,4 +60,7 @@# define USE_COPYSIGNF128_BUILTIN 0#endif +#define USE_SQRT_BUILTIN 0 +#define USE_SQRTF_BUILTIN 0 +#endif /* math-use-builtins.h */
sysdeps/ieee754/dbl-64/e_sqrt.c +6 -0
@@ -41,6 +41,7 @@#include <math_private.h> #include <fenv_private.h> #include <libm-alias-finite.h> +#include <math-use-builtins.h> /*********************************************************************/ /* An ultimate sqrt routine. Given an IEEE double machine number x */
@@ -50,6 +51,10 @@double __ieee754_sqrt (double x) { +#if USE_SQRT_BUILTIN +return __builtin_sqrt (x); +#else +/* Use generic implementation. */ static const double rt0 =9.99999999859990725855365213134618E-01 , rt1 = 4.99999999495955425917856814202739E-01,
@@ -138,6 +143,7 @@ __ieee754_sqrt (double x)return (x - x) / (x - x);/* sqrt(-ve)=sNaN */ return 0x1p-256 * __ieee754_sqrt (x * 0x1p512); } +#endif /* ! USE_SQRT_BUILTIN */ }#ifndef __ieee754_sqrtlibm_alias_finite (__ieee754_sqrt, __sqrt)
sysdeps/ieee754/flt-32/e_sqrtf.c +10 -6
@@ -16,12 +16,15 @@#include <math.h> #include <math_private.h> #include <libm-alias-finite.h> - -static const float one =1.0 , tiny=1.0e-30 ; +#include <math-use-builtins.h> float __ieee754_sqrtf (float x) { +#if USE_SQRTF_BUILTIN +return __builtin_sqrtf (x); +#else +/* Use generic implementation. */ float z;int32_t sign = (int )0x80000000 ;int32_t ix,s,q,m,t,i;
@@ -70,10 +73,10 @@ __ieee754_sqrtf(float x)/* use floating add to find out rounding direction */ if (ix!=0 ) { - z = one-tiny;/* trigger inexact flag */ -if (z>=one) { - z = one+tiny; -if (z>one) + z =0x1p0 -0x1.4484cp-100 ;/* trigger inexact flag. */ +if (z >=0x1p0 ) { + z =0x1p0 +0x1.4484cp-100 ; +if (z >0x1p0 ) q +=2 ;else q += (q&1 );
@@ -83,6 +86,7 @@ __ieee754_sqrtf(float x) ix += (m <<23 );SET_FLOAT_WORD (z,ix);return z; +#endif /* ! USE_SQRTF_BUILTIN */ }#ifndef __ieee754_sqrtflibm_alias_finite (__ieee754_sqrtf, __sqrtf)
sysdeps/s390/fpu/math-use-builtins.h +3 -0
@@ -108,4 +108,7 @@# define USE_COPYSIGNF128_BUILTIN 0#endif +#define USE_SQRT_BUILTIN 0 +#define USE_SQRTF_BUILTIN 0 +#endif /* math-use-builtins.h */
Signature · 7 lines
2.20.1 _______________________________________________ linux-snps-arc mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH v3 1/4] iee754: provide gcc builtins based generic sqrt functions
s/iee754/ieee754/
Andreas.
Signature · 8 lines
Andreas Schwab, [email protected] GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." _______________________________________________ linux-snps-arc mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH v3 1/4] iee754: provide gcc builtins based generic sqrt functions
Quoted 1 line · Andreas Schwab
s/iee754/ieee754/
Fixed. Thx
_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH v3 1/4] iee754: provide gcc builtins based generic sqrt functions
Quoted 5 lines · Vineet Gupta via Libc-alpha
Quoted 1 line · Andreas Schwab
s/iee754/ieee754/
Fixed. Thx
I think this patchset is ok, there is no need to send a v4. Do you need someone to push it upstream for you?
_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH v3 1/4] iee754: provide gcc builtins based generic sqrt functions
Quoted 2 lines · Adhemerval Zanella via Libc-alpha
I think this patchset is ok, there is no need to send a v4. Do you need someone to push it upstream for you?
I do have write access to repo, I'll push it shortly.
Thx,
-Vineet
_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
PATCH v3 2/4 iee754: provide gcc builtins based generic fma functions
In reply to Vineet Gupta--- sysdeps/generic/math-use-builtins.h | 5 +++++ sysdeps/ieee754/dbl-64/s_fma.c | 6 ++++++ sysdeps/ieee754/dbl-64/s_fmaf.c | 6 ++++++ sysdeps/ieee754/float128/float128_private.h | 2 ++ sysdeps/ieee754/ldbl-128/s_fma.c | 5 +++++ sysdeps/ieee754/ldbl-128/s_fmal.c | 5 +++++ sysdeps/s390/fpu/math-use-builtins.h | 5 +++++ 7 files changed, 34 insertions(+)
sysdeps/generic/math-use-builtins.h +5 -0
@@ -63,4 +63,9 @@#define USE_SQRT_BUILTIN 0#define USE_SQRTF_BUILTIN 0 +#define USE_FMA_BUILTIN 0 +#define USE_FMAF_BUILTIN 0 +#define USE_FMAL_BUILTIN 0 +#define USE_FMAF128_BUILTIN 0 +#endif /* math-use-builtins.h */
sysdeps/ieee754/dbl-64/s_fma.c +6 -0
@@ -25,6 +25,7 @@#include <fenv_private.h> #include <libm-alias-double.h> #include <tininess.h> +#include <math-use-builtins.h> /* This implementation uses rounding to odd to avoid problems with double rounding. See a paper by Boldo and Melquiond:
@@ -33,6 +34,10 @@double __fma (double x,double y,double z) { +#if USE_FMA_BUILTIN +return __builtin_fma (x, y, z); +#else +/* Use generic implementation. */ union ieee754_double u, v, w;int adjust =0 ; u.d = x;
@@ -292,6 +297,7 @@ __fma (double x, double y, double z) v.ieee.mantissa1 |= j; return v.d * 0x1p-108; } +#endif /* ! USE_FMA_BUILTIN */ }#ifndef __fmalibm_alias_double (__fma, fma)
sysdeps/ieee754/dbl-64/s_fmaf.c +6 -0
@@ -23,6 +23,7 @@#include <math-barriers.h> #include <fenv_private.h> #include <libm-alias-float.h> +#include <math-use-builtins.h> /* This implementation relies on double being more than twice as precise as float and uses rounding to odd in order to avoid problems
@@ -33,6 +34,10 @@float __fmaf (float x,float y,float z) { +#if USE_FMAF_BUILTIN +return __builtin_fmaf (x, y, z); +#else +/* Use generic implementation. */ fenv_t env;/* Multiplication is always exact. */
@@ -60,6 +65,7 @@ __fmaf (float x, float y, float z)/* And finally truncation with round to nearest. */ return (float ) u.d; +#endif /* ! USE_FMAF_BUILTIN */ }#ifndef __fmaflibm_alias_float (__fma, fma)
sysdeps/ieee754/float128/float128_private.h +2 -0
@@ -154,6 +154,8 @@#define USE_ROUNDL_BUILTIN USE_ROUNDF128_BUILTIN#undef USE_COPYSIGNL_BUILTIN#define USE_COPYSIGNL_BUILTIN USE_COPYSIGNF128_BUILTIN +#undef USE_FMAL_BUILTIN +#define USE_FMAL_BUILTIN USE_FMAF128_BUILTIN/* IEEE function renames. */ #define __ieee754_acoshl __ieee754_acoshf128
sysdeps/ieee754/ldbl-128/s_fma.c +5 -0
@@ -21,6 +21,7 @@#include <fenv.h> #include <ieee754.h> #include <libm-alias-double.h> +#include <math-use-builtins.h> /* This implementation relies on long double being more than twice as precise as double and uses rounding to odd in order to avoid problems
@@ -31,6 +32,9 @@double __fma (double x,double y,double z) { +#if USE_FMA_BUILTIN +return __builtin_fma (x, y, z); +#else fenv_t env;/* Multiplication is always exact. */ long double temp = (long double ) x * (long double ) y;
@@ -50,6 +54,7 @@ __fma (double x, double y, double z)feupdateenv (&env);/* And finally truncation with round to nearest. */ return (double ) u.d; +#endif /* ! USE_FMA_BUILTIN */ }#ifndef __fmalibm_alias_double (__fma, fma)
sysdeps/ieee754/ldbl-128/s_fmal.c +5 -0
@@ -25,6 +25,7 @@#include <math_private.h> #include <libm-alias-ldouble.h> #include <tininess.h> +#include <math-use-builtins.h> /* This implementation uses rounding to odd to avoid problems with double rounding. See a paper by Boldo and Melquiond:
@@ -33,6 +34,9 @@_Float128 __fmal (_Float128 x,_Float128 y,_Float128 z) { +#if USE_FMAL_BUILTIN +return __builtin_fmal (x, y, z); +#else union ieee854_long_double u, v, w;int adjust =0 ; u.d = x;
@@ -296,5 +300,6 @@ __fmal (_Float128 x, _Float128 y, _Float128 z) v.ieee.mantissa3 |= j; return v.d * L(0x1p-228); } +#endif /* ! USE_FMAL_BUILTIN */ }libm_alias_ldouble (__fma, fma)
sysdeps/s390/fpu/math-use-builtins.h +5 -0
@@ -111,4 +111,9 @@#define USE_SQRT_BUILTIN 0#define USE_SQRTF_BUILTIN 0 +#define USE_FMA_BUILTIN 0 +#define USE_FMAF_BUILTIN 0 +#define USE_FMAL_BUILTIN 0 +#define USE_FMAF128_BUILTIN 0 +#endif /* math-use-builtins.h */
Signature · 7 lines
2.20.1 _______________________________________________ linux-snps-arc mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-snps-arc
PATCH v3 3/4 aarch/fpu: use generic builtins based math functions
In reply to Vineet Guptaintroduce sysdep header math-use-builtins.h to replace aarch64 implementations with corresponding generic ones.
- newly inroduced generic sqrt{,f}, fma{,f}
- existing floor{,f}, nearbyint{,f}, rint{,f}, round{,f}, trunc{,f}
- Note that generic copysign was already enabled (via generic math-use-builtins.h) now thru sysdep header
Tested with build-many-glibcs for aarch64-linux-gnu
This is a non functional change and aarch64 libm before/after was byte invariant as compared below:
| cd /SCRATCH/vgupta/gnu/install-glibc-A-baseline | for i in `find . -name libm-2.31.9000.so`; do | echo $i; diff $i /SCRATCH/vgupta/gnu/install-glibc-C-reduce-scope/$i ; | echo $?; | done
| ./aarch64-linux-gnu/lib64/libm-2.31.9000.so | 0 | ./arm-linux-gnueabi/lib/libm-2.31.9000.so | 0 | ./x86_64-linux-gnu/lib64/libm-2.31.9000.so | 0 | ./arm-linux-gnueabihf/lib/libm-2.31.9000.so | 0 | ./riscv64-linux-gnu-rv64imac-lp64/lib64/lp64/libm-2.31.9000.so | 0 | ./riscv64-linux-gnu-rv64imafdc-lp64/lib64/lp64/libm-2.31.9000.so | 0 | ./powerpc-linux-gnu/lib/libm-2.31.9000.so | 0 | ./microblaze-linux-gnu/lib/libm-2.31.9000.so | 0 | ./nios2-linux-gnu/lib/libm-2.31.9000.so | 0 | ./hppa-linux-gnu/lib/libm-2.31.9000.so | 0 | ./s390x-linux-gnu/lib64/libm-2.31.9000.so | 0
--- sysdeps/aarch64/fpu/e_sqrt.c | 27 ---------- sysdeps/aarch64/fpu/e_sqrtf.c | 27 ---------- sysdeps/aarch64/fpu/math-use-builtins.h | 71 +++++++++++++++++++++++++ sysdeps/aarch64/fpu/s_floor.c | 29 ---------- sysdeps/aarch64/fpu/s_floorf.c | 29 ---------- sysdeps/aarch64/fpu/s_fma.c | 28 ---------- sysdeps/aarch64/fpu/s_fmaf.c | 28 ---------- sysdeps/aarch64/fpu/s_nearbyint.c | 28 ---------- sysdeps/aarch64/fpu/s_nearbyintf.c | 28 ---------- sysdeps/aarch64/fpu/s_rint.c | 29 ---------- sysdeps/aarch64/fpu/s_rintf.c | 29 ---------- sysdeps/aarch64/fpu/s_round.c | 29 ---------- sysdeps/aarch64/fpu/s_roundf.c | 29 ---------- sysdeps/aarch64/fpu/s_trunc.c | 29 ---------- sysdeps/aarch64/fpu/s_truncf.c | 29 ---------- 15 files changed, 71 insertions(+), 398 deletions(-) delete mode 100644 sysdeps/aarch64/fpu/e_sqrt.c delete mode 100644 sysdeps/aarch64/fpu/e_sqrtf.c create mode 100644 sysdeps/aarch64/fpu/math-use-builtins.h delete mode 100644 sysdeps/aarch64/fpu/s_floor.c delete mode 100644 sysdeps/aarch64/fpu/s_floorf.c delete mode 100644 sysdeps/aarch64/fpu/s_fma.c delete mode 100644 sysdeps/aarch64/fpu/s_fmaf.c delete mode 100644 sysdeps/aarch64/fpu/s_nearbyint.c delete mode 100644 sysdeps/aarch64/fpu/s_nearbyintf.c delete mode 100644 sysdeps/aarch64/fpu/s_rint.c delete mode 100644 sysdeps/aarch64/fpu/s_rintf.c delete mode 100644 sysdeps/aarch64/fpu/s_round.c delete mode 100644 sysdeps/aarch64/fpu/s_roundf.c delete mode 100644 sysdeps/aarch64/fpu/s_trunc.c delete mode 100644 sysdeps/aarch64/fpu/s_truncf.c
sysdeps/aarch64/fpu/e_sqrt.c deleted +0 -27
@@ -1,27 +0,0 @@ -/* Square root of floating point number. -Copyright (C) 2015-2020 Free Software Foundation, Inc. -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public -License as published by the Free Software Foundation; either -version 2.1 of the License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#include <math_private.h> -#include <libm-alias-finite.h> - -double -__ieee754_sqrt (double d) -{ -return __builtin_sqrt (d); -} -libm_alias_finite (__ieee754_sqrt, __sqrt)
sysdeps/aarch64/fpu/e_sqrtf.c deleted +0 -27
@@ -1,27 +0,0 @@ -/* Single-precision floating point square root. -Copyright (C) 2015-2020 Free Software Foundation, Inc. -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public -License as published by the Free Software Foundation; either -version 2.1 of the License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#include <math_private.h> -#include <libm-alias-finite.h> - -float -__ieee754_sqrtf (float s) -{ -return __builtin_sqrtf (s); -} -libm_alias_finite (__ieee754_sqrtf, __sqrtf)
sysdeps/aarch64/fpu/math-use-builtins.h new file +71 -0
71 lines not on this page · raw message
sysdeps/aarch64/fpu/s_floor.c deleted +0 -29
@@ -1,29 +0,0 @@ -/* Copyright (C) 2011-2020 Free Software Foundation, Inc. - -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public License as -published by the Free Software Foundation; either version 2.1 of the -License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#define NO_MATH_REDIRECT -#include <math.h> -#include <libm-alias-double.h> - -double -__floor (double x) -{ -return __builtin_floor (x); -} - -libm_alias_double (__floor, floor)
sysdeps/aarch64/fpu/s_floorf.c deleted +0 -29
@@ -1,29 +0,0 @@ -/* Copyright (C) 2011-2020 Free Software Foundation, Inc. - -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public License as -published by the Free Software Foundation; either version 2.1 of the -License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#define NO_MATH_REDIRECT -#include <math.h> -#include <libm-alias-float.h> - -float -__floorf (float x) -{ -return __builtin_floorf (x); -} - -libm_alias_float (__floor, floor)
sysdeps/aarch64/fpu/s_fma.c deleted +0 -28
@@ -1,28 +0,0 @@ -/* Copyright (C) 1996-2020 Free Software Foundation, Inc. - -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public -License as published by the Free Software Foundation; either -version 2.1 of the License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#include <math.h> -#include <libm-alias-double.h> - -double -__fma (double x,double y,double z) -{ -return __builtin_fma (x, y, z); -} - -libm_alias_double (__fma, fma)
sysdeps/aarch64/fpu/s_fmaf.c deleted +0 -28
@@ -1,28 +0,0 @@ -/* Copyright (C) 2011-2020 Free Software Foundation, Inc. - -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public License as -published by the Free Software Foundation; either version 2.1 of the -License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#include <math.h> -#include <libm-alias-float.h> - -float -__fmaf (float x,float y,float z) -{ -return __builtin_fmaf (x, y, z); -} - -libm_alias_float (__fma, fma)
sysdeps/aarch64/fpu/s_nearbyint.c deleted +0 -28
@@ -1,28 +0,0 @@ -/* Copyright (C) 2011-2020 Free Software Foundation, Inc. - -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public License as -published by the Free Software Foundation; either version 2.1 of the -License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#include <math.h> -#include <libm-alias-double.h> - -double -__nearbyint (double x) -{ -return __builtin_nearbyint (x); -} - -libm_alias_double (__nearbyint, nearbyint)
sysdeps/aarch64/fpu/s_nearbyintf.c deleted +0 -28
@@ -1,28 +0,0 @@ -/* Copyright (C) 2011-2020 Free Software Foundation, Inc. - -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public License as -published by the Free Software Foundation; either version 2.1 of the -License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#include <math.h> -#include <libm-alias-float.h> - -float -__nearbyintf (float x) -{ -return __builtin_nearbyintf (x); -} - -libm_alias_float (__nearbyint, nearbyint)
sysdeps/aarch64/fpu/s_rint.c deleted +0 -29
@@ -1,29 +0,0 @@ -/* Copyright (C) 2011-2020 Free Software Foundation, Inc. - -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public License as -published by the Free Software Foundation; either version 2.1 of the -License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#define NO_MATH_REDIRECT -#include <math.h> -#include <libm-alias-double.h> - -double -__rint (double x) -{ -return __builtin_rint (x); -} - -libm_alias_double (__rint, rint)
sysdeps/aarch64/fpu/s_rintf.c deleted +0 -29
@@ -1,29 +0,0 @@ -/* Copyright (C) 2011-2020 Free Software Foundation, Inc. - -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public License as -published by the Free Software Foundation; either version 2.1 of the -License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#define NO_MATH_REDIRECT -#include <math.h> -#include <libm-alias-float.h> - -float -__rintf (float x) -{ -return __builtin_rintf (x); -} - -libm_alias_float (__rint, rint)
sysdeps/aarch64/fpu/s_round.c deleted +0 -29
@@ -1,29 +0,0 @@ -/* Copyright (C) 2011-2020 Free Software Foundation, Inc. - -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public License as -published by the Free Software Foundation; either version 2.1 of the -License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#define NO_MATH_REDIRECT -#include <math.h> -#include <libm-alias-double.h> - -double -__round (double x) -{ -return __builtin_round (x); -} - -libm_alias_double (__round, round)
sysdeps/aarch64/fpu/s_roundf.c deleted +0 -29
@@ -1,29 +0,0 @@ -/* Copyright (C) 2011-2020 Free Software Foundation, Inc. - -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public License as -published by the Free Software Foundation; either version 2.1 of the -License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#define NO_MATH_REDIRECT -#include <math.h> -#include <libm-alias-float.h> - -float -__roundf (float x) -{ -return __builtin_roundf (x); -} - -libm_alias_float (__round, round)
sysdeps/aarch64/fpu/s_trunc.c deleted +0 -29
@@ -1,29 +0,0 @@ -/* Copyright (C) 2011-2020 Free Software Foundation, Inc. - -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public License as -published by the Free Software Foundation; either version 2.1 of the -License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#define NO_MATH_REDIRECT -#include <math.h> -#include <libm-alias-double.h> - -double -__trunc (double x) -{ -return __builtin_trunc (x); -} - -libm_alias_double (__trunc, trunc)
sysdeps/aarch64/fpu/s_truncf.c deleted +0 -29
@@ -1,29 +0,0 @@ -/* Copyright (C) 2011-2020 Free Software Foundation, Inc. - -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public License as -published by the Free Software Foundation; either version 2.1 of the -License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#define NO_MATH_REDIRECT -#include <math.h> -#include <libm-alias-float.h> - -float -__truncf (float x) -{ -return __builtin_truncf (x); -} - -libm_alias_float (__trunc, trunc)
Signature · 7 lines
2.20.1 _______________________________________________ linux-snps-arc mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-snps-arc
PATCH v3 4/4 powerpc/fpu: use generic fma functions
In reply to Vineet GuptaTested with build-many-glibcs for powerpc-linux-gnu
This is a non functional change and powerpc libm before/after was byte invariant as compared below:
| cd /SCRATCH/vgupta/gnu/install-glibc-A-baseline | for i in `find . -name libm-2.31.9000.so`; do | echo $i; diff $i /SCRATCH/vgupta/gnu/install-glibc-C-reduce-scope/$i ; | echo $?; | done
| ./aarch64-linux-gnu/lib64/libm-2.31.9000.so | 0 | ./arm-linux-gnueabi/lib/libm-2.31.9000.so | 0 | ./x86_64-linux-gnu/lib64/libm-2.31.9000.so | 0 | ./arm-linux-gnueabihf/lib/libm-2.31.9000.so | 0 | ./riscv64-linux-gnu-rv64imac-lp64/lib64/lp64/libm-2.31.9000.so | 0 | ./riscv64-linux-gnu-rv64imafdc-lp64/lib64/lp64/libm-2.31.9000.so | 0 | ./powerpc-linux-gnu/lib/libm-2.31.9000.so | 0 | ./microblaze-linux-gnu/lib/libm-2.31.9000.so | 0 | ./nios2-linux-gnu/lib/libm-2.31.9000.so | 0 | ./hppa-linux-gnu/lib/libm-2.31.9000.so | 0 | ./s390x-linux-gnu/lib64/libm-2.31.9000.so | 0
--- sysdeps/powerpc/fpu/math-use-builtins.h | 69 +++++++++++++++++++++++++ sysdeps/powerpc/fpu/s_fma.c | 27 ---------- sysdeps/powerpc/fpu/s_fmaf.c | 27 ---------- 3 files changed, 69 insertions(+), 54 deletions(-) create mode 100644 sysdeps/powerpc/fpu/math-use-builtins.h delete mode 100644 sysdeps/powerpc/fpu/s_fma.c delete mode 100644 sysdeps/powerpc/fpu/s_fmaf.c
sysdeps/powerpc/fpu/math-use-builtins.h new file +69 -0
@@ -0,0 +1,69 @@ +/* Using math gcc builtins instead of generic implementation. PowerPC version. +Copyright (C) 2019-2020 Free Software Foundation, Inc. +This file is part of the GNU C Library. + +The GNU C Library is free software; you can redistribute it and/or +modify it under the terms of the GNU Lesser General Public +License as published by the Free Software Foundation; either +version 2.1 of the License, or (at your option) any later version. + +The GNU C Library is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +Lesser General Public License for more details. + +You should have received a copy of the GNU Lesser General Public +License along with the GNU C Library; if not, see +<https://www.gnu.org/licenses/>. */ + +#ifndef MATH_USE_BUILTINS_H +#define MATH_USE_BUILTINS_H 1 + +#include <features.h> /* For __GNUC_PREREQ. */ + +/* Define these macros to 1 to use __builtin_xyz instead of the +generic implementation. */ +#define USE_NEARBYINT_BUILTIN 0 +#define USE_NEARBYINTF_BUILTIN 0 +#define USE_NEARBYINTL_BUILTIN 0 +#define USE_NEARBYINTF128_BUILTIN 0 + +#define USE_RINT_BUILTIN 0 +#define USE_RINTF_BUILTIN 0 +#define USE_RINTL_BUILTIN 0 +#define USE_RINTF128_BUILTIN 0 + +#define USE_FLOOR_BUILTIN 0 +#define USE_FLOORF_BUILTIN 0 +#define USE_FLOORL_BUILTIN 0 +#define USE_FLOORF128_BUILTIN 0 + +#define USE_CEIL_BUILTIN 0 +#define USE_CEILF_BUILTIN 0 +#define USE_CEILL_BUILTIN 0 +#define USE_CEILF128_BUILTIN 0 + +#define USE_TRUNC_BUILTIN 0 +#define USE_TRUNCF_BUILTIN 0 +#define USE_TRUNCL_BUILTIN 0 +#define USE_TRUNCF128_BUILTIN 0 + +#define USE_ROUND_BUILTIN 0 +#define USE_ROUNDF_BUILTIN 0 +#define USE_ROUNDL_BUILTIN 0 +#define USE_ROUNDF128_BUILTIN 0 + +#define USE_COPYSIGNL_BUILTIN 1 +#if __GNUC_PREREQ (7 ,0 ) +# define USE_COPYSIGNF128_BUILTIN 1 +#else +# define USE_COPYSIGNF128_BUILTIN 0 +#endif + +#define USE_SQRT_BUILTIN 0 +#define USE_SQRTF_BUILTIN 0 + +#define USE_FMA_BUILTIN 1 +#define USE_FMAF_BUILTIN 1 + +#endif
sysdeps/powerpc/fpu/s_fma.c deleted +0 -27
@@ -1,27 +0,0 @@ -/* Compute x * y + z as ternary operation. PowerPC version. -Copyright (C) 2019-2020 Free Software Foundation, Inc. -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public -License as published by the Free Software Foundation; either -version 2.1 of the License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#include <sysdep.h> -#include <libm-alias-double.h> - -double -__fma (double x,double y,double z) -{ -return __builtin_fma (x, y, z); -} -libm_alias_double (__fma, fma)
sysdeps/powerpc/fpu/s_fmaf.c deleted +0 -27
@@ -1,27 +0,0 @@ -/* Compute x * y + z as ternary operation. PowerPC version. -Copyright (C) 2019-2020 Free Software Foundation, Inc. -This file is part of the GNU C Library. - -The GNU C Library is free software; you can redistribute it and/or -modify it under the terms of the GNU Lesser General Public -License as published by the Free Software Foundation; either -version 2.1 of the License, or (at your option) any later version. - -The GNU C Library is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -Lesser General Public License for more details. - -You should have received a copy of the GNU Lesser General Public -License along with the GNU C Library; if not, see -<https://www.gnu.org/licenses/>. */ - -#include <sysdep.h> -#include <libm-alias-float.h> - -float -__fmaf (float x,float y,float z) -{ -return __builtin_fmaf (x, y, z); -} -libm_alias_float (__fma, fma)
Signature · 7 lines
2.20.1 _______________________________________________ linux-snps-arc mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-snps-arc