hwmon: bt1-pvt: Declare Temp- and Volt-to-N poly when alarms are enabled
PATCH 1/1 hwmon: bt1-pvt: Declare Temp- and Volt-to-N poly when alarms are enabled
Clang-based kernel building with W=1 warns that some static const variables are unused:
drivers/hwmon/bt1-pvt.c:67:30: warning: unused variable 'poly_temp_to_N' [-Wunused-const-variable]
static const struct pvt_poly poly_temp_to_N = {
^
drivers/hwmon/bt1-pvt.c:99:30: warning: unused variable 'poly_volt_to_N' [-Wunused-const-variable]
static const struct pvt_poly poly_volt_to_N = {
^Indeed these polynomials are utilized only when the PVT sensor alarms are enabled. In that case they are used to convert the temperature and voltage alarm limits from normal quantities (Volts and degree Celsius) to the sensor data representation N = [0, 1023]. Otherwise when alarms are disabled the driver only does the detected data conversion to the human readable form and doesn't need that polynomials defined. So let's declare the Temp-to-N and Volt-to-N polynomials only if the PVT alarms are switched on at compile-time.
Note gcc with W=1 doesn't notice the problem.
--- drivers/hwmon/bt1-pvt.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/hwmon/bt1-pvt.c +4 -0
@@ -64,6 +64,7 @@ static const struct pvt_sensor_info pvt_info[] = {* 48380, * where T = [-48380, 147438] mC and N = [0, 1023]. */ +#if defined(CONFIG_SENSORS_BT1_PVT_ALARMS) static const struct pvt_poly poly_temp_to_N = { .total_divider = 10000, .terms = {
@@ -74,6 +75,7 @@ static const struct pvt_poly poly_temp_to_N = { {0, 1720400, 1, 1} } }; +#endif /* CONFIG_SENSORS_BT1_PVT_ALARMS */ static const struct pvt_poly poly_N_to_temp = { .total_divider =1 ,
@@ -96,6 +98,7 @@ static const struct pvt_poly poly_N_to_temp = {* N = (18658e-3*V - 11572) / 10, * V = N * 10^5 / 18658 + 11572 * 10^4 / 18658. */ +#if defined(CONFIG_SENSORS_BT1_PVT_ALARMS) static const struct pvt_poly poly_volt_to_N = { .total_divider = 10, .terms = {
@@ -103,6 +106,7 @@ static const struct pvt_poly poly_volt_to_N = { {0, -11572, 1, 1} } }; +#endif /* CONFIG_SENSORS_BT1_PVT_ALARMS */ static const struct pvt_poly poly_N_to_volt = { .total_divider =10 ,
Signature · 1 line
2.26.2
Guenter Roeck
maintainerQuoted 19 lines · Serge Semin
Clang-based kernel building with W=1 warns that some static const variables are unused:
drivers/hwmon/bt1-pvt.c:67:30: warning: unused variable 'poly_temp_to_N' [-Wunused-const-variable]static const struct pvt_poly poly_temp_to_N = { ^ drivers/hwmon/bt1-pvt.c:99:30: warning: unused variable 'poly_volt_to_N' [-Wunused-const-variable] static const struct pvt_poly poly_volt_to_N = { ^Indeed these polynomials are utilized only when the PVT sensor alarms are enabled. In that case they are used to convert the temperature and voltage alarm limits from normal quantities (Volts and degree Celsius) to the sensor data representation N = [0, 1023]. Otherwise when alarms are disabled the driver only does the detected data conversion to the human readable form and doesn't need that polynomials defined. So let's declare the Temp-to-N and Volt-to-N polynomials only if the PVT alarms are switched on at compile-time.
Quoted 7 lines
Note gcc with W=1 doesn't notice the problem.
Fixes 87976ce2825d ("hwmon: Add Baikal-T1 PVT sensor driver")Reported-by kbuild test robot <[email protected]>Signed-off-by Serge Semin <[email protected]>Cc Maxim Kaurkin <[email protected]>Cc Alexey Malahov <[email protected]>
I don't really like the added #if. Can you use __maybe_unused instead ?
Thanks,
Guenter
Quoted 40 lines
--- drivers/hwmon/bt1-pvt.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/hwmon/bt1-pvt.c +4
-0@@ -64,6 +64,7 @@ static const struct pvt_sensor_info pvt_info[] = {* 48380, * where T = [-48380, 147438] mC and N = [0, 1023]. */ +#if defined(CONFIG_SENSORS_BT1_PVT_ALARMS) static const struct pvt_poly poly_temp_to_N = { .total_divider = 10000, .terms = {@@ -74,6 +75,7 @@ static const struct pvt_poly poly_temp_to_N = { {0, 1720400, 1, 1} } }; +#endif /* CONFIG_SENSORS_BT1_PVT_ALARMS */ static const struct pvt_poly poly_N_to_temp = { .total_divider =1 ,@@ -96,6 +98,7 @@ static const struct pvt_poly poly_N_to_temp = {* N = (18658e-3*V - 11572) / 10, * V = N * 10^5 / 18658 + 11572 * 10^4 / 18658. */ +#if defined(CONFIG_SENSORS_BT1_PVT_ALARMS) static const struct pvt_poly poly_volt_to_N = { .total_divider = 10, .terms = {@@ -103,6 +106,7 @@ static const struct pvt_poly poly_volt_to_N = { {0, -11572, 1, 1} } }; +#endif /* CONFIG_SENSORS_BT1_PVT_ALARMS */ static const struct pvt_poly poly_N_to_volt = { .total_divider =10 ,
Quoted 22 lines · Guenter Roeck
Quoted 21 lines · Serge Semin
Clang-based kernel building with W=1 warns that some static const variables are unused:
drivers/hwmon/bt1-pvt.c:67:30: warning: unused variable 'poly_temp_to_N' [-Wunused-const-variable]static const struct pvt_poly poly_temp_to_N = { ^ drivers/hwmon/bt1-pvt.c:99:30: warning: unused variable 'poly_volt_to_N' [-Wunused-const-variable] static const struct pvt_poly poly_volt_to_N = { ^Indeed these polynomials are utilized only when the PVT sensor alarms are enabled. In that case they are used to convert the temperature and voltage alarm limits from normal quantities (Volts and degree Celsius) to the sensor data representation N = [0, 1023]. Otherwise when alarms are disabled the driver only does the detected data conversion to the human readable form and doesn't need that polynomials defined. So let's declare the Temp-to-N and Volt-to-N polynomials only if the PVT alarms are switched on at compile-time.
Note gcc with W=1 doesn't notice the problem.
Quoted 8 lines
Quoted 5 lines
Fixes 87976ce2825d ("hwmon: Add Baikal-T1 PVT sensor driver")Reported-by kbuild test robot <[email protected]>Signed-off-by Serge Semin <[email protected]>Cc Maxim Kaurkin <[email protected]>Cc Alexey Malahov <[email protected]>I don't really like the added #if. Can you use
__maybe_unusedinstead ?
Ok. __maybe_unused is much better. Thanks for suggestion.
-Sergey
Quoted 44 lines
Thanks,
GuenterQuoted 40 lines
--- drivers/hwmon/bt1-pvt.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/hwmon/bt1-pvt.c +4
-0@@ -64,6 +64,7 @@ static const struct pvt_sensor_info pvt_info[] = {* 48380, * where T = [-48380, 147438] mC and N = [0, 1023]. */ +#if defined(CONFIG_SENSORS_BT1_PVT_ALARMS) static const struct pvt_poly poly_temp_to_N = { .total_divider = 10000, .terms = {@@ -74,6 +75,7 @@ static const struct pvt_poly poly_temp_to_N = { {0, 1720400, 1, 1} } }; +#endif /* CONFIG_SENSORS_BT1_PVT_ALARMS */ static const struct pvt_poly poly_N_to_temp = { .total_divider =1 ,@@ -96,6 +98,7 @@ static const struct pvt_poly poly_N_to_temp = {* N = (18658e-3*V - 11572) / 10, * V = N * 10^5 / 18658 + 11572 * 10^4 / 18658. */ +#if defined(CONFIG_SENSORS_BT1_PVT_ALARMS) static const struct pvt_poly poly_volt_to_N = { .total_divider = 10, .terms = {@@ -103,6 +106,7 @@ static const struct pvt_poly poly_volt_to_N = { {0, -11572, 1, 1} } }; +#endif /* CONFIG_SENSORS_BT1_PVT_ALARMS */ static const struct pvt_poly poly_N_to_volt = { .total_divider =10 ,
PATCH v2 1/1 hwmon: bt1-pvt: Define Temp- and Volt-to-N poly as maybe-unused
In reply to Serge SeminClang-based kernel building with W=1 warns that some static const variables are unused:
drivers/hwmon/bt1-pvt.c:67:30: warning: unused variable 'poly_temp_to_N' [-Wunused-const-variable]
static const struct pvt_poly poly_temp_to_N = {
^
drivers/hwmon/bt1-pvt.c:99:30: warning: unused variable 'poly_volt_to_N' [-Wunused-const-variable]
static const struct pvt_poly poly_volt_to_N = {
^Indeed these polynomials are utilized only when the PVT sensor alarms are enabled. In that case they are used to convert the temperature and voltage alarm limits from normal quantities (Volts and degree Celsius) to the sensor data representation N = [0, 1023]. Otherwise when alarms are disabled the driver only does the detected data conversion to the human readable form and doesn't need that polynomials defined. So let's mark the Temp-to-N and Volt-to-N polynomials with __maybe_unused attribute.
Note gcc with W=1 doesn't notice the problem.
---
Changelog v2:
- Repalce if-defs with __maybe_unused attribute.
--- drivers/hwmon/bt1-pvt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/bt1-pvt.c +2 -2
@@ -64,7 +64,7 @@ static const struct pvt_sensor_info pvt_info[] = {* 48380, * where T = [-48380, 147438] mC and N = [0, 1023]. */ -static const struct pvt_poly poly_temp_to_N = { +static const struct pvt_poly __maybe_unused poly_temp_to_N = { .total_divider =10000 , .terms = { {4 ,18322 ,10000 ,10000 },
@@ -96,7 +96,7 @@ static const struct pvt_poly poly_N_to_temp = {* N = (18658e-3*V - 11572) / 10, * V = N * 10^5 / 18658 + 11572 * 10^4 / 18658. */ -static const struct pvt_poly poly_volt_to_N = { +static const struct pvt_poly __maybe_unused poly_volt_to_N = { .total_divider =10 , .terms = { {1 ,18658 ,1000 ,1 },
Signature · 1 line
2.26.2
Re: [PATCH v2] hwmon: bt1-pvt: Define Temp- and Volt-to-N poly as maybe-unused
Quoted 18 lines · Serge Semin
Clang-based kernel building with W=1 warns that some static const variables are unused:
drivers/hwmon/bt1-pvt.c:67:30: warning: unused variable 'poly_temp_to_N' [-Wunused-const-variable]static const struct pvt_poly poly_temp_to_N = { ^ drivers/hwmon/bt1-pvt.c:99:30: warning: unused variable 'poly_volt_to_N' [-Wunused-const-variable] static const struct pvt_poly poly_volt_to_N = { ^Indeed these polynomials are utilized only when the PVT sensor alarms are enabled. In that case they are used to convert the temperature and voltage alarm limits from normal quantities (Volts and degree Celsius) to the sensor data representation N = [0, 1023]. Otherwise when alarms are disabled the driver only does the detected data conversion to the human readable form and doesn't need that polynomials defined. So let's mark the Temp-to-N and Volt-to-N polynomials with
__maybe_unusedattribute.
Quoted 7 lines
Note gcc with W=1 doesn't notice the problem.
Fixes 87976ce2825d ("hwmon: Add Baikal-T1 PVT sensor driver")Reported-by kbuild test robot <[email protected]>Signed-off-by Serge Semin <[email protected]>Cc Maxim Kaurkin <[email protected]>Cc Alexey Malahov <[email protected]>
Applied.
Thanks,
Guenter
Quoted 31 lines
---
Changelog v2:
- Repalce if-defs with__maybe_unusedattribute.--- drivers/hwmon/bt1-pvt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/hwmon/bt1-pvt.c +2
-2@@ -64,7 +64,7 @@ static const struct pvt_sensor_info pvt_info[] = {* 48380, * where T = [-48380, 147438] mC and N = [0, 1023]. */ -static const struct pvt_poly poly_temp_to_N = { +static const struct pvt_poly __maybe_unused poly_temp_to_N = { .total_divider =10000 , .terms = { {4 ,18322 ,10000 ,10000 },@@ -96,7 +96,7 @@ static const struct pvt_poly poly_N_to_temp = {* N = (18658e-3*V - 11572) / 10, * V = N * 10^5 / 18658 + 11572 * 10^4 / 18658. */ -static const struct pvt_poly poly_volt_to_N = { +static const struct pvt_poly __maybe_unused poly_volt_to_N = { .total_divider =10 , .terms = { {1 ,18658 ,1000 ,1 },